On Mon, Mar 18, 2024 at 04:55:20PM +0100, Thomas Lamprecht wrote: > On 12/03/2024 12:59, Christoph Heiss wrote: > > Otherwise, when using the serial debug shell, the console size will be > > 0x0. This in turn breaks the TUI installer, as it cannot detect the size > > properly. > > That's ok, but... > > > > > It also adjust the size to the proper 80x24 instead of 80x25, as > > advertised in the log message. > > ... why not going the opposite direction and change the log message, > or is there some reason to go for 24 rows? > > Isn't 80x25 the standard VGA one?
For VGA 80x25 is the standard size [0], yes. But for serial consoles aka. VT10x emulated terminals it is actually 80x24 [1], which basically everything uses as reference. GRUB also uses 80x24 when used over a serial interface. It spits out 24 lines at least. Probably should have noted that in the commit messages, sorry. [0] https://www.kernel.org/doc/Documentation/svga.txt (`NORMAL_VGA`) [1] https://vt100.net/dec/ek-vt100-tm-002.pdf (page 21, "Format") _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
