--- Begin Message ---
10.10.2023 16:54, Fiona Ebner пишет:
Hi,
Hi, Fiona!
Thanks for your review! I will send updated patch soon.
thank you for the contribution! Please prepend the commit title with
"fix #254: ".
Am 16.08.23 um 13:56 schrieb ykonoto...@gnome.org:
From: Yuri Konotopov
Fi
Signed-off-by: Filip Schauer
---
proxinstall | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxinstall b/proxinstall
index d5b2565..764187f 100755
--- a/proxinstall
+++ b/proxinstall
@@ -481,8 +481,8 @@ sub create_ipconf_view {
$text = $ipconf_entry_dns->get_text
On 10/13/23 15:33, Lukas Wagner wrote:
> - Additionally, it should be easy to run these integration tests locally
> on a developer's workstation in order to write new test cases, as well
> as troubleshooting and debugging existing test cases. The local
> test environment should match the
On 13/10/2023 12:36, Christoph Heiss wrote:
See inline comments. Also, `cargo fmt` please :^)
On Thu, Oct 12, 2023 at 03:02:08PM +0200, Filip Schauer wrote:
[..]
diff --git a/proxinstall b/proxinstall
index d5b2565..51170cd 100755
--- a/proxinstall
+++ b/proxinstall
@@ -347,7 +347,9 @@ sub cr
I'd add a bit to the commit message, but changes look good to me:
Am 13.10.23 um 15:50 schrieb Filip Schauer:
> Fix races with ACPI-suspended VMs which could wake up during migration
> or during a suspend-mode backup.
>
> Revert prevention, of ACPI-suspended VMs automatically resuming after
> mig
if a base-image is to be migrated to a lvm-thin storage, a new
vm-image is allocated on the target side, then the data is written
and afterwards the image is converted to a base-image
Signed-off-by: Hannes Duerr
---
In the bugtracker wolfgang suggested two different approaches. In my
opinion th
Since commit 2dc0eb61 ("qm: assume correct VNC setup in 'vncproxy',
disallow passwordless"), 'qm vncproxy' will just fail when the
LC_PVE_TICKET environment variable is not set. Fix the vncproxy API
call, which previously, would only set the variable in presence of the
'websocket' parameter.
Fion
Since commit 3e7567e0 ("do not use novnc wsproxy"), the websocket
upgrade is done via the HTTP server.
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index c8a87f3f..a31ddb81 100644
--- a/PVE
Since commit 2dc0eb61 ("qm: assume correct VNC setup in 'vncproxy',
disallow passwordless"), 'qm vncproxy' will just fail when the
LC_PVE_TICKET environment variable is not set. Since it is not only
required in combination with websocket, drop that conditional.
For the non-serial case, this was th
A few things, most of which we talked off-list already anyway.
We should eye if we can integrate existing regression testing in there
too, i.e.:
- The qemu autotest that Stefan Reiter started and Fiona still uses,
here we should drop the in-git tracked backup that the test VM is
restored from
hi,
a few high level comments:
first:
is the iscsi.cfg really necessary? couldn't we just lookup on demand like we do
now?
*if* we want to cache that list, we should only do this on a per node level,
since
there is no guarantee that this is the same for all nodes.
(e.g. use /var/run//scs
Am 16/10/2023 um 15:12 schrieb Fiona Ebner:
> Since commit 2dc0eb61 ("qm: assume correct VNC setup in 'vncproxy',
> disallow passwordless"), 'qm vncproxy' will just fail when the
> LC_PVE_TICKET environment variable is not set. Fix the vncproxy API
> call, which previously, would only set the varia
Am 13/10/2023 um 15:50 schrieb Filip Schauer:
> Fix races with ACPI-suspended VMs which could wake up during migration
> or during a suspend-mode backup.
>
> Revert prevention, of ACPI-suspended VMs automatically resuming after
> migration, introduced by 7ba974a6828d. The commit introduced a poten
Thank you for the feedback!
On 10/16/23 13:20, Stefan Hanreich wrote:
On 10/13/23 15:33, Lukas Wagner wrote:
- Additionally, it should be easy to run these integration tests locally
on a developer's workstation in order to write new test cases, as well
as troubleshooting and debugging ex
Thanks for the summary from our discussion and the additional feedback!
On 10/16/23 15:57, Thomas Lamprecht wrote:
- create some sort of test report
As Stefan mentioned, test-output can be good to have. Our buildbot
instance provides that, and while I don't look at them in 99% of the
builds
--- Begin Message ---
16.10.2023 17:58, Dominik Csapak пишет:
hi,
Hi, Dominik!
Thanks for your review. I will try to address all issues.
Some comments are below.
a few high level comments:
first:
is the iscsi.cfg really necessary? couldn't we just lookup on demand
like we do now?
Unti
some icons intentionally use black as their color in the light theme.
this includes the little pencil and check mark icon in the acme
overview. change their color to the regular dark-mode icon-color. for
this to work the filter inversion needed for some other icons needs to
be remove too.
Signed-o
Am 16/10/2023 um 17:33 schrieb Lukas Wagner:
>> Or is this some part that takes place in the test, i.e., a
>> generalization of product to test and supplementary tool/app that helps
>> on that test?
>
> It was intended to be a 'general VM/CT base thingy' that can be
> instantiated and managed by t
18 matches
Mail list logo
