Re: [pve-devel] [PATCH qemu-server] vzdump: use minimal VM config for offline backup

2020-09-07 Thread Dominik Csapak
does that not break the feature that we can start a vm that started a backup while stopped? atm we can start a backup on a stopped vm, and then simply start it, without aborting the backup. if i read the patch correctly, the vm now has just a minimal config and not what the user configured On 8/

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

2020-09-07 Thread Thomas Lamprecht
On 06.09.20 14:19, dietmar wrote: >> On 09/06/2020 2:14 PM dietmar wrote: >> >> >>> Sep 3 10:40:51 m6kvm7 pve-ha-lrm[16140]: loop take too long (87 seconds) >>> Sep 3 10:40:51 m6kvm7 pve-ha-crm[16196]: loop take too long (92 seconds) >> >> Indeed, this should not happen. Do you use a spearate

Re: [pve-devel] [PATCH qemu-server] vzdump: use minimal VM config for offline backup

2020-09-07 Thread Thomas Lamprecht
On 07.09.20 08:59, Dominik Csapak wrote: > does that not break the feature that > we can start a vm that started a backup while stopped? > > atm we can start a backup on a stopped vm, and then simply start > it, without aborting the backup. if i read the patch > correctly, the vm now has just a mi

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

2020-09-07 Thread Alexandre DERUMIER
>>Indeed, this should not happen. Do you use a spearate network for corosync? No, I use 2x40GB lacp link. >>was there high traffic on the network? but I'm far from saturated them. (in pps or througput), (I'm around 3-4gbps) The cluster is 14 nodes, with around 1000vms (with ha enabled on a

Re: [pve-devel] [PATCH qemu-server] api: cloud-init support for mtu and userdata

2020-09-07 Thread Alexandre DERUMIER
Hi, not related to cloudinit, but for virtio-net nic, it's already possible to add "mtu=xxx" option to netX:. It's not yet available in gui, but you should be able to do it with "qm set --net0 ...,mtu=" - Mail original - De: "proxmox" À: "Proxmox VE development discussion

[pve-devel] applied-series: [PATCH common/manager v2] adapt PVE::Tools::sendmail to match rust-implementation and use it for apt update notifications

2020-09-07 Thread Thomas Lamprecht
On 03.09.20 14:09, Stoiko Ivanov wrote: > v1->v2: > * dropped the moving of the email regex for reuse in the sendmail helper: > we use local usernames (mostly 'root') quite extensively in our code-base > and > our users probably do so as well (for backup notifications) > * replaced the direct

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

2020-09-07 Thread dietmar
There is a similar report in the forum: https://forum.proxmox.com/threads/cluster-die-after-adding-the-39th-node-proxmox-is-not-stable.75506/#post-336111 No HA involved... > On 09/07/2020 9:19 AM Alexandre DERUMIER wrote: > > > >>Indeed, this should not happen. Do you use a spearate network

Re: [pve-devel] [Patch v2 access-control] fix #2947 login name for the LDAP/AD realm can be case-insensitive

2020-09-07 Thread Dominik Csapak
one comment inline On 9/3/20 10:36 AM, Wolfgang Link wrote: This is an optional for LDAP and AD realm. The default behavior is case-sensitive. Signed-off-by: Wolfgang Link --- v1 -> v2:* naming of paramenter * use grep instead of a loop, to avoid login errors

Re: [pve-devel] [Patch v2 access-control] fix #2947 login name for the LDAP/AD realm can be case-insensitive

2020-09-07 Thread Wolfgang Link
No I missed your mail. Will fix it and resend it. > On 09/07/2020 10:20 AM Dominik Csapak wrote: > > > one comment inline > > On 9/3/20 10:36 AM, Wolfgang Link wrote: > > This is an optional for LDAP and AD realm. > > The default behavior is case-sensitive. > > > > Signed-off-by: Wolfgang Lin

Re: [pve-devel] [Patch v2 access-control] fix #2947 login name for the LDAP/AD realm can be case-insensitive

2020-09-07 Thread Thomas Lamprecht
On 07.09.20 10:42, Wolfgang Link wrote: > No I missed your mail. > Will fix it and resend it. Please also include my proposed change from then: On 28.08.20 14:39, Thomas Lamprecht wrote: > And we then actually want to use this method also in the API call for adding > new users, to ensure an admi

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

2020-09-07 Thread Alexandre DERUMIER
>>https://forum.proxmox.com/threads/cluster-die-after-adding-the-39th-node-proxmox-is-not-stable.75506/#post-336111 >> >> >>No HA involved... I had already help this user some week ago https://forum.proxmox.com/threads/proxmox-6-2-4-cluster-die-node-auto-reboot-need-help.74643/#post-333093 HA

Re: [pve-devel] [PATCH 0/7] Handle guest shutdown during backups

2020-09-07 Thread Thomas Lamprecht
On 03.09.20 10:58, Stefan Reiter wrote: > Use QEMU's -no-shutdown argument so the QEMU instance stays alive even if the > guest shuts down. This allows running backups to continue. > > To handle cleanup of QEMU processes, this series extends the qmeventd to > handle > SHUTDOWN events not just for

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

2020-09-07 Thread Alexandre DERUMIER
Looking at theses logs: Sep 3 10:40:51 m6kvm7 pve-ha-crm[16196]: lost lock 'ha_manager_lock - cfs lock update failed - Permission denied Sep 3 10:40:51 m6kvm7 pve-ha-lrm[16140]: lost lock 'ha_agent_m6kvm7_lock - cfs lock update failed - Permission denied in PVE/HA/Env/PVE2.pm " my $ctime

Re: [pve-devel] Telegraf added in-built Proxmox support - thoughts versus our external metric support?

2020-09-07 Thread Alexandre DERUMIER
Hi, >>Anyway, I do not think that we should drop our direct plugins (yet), some >>people like me, are happy feeding directly to InfluxDB without anything >>in-between. me too ;) I'm not sure, but I think than we send more metrics to influxdb, than we stream through the cluster. and the plugi

[pve-devel] applied: [PATCH pve-docs] faq & pct: Improve explanation of containers

2020-09-07 Thread Thomas Lamprecht
On 27.08.20 10:16, Dylan Whyte wrote: > This adds more clarity to the explanation of containers and to > the different terms we use to refer to containers, in both the FAQ and > the introduction section of pct. > > It also contains minor grammar fixes and rewording where appropriate. > > Signed-o

Re: [pve-devel] [RFC container] Improve feedback for startup

2020-09-07 Thread Thomas Lamprecht
On 27.08.20 10:44, Wolfgang Bumiller wrote: > On Thu, Aug 20, 2020 at 11:36:39AM +0200, Thomas Lamprecht wrote: >> On 19.08.20 12:30, Fabian Ebner wrote: >>> Since it was necessary to switch to 'Type=Simple' in the systemd >>> service (see 545d6f0a13ac2bf3a8d3f224c19c0e0def12116d ), >>> 'systemctl

Re: [pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from vnet-subnet-ipam

2020-09-07 Thread Thomas Lamprecht
On 24.08.20 18:49, Alexandre Derumier wrote: > This is a POC to call ip to retreive ip address from ipam. > > (it's really just a poc && buggt , it need to be improve for vnet changes, > pending config apply/revert,...) When trying this I got the gateway IP returned for both, as CT IP and gatewa

Re: [pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from vnet-subnet-ipam

2020-09-07 Thread Alexandre DERUMIER
>>When trying this I got the gateway IP returned for both, as CT IP and gateway >>IP. >>Did not checked this patch closer, but I figured that this behavior is caused >>by >>the SDN code. mmm, that's strange. When you create or update the subnet, the gateway ip you define on the subnet shou

Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown

2020-09-07 Thread dietmar
> I don't known too much how locks are working in pmxcfs, but when a corosync > member leave or join, and a new cluster memership is formed, could we have > some lock lost or hang ? It would really help if we can reproduce the bug somehow. Do you have and idea how to trigger the bug?