Hi hackers,
6af1793954 added a new field namely "isCatalogRel" in some WAL records
to help detecting row removal conflict during logical decoding from standby.
Please find attached a patch to add this field in the related rmgrdesc (i.e
all the ones that already provide the snapshotConflictHorizo
Dear Hackers,
I've come across a behaviour of the planner I can't explain.
After a migration from 11 to 15 (on RDS) we noticed a degradation in
response time on a query, it went from a few seconds to ten minutes.
A vacuum(analyze) has been realized to be sure that all is clean.
The 'explain an
On Sat, Dec 9, 2023 at 9:30 AM Alexander Lakhin wrote:
>
> Hello hackers,
>
> While studying bug #18158, I've come to the conclusion that the existing
> testing infrastructure is unable to detect abnormal situations. of some
> kind.
>
> Just a simple example:
> With Assert(0) injected in walsender
On Mon, Dec 11, 2023 at 7:12 PM Amit Kapila wrote:
>
> On Mon, Dec 11, 2023 at 2:41 PM shveta malik wrote:
> >
> > >
> > > 5.
> > > +synchronize_slots(WalReceiverConn *wrconn)
> > > {
> > > ...
> > > ...
> > > + /* The syscache access needs a transaction env. */
> > > + StartTransactionCommand();
On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote:
> Please find attached a patch to add this field in the related rmgrdesc (i.e
> all the ones that already provide the snapshotConflictHorizon except the one
> related to xl_heap_visible: indeed a new bit was added in its flag field
Hi,
On 12/12/23 10:15 AM, Michael Paquier wrote:
On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote:
Please find attached a patch to add this field in the related rmgrdesc (i.e
all the ones that already provide the snapshotConflictHorizon except the one
related to xl_heap_visible
On Monday, December 11, 2023 3:32 PM Peter Smith
>
> Here are some review comments for v44-0001
>
> ==
> src/backend/replication/slot.c
>
>
> 1. ReplicationSlotCreate
>
> * during getting changes, if the two_phase option is enabled it can skip
> * prepare because by that time
Hi,
There's been a lot discussed over the past month or so, and it's become
difficult to get a good idea what's the current state - what issues
remain to be solved, what's unrelated to this patch, and how to move if
forward. Long-running threads tend to be confusing, so I had a short
call with Ami
> On 12 Dec 2023, at 01:09, Tristan Partin wrote:
>
> Not sold on the name, but --check is a combination of --silent-diff and
> --show-diff. I envision --check mostly being used in CI environments. I
> recently came across a situation where this behavior would have been useful.
> Without --che
Hi,
On Tue, Dec 12, 2023 at 11:18:59AM +0100, Daniel Gustafsson wrote:
> > On 12 Dec 2023, at 01:09, Tristan Partin wrote:
> >
> > Not sold on the name, but --check is a combination of --silent-diff
> > and --show-diff. I envision --check mostly being used in CI
> > environments. I recently came
build system using configure set VAL_CFLAGS with debug and
optimization flags, so pg_config will show these infos. Some
extensions depend on the mechanism.
This patch exposes these flags with a typo fixed together.
--
Regards
Junwang Zhao
0001-meson-expose-buildtype-debug-optimization-info-to-
On Tue, Dec 12, 2023 at 10:27:09AM +0530, Dilip Kumar wrote:
> Oops, I only included the code changes where I am adding injection
> points and some comments to verify that, but missed the actual test
> file. Attaching it here.
I see. Interesting that this requires persistent connections to work.
On Mon, 11 Dec 2023 15:43:12 -0500
Tom Lane wrote:
> Jehan-Guillaume de Rorthais writes:
> > It looks like since 586b98fdf1aae, the result type collation of
> > "convert_from" is forced to "C", like the patch does for type "name",
> > instead of the "default" collation for type "text".
>
> We
On 12/11/23 16:41, Tomas Vondra wrote:
> On 12/11/23 16:00, Alexander Lakhin wrote:
>> Hello Tomas and Soumyadeep,
>>
>> 25.11.2023 23:06, Tomas Vondra wrote:
>>> I've done a bit more cleanup on the last version of the patch (renamed
>>> the fields to start with bis_ as agreed, rephrased the comm
Hi,
Thanks for the feedback! The new version of the patch is attached.
On Tue, 5 Dec 2023 at 09:16, Michael Paquier wrote:
>
> - if (io_op == IOOP_WRITE || io_op == IOOP_EXTEND)
> + if (io_op == IOOP_EXTEND || io_op == IOOP_WRITE)
>
> Unrelated diff.
Done.
>
> + if (io_object ==
On Tue, Dec 12, 2023, at 7:28 AM, Michael Banck wrote:
> On Tue, Dec 12, 2023 at 11:18:59AM +0100, Daniel Gustafsson wrote:
> > > On 12 Dec 2023, at 01:09, Tristan Partin wrote:
> > >
> > > Not sold on the name, but --check is a combination of --silent-diff
> > > and --show-diff. I envision --che
A review on v45 patch:
If one creates a logical slot with failover=true as -
select pg_create_logical_replication_slot('logical_slot','pgoutput',
false, true, true);
Then, uses the existing logical slot while creating a subscription -
postgres=# create subscription sub4 connection 'dbname=postgr
On Mon, Dec 11, 2023 at 10:05 PM Alena Rybakina
wrote:
>
> Hi! Thank you for your work. Your patch looks better!
> Yes, thank you! It works fine, and I see that the regression tests have been
> passed. 🙂
> However, when I ran 'copy from with save_error' operation with simple csv
> files (copy_te
On Mon, Dec 11, 2023 at 6:16 PM Peter Geoghegan wrote:
> Will you be in Prague this week? If not this might have to wait.
Sorry, I wouldn't be in Prague this week. Due to my current
immigration status, I can't travel.
I wish you to have a lovely time in Prague. I'm OK to wait, review
once you c
[Added Andrey again in CC, because as I understand they are using this
code or something like it in production. Please don't randomly remove
people from CC lists.]
I've been looking at this some more, and I'm not confident in that the
group clog update stuff is correct. I think the injection poi
Hi hackers,
I would like to give more details of my patch.
In postgres, it uses a global snapshot “CatalogSnapshot” to check catalog
data visibility.
“CatalogSnapshot” is always updated to the latest version to make the
latest catalog table
content visible.
If there is any updating on catalo
Hello Shveta,
12.12.2023 11:44, shveta malik wrote:
The postmaster process exits with exit code 1, but pg_ctl can't get the
code and just reports that stop was completed successfully.
For what it's worth, there is another thread which stated the similar problem:
https://www.postgresql.org/me
"Euler Taveira" writes:
> When you add exceptions, it starts to complicate the UI.
Indeed. It seems like --silent-diff was poorly defined and poorly
named, and we need to rethink that option along the way to adding
this behavior. The idea that --show-diff and --silent-diff can
be used together
On Tue Dec 12, 2023 at 5:47 AM CST, Euler Taveira wrote:
On Tue, Dec 12, 2023, at 7:28 AM, Michael Banck wrote:
> On Tue, Dec 12, 2023 at 11:18:59AM +0100, Daniel Gustafsson wrote:
> > > On 12 Dec 2023, at 01:09, Tristan Partin wrote:
> > >
> > > Not sold on the name, but --check is a combinati
On 2023-Dec-12, Tom Lane wrote:
> "Euler Taveira" writes:
> > When you add exceptions, it starts to complicate the UI.
>
> Indeed. It seems like --silent-diff was poorly defined and poorly
> named, and we need to rethink that option along the way to adding
> this behavior. The idea that --show
On Thu May 12, 2022 at 4:21 PM CDT, Tom Lane wrote:
I wrote:
> every buildfarm member that's contributing to the typedefs list
> builds with OpenSSL. That wouldn't surprise me, except that
> my own animal sifaka should be filling that gap. Looking at
> its latest attempt[1], it seems to be gene
"Tristan Partin" writes:
> Was this patch ever committed?
Yes, though not till
commit dcca861554e90d6395c3c153317b0b0e3841f103
Author: Andrew Dunstan
Date: Sun Jan 15 07:32:50 2023 -0500
Improve typedef logic for MacOS
sifaka is currently generating typedefs, and I'm pretty certain
it's
Hi hackers,
Currently walrcv->walRcvState is set to WALRCV_STREAMING at the
beginning of WalReceiverMain().
But it seems that after this assignment things could be wrong before the
walreicever actually starts streaming (like not being able to connect
to the primary).
It looks to me that WALRCV_
On Tue, Dec 12, 2023, at 12:58 PM, Drouvot, Bertrand wrote:
> Currently walrcv->walRcvState is set to WALRCV_STREAMING at the
> beginning of WalReceiverMain().
>
> But it seems that after this assignment things could be wrong before the
> walreicever actually starts streaming (like not being able
I would replace the text in explain.sgml with this:
+ Include information on memory consumption by the query planning phase.
+ This includes the precise amount of storage used by planner in-memory
+ structures, as well as overall total consumption of planner memory,
+ including
On 2023-Dec-12, Alvaro Herrera wrote:
> I would replace the text in explain.sgml with this:
>
> + Include information on memory consumption by the query planning phase.
> + This includes the precise amount of storage used by planner in-memory
> + structures, as well as overall tota
On Thu, Dec 7, 2023 at 8:15 PM vignesh C wrote:
>
> On Tue, 5 Dec 2023 at 10:56, Michael Paquier wrote:
> >
> > On Mon, Dec 04, 2023 at 04:30:49PM +0530, Amit Kapila wrote:
> > > I have made minor changes in the comments and code at various places.
> > > See and let me know if you are not happy w
On 12/5/23 3:46 PM, Jeff Davis wrote:
> === Character Classification ===
>
> Character classification is used for regexes, e.g. whether a character
> is a member of the "[[:digit:]]" ("\d") or "[[:punct:]]"
> class. Unicode defines what character properties map into these
> classes in TR #18 [1],
The script was using a few deprecated things according to POSIX:
- -o instead of ||
- egrep
- `` instead of $()
I removed those for their "modern" equivalents. Hopefully no buildfarm
member complains. I can remove any of those patches though. I did go
ahead and remove egrep usage from the enti
On Sun, 2023-12-10 at 10:39 +1300, Thomas Munro wrote:
>
> How would you specify what you want?
One proposal would be to have a builtin collation provider:
https://postgr.es/m/9d63548c4d86b0f820e1ff15a83f93ed9ded4543.ca...@j-davis.com
I don't think there are very many ctype options, but they c
On 12/12/23 1:39 PM, Jeff Davis wrote:
> On Sun, 2023-12-10 at 10:39 +1300, Thomas Munro wrote:
>> Unless you also
>> implement built-in case mapping, you'd still have to call libc or ICU
>> for that, right?
>
> We can do built-in case mapping, see:
>
> https://postgr.es/m/ff4c2f2f9c8fc7ca27c1c24
"Tristan Partin" writes:
> The big patch here is adding support for Mac. objdump -W doesn't work on
> Mac. So, I used dsymutil and dwarfdump to achieve the same result.
We should probably nuke the current version of src/tools/find_typedef
altogether in favor of copying the current buildfarm code
On Tue, Dec 12, 2023 at 1:33 PM Dilip Kumar wrote:
>
> On Tue, Dec 12, 2023 at 9:01 AM Masahiko Sawada wrote:
> >
> > Hi all,
> >
> > As the comment of ReorderBufferLargestTXN() says, it's very slow with
> > many subtransactions:
> >
> > /*
> > * Find the largest transaction (toplevel or subxact
On 6/12/2023 14:30, Richard Guo wrote:
I've self-reviewed this patch again and I think it's now in a
committable state. I'm wondering if we can mark it as 'Ready for
Committer' now, or we need more review comments/feedbacks.
To recap, this patch postpones reparameterization of paths until
creat
On Tue, Oct 10, 2023 at 05:54:34PM -0700, Andres Freund wrote:
> On 2023-10-10 17:08:25 -0700, Jeff Davis wrote:
> > After this, it seems "make check" no longer picks up the locale from
> > the system environment by default.
>
> Yea. I wonder if the better fix would have been to copy setenv("LC_ME
Noah Misch writes:
> An alternative would be to declare that the tests are supported in one
> encoding+locale only, then stop testing others in the buildfarm.
Surely that's not even a thinkably acceptable choice.
regards, tom lane
On Tue, Dec 12, 2023 at 2:44 PM shveta malik wrote:
>
> On Mon, Dec 11, 2023 at 7:12 PM Amit Kapila wrote:
> >
>
> > I am
> > asking this because the context used is TopMemoryContext which should
> > be used only if we need something specific to be retained at the
> > process level which doesn't
On Fri, Dec 8, 2023 at 4:21 AM Federico wrote:
>
> Hi,
>
> Postgresql seems to be missing upcasting when doing INT range and
> multi-range operation, for example when checking if an int4 is inside
> an int8 range.
> Some non working example are the following
>
> SELECT 2::INT4 <@ '[1, 4)'::INT
jian he writes:
> Based on my interpretation, I don't think SELECT 2::INT4 <@ '[1,
> 4)'::INT8RANGE is doable.
Yeah, it would require a considerable expansion of the scope of
what can be matched by a polymorphic operator. I'm afraid that
the negative consequences (mainly, "ambiguous operator" fa
On Tue, Dec 12, 2023 at 6:58 PM Alvaro Herrera wrote:
>
> [Added Andrey again in CC, because as I understand they are using this
> code or something like it in production. Please don't randomly remove
> people from CC lists.]
Oh, glad to know that. Yeah, I generally do not remove but I have
not
On Mon, Dec 11, 2023 at 5:13 PM shveta malik wrote:
>
> On Mon, Dec 11, 2023 at 1:22 PM Drouvot, Bertrand
> wrote:
> >
> > > If we agree
> > > on that then it would be good to prohibit setting this GUC on standby
> > > or at least it should be a no-op even if this GUC should be set on
> > > physi
On Wed, Dec 13, 2023 at 6:01 AM Masahiko Sawada wrote:
>
> > Thanks for working on this, I think it would be good to test other
> > scenarios as well where this might have some negative impact and see
> > where we stand.
>
> Agreed.
>
> > 1) A scenario where suppose you have one very large transac
Can postgres client send subsequent requests without receiving response? If
so, how does the postgres client correlate between a request and its
response? Where can I get more hints about it?
On Tue, Dec 12, 2023 at 5:56 PM Nisha Moond wrote:
>
> A review on v45 patch:
>
> If one creates a logical slot with failover=true as -
> select pg_create_logical_replication_slot('logical_slot','pgoutput',
> false, true, true);
>
> Then, uses the existing logical slot while creating a subscriptio
On Wed, Dec 13, 2023 at 10:40 AM Amit Kapila wrote:
>
> On Mon, Dec 11, 2023 at 5:13 PM shveta malik wrote:
> >
> > On Mon, Dec 11, 2023 at 1:22 PM Drouvot, Bertrand
> > wrote:
> > >
> > > > If we agree
> > > > on that then it would be good to prohibit setting this GUC on standby
> > > > or at l
On Wed, 13 Dec 2023 at 01:56, Masahiko Sawada wrote:
>
> On Thu, Dec 7, 2023 at 8:15 PM vignesh C wrote:
> >
> > On Tue, 5 Dec 2023 at 10:56, Michael Paquier wrote:
> > >
> > > On Mon, Dec 04, 2023 at 04:30:49PM +0530, Amit Kapila wrote:
> > > > I have made minor changes in the comments and code
Hi, Thomas Munro and Laurenz Albe.
Since I didn't subscribe to the psql-hackers mailing list before this bug
was raised, please forgive me for not being able to reply to this email by
placing the email message below.
https://www.postgresql.org/message-id/flat/e48a5d9a2d3d72985d61ee254314f5f5f5444a
52 matches
Mail list logo
