Re: Addition of PostgreSQL::Test::Cluster::pg_version()

> On 19 May 2022, at 03:38, Michael Paquier wrote: > Any objections or comments about the addition of a routine to get the > PostgreSQL::Version, as of the attached? I haven't tested the patch, but +1 on the idea. -- Daniel Gustafsson https://vmware.com/

Re: Limiting memory allocation

> On Wed, May 18, 2022 at 04:49:24PM -0400, Joe Conway wrote: > On 5/18/22 16:20, Alvaro Herrera wrote: > > On 2022-May-18, Joe Conway wrote: > > > > > On 5/18/22 11:11, Alvaro Herrera wrote: > > > > > > Apparently, if the cgroup goes over the "high" limit, the processes are > > > > *throttled*. T

Re: Skipping schema changes in publication

Below are my review comments for v6-0001. == 1. General. The patch failed 'publication' tests in the make check phase. Please add this work to the commit-fest so that the 'cfbot' can report such errors sooner. ~~~ 2. src/backend/commands/publicationcmds.c - AlterPublicationReset +/* + *

Re: Zstandard support for toast compression

On Wed, May 18, 2022 at 12:17:16PM -0400, Robert Haas wrote: > i.e. something like: > > 00 = PGLZ > 01 = LZ4 > 10 = reserved for future emergencies > 11 = extended header with additional type byte (1 of 256 possible > values reserved for Zstandard) Btw, shouldn't we have something a bit more, err

RE: Handle infinite recursion in logical replication setup

On Wed, May 4, 2022 2:47 PM vignesh C wrote: > > Thanks for the comments, the attached v13 patch has the changes for the same. > Here are some comments on v13-0002 patch. 1) +* Throw an error so that the user can take care of the initial data +* copying and then

Re: First draft of the PG 15 release notes

On Thu, May 19, 2022 at 2:56 PM David Rowley wrote: > On Thu, 19 May 2022 at 14:41, Amit Langote wrote: > > Though a bit late given beta is now wrapped, I have another partition > > item wording improvement suggestion: > > > > -Previously, a partitioned table with any LIST partition containing >

Re: Build-farm - intermittent error in 031_column_list.pl

On Thu, May 19, 2022 at 12:28 PM Kyotaro Horiguchi wrote: > > At Thu, 19 May 2022 14:26:56 +1000, Peter Smith wrote > in > > Hi hackers. > > > > FYI, I saw that there was a recent Build-farm error on the "grison" machine > > [1] > > [1] > > https://buildfarm.postgresql.org/cgi-bin/show_history

Re: Intermittent buildfarm failures on wrasse

I was looking at backpatching this to pg13. That made me realize that commit dc7420c2c927 changed things in 14; and before that commit, the bitmask that is checked is PROCARRAY_FLAGS_VACUUM, which has a definition independently from whatever proc.h says. As far as I can tell, there's no problem w

Re: Zstandard support for toast compression

On Wed, May 18, 2022 at 9:47 PM Robert Haas wrote: > > I do understand that Zstandard is a good compression algorithm, and if > we had an extensibility mechanism here where one of the four possible > bit patterns then indicates that the next byte (or two or four) stores > the real algorithm type,

Re: Removing unneeded self joins

On 5/17/22 19:14, Ronan Dunklau wrote: Le vendredi 13 mai 2022, 07:07:47 CEST Andrey Lepikhov a écrit : New version of the feature. Here a minor bug with RowMarks is fixed. A degenerated case is fixed, when uniqueness of an inner deduced not from join quals, but from a baserestrictinfo clauses '

Re: Build-farm - intermittent error in 031_column_list.pl

On Thu, May 19, 2022 at 3:16 PM Amit Kapila wrote: > > On Thu, May 19, 2022 at 12:28 PM Kyotaro Horiguchi > wrote: > > > > At Thu, 19 May 2022 14:26:56 +1000, Peter Smith > > wrote in > > > Hi hackers. > > > > > > FYI, I saw that there was a recent Build-farm error on the "grison" > > > machin

Re: Addition of PostgreSQL::Test::Cluster::pg_version()

On 2022-05-18 We 21:38, Michael Paquier wrote: > Hi all, > (Added Andrew in CC.) > > While working more on expanding the tests of pg_upgrade for > cross-version checks, I have noticed that we don't expose a routine > able to get back _pg_version from a node, which should remain a > private field

Re: Removing unneeded self joins

Le jeudi 19 mai 2022, 12:48:18 CEST Andrey Lepikhov a écrit : > On 5/17/22 19:14, Ronan Dunklau wrote: > > Le vendredi 13 mai 2022, 07:07:47 CEST Andrey Lepikhov a écrit : > >> New version of the feature. > >> Here a minor bug with RowMarks is fixed. A degenerated case is fixed, > >> when uniquenes

parallel not working

Hi: I write a  C function, the function is as follows: create function st_geosotgrid(geom geometry, level integer) returns geosotgrid[] immutable strict parallel safe language c as $$ begin -- missing source code end; $$; At the same time, I set the relevant parameters: force_pa

Re: bogus: logical replication rows/cols combinations

On Thu, May 19, 2022 at 10:33:13AM +0530, Amit Kapila wrote: > I have committed the first patch after fixing this part. It seems Tom > is not very happy doing this after beta-1 [1]. The reason we get this > information via this view (and underlying function) is that it > simplifies the queries on t

Re: JSON Functions and Operators Docs for v15

> + same level are considerd to be siblings, considered > +PostgreSQL specific functions detailed in postgresql hyphen specific (as in the original) These would all be easier to read with commas: +expression is NULL an +If WITH UNIQUE is specified the +If the inpu

Re: bogus: logical replication rows/cols combinations

Justin Pryzby writes: > On Thu, May 19, 2022 at 10:33:13AM +0530, Amit Kapila wrote: >> I have committed the first patch after fixing this part. It seems Tom >> is not very happy doing this after beta-1 [1]. The reason we get this >> information via this view (and underlying function) is that it >

Re: JSON Functions and Operators Docs for v15

On 2022-05-19 Th 08:19, Justin Pryzby wrote: >> + same level are considerd to be siblings, > considered > >> +PostgreSQL specific functions detailed in > postgresql hyphen specific (as in the original) > > These would all be easier to read with commas: > > +expression is NULL an > +

15beta1 crash on mips64el in pg_regress/triggers

Debian unstable mips64el: 2022-05-18 22:57:34.436 UTC client backend[19222] pg_regress/triggers STATEMENT: drop trigger trg1 on trigpart3; ... 2022-05-18 22:57:39.110 UTC postmaster[7864] LOG: server process (PID 19222) was terminated by signal 11: Segmentation fault 2022-05-18 22:57:39.110 UT

Re: 15beta1 crash on mips64el in pg_regress/triggers

Christoph Berg writes: > Debian unstable mips64el: Hmm, so what's different between this and buildfarm member topminnow? Is the crash 100% reproducible for you? regards, tom lane

Re: 15beta1 crash on mips64el in pg_regress/triggers

Re: Tom Lane > Christoph Berg writes: > > Debian unstable mips64el: > > Hmm, so what's different between this and buildfarm member topminnow? > > Is the crash 100% reproducible for you? I have scheduled a rebuild now, we'll know in a few hours... Christoph

15beta1 test failure on mips in isolation/expected/stats

Debian unstable mips (the old 32-bit one): test vacuum-conflict ... ok 2170 ms test vacuum-skip-locked ... ok 2445 ms test stats... FAILED38898 ms test horizons ... ok 4543 ms test predicate-hash

Re: 15beta1 crash on mips64el in pg_regress/triggers

Re: Tom Lane > Christoph Berg writes: > > Debian unstable mips64el: > > Hmm, so what's different between this and buildfarm member topminnow? That one is running Debian jessie (aka oldoldoldoldstable), uses -mabi=32 with gcc 4.9, and runs a kernel from 2015. The Debian buildd is this: https://d

[PATCH] Add result_types column to pg_prepared_statements view

Hi hackers, Prompted by a question on IRC, here's a patch to add a result_types column to the pg_prepared_statements view, so that one can see the types of the columns returned by a prepared statement, not just the parameter types. I'm not quite sure about the column name, suggestions welcome. -

Re: [PATCH] Add result_types column to pg_prepared_statements view

Dagfinn Ilmari Mannsåker writes: > Hi hackers, > > Prompted by a question on IRC, here's a patch to add a result_types > column to the pg_prepared_statements view, so that one can see the types > of the columns returned by a prepared statement, not just the parameter > types. Added to the 2022-0

Re: 15beta1 crash on mips64el in pg_regress/triggers

Christoph Berg writes: > Re: Tom Lane >> Hmm, so what's different between this and buildfarm member topminnow? > That one is running Debian jessie (aka oldoldoldoldstable), uses > -mabi=32 with gcc 4.9, and runs a kernel from 2015. > The Debian buildd is this: > https://db.debian.org/machines.cg

Re: 15beta1 crash on mips64el in pg_regress/triggers

Re: To Tom Lane > > Is the crash 100% reproducible for you? > > I have scheduled a rebuild now, we'll know in a few hours... The build was much faster this time (different machine), and worked. https://buildd.debian.org/status/logs.php?pkg=postgresql-15&arch=mips64el I'll also start a test buil

Re: Zstandard support for toast compression

В письме от вторник, 17 мая 2022 г. 23:01:07 MSK пользователь Tom Lane написал: Hi! I came to this branch looking for a patch to review, but I guess I would join the discussion instead of reading the code. > >> Yeah - I think we had better reserve the fourth bit pattern for > >> something exten

Re: [RFC] Improving multi-column filter cardinality estimation using MCVs and HyperLogLog

On Mon, 16 May 2022 at 00:09, Tomas Vondra wrote: > > On 5/15/22 21:55, Matthias van de Meent wrote: > > Note: I am not (currently) planning on implementing this rough idea, > > just putting it up to share and document the idea, on request of Tomas > > (cc-ed). > > > > The excellent pgconf.de pres

Re: Privileges on PUBLICATION

Euler Taveira wrote: > On Wed, May 18, 2022, at 6:16 AM, Antonin Houska wrote: > > The patch is attached to this message. > > Great. Add it to the next CF. I'll review it when I have some spare time. https://commitfest.postgresql.org/38/3641/ Thanks! -- Antonin Houska Web: https://www.cybe

Inquiring about my GSoC Proposal.

Greetings! I was wondering if you could provide me with initial feedback on my GSoC proposal, as well as if you have any comments about it. And would it be possible to know whether I got accepted as a contributor? Best Regards, Israa Odeh. Sent from Mail

pg15b1: FailedAssertion("val > base", File: "...src/include/utils/relptr.h", Line: 67, PID: 30485)

./tmp_install/usr/local/pgsql/bin/postgres -D ./src/test/regress/tmp_check/data -c min_dynamic_shared_memory=1MB TRAP: FailedAssertion("val > base", File: "../../../../src/include/utils/relptr.h", Line: 67, PID: 21912) ./tmp_install/usr/local/pgsql/bin/postgres(ExceptionalCondition+0xa0)[0x55af5

Re: Zstandard support for toast compression

On Thu, May 19, 2022 at 4:20 AM Michael Paquier wrote: > Btw, shouldn't we have something a bit more, err, extensible for the > design of an extensible varlena header? If we keep it down to some > bitwise information, we'd be fine for a long time but it would be > annoying to review again an exte

Re: A qsort template

On Fri, Apr 22, 2022 at 11:37:29AM +0700, John Naylor wrote: > On Fri, Apr 22, 2022 at 11:13 AM David Rowley wrote: > > > > On Thu, 21 Apr 2022 at 19:09, John Naylor > > wrote: > > > I intend to commit David's v2 fix next week, unless there are > > > objections, or unless he beats me to it. > >

Re: parallel not working

On Thu, May 19, 2022 at 8:05 AM huangning...@yahoo.com < huangning...@yahoo.com> wrote: > I would like to know how can I get it to work properly？ > I suppose you have a bug in your C code. Try hooking up a debugger to one of the sessions that is hung and see what it's doing e.g. gdb -p 26130 bt

Re: pg15b1: FailedAssertion("val > base", File: "...src/include/utils/relptr.h", Line: 67, PID: 30485)

Justin Pryzby writes: > ./tmp_install/usr/local/pgsql/bin/postgres -D > ./src/test/regress/tmp_check/data -c min_dynamic_shared_memory=1MB > TRAP: FailedAssertion("val > base", File: > "../../../../src/include/utils/relptr.h", Line: 67, PID: 21912) Yeah, I see it too. > It looks like this may

Re: A qsort template

On Thu, May 19, 2022 at 1:12 PM Justin Pryzby wrote: > Should these debug lines be removed ? > > elog(DEBUG1, "qsort_tuple"); I agree -- DEBUG1 seems too chatty for something like this. DEBUG2 would be more appropriate IMV. Though I don't feel very strongly about it. -- Peter Geoghegan

Re: A qsort template

Peter Geoghegan writes: > On Thu, May 19, 2022 at 1:12 PM Justin Pryzby wrote: >> Should these debug lines be removed ? >> >> elog(DEBUG1, "qsort_tuple"); > I agree -- DEBUG1 seems too chatty for something like this. DEBUG2 > would be more appropriate IMV. Though I don't feel very strongly abou

Re: 15beta1 crash on mips64el in pg_regress/triggers

I wrote: > I see that the gcc farm[1] has another mips64 machine running Debian > buster, so I've started a build there to see what happens. Many kilowatt-hours later, I've entirely failed to reproduce this on gcc230. Not sure how to investigate further. Given that your original build machine is

Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

On Thu, 19 May 2022 at 11:20, Tom Lane wrote: > The thing that makes this a bit more difficult than it might be is > the special cases we have for known-aligned and so on targets, which > are particularly critical for palloc0 and makeNode etc. So there's > more than one case to look into. But I'

Re: Skipping schema changes in publication

FYI, although the v6-0002 patch applied cleanly, I found that the SGML was malformed and so the pg docs build fails. ~~~ e.g. [postgres@CentOS7-x64 sgml]$ make STYLE=website html { \ echo ""; \ echo ""; \ } > version.sgml '/usr/bin/perl' ./mk_feature_tables.pl YES ../../../src/backend/catalog

Re: Addition of PostgreSQL::Test::Cluster::pg_version()

On Thu, May 19, 2022 at 07:28:53AM -0400, Andrew Dunstan wrote: > Looks ok. PostgreSQL::Version is designed so that the object behaves > sanely in comparisons and when interpolated into a string. I saw that, and that's kind of nice when it comes to write version-specific code paths in the tests ;)

Re: Skipping schema changes in publication

On Fri, May 20, 2022 at 10:19 AM Peter Smith wrote: > > FYI, although the v6-0002 patch applied cleanly, I found that the SGML > was malformed and so the pg docs build fails. > > ~~~ > e.g. > > [postgres@CentOS7-x64 sgml]$ make STYLE=website html > { \ > echo ""; \ > echo ""; \ > } > version.s

Re: Build-farm - intermittent error in 031_column_list.pl

At Thu, 19 May 2022 16:42:31 +0530, Amit Kapila wrote in > On Thu, May 19, 2022 at 3:16 PM Amit Kapila wrote: > > > > This happens after "ALTER SUBSCRIPTION sub1 SET PUBLICATION pub9". The > > probable theory is that ALTER SUBSCRIPTION will lead to restarting of > > apply worker (which we can s

Re: 15beta1 test failure on mips in isolation/expected/stats

Christoph Berg writes: > Debian unstable mips (the old 32-bit one): > --- /<>/src/test/isolation/expected/stats.out2022-05-16 > 21:10:42.0 + > +++ /<>/build/src/test/isolation/output_iso/results/stats.out > 2022-05-18 23:26:56.573000536 + > @@ -2854,7 +2854,7 @@ > > se

Re: 15beta1 test failure on mips in isolation/expected/stats

At Thu, 19 May 2022 21:42:31 -0400, Tom Lane wrote in > Christoph Berg writes: > > Debian unstable mips (the old 32-bit one): > > > --- /<>/src/test/isolation/expected/stats.out 2022-05-16 > > 21:10:42.0 + > > +++ /<>/build/src/test/isolation/output_iso/results/stats.out > > 202

Re: 15beta1 test failure on mips in isolation/expected/stats

At Fri, 20 May 2022 11:02:21 +0900 (JST), Kyotaro Horiguchi wrote in > Doesn't the step s1_table_stats needs a blocking condition (s2_ff)? s/needs/need/; If I removed the step s2_ff, I see the same difference. So I think it is that. Some other permutations seem to need the same. regards. --

Re: 15beta1 test failure on mips in isolation/expected/stats

Kyotaro Horiguchi writes: > At Fri, 20 May 2022 11:02:21 +0900 (JST), Kyotaro Horiguchi > wrote in >> Doesn't the step s1_table_stats needs a blocking condition (s2_ff)? > s/needs/need/; > If I removed the step s2_ff, I see the same difference. So I think it > is that. Some other permutations

Re: pg15b1: FailedAssertion("val > base", File: "...src/include/utils/relptr.h", Line: 67, PID: 30485)

At Thu, 19 May 2022 17:16:03 -0400, Tom Lane wrote in > Justin Pryzby writes: > > ./tmp_install/usr/local/pgsql/bin/postgres -D > > ./src/test/regress/tmp_check/data -c min_dynamic_shared_memory=1MB > > TRAP: FailedAssertion("val > base", File: > > "../../../../src/include/utils/relptr.h", Lin

Re: bogus: logical replication rows/cols combinations

On Thu, May 19, 2022 at 7:54 PM Tom Lane wrote: > > Justin Pryzby writes: > > On Thu, May 19, 2022 at 10:33:13AM +0530, Amit Kapila wrote: > >> I have committed the first patch after fixing this part. It seems Tom > >> is not very happy doing this after beta-1 [1]. The reason we get this > >> inf

Re: 15beta1 test failure on mips in isolation/expected/stats

Hi, On 2022-05-19 21:42:31 -0400, Tom Lane wrote: > > > > seq_scan|seq_tup_read|n_tup_ins|n_tup_upd|n_tup_del|n_live_tup|n_dead_tup|vacuum_count > > > > ++-+-+-+--+--+ > > - 3| 9|5|1|

Re: 15beta1 test failure on mips in isolation/expected/stats

Andres Freund writes: > On 2022-05-19 21:42:31 -0400, Tom Lane wrote: >> Even more interesting, the repeatability varies with the settings >> of max_connections and max_prepared_transactions. > That is indeed quite odd. >> At low values (resp. 20 and 0) I've not been able to make it happen at al

Re: Build-farm - intermittent error in 031_column_list.pl

On Fri, May 20, 2022 at 6:58 AM Kyotaro Horiguchi wrote: > > > > the apply worker will use the existing slot and replication origin > > > corresponding to the subscription. Now, it is possible that before > > > restart the origin has not been updated and the WAL start location > > > points to a lo

Re: 15beta1 test failure on mips in isolation/expected/stats

Hi, On 2022-05-19 22:58:14 -0400, Tom Lane wrote: > What I am wondering about at this point is whether the effects of > pg_stat_force_next_flush() could somehow be delayed until after we > have told the client the command is complete. It shouldn't - it just forces pg_stat_report_stat() to flush (

Re: 15beta1 test failure on mips in isolation/expected/stats

At Thu, 19 May 2022 22:58:14 -0400, Tom Lane wrote in > Kyotaro Horiguchi writes: > Notice that these markers can only delay reporting of the completion > of a step, not the launch of a step. The isolationtester will launch > the next step in a permutation as soon as (A) all prior s

Re: 15beta1 test failure on mips in isolation/expected/stats

Andres Freund writes: > Hm. Does the instability vanish if you switch s2_commit_prepared_a and s1_ff? Like this? diff --git a/src/test/isolation/specs/stats.spec b/src/test/isolation/specs/stats.spec index be4ae1f4ff..70be29b207 100644 --- a/src/test/isolation/specs/stats.spec +++ b/src/test/is

Re: 15beta1 test failure on mips in isolation/expected/stats

Hi, On 2022-05-20 00:22:14 -0400, Tom Lane wrote: > Andres Freund writes: > > Hm. Does the instability vanish if you switch s2_commit_prepared_a and > > s1_ff? > > Like this? Yea. > diff --git a/src/test/isolation/specs/stats.spec > b/src/test/isolation/specs/stats.spec > index be4ae1f4ff..

Re: Tracking notnull attributes inside Var

Hi Tom: Thanks for your attention! On Wed, May 18, 2022 at 1:25 AM Tom Lane wrote: > Andy Fan writes: > > notnulls discussion is forked from UniqueKey stuff, you can see the > > attachment > > for the UnqiueKey introduction. Tom raised his opinion to track the > > nullability > > inside Var[1]

Re: Tracking notnull attributes inside Var

Hi Ashutosh: Nice to see you again! On Tue, May 17, 2022 at 8:50 PM Ashutosh Bapat wrote: > On Sun, May 15, 2022 at 8:41 AM Andy Fan wrote: > > > > > The var in RelOptInfo->reltarget should have nullable = 0 but the var in > > RelOptInfo->baserestrictinfo should have nullable = 1; The beau

Re: 15beta1 test failure on mips in isolation/expected/stats

Andres Freund writes: > On 2022-05-20 00:22:14 -0400, Tom Lane wrote: >> There's some fallout in the expected-file, of course, but this >> does seem to fix it (20 consecutive successful runs now at >> 100/2). Don't see why though ... > I think what might be happening is that the transactional st

Re: Skipping schema changes in publication

Below are my review comments for v6-0002. == 1. Commit message. The psql \d family of commands to display excluded tables. SUGGESTION The psql \d family of commands can now display excluded tables. ~~~ 2. doc/src/sgml/ref/alter_publication.sgml @@ -22,6 +22,7 @@ PostgreSQL documentation

PG15 beta1 sort performance regression due to Generation context change

Hackers, Over the past few days I've been gathering some benchmark results together to show the sort performance improvements in PG15 [1]. One of the test cases I did was to demonstrate Heikki's change to use a k-way merge (65014000b). The test I did to try this out was along the lines of: set

docs: mention "pg_read_all_stats" in "track_activities" description

Hi Regarding the visibility of query information, the description for "track_activities" [1] says: > Note that even when enabled, this information is not visible to all users, > only to superusers and the user owning the session being reported on, so it > should not represent a security risk. [1

Re: A qsort template

On Fri, May 20, 2022 at 5:43 AM Tom Lane wrote: > > Peter Geoghegan writes: > > On Thu, May 19, 2022 at 1:12 PM Justin Pryzby wrote: > >> Should these debug lines be removed ? > >> > >> elog(DEBUG1, "qsort_tuple"); > > > I agree -- DEBUG1 seems too chatty for something like this. DEBUG2 > > woul