Re: RM5576: Improve error messaging if the storage and log directories cannot be created

Hi Dave I have tested the logic on Mac OSX but not on Windows. The "*pwd*" module is not available on windows hence Jenkins build is failing. Attached is the patch to fix for Windows OS. I have used the "*getpass*" module for Windows. Please review it. If looks good I'll commit the code. On Tue,

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

Hi Kushboo, All the menus for all the deleted nodes were handled except Maintenance, backup /restore, import/export. Scripts,Refers View,View/Edit data and Create- child nodes for any parent node which is deleted are handled. Refresh, Delete/drop,drop cascade and properties were already handled f

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

Hi Urgh, didn't realise pwd wasn't available on Windows :-(. What about just using getpass.getuser() everywhere? According to the docs it falls back to using pwd where that's supported anyway: https://docs.python.org/3.8/library/getpass.html On Tue, Jun 2, 2020 at 8:00 AM Akshay Joshi wrote: >

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

Hi Dave On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: > Hi > > Urgh, didn't realise pwd wasn't available on Windows :-(. What about just > using getpass.getuser() everywhere? According to the docs it falls back to > using pwd where that's supported anyway: > https://docs.python.org/3.8/library

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi wrote: > Hi Dave > > On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: > >> Hi >> >> Urgh, didn't realise pwd wasn't available on Windows :-(. What about just >> using getpass.getuser() everywhere? According to the docs it falls back to >> using pwd wher

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

I'll change and commit the code. On Tue, Jun 2, 2020 at 1:55 PM Dave Page wrote: > > > On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi > wrote: > >> Hi Dave >> >> On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: >> >>> Hi >>> >>> Urgh, didn't realise pwd wasn't available on Windows :-(. What about

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

Thanks. On Tue, Jun 2, 2020 at 9:27 AM Akshay Joshi wrote: > I'll change and commit the code. > > On Tue, Jun 2, 2020 at 1:55 PM Dave Page wrote: > >> >> >> On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Tue, Jun 2, 2020 at 1:41

pgAdmin 4 commit: The 'pwd' module is not available on Windows, so repl

The 'pwd' module is not available on Windows, so replacing it with the 'getpass' module. refs #5576 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1a232a1f19b003ed261aad8bcd5235d160d6b62 Modified Files -- web/pgadmin/setup/data

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

Hi Satish, - On failure, you have added a new condition if (e.status == 410) at some places, this is not necessary as we have generalised code for that. - Please maintain the consistency in messages, you can check the GONE message template, we do have them at some places. (Example: on Database exp

pgAdmin 4 commit: Include postgresql-libs in our Yum repos.

Include postgresql-libs in our Yum repos. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e67a0b0e7624dd638253fbfcb74acf2d6504035 Modified Files -- pkg/redhat/build.sh | 11 +-- pkg/redhat/setup.sh | 19 +++

pgAdmin 4 commit: We need yum-utils. Fix the rpmmacros message whilst p

We need yum-utils. Fix the rpmmacros message whilst passing. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2549085872c435bc08e1f00a68e0893f779e6ca1 Modified Files -- pkg/redhat/setup.sh | 23 +++ 1 file changed

pgAdmin 4 commit: Include the PostgreSQL repo so we get the latest libp

Include the PostgreSQL repo so we get the latest libpq Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f58552f60235cf79a8c63f9c10bc4a29377ddfa Modified Files -- pkg/debian/setup.sh | 7 ++- 1 file changed, 6 insertions(+), 1 de

pgAdmin 4 commit: Quieten pushd/popd

Quieten pushd/popd Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=445abf1e3152277901879b739e0ddcd131bee0c1 Modified Files -- pkg/linux/build-functions.sh | 4 ++-- pkg/src/build.sh | 4 ++-- 2 files changed, 4 insertions

pgAdmin 4 commit: Include the libpq5 deb in the Debian/Ubuntu repos.

Include the libpq5 deb in the Debian/Ubuntu repos. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3d0319dba7ef91561c508cb480dd5fbe9297c0cf Modified Files -- pkg/debian/build.sh | 9 - 1 file changed, 8 insertions(+), 1 dele

pgAdmin 4 commit: Fix message.

Fix message. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a0efc0e869b3a06499154676bdbd76f47b75fce Modified Files -- pkg/redhat/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

Hi Khushboo, The Reason for checking status==410 is to show error dialog to the user which will not go unnoticed at any situation. For closing the empty query tool we need this error dialog pop which shows the error message and closes the empty query tool for deleted nodes upon clicking ok. Chang

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

The patch looks good to me. On Tue, Jun 2, 2020 at 6:36 PM Satish V wrote: > Hi Khushboo, > > The Reason for checking status==410 is to show error dialog to the user > which will not go unnoticed at any situation. For closing the empty query > tool we need this error dialog pop which shows the e

pgAdmin 4 commit: Ensure that proper error should be displayed for the

Ensure that proper error should be displayed for the deleted node. Fixes #3669 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d22e27658671dac11d91e4ce7ecf72a4ea167e39 Author: Satish V Modified Files -- docs/en_US/release_notes_4_

Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

Thanks, patch applied. On Tue, Jun 2, 2020 at 6:36 PM Satish V wrote: > Hi Khushboo, > > The Reason for checking status==410 is to show error dialog to the user > which will not go unnoticed at any situation. For closing the empty query > tool we need this error dialog pop which shows the error