Re: pgAdmin is freezing

Yes, its same for all objects in the database. Thanks,Rj Sent from Yahoo Mail for iPhone On Sunday, April 19, 2020, 8:01 PM, Khushboo Vashi wrote: Hi, On Sat, Apr 18, 2020 at 1:41 AM Nagaraj Raj wrote: Hi, pgAdmin is freezing for other activities when dropping any table or index if comman

[pgAdmin][RM5401] Object name does not displayed in search object if object name contains special characters

Hi Hackers, Attached is the patch to fix the issue in search objects where object name does not display correctly if it html characters. Code is changed to escape the HTML chars in Object name and path. Code is also changed to escape single quotes in the like clause of the search query. Please re

[pgAdmin][RM5415] Query tool context menu on collection nodes not working

Hi Hackers, Attached is a small fix to make the query tool context menu on collection node work. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM5415.patch Description: Binary

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Thanks for the feedback. 1. The test case is particularly written for Temporary table with Commit Drop, so please mention it in the comments. *- Done* 2. Also, the class TestQueryUpdatableResultset is been inherited, so no need to repeat the same methods, for example: setUp, _execute_select_sql,

[Patch][pgAdmin4]: Fix pgagent issues

Hi, Please find the attached patch to stabilize the pgagent and fix below issues. - Reverse engineering SQL and MSQL was incorrect when the user added a job schedule with exception Fixes #5356 - Job schedule exception time was not showing correctly in SQL tab. - Identify the job step

pgAdmin 4 commit: Some more gettext() usage fixes:

Some more gettext() usage fixes: - fixed `%` vs. `.format()`   - unified texts and usage `%s` vs. `{}`/`{0}`   - improved text sentences for translate   - added gettext for next texts Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36a3d4e53b

pgAdmin 4 commit: Ensure that the query tool context menu should work o

Ensure that the query tool context menu should work on the collection nodes. Fixes #5415 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05abb9e43062a1c6155af7d57076aa5d7e2768a6 Author: Aditya Toshniwal Modified Files -- docs/en_

pgAdmin 4 commit: Fixed search object issue when the object name contai

Fixed search object issue when the object name contains special characters. Fixes #5401 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc4571a3c87e3bce976230500dad6e2eee61e653 Author: Aditya Toshniwal Modified Files -- docs/en_U

pgAdmin 4 commit: Fixed an issue where schema diff marks an identical t

Fixed an issue where schema diff marks an identical table as different. Fixes #5350 Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315 Ignore the keys from the source and target list and also sort both the lists. Branch -- master Details -

pgAdmin 4 commit: Fixed an issue when the user creates a temporary tabl

Fixed an issue when the user creates a temporary table with 'on commit drop as' clause. Fixes #4946 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f282b2688397e461fcc181befcb18970f3ba280f Author: Amol Vyavahare Modified Files --

pgAdmin 4 commit: Fixed an issue where the search object module unable

Fixed an issue where the search object module unable to locate the object in the browser tree. Fixes #5396 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7361470b64a2db9d9349e7a71da636d651e38389 Author: Aditya Toshniwal Modified Files -

pgAdmin 4 commit: Fixed an issue where the checkbox is not visible on C

Fixed an issue where the checkbox is not visible on Configuration dialog in runtime for the dark theme. Fixes #5402 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b0b60da84acf13250238d63b724b5265f6bfc4c0 Author: Neel Patel Modified Files --

Re: pgAdmin 4 - next gettext usage fixes

Thanks, patch applied. On Sun, Apr 19, 2020 at 5:50 PM Libor M. wrote: > Hi, > I sending patch for slightly modified the use of gettext: > - fixed `%` vs. `.format()` > - unified texts and usage `%s` vs. `{}`/`{0}` > - improved text sentences for translate > - added gettext for next texts > > Be

Re: [pgAdmin][RM5396] Unable to locate this object in the browser in search objects

Thanks, patch applied. On Mon, Apr 20, 2020 at 11:36 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the updated patch to also make required changes in the test > cases. > Please review. > > On Mon, Apr 20, 2020 at 11:28 AM Akshay Joshi < > akshay.jo...@enter

Re: [pgAdmin][RM5401] Object name does not displayed in search object if object name contains special characters

Thanks, patch applied. On Mon, Apr 20, 2020 at 1:49 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue in search objects where object name > does not display correctly if it html characters. > Code is changed to escape the HTML

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Thanks, patch applied. On Mon, Apr 20, 2020 at 2:38 PM Amol Vyavahare < amol.vyavah...@enterprisedb.com> wrote: > Thanks for the feedback. > > 1. The test case is particularly written for Temporary table with Commit > Drop, so please mention it in the comments. > *- Done* > > 2. Also, the class T

Re: [pgAdmin][RM5415] Query tool context menu on collection nodes not working

Thanks, patch applied. On Mon, Apr 20, 2020 at 2:01 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a small fix to make the query tool context menu on collection > node work. > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin H

[pgAdmin][RM4545]: In grant wizard, last object is not selectable

Hi Hackers, Attached is a patch to fix the issue in the grand wizard. This patch will fix: 1. If we try to select the last object type in grant wizard, it's not getting selected. 2. If we filter any object and select it, all the listed object types are getting selected. 3. When yo

[pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Hi Hackers, Attached is the patch to fix the rightmost & bottom tooltip crop issues in the explain query plan. FYI : While explaining a large query if we hover the rightmost or bottom icon the tooltip is cropped & partially visible, which is fixed in this patch. Please review. PFA. -- Regards,

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

Hi Khushboo, I have modified the code as per review comments. Please review the attached patch file. Thanks! On Mon, Apr 20, 2020 at 10:56 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Navnath, > > Review comments: > > 1. If we have multiple Primary keys, then we should inc

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

Hi Khushboo, Please hold this patch for review I'm still optimizing the code in the patch. On Mon, Apr 20, 2020 at 9:16 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Khushboo, >I have modified the code as per review comments. Please review the > attached patch file. >

[pgAdmin][RM3269] Slider jumps up issue in DataView panel

Hi Hackers, The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool. Fix uses *rows_affected *field to create dummy rows (Apart from the first *batch of rows). *Dummy rows will be updated as and when they are requ

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

Hello Hackers, It's related to applying data sorting on table data by primary key. With the existing implementation, we can view the table's data using 4 options with the different orders by default 1 - All Rows (No order) 2 - First 100 rows (ASC order) 3 - Last 100 rows (DESC order) 4 - F