Fixes for pgAdmin4 messages

Hello, While translating the messages, I encountered some English messages, that I think should be fixed. Please consider applying the attached patches. If you have any concerns or questions, I'm ready to explain all the fixes proposed. And I have a question - do you use some kind of style g

Re: Fixes for pgAdmin4 messages

Hi, Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of). On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin wrote: > Hello, > > While translating the messages, I encountered some English messages, that > I think should be

Re: Fixes for pgAdmin4 messages

01.11.2017 12:04, Dave Page wrote: Hi, Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of). Sure, If you are going to accept all (or almost all) the changes, a single patch is better. On Wed, Nov 1, 2017 at 7:33 AM,

[pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Hi, PFA patch to fix the issue where "Rows (estimated)" field was not displaying long number properly. RM#2386 I have also added the code to count actual rows in a table [ "Rows (counted)" filed ] which was missing. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Ent

pgAdmin 4 commit: Update psycopg2 requirement to ensure 10.x+ features

Update psycopg2 requirement to ensure 10.x+ features work. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=714a429879d15f3b923b6f78001057572d82547f Author: Murtuza Zabuawala Modified Files -- requirements.txt | 2 +- 1 file changed

Re: [pgAdmin4][Patch]: To update Psycopg2 version

Thanks, applied. On Tue, Oct 31, 2017 at 1:15 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch, which will allow us to use newer version Psycopg2 which > comes with libpq v.10 support. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.ent

pgAdmin 4 commit: Various string improvements and fixes.

Various string improvements and fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9be1364d1afa92f9525cd9df2f4420ee2f4e423f Author: Alexander Lakhin Modified Files -- .../databases/foreign_data_wrappers/__init__.py| 4 ++-

pgAdmin 4 commit: Message catalog update. Current stats look like:

Message catalog update. Current stats look like: 1503 of 1756 messages (85%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1716 of 1756 messages (97%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1494 of 1756 messages (85%) translated in pgadmin/translations/pl/

Re: Fixes for pgAdmin4 messages

Hi On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin wrote: > 01.11.2017 12:04, Dave Page wrote: > > Hi, > > Can you re-sent this as a single patch please? Working through 23 will > take me significantly more time (which I have little of). > > Sure, If you are going to accept all (or almost all)

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Hi On Wed, Nov 1, 2017 at 11:58 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where "Rows (estimated)" field was not > displaying long number properly. > RM#2386 > > I have also added the code to count actual rows in a table [ "Rows > (cou

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Thanks Dave, I'll check the implementation in pgAdmin3 & send new patch with suggested changes. On Wed, Nov 1, 2017 at 6:41 PM, Dave Page wrote: > Hi > > On Wed, Nov 1, 2017 at 11:58 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue w

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Hi Dave, Please find updated patch. ​-- Murtuza​ On Wed, Nov 1, 2017 at 6:50 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Dave, I'll check the implementation in pgAdmin3 & send new patch > with suggested changes. > > > On Wed, Nov 1, 2017 at 6:41 PM, Dave Page w

Re: Fixes for pgAdmin4 messages

Hello Dave, 01.11.2017 16:05, Dave Page wrote: Hi On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin > wrote: I did - albeit with a couple of additional tweaks. Thanks! No, I don't think there are reasons to have exclamation marks. pgAdmin shouldn't ever be surpri

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Hi Murtuza, I think for tables having row count more than preference count it should show preference count with plus '+' sign instead empty. eg. 2000+ (for table with rows more than 2000 and for preference count of 2000.) [image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* E

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

On Wed, Nov 1, 2017 at 2:25 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Murtuza, > > I think for tables having row count more than preference count it should > show preference count with plus '+' sign instead empty. > eg. 2000+ (for table with rows more than 2000 and for pref

Feature request: show time elapsed

I'm currently migrating from pgadmin III and missed the live time elapsed feature that I think is good for developing long run queries. Thanks, Caio.

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

In my opinion, displaying 2000+ instead of actual value doesn't looks good. Let say my threshold is set to 5000 and I have 1million rows, displaying 5000+ instead of actual value doesn't looks good. OR What we can do is, we can hide the field if it is empty/or less than threshold. Thoughts? On

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

On Wed, Nov 1, 2017 at 2:40 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > In my opinion, displaying 2000+ instead of actual value doesn't looks good. > > Let say my threshold is set to 5000 and I have 1million rows, displaying > 5000+ instead of actual value doesn't looks go

pgAdmin 4 commit: Remove more exclamation marks from error messages.

Remove more exclamation marks from error messages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23d431fb54b0bd5fd15ecbe2a8f6e22a0caacd38 Author: Alexander Lakhin Modified Files -- web/pgadmin/browser/server_groups/servers/__ini

pgAdmin 4 commit: Another message catalog update. Stats:

Another message catalog update. Stats: 1481 of 1750 messages (84%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1694 of 1750 messages (96%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1472 of 1750 messages (84%) translated in pgadmin/translations/pl/LC_MESSAGE

Re: Fixes for pgAdmin4 messages

Hi On Wed, Nov 1, 2017 at 2:13 PM, Alexander Lakhin wrote: > Hello Dave, > 01.11.2017 16:05, Dave Page wrote: > > Hi > > On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin > wrote: > >> >> > I did - albeit with a couple of additional tweaks. > > Thanks! > > No, I don't think there are reasons to

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Hi Dave, Please find updated patch with suggested changes. On Wed, Nov 1, 2017 at 8:42 PM, Dave Page wrote: > > > On Wed, Nov 1, 2017 at 2:40 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> In my opinion, displaying 2000+ instead of actual value doesn't looks >> good. >> >> Let say my thr

Re: pgAdmin 4: Russian translation

Thanks - committed! On Wed, Nov 1, 2017 at 5:08 PM, Alexander Lakhin wrote: > Please update the Russian translation for the current messages. > > Best regards, > -- > Alexander Lakhin > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > > -- Dave Page Blog:

pgAdmin 4 commit: Update Russian translation.

Update Russian translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2dcd2cc77f1a44f64dd97d16efd9624aecdc53c4 Author: Alexander Lakhin Modified Files -- .../translations/ru/LC_MESSAGES/messages.mo| Bin 161826 -> 164

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Hi I created a table with: create table bigun as select * from generate_series(0, 100) I then selected it in the treeview, and it showed 0 for estimated rows, and nothing at all for counted rows. I ran a vacuum full on the new table, and now it fails to display the properties. On the console

Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated) field in Table's properties

Oops..that was due to float4->text (rel.reltuples::text) datatype casting in postgres. Please find updated patch. On Thu, Nov 2, 2017 at 2:31 AM, Dave Page wrote: > Hi > > I created a table with: > > create table bigun as select * from generate_series(0, 100) > > I then selected it in the

[pgAdmin4][Patch]: RM #2651 : "Create Script" view of functions always shows "ROWS 0"

Hi, Please find the attached patch to fix RM #2651 : "Create Script" view of functions always shows "ROWS 0". Right now function displays ROWS 0 in case of empty ROWS field. Now it will display correct value of the filed. This has been fixed in Create/Update/View function. Thanks, Khushboo diff