Re: Next release

​Hi​ On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> On Fri, Aug 25, 2017 at 1:03 AM, Dave Page wrote: >> >>> >>> >>> On Thu, Aug 24, 2017 at 8:28 PM,

Re: Next release

On Fri, Aug 25, 2017 at 9:15 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi​ > > On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi

Re: Next release

One more thing that this will only work for future pgAdmin4 versions -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Aug 25, 2017 at 1:48 PM, Dave Page wrote: > > > On Fri, Aug 25, 2017 at 9:15 AM, Surinder

pgAdmin 4 commit: Properly cleanup after running the FTS test cases.

Properly cleanup after running the FTS test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd04cfaaa8bd6830b8c6277d5580fe5b1bb0aabe Author: Navnath Gadakh Modified Files -- .../foreign_data_wrappers/tests/test_fdw_add.py

Re: Next release

On Fri, Aug 25, 2017 at 9:28 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > One more thing that this will only work for future pgAdmin4 versions > Yeah :-( > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise P

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

Thanks, patch applied. On Fri, Aug 25, 2017 at 6:47 AM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch. The code added to tear down the FTS > related objects. As this issue was random, I have tested this patch on all > 12 servers (pg/p

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

Hi On Thu, Aug 24, 2017 at 9:02 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to allow user to provide custom path for SSL certificates and > also allow user to pass .pgpass file when making server connection. > RM#2649 > RM#2650 > > *SSL certificates opti

Re: [pgAdmin4][RM2586] Cleanup feature test

Hi On Thu, Aug 24, 2017 at 11:51 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Last week Sarah, Matt and I had call regarding some issues with feature > test cases. > For example in auto commit disable test scenario from query tool test > cases by removing code line > *se

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

Hi Dave, On Fri, Aug 25, 2017 at 2:14 PM, Dave Page wrote: > Hi > > On Thu, Aug 24, 2017 at 9:02 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to allow user to provide custom path for SSL certificates and >> also allow user to pass .pgpass file when making server conne

pgAdmin 4 commit: Bump the version number for 2.0. Let's get testing st

Bump the version number for 2.0. Let's get testing started ASAP! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb9eee47bd9b2745b613336f0c4ef76d19fe2bde Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +-

Re: Next release

Hi On Fri, Aug 25, 2017 at 2:04 PM, Dave Page wrote: > > > On Fri, Aug 25, 2017 at 9:28 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> One more thing that this will only work for future pgAdmin4 versions >> > > > Yeah :-( > > >> >> -- >> *Harshal Dhumal* >> *Sr. Software Eng

pgAdmin 4 commit: Ship with pre-configured paths that can work in both

Ship with pre-configured paths that can work in both Server and Desktop modes out of the box. Fixes #2662 Ship the web code using server mode with appropriate paths by default and enable the runtime to override the mode, and force into desktop changing the appropriate paths to user-specific one

Re: pgAdmin 4 commit: Ship with pre-configured paths that can work in both

All, Please note, this patch will probably break your dev environments :-). You may need to override a few more things in config_local.py, or as in my case, remove a few things. Devrim; we'll need RPM changes for this. We need to work together to thoroughly test those changes. Please book time in

Build failed in Jenkins: pgadmin4-master-python36 #291

See Changes: [Dave Page] Bump the version number for 2.0. Let's get testing started ASAP! [Dave Page] Ship with pre-configured paths that can work in both Server and Desktop --

Re: pgAdmin 4 commit: Ship with pre-configured paths that can work in both

Hi Dave, On Fri, 2017-08-25 at 10:59 +0100, Dave Page wrote: > Devrim; we'll need RPM changes for this. We need to work together to > thoroughly test those changes. Please book time in my calendar to > collaborate. Ack. Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com Post

Build failed in Jenkins: pgadmin4-master-python26 #416

See Changes: [Dave Page] Bump the version number for 2.0. Let's get testing started ASAP! [Dave Page] Ship with pre-configured paths that can work in both Server and Desktop --

pgAdmin 4 commit: Ensure builtins.SERVER_MODE is present so the docs bu

Ensure builtins.SERVER_MODE is present so the docs build cleanly. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e5ea582943dd345c6b5e62a1d5213f89f6ca834 Modified Files -- docs/en_US/build_code_snippet.py | 8 docs/en_US/c

Build failed in Jenkins: pgadmin4-master-python35 #293

See Changes: [Dave Page] Ship with pre-configured paths that can work in both Server and Desktop -- [...truncated 360.50 KB...] 25 08 2017 10:19:02.541:WARN

Build failed in Jenkins: pgadmin4-master-python27 #295

See Changes: [Dave Page] Ship with pre-configured paths that can work in both Server and Desktop -- [...truncated 361.47 KB...] PhantomJS 2.1.1 (Linux 0.

Build failed in Jenkins: pgadmin4-master-python34 #287

See Changes: [Dave Page] Ship with pre-configured paths that can work in both Server and Desktop [Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly. -

pgAdmin 4 commit: Branch refs/heads/REL-1_X was created

Branch refs/heads/REL-1_X was created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=shortlog;h=refs/heads/REL-1_X

Build failed in Jenkins: pgadmin4-master-python33 #295

See Changes: [Dave Page] Ship with pre-configured paths that can work in both Server and Desktop [Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly. -

Build failed in Jenkins: pgadmin4-master-python35 #294

See Changes: [Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly. -- [...truncated 797.09 KB...] Adding en_US/images/index_general.png Ad

pgAdmin 4 commit: Regression tests aren't run under the runtime, so no

Regression tests aren't run under the runtime, so no need to check for builtins.SERVER_MODE's existence. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=507d8b3fe41fcb7d402822f3b02c0b2cbc85f7b7 Modified Files -- web/regression/run

pgAdmin 4 commit: Ensure builtins.SERVER_MODE is handled if running set

Ensure builtins.SERVER_MODE is handled if running setup.py standalone. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a65f7b330b48b83adfde0ca661c0e6ec9f05909b Modified Files -- web/setup.py | 10 ++ 1 file changed, 10 inser

Build failed in Jenkins: pgadmin4-master-python26 #417

See Changes: [Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly. -- [...truncated 816.81 KB...] Adding en_US/images/import_export_pw.png

Build failed in Jenkins: pgadmin4-master-python36 #292

See Changes: [Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly. [Dave Page] Regression tests aren't run under the runtime, so no need to check for [Dave Page] Ensure builtin

pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD

Update docs to more accurately reflect the SERVER_MODE config requirements. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c016f0993fb557052cce7e11cd6ad818bd7c3a3 Modified Files -- docs/en_US/desktop_deployment.rst | 39 +

Build failed in Jenkins: pgadmin4-master-python27 #296

See Changes: [Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly. [Dave Page] Regression tests aren't run under the runtime, so no need to check for [Dave Page] Ensure builtin

Re: pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD

Akshay, Ashesh, I've committed these doc changes to reflect the paths/SERVER_MODE changes. Could you both please review them and let me know if I missed anything of importance, or if anything isn't clear? Thanks. On Fri, Aug 25, 2017 at 12:13 PM, Dave Page wrote: > Update docs to more accurate

pgAdmin 4 commit: Ensure the SERVER_MODE changes don't break the PIP bu

Ensure the SERVER_MODE changes don't break the PIP build. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=857990955864ebc78697e6de0455c45a36571907 Modified Files -- pkg/pip/setup_pip.py | 8 1 file changed, 8 insertions(+)

Build failed in Jenkins: pgadmin4-master-python26 #418

See Changes: [Dave Page] Regression tests aren't run under the runtime, so no need to check for [Dave Page] Ensure builtins.SERVER_MODE is handled if running setup.py standalone. [Dave Page] Update d

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

I'm suggesting that it be pushed Dave Cramer On 24 August 2017 at 23:00, Teng Zhang wrote: > Sure, you can get as much as you like. > Thanks > > -- Forwarded message -- > From: Dave Cramer > Date: Thu, Aug 24, 2017 at 8:34 PM > Subject: Re: [pgadmin4][Patch] Greenplum specific

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer wrote: > I'm suggesting that it be pushed > Akshay is already on to it, and currently reviewing it. Will push it once get the confirmation. -- Thanks, Ashesh > > Dave Cramer > > On 24 August 2017 at 23:00, Teng Zhang wrote: > >> Sure, you can get as

Jenkins build is back to normal : pgadmin4-master-python33 #296

See

Jenkins build is back to normal : pgadmin4-master-python34 #288

See

Re: pgAdmin4 - Tree view icons for final reveiw

Dave and all, Out of curiosity (because I’m writing a book that includes pgAdmin screen grabs), do you expect these icons to make it into your September release? Thanks, Anthony On August 23, 2017 at 4:03:42 AM, Murtuza Zabuawala ( murtuza.zabuaw...@enterprisedb.com) wrote: Hi Chethana, On W

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Yes, that's my expectation. Hopefully they'll go in in the next week or so. On Fri, Aug 25, 2017 at 12:40 PM, Anthony DeBarros wrote: > Dave and all, > > Out of curiosity (because I’m writing a book that includes pgAdmin screen > grabs), do you expect these icons to make it into your Septemb

pgAdmin 4 commit: Fix the feature tests failuers.

Fix the feature tests failuers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5dd375dd2081c126b7b3b9f0dba21976d2a45a1f Author: Wenlin Zhang Modified Files -- web/pgadmin/feature_tests/query_tool_journey_test.py | 7 --- web/

Jenkins build is back to normal : pgadmin4-master-python35 #295

See

Re: [pgAdmin4][patch] Fix feature tests failure

On Wed, Aug 16, 2017 at 8:54 AM, Violet Cheng wrote: > Hi, > > Is there any update on this patch? Will it be committed soon? > > Hi Violet, I've committed the patch with some changes. Removed one more occurrence of '_assert_not_clickable_because_out_of_view' added later by Hao Wang in commit: 51

Jenkins build is back to normal : pgadmin4-master-python36 #293

See

pgAdmin 4 commit: Add package run scripts to allow to run the webpack i

Add package run scripts to allow to run the webpack in watch mode, also added '--progress' option to make it more interactive. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f711336a6b96b6a893605cd28beb6486d186975d Author: Surinder Kumar Mod

Re: [pgAdmin4][Patch]: Add command under scripts to run webpack bundle in watch mode

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, Aug 9, 2017 at 6:51 PM, Surinder Kumar < surinder.ku...@enterprisedb.

Jenkins build is back to normal : pgadmin4-master-python27 #297

See

pgAdmin 4 commit: Fixes #2560 - View is not fully qualified in Trigger

Fixes #2560 - View is not fully qualified in Trigger definition. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3babd78aa9f337344480f56359f9eab66d9b56a Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/server

Re: [pgAdmin4][PATCH] Fix trigger's reversed engineered SQL for View

On Fri, Aug 18, 2017 at 1:18 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where view is not fully qualified in > Trigger definition. > RM#2560 > Thanks - committed! -- Thanks, Ashesh > > -- > Regards, > Murtuza Zabuawala > Enterpri

Jenkins build is back to normal : pgadmin4-master-python26 #419

See

pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

Greenplum specific DDL and Dashboard display changes. Initial patch by Sarah McAlear. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46c5df4e7bb7abba6896cfb86eed43914a74850a Author: Teng Zhang Modified Files -- web/config.py

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Thanks patch applied. I haven't tested it on GPDB. On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi wrote: > On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer wrote: > >> I'm suggesting that it be pushed >> > Akshay is already on to it, and currently reviewing it. > Will push it once get the confirmati

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Given that Greenplum is going to GA next month can we get that stable OSS version included in the CI? Rob On Aug 25, 2017 8:27 AM, "Akshay Joshi" wrote: > Thanks patch applied. I haven't tested it on GPDB. > > On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrot

[pgAdmin4][Patch]: Ensure any changes to the config database are backward compatible

​Hi,​ We will use config variable `SCHEMA_VERSION` to keep track of SQLite database changes. Whenever there is any change is performed in the database, the count of schema version will be incremented by 1 and the same will be updated in SQLite table `version`. So, these changes make sure the data

Re: [pgAdmin4][Patch]: Ensure any changes to the config database are backward compatible

Created an RM to track this issue. On Fri, Aug 25, 2017 at 7:19 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi,​ > > We will use config variable `SCHEMA_VERSION` to keep track of SQLite > database changes. Whenever there is any chan

Build failed in Jenkins: pgadmin4-master-python27-feature #10

See Changes: [Dave Page] Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593 [Dave Page] Fix test assertion. [Dave Page] Update yarn.lock [Dave Page] Ensure the appropriate entry is

Re: pgAdmin 4 commit: Fix the feature tests failuers.

QueryToolFeatureTest seems to be failing on both Jenkins and my test mac system since this was applied. The other one below seems more intermittent. == ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) Q

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

I believe this patch has broken my installation. When I try to run now, I get: Exception in thread Thread-1: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 810, in __bootstrap_inner self.run() File "/Syste

Re: pgAdmin 4 commit: Fix the feature tests failuers.

On Fri, Aug 25, 2017 at 8:26 PM, Dave Page wrote: > QueryToolFeatureTest seems to be failing on both Jenkins and my test mac > system since this was applied. The other one below seems more intermittent. > > == > ERROR: runTest (p

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

On Fri, Aug 25, 2017 at 8:30 PM, Dave Page wrote: > I believe this patch has broken my installation. When I try to run now, I > get: > > Exception in thread Thread-1: > Traceback (most recent call last): > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading

pgAdmin 4 commit: Allow queries to be cancelled from the dashboard, and

Allow queries to be cancelled from the dashboard, and display additional info in the subnode control. Fixes #2597 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74db8374173fe42112c9ed9c3477c6301337e290 Author: Murtuza Zabuawala Modified Fil

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Thanks, patch applied. On Wed, Aug 9, 2017 at 12:19 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find the updated patch with new UI style in dashboard subnode > control based on Chethana's design suggestion. > > @Shirley, > Yes, DBA needs to click on the dro

pgAdmin 4 commit: Define the utility path lable, and help message for t

Define the utility path lable, and help message for the Greenplum database server, shown in the preferences dialog. Also, fixed the issue, when server type is not defined in the DEFAULT_BINARY_PATHS, in the configuration. Branch -- master Details --- https://git.postgresql.org/gitweb?p=p

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

On Fri, Aug 25, 2017 at 9:14 PM, Ashesh Vashi wrote: > On Fri, Aug 25, 2017 at 8:30 PM, Dave Page wrote: > >> I believe this patch has broken my installation. When I try to run now, I >> get: >> >> Exception in thread Thread-1: >> Traceback (most recent call last): >> File >> "/System/Library

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

Thanks. On Fri, Aug 25, 2017 at 5:06 PM, Ashesh Vashi wrote: > On Fri, Aug 25, 2017 at 9:14 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Fri, Aug 25, 2017 at 8:30 PM, Dave Page wrote: >> >>> I believe this patch has broken my installation. When I try to run now, >>> I get:

fix keyerror problems

See attached patch Dave Cramer keyerror.patch Description: Binary data

Re: fix keyerror problems

how about this? default_path = ( config.DEFAULT_BINARY_PATHS.get(st.stype, "") ) On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer wrote: > See attached patch > > > Dave Cramer >

Re: fix keyerror problems

Even better. I'm a python noob so help me out! Dave Cramer On 25 August 2017 at 15:17, Harshal Dhumal wrote: > how about this? > > default_path = ( > config.DEFAULT_BINARY_PATHS.get(st.stype, "") > ) > > > > > On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer > wr

pgAdmin 4 commit: Using the proper python syntax to fetch the default b

Using the proper python syntax to fetch the default binary path for different servers types. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b1ad89fb4a772c0b396cb8907a1a1ce5973bc82e Author: Harshal Dhumal Modified Files -- web/pga

Re: fix keyerror problems

On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer wrote: > See attached patch > I have already committed a patch for the same. But - improved the syntax as per Harshal's suggestion. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company