Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Hi Dave Please find updated patch, On Fri, Jun 23, 2017 at 7:09 PM, Dave Page wrote: > Hi > > I'm unable to properly test this, as the debugger doesn't even seem to > launch for a non-superuser. I just get a white tab, and a whole lot of > polling indefinitely. Can you debug if you're not a sup

crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

I am running on following Gentoo system with Python 3.5 as default (although i have 2.7 and 3.4 available to switch as well). I compiled from source code via github: commit 15cb9fc35b41736a331a452b9303a79e8f13ee36 (HEAD -> master, origin/master, origin/HEAD) The error appears when I want to click

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

Hi, Can you send the patch for the same. I think this is the valid fix. Thanks, Khushboo On Tue, Jun 27, 2017 at 3:02 PM, Ladislav Jech wrote: > I am running on following Gentoo system with Python 3.5 as default > (although i have 2.7 and 3.4 available to switch as well). > > I compiled from s

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

Hi, It will be good if you support fully github or any GIT repository for managing pull requests. Is there any or you wan't me to generate *.patch file? I am new to pgadmin 4, so not sure how this works. Let me know. Ladislav 2017-06-27 11:52 GMT+02:00 Khushboo Vashi : > Hi, > > Can you send the

pgAdmin 4 commit: Use on-demand loading for results in the query tool.

Use on-demand loading for results in the query tool. Fixes #2137 With a 27420 row query, pgAdmin III runs the query in 5.873s on my laptop. pgAdmin 4 now takes ~1s. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c65158312d6db6425abfde67d4f22

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Thanks - patch committed! Awsome job :-) On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find rebased patch. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise Postgre

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Tue, Jun 27, 2017 at 6:33 PM, Dave Page wrote: > Thanks - patch committed! > > Awsome job :-) > Woohoo! -- Thanks & Regards, Ashesh Vashi > > On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find rebased patch. >> >> -- >> *Har

Re: [pgadmin-hackers][patch] History Detail Pane

Can you rebase this patch please? Thankfully I think we're basically at the end of our changes in this area! On Mon, Jun 26, 2017 at 10:08 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Surinder, > > You can find our answers inline and attached the patch with the c

pgAdmin 4 commit: Allow the user to close the dashboard panel. Fixes #2

Allow the user to close the dashboard panel. Fixes #2506 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a87ee6d059e478a9ed6bea4fa628e93e1ce46c50 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/static/js/panel.js

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Thanks, patch applied. On Tue, Jun 27, 2017 at 2:58 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Jun 26, 2017 at 5:08 PM, Dave Page wrote: > >> Hi >> >> Looks good, except that when I close the d

[pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

Hi, Please find patch to add preferences for brace matching and auto brace closing in SQL editor. RM#2513 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/__init__.py b/web/pgadmin/browser/__init__.py index

Jenkins build is back to normal : pgadmin4-master-python26 #320

See

pgAdmin 4 commit: Add preferences to enable brace matching and brace cl

Add preferences to enable brace matching and brace closing in the SQL editors. Fixes #2513 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b49bb8b220e2dd28641e2b424e225e6612f147b Author: Murtuza Zabuawala Modified Files -- web/p

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

Thanks - patch applied with some minor tweaks to enable both options by default and adjust the help wording. However, I realised right as I committed it, that you haven't updated the docs. Can you please update the screenshots affected and add the two new options to the docs please? Thanks. On T

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

Sure Dave, I'll do the needful. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 27, 2017 at 7:29 PM, Dave Page wrote: > Thanks - patch applied with some minor tweaks to enable both options by > default and adjust the help wor

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Hi I've had to revert this. Whilst it seems to work, after showing/hiding the dashboard, I later find that when I completely reload the app, it fails, leaving just the object menu present. I haven't come up with a concrete case to reproduce it. In the console, I see: wcDocker.min.js:38 Uncaught

pgAdmin 4 commit: Revert "Allow the user to close the dashboard panel.

Revert "Allow the user to close the dashboard panel. Fixes #2506" This reverts commit a87ee6d059e478a9ed6bea4fa628e93e1ce46c50. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96412b32196c0e4da2104d323a79106d43265606 Modified Files --

pgAdmin 4 commit: Add stylesheet to override brace matching styles, mis

Add stylesheet to override brace matching styles, missed from the feature commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e413186d239150cc993ac100601c10ded1000400 Modified Files -- web/pgadmin/static/css/codemirror.overrid

pgAdmin 4 commit: Overhaul the query history tab to allow browsing of t

Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282 Patch by Joao and the team at Pivotal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f5541205936e32b08a2183f00173a0c64019c8e Author: Joao Pedr

Re: [pgadmin-hackers][patch] History Detail Pane

Thanks - patch applied (just in time for Raffi's & my talk)! On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Yep, > please see attached > > On Tue, Jun 27, 2017 at 9:11 AM, Dave Page wrote: > >> Can you rebase this patch please? >> >> Than

Build failed in Jenkins: pgadmin4-master-python36 #200

See Changes: [Dave Page] Revert "Allow the user to close the dashboard panel. Fixes #2506" [Dave Page] Add stylesheet to override brace matching styles, missed from the [Dave Page] Overhaul the query h

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On 27 Jun 2017 18:33, "Dave Page" wrote: Thanks - patch committed! Awsome job :-) Gr8. Finally no more rebase request for Harshal. :) On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find rebased patch. > > -- > *Harshal Dhumal* > *Sr.

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Tue, Jun 27, 2017 at 12:16 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 27 Jun 2017 18:33, "Dave Page" wrote: > > Thanks - patch committed! > > Awsome job :-) > > Gr8. Finally no more rebase request for Harshal. :) > +1 > On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhu

Re: [pgadmin-hackers][patch] History Detail Pane

Hi, New history pane is really nice and informative than existing one. I'm just thinking about one minor improvement we can make, to allow history tab to respond to up and down arrow keys so that user can easily switch between executed queries without using mouse. Thanks, -- *Harshal Dhumal* *

Re: [pgadmin-hackers][patch] History Detail Pane

Harshal, Thanks for taking a look. That exact feature should be in our next patch along with a few style changes. -- Rob On Tue, Jun 27, 2017 at 2:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > New history pane is really nice and informative than existing one. > I'm j

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Thanks, patch applied. On Tue, Jun 27, 2017 at 4:21 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave > > Please find updated patch, > > On Fri, Jun 23, 2017 at 7:09 PM, Dave Page wrote: > >> Hi >> >> I'm unable to properly test this, as the debugger doesn't even seem

pgAdmin 4 commit: Allow non-superusers to debug their own functions and

Allow non-superusers to debug their own functions and prevent them from setting global breakpoints. Fixes #2162 Based on a patch from Kit Yam Tse Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9fa093d4b988403f8350f06958951272a5304e1 Author:

pgAdmin 4 commit: Update preferences docs.

Update preferences docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0066d60066d3a2297bbec0fa1acbcd9d0d858f8 Author: Murtuza Zabuawala Modified Files -- docs/en_US/images/preferences_sql_options.png | Bin 49360 -> 232229 byte

pgAdmin 4 commit: Fix image size.

Fix image size. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed5c74affece560138d79dab3245592ee0b60e64 Modified Files -- docs/en_US/images/server_advanced.png | Bin 75902 -> 41923 bytes 1 file changed, 0 insertions(+), 0 deletion

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

Thanks, applied. On Tue, Jun 27, 2017 at 2:00 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch for doc & screenshot. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Jun 27,

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > When we started the app we noticed some change in the front end. > > The line numbers in the Editor: > - We noticed a bug with the numbers where at 1 rows, the numbers wou

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

> On 27 Jun 2017, at 17:18, Robert Eckhardt wrote: > > > >> On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira >> wrote: >> Hello Hackers, >> >> When we started the app we noticed some change in the front end. >> >> The line numbers in the Editor: >> - We noticed a bug with t

Jenkins build is back to normal : pgadmin4-master-python36 #201

See

Re: [pgadmin-hackers][patch] History Detail Pane

On Tue, Jun 27, 2017 at 8:26 PM, Dave Page wrote: > Thanks - patch applied (just in time for Raffi's & my talk)! > > The history tab looks really very good. > On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Yep, >> please see attached

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Hi Dave, On Tue, Jun 27, 2017 at 8:08 PM, Dave Page wrote: > Hi > > I've had to revert this. Whilst it seems to work, after showing/hiding the > dashboard, I later find that when I completely reload the app, it fails, > leaving just the object menu present. I haven't come up with a concrete > ca

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

Hi, Please find the attached patch which will fix the password encryption/decryption for python3. I have modified the fix suggested by Ladislav to work with both python2 and python3. Thanks, Khushboo On Tue, Jun 27, 2017 at 4:41 PM, Ladislav Jech wrote: > Hi, > It will be good if you support f