[Lldb-commits] [lldb] Skip tests if socket name is longer than 107 bytes (PR #137405)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Abstract sockets aren't tied to the filesystem, so you don't need to make them "be in" any particular directory, or even look like a path. The only reason I suggested to use `createUniquePath` is because it's a convenient way to create a random (path-like)

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. This looks good. Thanks for trying it out. https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e665d95 - [lldb] Highlight basenames in backtraces (#137301)

2025-04-28 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-28T08:29:31+01:00 New Revision: e665d95426a454b8f4a04252b815e6366491dfad URL: https://github.com/llvm/llvm-project/commit/e665d95426a454b8f4a04252b815e6366491dfad DIFF: https://github.com/llvm/llvm-project/commit/e665d95426a454b8f4a04252b815e6366491dfad.diff

[Lldb-commits] [lldb] fcb1a48 - [lldb][docs] Document new frame-format variables (#137522)

2025-04-28 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-28T08:28:54+01:00 New Revision: fcb1a481cec002f4e505d165cfba85d8b5986a57 URL: https://github.com/llvm/llvm-project/commit/fcb1a481cec002f4e505d165cfba85d8b5986a57 DIFF: https://github.com/llvm/llvm-project/commit/fcb1a481cec002f4e505d165cfba85d8b5986a57.diff

[Lldb-commits] [lldb] [lldb][docs] Document new frame-format variables (PR #137522)

2025-04-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/137522 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add settings to control how synthetic symbol names are generated (PR #137512)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: I see. Thanks for explaining, I'll let the experts weigh in on that topic then :) https://github.com/llvm/llvm-project/pull/137512 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: @Michael137, in the second screenshot in the PR description, ``clang-21`clang-main`` has `clang-main` highlighted, but ``clang-21`main`` does not highlight `main`. dyld also doesn't highlight start but that could be a lack of the debug information needed. Is that expected

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-28 Thread Michael Buch via lldb-commits
Michael137 wrote: > @Michael137, in the second screenshot in the PR description, `` > clang-21`clang-main `` has `clang-main` highlighted, but `` clang-21`main `` > does not highlight `main`. dyld also doesn't highlight start but that could > be a lack of the debug information needed. > > Is

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-28 Thread Pavel Labath via lldb-commits
labath wrote: Maybe we should say that if the name is not mangled, the entire string is the name of the function (and so it should be highlighted)? https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-28 Thread Pavel Labath via lldb-commits
labath wrote: Yes, I think that would be best, although if you structure the error message like the current command, it may not be even necessary to have a dedicated error message for that. This is what I get with the current implementation, and I think it's quite okay: ``` (lldb) v *x.x->x->x

[Lldb-commits] [lldb] [lldb] add settings to control how synthetic symbol names are generated (PR #137512)

2025-04-28 Thread Ely Ronnen via lldb-commits
eronnen wrote: The use case is to make it easier to work with static disassemblers: If I see an interesting unnamed function while debugging, it would be immediate to search it in the static disassembler if it was named `lldb_unnamed_symbol_{file-addreds}` as opposed to a random index. Also vic

[Lldb-commits] [lldb] 9f2bcc7 - [debugserver] Migrate DNBTimer away from PThreadMutex (NFC) (#137540)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-28T09:44:14-07:00 New Revision: 9f2bcc7a663dc36c3cd0b3d6c3616d9661a03c0f URL: https://github.com/llvm/llvm-project/commit/9f2bcc7a663dc36c3cd0b3d6c3616d9661a03c0f DIFF: https://github.com/llvm/llvm-project/commit/9f2bcc7a663dc36c3cd0b3d6c3616d9661a03c0f.d

[Lldb-commits] [lldb] 46fd2b9 - [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (#137554)

2025-04-28 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-28T10:31:59-07:00 New Revision: 46fd2b94affdb4727a2a0757d3de269989428df0 URL: https://github.com/llvm/llvm-project/commit/46fd2b94affdb4727a2a0757d3de269989428df0 DIFF: https://github.com/llvm/llvm-project/commit/46fd2b94affdb4727a2a0757d3de269989428df0.d

[Lldb-commits] [lldb] [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (PR #137554)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4e4c6d7 - [lldb/Format] Make progress count show thousands separators (NFC) (#137446)

2025-04-28 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2025-04-28T10:26:40-07:00 New Revision: 4e4c6d7e273a91d230389b98c280c9dbde0f6c32 URL: https://github.com/llvm/llvm-project/commit/4e4c6d7e273a91d230389b98c280c9dbde0f6c32 DIFF: https://github.com/llvm/llvm-project/commit/4e4c6d7e273a91d230389b98c280c9dbde0f6c32.

[Lldb-commits] [lldb] [lldb/Format] Make progress count show thousands separators (NFC) (PR #137446)

2025-04-28 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/137446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-28 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,13 @@ +// Skipping temporarily due to rdar://14958 medismailben wrote: This is probably just an artifact of the downstream fork, I believe @chelcassanova has a fix for this already https://github.com/llvm/llvm-project/pull/136748

[Lldb-commits] [lldb] 64737ce - [lldb-dap] Bump the version to 0.2.12

2025-04-28 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-28T10:33:22-07:00 New Revision: 64737ceb9a2060db940e4562fe04887e73f7a65c URL: https://github.com/llvm/llvm-project/commit/64737ceb9a2060db940e4562fe04887e73f7a65c DIFF: https://github.com/llvm/llvm-project/commit/64737ceb9a2060db940e4562fe04887e73f7a65c.d

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: I

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/137383 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,13 @@ +// Skipping temporarily due to rdar://14958 chelcassanova wrote: The issue is that the tests need the clang resource dir in order to run properly (since `lldb-rpc-gen` is a `ClangTool`). They were originally skipped so that I could add tha

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm JDevlieghere wrote: Is

[Lldb-commits] [lldb] [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (PR #137554)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137554 >From 17adb27c995a4bcf5218c50a8849d571085005b6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 27 Apr 2025 14:51:22 -0700 Subject: [PATCH] [debugserver] Migrate PThreadEvent away from PThreadMut

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

2025-04-28 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd approved this pull request. I see, makes sense now, thank you. https://github.com/llvm/llvm-project/pull/137311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] 41ab76b - Revert "[debugserver] Migrate DNBTimer away from PThreadMutex (NFC) (#137540)"

2025-04-28 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-28T08:44:30-07:00 New Revision: 41ab76bf0aafb35d6d023429560b44637dfb8de6 URL: https://github.com/llvm/llvm-project/commit/41ab76bf0aafb35d6d023429560b44637dfb8de6 DIFF: https://github.com/llvm/llvm-project/commit/41ab76bf0aafb35d6d023429560b44637dfb8de6.d

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

2025-04-28 Thread Pavel Labath via lldb-commits
labath wrote: > So the difference is that if `value->Dereference` fails, the user should try > to manually dereference a synthetic value? If that's what they want, yes. > Are there no other users of this function other than the ones you addressed > in this patch? What about some Python code s

[Lldb-commits] [lldb] [debugserver] Remove PThreadMutex (NFC) (PR #137555)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137555 >From 1ebef7a5a58c8153e387f299d4831587e5af82c2 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 27 Apr 2025 14:55:34 -0700 Subject: [PATCH] [debugserver] Remove PThreadMutex (NFC) Now that all u

[Lldb-commits] [lldb] 9d77a3f - [debugserver] Remove PThreadMutex (NFC) (#137555)

2025-04-28 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-28T11:28:45-07:00 New Revision: 9d77a3fa1a4a68a53309022863d32e9d5717 URL: https://github.com/llvm/llvm-project/commit/9d77a3fa1a4a68a53309022863d32e9d5717 DIFF: https://github.com/llvm/llvm-project/commit/9d77a3fa1a4a68a53309022863d32e9d5717.d

[Lldb-commits] [lldb] [debugserver] Remove PThreadMutex (NFC) (PR #137555)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Deploy Python DLL on Windows (PR #137467)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I don't know how the prebuilt binaries are built, but I'd guess they will > install and zip the install-directory. In that case, this should work. @omjavaid would know this for Windows on Arm. https://github.com/llvm/llvm-project/pull/137467 _

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM, I know when configuring via llvm CMAKE_BUILD_TYPE is required now. I'd have guessed it's required for a standalone build as well, but you're not changing that, so it must not be? https://github.com/llvm/llvm-project/pull/137383

[Lldb-commits] [lldb] 5afe9c7 - [lldb][lldb-dap] Disable launch tests that rely on get_stdout()

2025-04-28 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-04-28T09:10:12Z New Revision: 5afe9c72e4bea2ea38beb1cb0d3a3edc9a958414 URL: https://github.com/llvm/llvm-project/commit/5afe9c72e4bea2ea38beb1cb0d3a3edc9a958414 DIFF: https://github.com/llvm/llvm-project/commit/5afe9c72e4bea2ea38beb1cb0d3a3edc9a958414.diff LOG

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

2025-04-28 Thread Michael Buch via lldb-commits
Michael137 wrote: > As for the syntax for alternatives, I was suggesting (privately, I think) to > use :-, as that what > [bash](https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html) > uses for conditional expansion (and the formatter language feels more like > ba

[Lldb-commits] [lldb] [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (PR #137630)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/137630 Remove a couple of levels of indentation before I need to add another one to fix a bug. >From 4df8ad6e50cabef615ab8c2a28f9c869737db498 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 28 Apr 2025 15:16:27

[Lldb-commits] [lldb] [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (PR #137630)

2025-04-28 Thread Pavel Labath via lldb-commits
@@ -3579,129 +3579,108 @@ bool TypeSystemClang::IsPossibleDynamicType(lldb::opaque_compiler_type_t type, CompilerType *dynamic_pointee_type, bool check_cplusplus,

[Lldb-commits] [lldb] [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (PR #137630)

2025-04-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Remove a couple of levels of indentation before I need to add another one to fix a bug. --- Full diff: https://github.com/llvm/llvm-project/pull/137630.diff 1 Files Affected: - (modified) lldb/source/Plugin

[Lldb-commits] [lldb] [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (PR #137630)

2025-04-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/137630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-28 Thread Michael Buch via lldb-commits
Michael137 wrote: > Maybe we should say that if the name is not mangled, the entire string is the > name of the function (and so it should be highlighted)? That could work. Just need to audit in which cases we might set a demangled name without specifying it's mangled name too. If the demangle

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

2025-04-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/137408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cebf86e - [lldb][Format] Make function name frame-format variables work without debug-info (#137408)

2025-04-28 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-28T10:46:00+01:00 New Revision: cebf86eb1de163faaf5f9781f6bbded70dc1f9f0 URL: https://github.com/llvm/llvm-project/commit/cebf86eb1de163faaf5f9781f6bbded70dc1f9f0 DIFF: https://github.com/llvm/llvm-project/commit/cebf86eb1de163faaf5f9781f6bbded70dc1f9f0.diff

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

2025-04-28 Thread Pavel Labath via lldb-commits
labath wrote: > > As for the syntax for alternatives, I was suggesting (privately, I think) > > to use :-, as that what > > [bash](https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html) > > uses for conditional expansion (and the formatter language feels more like

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread David Peixotto via lldb-commits
@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
kastiglione wrote: @JDevlieghere Does lit run all tests, even those that have duplicate names? If so, it seems like a step back to break lit from doing what it's capable of doing. This code contains the below comment that proposes eliminating the test name uniqueness constraint. If that is th

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread via lldb-commits
@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From fc5e5e4d10f15608cc7727b5ad6af6237417d36c Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix machine-overridable scope (PR #137723)

2025-04-28 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/137723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: F

[Lldb-commits] [lldb] [lldb-dap] Fix machine-overridable scope (PR #137723)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 82ab359 - [lldb-dap] Fix machine-overridable scope (#137723)

2025-04-28 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-28T17:01:03-07:00 New Revision: 82ab35961f62c8019f3b0129da42c42287a557b0 URL: https://github.com/llvm/llvm-project/commit/82ab35961f62c8019f3b0129da42c42287a557b0 DIFF: https://github.com/llvm/llvm-project/commit/82ab35961f62c8019f3b0129da42c42287a557b0.d

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

2025-04-28 Thread Jorge Gorbe Moya via lldb-commits
slackito wrote: I think this change broke lldb/test/Shell/Unwind/split-machine-functions.test. I can reproduce locally at HEAD with `ninja check-lldb-shell-unwind`. The test binary has a symbol named `_Z3foov.cold` and the test expects the backtrace to print the name of the cold part of the fu

[Lldb-commits] [lldb] [lldb-dap] Fix formatting chrono::seconds warning. (PR #137371)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: :+1: https://github.com/llvm/llvm-project/pull/137371 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ec6b619 - [lldb][DNB] Add missing include

2025-04-28 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-04-28T09:39:45+01:00 New Revision: ec6b61943009ed695bdf268bf5a8bf448085df1e URL: https://github.com/llvm/llvm-project/commit/ec6b61943009ed695bdf268bf5a8bf448085df1e DIFF: https://github.com/llvm/llvm-project/commit/ec6b61943009ed695bdf268bf5a8bf448085df1e.diff

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: We (Linaro) are seeing the same error message with a different test on our AArch64 Linux bot: ``` ERROR: test_indexedVariables_with_raw_child_for_synthetics (TestDAP_variables.TestDAP_variables) -- Tracebac

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Having separate variables for these makes sense since they are kind of showing completely different information (demangler will show you the types, while the formatter will show you names and values), but I think that a single variable make

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

2025-04-28 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: Perhaps silly initial question: why do we need a whole different qualifier for this? Why can you not write `__ptrauth uintptr_t foo`? https://github.com/llvm/llvm-project/pull/137580 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

2025-04-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes As of #117683, Blocks are always enclosed in a function, so these checks never fail. We can't change the signature of `CalculateSymbolContextFunction` as it's an abstract function (and some of its implementati

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: A few failures in [Linux CI](https://buildkite.com/llvm-project/github-pull-requests/builds/171994#01966898-2a91-49c2-9cbe-911629208365). All are like: ``` CheckArrayPointer.test.script: line 3: fg: no job control ``` https://github.com/llvm/llvm-project/pull/136748 _

[Lldb-commits] [lldb] [lldb] add settings to control how synthetic symbol names are generated (PR #137512)

2025-04-28 Thread Ely Ronnen via lldb-commits
eronnen wrote: I'm not sure whether this synthetic name style is preferred by everyone, so that's why I made it a setting and not default. The problem it's trying to solve is that stack traces from crashes may contain unnamed symbols from binaries without debug info, and if these unnamed symbo

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/137611 As of #117683, Blocks are always enclosed in a function, so these checks never fail. We can't change the signature of `CalculateSymbolContextFunction` as it's an abstract function (and some of its implementation

[Lldb-commits] [lldb] [lldb] add settings to control how synthetic symbol names are generated (PR #137512)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: I have zero context for the problem this aims to solve, but the way you describe it, it seems like this shouldn't be a setting, it should just be how we do it. > this could make it easier when debugging crashes and stack traces to > understand which function the unnamed s

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,13 @@ +// Skipping temporarily due to rdar://14958 DavidSpickett wrote: Not a great sign that all the client tests are disabled on the system that they're originally intended for. What exactly is the issue here? https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: > FWIW, it would be super convenient if QEMU could be set up to emulate this > precise configuration. You don't happen to have connections to someone who > could be prodded into implementing it? :-) A least for Linaro, there are no plans to implement this. QEMU doesn't try

[Lldb-commits] [lldb] [lldb] add settings to control how synthetic symbol names are generated (PR #137512)

2025-04-28 Thread Pavel Labath via lldb-commits
labath wrote: FWIW, my first though was also: "why not just do it all the time". I'm somewhat unclear about the use case though. In the normal lldb backtrace you should see both the PC value and the (synthetic) function name. What's there to be gained by putting it in the name itself. Support

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

2025-04-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: > We can't change the signature of CalculateSymbolContextFunction as it's an > abstract function (and some of its implementations can return nullptr) By which you mean, because there are still use cases for `CalculateSymbolContextFunction` to return `nullptr`, so it must r

[Lldb-commits] [lldb] 985410f - [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (#106271)

2025-04-28 Thread via lldb-commits
Author: Jan Svoboda Date: 2025-04-28T07:43:26-07:00 New Revision: 985410f87f2d19910a8d327527fd30062b042b63 URL: https://github.com/llvm/llvm-project/commit/985410f87f2d19910a8d327527fd30062b042b63 DIFF: https://github.com/llvm/llvm-project/commit/985410f87f2d19910a8d327527fd30062b042b63.diff L

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (PR #106271)

2025-04-28 Thread Jan Svoboda via lldb-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/106271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

2025-04-28 Thread Pavel Labath via lldb-commits
labath wrote: > > We can't change the signature of CalculateSymbolContextFunction as it's an > > abstract function (and some of its implementations can return nullptr) > > By which you mean, because there are still use cases for > `CalculateSymbolContextFunction` to return `nullptr`, so it mus

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137311 >From a295fdb31c59050f9b6d9fc9ba4e0156a7e35c1b Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 25 Apr 2025 11:21:52 +0200 Subject: [PATCH 1/2] [lldb] Make ValueObject::Dereference less aggressive The func

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

2025-04-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/137611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

2025-04-28 Thread via lldb-commits
hapee wrote: > It seems wrong to have the source manager pretend there are more lines in the > file with the content "there are no more lines in this file". At some point, > someone is going to want to know that there are no more lines and this > artificial content will be confusing. > >

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/137751 This PR implements support for specifying multiple alternatives for scope format entries. Scopes are used to enclose things that should only be printed when everything in the scope resolves. For example,

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR implements support for specifying multiple alternatives for scope format entries. Scopes are used to enclose things that should only be printed when everything in the scope resolves. For ex

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @labath this ended up quite different from the bash-like syntax that we discussed at EuroLLVM [1]. Using a single character keeps the parsing code simple and limiting this to scopes eliminates some design complexity like recursion. The current implementation covers all of m

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

2025-04-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Reverts llvm/llvm-project#137408 --- Full diff: https://github.com/llvm/llvm-project/pull/137757.diff 8 Files Affected: - (modified) lldb/source/Core/FormatEntity.cpp (+4-5) - (modified) lldb/source/Plu

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

2025-04-28 Thread Michael Buch via lldb-commits
Michael137 wrote: > I think this change broke > lldb/test/Shell/Unwind/split-machine-functions.test. I can reproduce locally > at HEAD with `ninja check-lldb-shell-unwind`. > > The test binary has a symbol named `_Z3foov.cold` and the test expects the > backtrace to print the name of the cold

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

2025-04-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/137757 Reverts llvm/llvm-project#137408 >From f7159a00fdd1950dbac5c24f532a13af76af44a5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 29 Apr 2025 07:03:26 +0100 Subject: [PATCH] =?UTF-8?q?Revert=20"[lldb][F

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

2025-04-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] da70992 - Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (#137757)

2025-04-28 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-29T07:13:04+01:00 New Revision: da7099290cea7d11b83da01adda8afeb3bcd5362 URL: https://github.com/llvm/llvm-project/commit/da7099290cea7d11b83da01adda8afeb3bcd5362 DIFF: https://github.com/llvm/llvm-project/commit/da7099290cea7d11b83da01adda8afeb3bcd5362.diff

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

2025-04-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/137757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

2025-04-28 Thread Jorge Gorbe Moya via lldb-commits
https://github.com/slackito approved this pull request. Thanks for the quick response! https://github.com/llvm/llvm-project/pull/137757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] ebaeecc - [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (#137630)

2025-04-28 Thread via lldb-commits
Author: Pavel Labath Date: 2025-04-29T08:17:53+02:00 New Revision: ebaeecc429f53c209ea58d6d4c7df3552adcb714 URL: https://github.com/llvm/llvm-project/commit/ebaeecc429f53c209ea58d6d4c7df3552adcb714 DIFF: https://github.com/llvm/llvm-project/commit/ebaeecc429f53c209ea58d6d4c7df3552adcb714.diff

[Lldb-commits] [lldb] [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (PR #137630)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 679cc0a - [lldb] Remove Function null checks in Block.cpp (#137611)

2025-04-28 Thread via lldb-commits
Author: Pavel Labath Date: 2025-04-29T08:20:08+02:00 New Revision: 679cc0a1ed60ea529abc04cecbcdd75d65ea0588 URL: https://github.com/llvm/llvm-project/commit/679cc0a1ed60ea529abc04cecbcdd75d65ea0588 DIFF: https://github.com/llvm/llvm-project/commit/679cc0a1ed60ea529abc04cecbcdd75d65ea0588.diff

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-28 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d1bb8d6 - [lldb][AIX] get host info for AIX (#134354)

2025-04-28 Thread via lldb-commits
Author: Hemang Gadhavi Date: 2025-04-29T11:23:03+05:30 New Revision: d1bb8d6a5c4a36490298ca75d144805179cc3b40 URL: https://github.com/llvm/llvm-project/commit/d1bb8d6a5c4a36490298ca75d144805179cc3b40 DIFF: https://github.com/llvm/llvm-project/commit/d1bb8d6a5c4a36490298ca75d144805179cc3b40.diff

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-28 Thread via lldb-commits
github-actions[bot] wrote: @HemangGadhavi Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-28 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

2025-04-28 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Should we also add a test for the `attach` request as well? https://github.com/llvm/llvm-project/pull/137722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

2025-04-28 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/137722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

2025-04-28 Thread via lldb-commits
https://github.com/hapee updated https://github.com/llvm/llvm-project/pull/137515 >From cc39f344a5284c16e2b446cde796681f1daa2888 Mon Sep 17 00:00:00 2001 From: hapee <623151...@qq.com> Date: Sun, 27 Apr 2025 18:27:04 +0800 Subject: [PATCH] [lldb] print a notice when `source list` paging

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

2025-04-28 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [debugserver] Remove PThreadMutex (NFC) (PR #137555)

2025-04-28 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/15188 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-04-28 Thread Ely Ronnen via lldb-commits
eronnen wrote: Nice!! https://github.com/llvm/llvm-project/pull/137694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Alex Langford via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm bulbazord wrote: I thi

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

2025-04-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Can you update the README that talks about these settings and explain the precedence between the launch/attach configuration and the settings? It'd be nice to give some guidance so folks know where to configure things based on their needs. Otherwise t

  1   2   >