@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,13 @@
+add_definitions("-D_ALL_SOURCE")
labath wrote:
Remind me please, what symbol is this needed for?
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.
@@ -0,0 +1,72 @@
+//===-- PlatformAIX.h -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
labath wrote:
Sounds like a nice feature to have. I'm not really familiar with these APIs, so
I don't have much to say in the way of specifics. One high level question I
have (I can't tell from the patch) is how are these files actually handled. Do
we need to (preemptively) read them into some
@@ -0,0 +1,13 @@
+add_definitions("-D_ALL_SOURCE")
DhruvSrivastavaX wrote:
For this plugin, it is there for `MAP_ANONYMOUS`
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@li
@@ -0,0 +1,72 @@
+//===-- PlatformAIX.h -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/6] Introducing PlatformAIX from PlatformLinux
---
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The whole unwind plan is already stored in a shared pointer, and there's no
need to persist Rows individually. If there's ever a need to do that, there are
at least two options:
- copy the row (they're not tha
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/128181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
-
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ std::error_code EC;
+ if (m_file == nullptr) {
+EC = std:
Author: David Spickett
Date: 2025-02-21T14:56:30Z
New Revision: d2b3912002693008141ed8a15c0f2fdb6e861f84
URL:
https://github.com/llvm/llvm-project/commit/d2b3912002693008141ed8a15c0f2fdb6e861f84
DIFF:
https://github.com/llvm/llvm-project/commit/d2b3912002693008141ed8a15c0f2fdb6e861f84.diff
LOG
Michael137 wrote:
> Sounds like a nice feature to have. I'm not really familiar with these APIs,
> so I don't have much to say in the way of specifics. One high level question
> I have (I can't tell from the patch) is how are these files actually handled.
> Do we need to (preemptively) read th
JDevlieghere wrote:
> @JDevlieghere, I've updated messages :)
Lightning fast! Thanks!
https://github.com/llvm/llvm-project/pull/128196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
JDevlieghere wrote:
> @JDevlieghere, it is still not merged. Are there any extra checks?
Nope, I just wasn't sure if you had commit access. I'll go ahead and merge it
for you.
https://github.com/llvm/llvm-project/pull/127974
___
lldb-commits mailing
labath wrote:
That, or even actual values. I'm looking over the construction code, and it
looks like most of the time it's making a (deep) copy of the value before/after
storing it in the unwind plan.
https://github.com/llvm/llvm-project/pull/128181
https://github.com/SuibianP edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/121860
>From 13524447f9af1c8d1923e9ef8cc3693a1c53253a Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 17 Jan 2025 17:10:36 -0800
Subject: [PATCH] [lldb] Implement a statusline in LLDB
MIME-Version: 1.0
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/127974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/128196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -158,13 +156,25 @@ std::string
RunInTerminalDebugAdapterCommChannel::GetLauncherError() {
}
Expected> CreateRunInTerminalCommFile() {
+ int comm_fd;
SmallString<256> comm_file;
- if (std::error_code EC = sys::fs::getPotentiallyUniqueTempFileName(
- "lldb-dap-
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
+std::error_code EC;
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ if (m_file == nullptr) {
+EC = std::e
@@ -24,41 +30,95 @@ using namespace llvm;
namespace lldb_dap {
-FifoFile::FifoFile(StringRef path) : m_path(path) {}
+std::error_code EC;
+FifoFile::FifoFile(StringRef path)
+: m_path(path), m_file(fopen(path.data(), "r+")) {
+ if (m_file == nullptr) {
+EC = std::e
https://github.com/SuibianP edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/SuibianP edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/SuibianP edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/128156
This reverts commit
https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2,
reapplying
https://github.com/llvm/llvm-project/commit/7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b
with a s
@@ -0,0 +1,155 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
JDevlieghere wrote:
Does this open the door towards storing these rows as unique pointers?
https://github.com/llvm/llvm-project/pull/128181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
Author: Pavel Labath
Date: 2025-02-21T13:17:36+01:00
New Revision: 917ed99d815a4cc6bde249d292376f75dbe3700c
URL:
https://github.com/llvm/llvm-project/commit/917ed99d815a4cc6bde249d292376f75dbe3700c
DIFF:
https://github.com/llvm/llvm-project/commit/917ed99d815a4cc6bde249d292376f75dbe3700c.diff
https://github.com/JDevlieghere approved this pull request.
LGTM. Would you mind making the `MESSAGE` lowercase in this file? I think this
is the only place where we use `MESSAGE` instead of `message` and it just looks
weird. Can be the same or a different PR.
https://github.com/llvm/llvm-pro
foxtran wrote:
@JDevlieghere, I've updated messages :)
https://github.com/llvm/llvm-project/pull/128196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
foxtran wrote:
@JDevlieghere, it is still not merged. Are there any extra checks?
https://github.com/llvm/llvm-project/pull/127974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/foxtran updated
https://github.com/llvm/llvm-project/pull/128196
>From 4683735bef8f43a5e39be6aedffd76c47e43beb2 Mon Sep 17 00:00:00 2001
From: "Igor S. Gerasimov"
Date: Fri, 21 Feb 2025 17:33:25 +0100
Subject: [PATCH 1/2] Use STATUS instead of explicit '--' in MESSAGE
---
l
https://github.com/foxtran created
https://github.com/llvm/llvm-project/pull/128196
Currently, configuring lldb with cmake with separated stdout and stderr gives
some unnecessary output in stderr which happens since message statement is used
without `[mode]` (See https://cmake.org/cmake/help/v
https://github.com/SuibianP edited
https://github.com/llvm/llvm-project/pull/121269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -58,12 +58,13 @@ const char DEV_NULL[] = "/dev/null";
namespace lldb_dap {
-DAP::DAP(llvm::StringRef path, std::ofstream *log, ReplMode repl_mode,
- StreamDescriptor input, StreamDescriptor output)
-: debug_adaptor_path(path), log(log), input(std::move(input)),
@@ -4952,6 +4895,29 @@ static int DuplicateFileDescriptor(int fd) {
#endif
}
+static llvm::Expected>
+validateConnection(llvm::StringRef conn) {
+ auto uri = lldb_private::URI::Parse(conn);
+
+ if (uri && (uri->scheme == "tcp" || uri->scheme == "connect" ||
+ !u
Author: foxtran
Date: 2025-02-21T11:02:19-06:00
New Revision: 506deb0cce3fe503f61ef1a1a08a40770ef4b978
URL:
https://github.com/llvm/llvm-project/commit/506deb0cce3fe503f61ef1a1a08a40770ef4b978
DIFF:
https://github.com/llvm/llvm-project/commit/506deb0cce3fe503f61ef1a1a08a40770ef4b978.diff
LOG:
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string des
@@ -43,29 +77,79 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
serializer.write("end_time", ToNanosec(end_time.value()));
}
-[[maybe_unused]] static std::string MakeUUID(Debugger *debugger) {
- uint8_t random_bytes[16];
- if (auto ec = llvm::g
@@ -41,17 +41,32 @@ static uint64_t ToNanosec(const SteadyTimePoint Point) {
return std::chrono::nanoseconds(Point.time_since_epoch()).count();
}
-static std::string MakeUUID(Debugger *debugger) {
+// Generate a unique string. This should be unique across different runs.
+//
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/128156
>From b213b08c0a6527ec4732ef977ad43e3261dd73ad Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 21 Feb 2025 10:36:20 +0100
Subject: [PATCH 1/3] Reapply "[lldb] Implement basic support for
reverse-continue
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This reverts commit
https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2,
reapplying
https://github.com/llvm/llvm-project/commit/7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b
with a
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
41cece8c86399dd1ffcb6b7a8b50c10083fe5a40...2dc2ff7a51f5173073a1b9aa57a49b1800657972
lldb/
labath wrote:
Okay, I've created a new version of the patch
[here](https://github.com/llvm/llvm-project/pull/128156). Would you like to
merge it at your convenience? There was a small merge conflict with Jason's
breakpoint detection patch, but I think I've was able to resolve that
correctly.
@@ -0,0 +1,177 @@
+import logging
+import os
+import os.path
+import random
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.gdbclientutils import *
+import lldbgdbserverutils
+from lldbsuite.support import seven
+
+
+class GDBProxyTestBase(TestBase):
+
@@ -635,10 +635,11 @@ bool Thread::SetupForResume() {
// what the current plan is.
lldb::RegisterContextSP reg_ctx_sp(GetRegisterContext());
-if (reg_ctx_sp) {
+ProcessSP process_sp(GetProcess());
+if (reg_ctx_sp && process_sp && direction == eRunForward) {
@@ -0,0 +1,155 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/labath approved this pull request.
Looks good. Thanks.
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dhruv Srivastava
Date: 2025-02-21T17:11:06+05:30
New Revision: a5f759ed9d119f4bf28f6f4c32487917fb93ec5e
URL:
https://github.com/llvm/llvm-project/commit/a5f759ed9d119f4bf28f6f4c32487917fb93ec5e
DIFF:
https://github.com/llvm/llvm-project/commit/a5f759ed9d119f4bf28f6f4c32487917fb93ec5e.di
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/7] Introducing PlatformAIX from PlatformLinux
---
@@ -0,0 +1,13 @@
+add_definitions("-D_ALL_SOURCE")
DhruvSrivastavaX wrote:
Done, Thanks!
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127829
>From 1aabc8a93ffac06755cbaf5e6c1fa8913cd63729 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 19 Feb 2025 12:47:30 +
Subject: [PATCH 1/3] [lldb][TypeSystemClang] Create MainFileID for
TypeSystemC
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/126526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/123622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-02-21T13:13:34+01:00
New Revision: 71af48fafdb6319da38ee7e5f04e16ff548fe57e
URL:
https://github.com/llvm/llvm-project/commit/71af48fafdb6319da38ee7e5f04e16ff548fe57e
DIFF:
https://github.com/llvm/llvm-project/commit/71af48fafdb6319da38ee7e5f04e16ff548fe57e.diff
@@ -6,15 +6,24 @@
include(CMakePushCheckState)
-function(lldb_check_curses_tinfo CURSES_LIBRARIES CURSES_HAS_TINFO)
+function(lldb_check_curses_tinfo CURSES_HEADER CURSES_LIBRARIES
CURSES_HAS_TINFO)
cmake_reset_check_state()
set(CMAKE_REQUIRED_LIBRARIES "${CURSES_LIBRA
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/128245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Rebased on the recent debugger stream changes & improved the test based on code
review feedback.
https://github.com/llvm/llvm-project/pull/121860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From 420153ffa051951332d1fca92af2a2bff7e9c52a Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH 1/6] [lldb-dap] Refactoring lldb-dap port listening mode to
allow
https://github.com/jimingham approved this pull request.
That's correct & useful.
https://github.com/llvm/llvm-project/pull/128215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds 'source' references to all stack frames. When opening a stack frame
users will see the disassembly of the frame if the source is not available.
This works around the odd behavior of navigating frame
https://github.com/ashgti commented:
I think this is a good idea to help simplify the lldb-dap.cpp file and improve
code organization
https://github.com/llvm/llvm-project/pull/128262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/128262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 79261d4aab4f7a0f56f5ea32a5ac06241c5cd94a
2f7885cfac5d5049c317de56109eed3bd2579acc --e
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/128268
This adds 'source' references to all stack frames. When opening a stack frame
users will see the disassembly of the frame if the source is not available.
This works around the odd behavior of navigating frames w
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,45 @@
+//===-- Request.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/6506
Here is the relevant piece of t
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/128278
This should fix the tests running on windows.
https://lab.llvm.org/buildbot/#/builders/141/builds/6506 is the failure, the
error message does not clearly indicate why the connection failed.
>From 0598331ccb5280
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/128278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This should fix the tests running on windows.
https://lab.llvm.org/buildbot/#/builders/141/builds/6506 is the failure, the
error message does not clearly indicate why the connection failed.
---
Full diff: ht
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/128278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/128278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
https://github.com/llvm/llvm-project/pull/128278 Should mark the test as
skipped on windows to unblock the CI.
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/128215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google created
https://github.com/llvm/llvm-project/pull/128245
At present, we automatically detect terminfo symbols in CURSES_LIBRARIES after
it is found through `find_package`. However, by introducing a check for
TINFO_LIBRARIES, we break systems which pass all of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jordan R AW (ajordanr-google)
Changes
At present, we automatically detect terminfo symbols in CURSES_LIBRARIES after
it is found through `find_package`. However, by introducing a check for
TINFO_LIBRARIES, we break systems which pass all o
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (foxtran)
Changes
Currently, configuring lldb with cmake with separated stdout and stderr gives
some unnecessary output in stderr which happens since message statement is used
without `[mode]` (See https://cmake.org/cmake/help/v3.31/c
ajordanr-google wrote:
Turns out `set(CURSES_LIBRARIES "${CURSES_LIBRARIES } ${TINFO_LIBRARIES}")`
definitely does NOT work. I think there's some string quoting which gives:
```
ninja -v -j96 -l999 distribution libclang.so
@@ -6,15 +6,24 @@
include(CMakePushCheckState)
-function(lldb_check_curses_tinfo CURSES_LIBRARIES CURSES_HAS_TINFO)
+function(lldb_check_curses_tinfo CURSES_HEADER CURSES_LIBRARIES
CURSES_HAS_TINFO)
cmake_reset_check_state()
set(CMAKE_REQUIRED_LIBRARIES "${CURSES_LIBRA
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From ff5884d252b8359bcec41024f9dc9e3c7bbe3fc2 Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH 1/4] [lldb] Fix manual CURSES_LIBRARIES tin
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From ff5884d252b8359bcec41024f9dc9e3c7bbe3fc2 Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH 1/3] [lldb] Fix manual CURSES_LIBRARIES tin
ajordanr-google wrote:
Rebasing to fix merge conflict...
https://github.com/llvm/llvm-project/pull/128245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From f0d81ca9124f0e4b0a60f2752c56c4166052813a Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH] [lldb] Fix manual CURSES_LIBRARIES tinfo f
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From f0d81ca9124f0e4b0a60f2752c56c4166052813a Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH] [lldb] Fix manual CURSES_LIBRARIES tinfo f
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From f0d81ca9124f0e4b0a60f2752c56c4166052813a Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH] [lldb] Fix manual CURSES_LIBRARIES tinfo f
Author: foxtran
Date: 2025-02-21T12:12:06-06:00
New Revision: 7c1f679c387a68defbc2b240cb58eb9152252c25
URL:
https://github.com/llvm/llvm-project/commit/7c1f679c387a68defbc2b240cb58eb9152252c25
DIFF:
https://github.com/llvm/llvm-project/commit/7c1f679c387a68defbc2b240cb58eb9152252c25.diff
LOG:
@@ -6,15 +6,24 @@
include(CMakePushCheckState)
-function(lldb_check_curses_tinfo CURSES_LIBRARIES CURSES_HAS_TINFO)
+function(lldb_check_curses_tinfo CURSES_HEADER CURSES_LIBRARIES
CURSES_HAS_TINFO)
cmake_reset_check_state()
set(CMAKE_REQUIRED_LIBRARIES "${CURSES_LIBRA
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From ff5884d252b8359bcec41024f9dc9e3c7bbe3fc2 Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH 1/2] [lldb] Fix manual CURSES_LIBRARIES tin
@@ -6,15 +6,24 @@
include(CMakePushCheckState)
-function(lldb_check_curses_tinfo CURSES_LIBRARIES CURSES_HAS_TINFO)
+function(lldb_check_curses_tinfo CURSES_HEADER CURSES_LIBRARIES
CURSES_HAS_TINFO)
cmake_reset_check_state()
set(CMAKE_REQUIRED_LIBRARIES "${CURSES_LIBRA
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/128262
None
>From 03bf2fafb0b8b7e1dc08f6510802b73b5fe4dde7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 21 Feb 2025 19:20:36 -0600
Subject: [PATCH] [lldb-dap] Move requests into their own object/fi
99 matches
Mail list logo
