================
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string description;
+};
+
+struct DebuggerTelemetryInfo : public LLDBBaseTelemetryInfo {
----------------
labath wrote:
Okay, but the fields are still there. I know why you did this, but I think it's
strange to have a field that is never set anywhere, and I definitely wouldn't
want to define a field for every piece of information that anybody wants to
collect. If we go in this direction (data collected downstream), then I think
the fields should be defined downstream as well. One way to do that would be to
wrap the upstream member in a vendor-specific event struct which includes the
upstream struct as a member (or just a copy of its members). Another would be
to attach them directly in the Destination class (that way the custom event
struct doesn't even have to exist).
https://github.com/llvm/llvm-project/pull/127696
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
