Author: Michael Buch
Date: 2024-09-12T08:11:09+01:00
New Revision: f0c6d30a5d80dd42cb298f857987aa2c8f01e63e
URL:
https://github.com/llvm/llvm-project/commit/f0c6d30a5d80dd42cb298f857987aa2c8f01e63e
DIFF:
https://github.com/llvm/llvm-project/commit/f0c6d30a5d80dd42cb298f857987aa2c8f01e63e.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/108196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/108343
This bug surfaced after https://github.com/llvm/llvm-project/pull/105865
(currently reverted, but blocked on this to be relanded).
Because Clang doesn't emit `DW_TAG_member`s for unnamed bitfields, LLDB has
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This bug surfaced after https://github.com/llvm/llvm-project/pull/105865
(currently reverted, but blocked on this to be relanded).
Because Clang doesn't emit `DW_TAG_member`s for unnamed bitfields, LLDB ha
Michael137 wrote:
This logic is getting very finicky, so I wouldn't be surprised if there are
cases not covered by this. Will have a think
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108343
>From 51bca430ecb8be09ccacef5e616ea4ed9d85ab30 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 09:07:16 +0100
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Prevent unnamed bitfield
crea
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-09-12T09:48:13+01:00
New Revision: 7294396a0878a6bd179fac9aa5c3743832c799f4
URL:
https://github.com/llvm/llvm-project/commit/7294396a0878a6bd179fac9aa5c3743832c799f4
DIFF:
https://github.com/llvm/llvm-project/commit/7294396a0878a6bd179fac9aa5c3743832c799f4.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/108183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-09-12T10:35:11Z
New Revision: adde85e7c3ade54b22c99d405fc9c3add869db0a
URL:
https://github.com/llvm/llvm-project/commit/adde85e7c3ade54b22c99d405fc9c3add869db0a
DIFF:
https://github.com/llvm/llvm-project/commit/adde85e7c3ade54b22c99d405fc9c3add869db0a.diff
LOG
omjavaid wrote:
> > Yes I think there might be a Windows API launch flag that can let us do
> > early detection of hardware breakpoints and watchpoints. But so far after
> > lots of experimentation I have not been able to find the right set.
>
> Is it possible this is a bug in Windows itself?
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/108362
IIUC, the history of `std::string`'s `__short` structure in the alternate ABI
layout (as recorded by the simulator test) looks as follows:
* First layout ( `SUBCLASS_PADDING` is defined):
```
struct __sh
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/108362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
IIUC, the history of `std::string`'s `__short` structure in the alternate ABI
layout (as recorded by the simulator test) looks as follows:
* First layout ( `SUBCLASS_PADDING` is defined):
```
struct __
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108362
>From 8b999e3330f4b414d3ffe56c500d407cbde57be0 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 11:05:27 +0100
Subject: [PATCH 1/2] [lldb][test] TestDataFormatterLibcxxStringSimulator.py:
f
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/108362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/108365
Fixes #107864
QEMU decided that when SVE is enabled it will only tell us about SVE registers
in the XML, and not include Neon registers. On the grounds that the Neon V
registers can be read from the bott
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Fixes #107864
QEMU decided that when SVE is enabled it will only tell us about SVE registers
in the XML, and not include Neon registers. On the grounds that the Neon V
registers can be read from the
DavidSpickett wrote:
The data order of SVE and Neon in this situation is probably wrong, but I'm not
aiming to address that here.
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/108169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/108375
Depends on https://github.com/llvm/llvm-project/pull/108362 and
https://github.com/llvm/llvm-project/pull/108343.
Adds new layout for https://github.com/llvm/llvm-project/pull/105865.
>From cac4ea7d5f3b4d3b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Depends on https://github.com/llvm/llvm-project/pull/108362 and
https://github.com/llvm/llvm-project/pull/108343.
Adds new layout for https://github.com/llvm/llvm-project/pull/105865.
---
Full diff: https
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108343
>From 51bca430ecb8be09ccacef5e616ea4ed9d85ab30 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 09:07:16 +0100
Subject: [PATCH 1/3] [lldb][DWARFASTParserClang] Prevent unnamed bitfield
crea
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 703ebca869e1e684147d316b7bdb15437c12206a
5d25eeb8cb993dc85869ace156d4a1505c9faa67 --e
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/108281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2024-09-12T07:01:59-07:00
New Revision: 7e74472801486cc702fba3e831c8fcd77c120142
URL:
https://github.com/llvm/llvm-project/commit/7e74472801486cc702fba3e831c8fcd77c120142
DIFF:
https://github.com/llvm/llvm-project/commit/7e74472801486cc702fba3e831c8fcd77
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108343
>From 51bca430ecb8be09ccacef5e616ea4ed9d85ab30 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 09:07:16 +0100
Subject: [PATCH 1/4] [lldb][DWARFASTParserClang] Prevent unnamed bitfield
crea
@@ -258,9 +258,27 @@ class DWARFASTParserClang : public
lldb_private::plugin::dwarf::DWARFASTParser {
private:
struct FieldInfo {
+///< Size in bits that this field occupies. Can but
adrian-prantl wrote:
```
/// comment
decl d;
```
or
```
decl d; ///ht
https://github.com/adrian-prantl approved this pull request.
Once we're in heuristic territory I think we can only get a hold of this
problem with lots of tests.
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108343
>From 51bca430ecb8be09ccacef5e616ea4ed9d85ab30 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 09:07:16 +0100
Subject: [PATCH 1/5] [lldb][DWARFASTParserClang] Prevent unnamed bitfield
crea
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108343
>From 51bca430ecb8be09ccacef5e616ea4ed9d85ab30 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 09:07:16 +0100
Subject: [PATCH 1/6] [lldb][DWARFASTParserClang] Prevent unnamed bitfield
crea
Michael137 wrote:
> Once we're in heuristic territory I think we can only get a hold of this
> problem with lots of tests.
Added more test in the latest iteration (the ones marked FIXME were still
misbehaving on top-of-tree, although in other ways...but we still asserted in
the expression eva
jimingham wrote:
You also have to be careful when treating Errors in ValueObjects, since it is
not always the case that a ValueObject that returns `GetError().Success() ==
true` on one stop will return that when the program is allowed to run. For
instance, the ValueObject for a local variable
adrian-prantl wrote:
Why don't we just make the unnamed fields explicit in DWARF and solve the
problem the correct way?
(We'll still needs this hack to support other/older compilers though)
https://github.com/llvm/llvm-project/pull/108343
___
lldb-com
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/108414
Our customers is reporting a serious performance issue (expanding a this
pointer takes 70 seconds in VSCode) in a specific execution context.
Profiling shows the hot path is triggered by an expression eval
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
Our customers is reporting a serious performance issue (expanding a this
pointer takes 70 seconds in VSCode) in a specific execution context.
Profiling shows the hot path is triggered by an expression evaluation
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-09-12T17:26:17+01:00
New Revision: a6a547f18d99f0b0bf5ffac55443d687200f972d
URL:
https://github.com/llvm/llvm-project/commit/a6a547f18d99f0b0bf5ffac55443d687200f972d
DIFF:
https://github.com/llvm/llvm-project/commit/a6a547f18d99f0b0bf5ffac55443d687200f972d.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/108375
>From 5b38bd48254d552dca2eb51d7270b01734494d90 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 12 Sep 2024 11:05:27 +0100
Subject: [PATCH 1/3] [lldb][test] TestDataFormatterLibcxxStringSimulator.py:
f
Jlalond wrote:
> The variable name should be `progress_tracker` but really we should just call
> it `progress` for consistency with the rest of lldb.
Good to know, I know this class has a lot of pascal casing from before and I'm
always unsure to break the existing pattern and use snake or not
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/3] Add Progress bar to minidump memory emission
---
.../Minid
@@ -645,6 +645,33 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
@@ -146,6 +146,8 @@ class LLDB_API SBValue {
lldb::SBValue CreateValueFromData(const char *name, lldb::SBData data,
lldb::SBType type);
+ lldb::SBValue CreateBoolValue(const char *name, bool value);
Jlalond wrote:
I woul
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108309
>From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 13:33:44 -0700
Subject: [PATCH 1/3] Add Progress bar to minidump memory emission
---
.../Minid
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/4] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108414
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/3] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
mstorsjo wrote:
> This broke building in mingw configurations, and possibly a few others as
> well.
>
> The `ReportWarning` function takes a pointer to a `std::once_flag`, while
> this is passing it with a `llvm::once_flag`. In many configurations, these
> are the same type, but in a couple o
pranavk wrote:
Hmm, this seems to be breaking LLVM build:
```
error: initialization of non-aggregate type 'FieldInfo' with a designated
initializer list
| FieldInfo this_field_info{.is_bitfield = false};
```
https://github.com/llvm/llvm-project/pull/108343
kazutakahirata wrote:
> Hmm, this seems to be breaking LLVM build:
>
> ```
> error: initialization of non-aggregate type 'FieldInfo' with a designated
> initializer list
> | FieldInfo this_field_info{.is_bitfield = false};
> ```
FWIW, with clang-16.0.6 as the host compiler, I get:
```
ll
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
return 0;
}
+struct SaveCoreRequest {
jeffreytan81 wrote:
Per our naming convention, let's call this RAII class
`FileRemoveHolder/DumpFailRemoveHolder` or something similar, then the re
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
return 0;
}
+struct SaveCoreRequest {
+ SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {}
+
+ ~SaveCoreRequest() {
+if (!m_success)
+ m_builder.DeleteFile();
---
Author: Kazu Hirata
Date: 2024-09-12T10:43:32-07:00
New Revision: 5d17293caaf0f62ea94fecc137b9b6f07c659dac
URL:
https://github.com/llvm/llvm-project/commit/5d17293caaf0f62ea94fecc137b9b6f07c659dac
DIFF:
https://github.com/llvm/llvm-project/commit/5d17293caaf0f62ea94fecc137b9b6f07c659dac.diff
L
kazutakahirata wrote:
I've fixed the warning with 5d17293caaf0f62ea94fecc137b9b6f07c659dac.
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
vogelsgesang wrote:
Hi @clayborg,
sorry for the late reply - got knocked out by Covid for a while 😷
> Let me know what you think of my idea to always just show the load address of
> any SBValue. I think that is the best for LLDB, but I am open to opinions.
I did check the other lldb-based de
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/3] [lldb-dap] Add feature to remember last non-empty
expression.
@@ -60,7 +60,10 @@ def run_test_evaluate_expressions(
# Expressions at breakpoint 1, which is in main
self.assertEvaluate("var1", "20")
+# Empty expression should equate to the previous expression.
cmtice wrote:
Done
https://github.co
cmtice wrote:
> I wrote a fairly long comment on Friday, but I don't see it anymore so, it
> looks like github has swallowed it. Here's my reconstruction of it:
>
> LLDB commands have the notion of a "repeat command", which can sometimes be
> more complicated than just running the same string
@@ -1363,6 +1363,14 @@ void request_evaluate(const llvm::json::Object &request)
{
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
+ static
@@ -1364,6 +1364,13 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
+ // Remember the last non-empty expression from the user, and
cmtice wrote:
I think I have addressed all the review comments; please take another look.
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
247d3ea843cb20d8d75ec781cd603c8ececf8934...616017152f3f0611462e9863273754036b52f7eb
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 247d3ea843cb20d8d75ec781cd603c8ececf8934
616017152f3f0611462e9863273754036b52f7eb --e
jimingham wrote:
The goal here is excellent! Not only is this a performance problem but if you
call the version of GetValueFromExpression that doesn't take an expression
options - as the code you are replacing does - you get the default value for
"TryAllThreads" - which is `true`. So if you
https://github.com/jimingham requested changes to this pull request.
This is good except the implementation should be in ValueObject not SBValue.
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Michael137 wrote:
> I've fixed the warning with 5d17293caaf0f62ea94fecc137b9b6f07c659dac.
>
>
Thanks!
https://github.com/llvm/llvm-project/pull/108343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
vogelsgesang wrote:
Hi @jennphilqc,
Great minds think alike - I actually also implemented the `readMemory` request
in #104317.
Thankfully, we didn't literally do the same, duplicated work
* your PR also implements `writeMemory` which my PR is still lacking. Here your
PR is clearly further al
https://github.com/vogelsgesang approved this pull request.
Thanks for fixing this! 🙂
https://github.com/llvm/llvm-project/pull/108227
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
vogelsgesang wrote:
Hi @clayborg,
Are you still planning to review this (as requested by @walter-erquinigo)? Or
are you fine with me landing this change without your review?
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing li
@@ -191,6 +198,14 @@ def run_test_evaluate_expressions(
self.continue_to_next_stop()
self.assertEvaluate("my_bool_vec", "size=2")
+# Test memory read, especially with 'empty' repeat commands.
+if context == "repl":
+ self.continue_to_ne
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -754,6 +760,7 @@ class Debugger : public
std::enable_shared_from_this,
uint32_t m_interrupt_requested = 0; ///< Tracks interrupt requests
std::mutex m_interrupt_mutex;
+ std::shared_ptr m_telemeter;
oontvoo wrote:
done
https://github.com/llvm/llvm-p
Author: Martin Storsjö
Date: 2024-09-12T22:26:02+03:00
New Revision: a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223
URL:
https://github.com/llvm/llvm-project/commit/a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223
DIFF:
https://github.com/llvm/llvm-project/commit/a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223.diff
mstorsjo wrote:
I pushed a fix in a81a4b2a7ac2d0b8195bb008b2c0f464cfbda223.
https://github.com/llvm/llvm-project/pull/107968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108259
>From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 11 Sep 2024 10:27:31 -0700
Subject: [PATCH 1/5] Unlink file on failure
---
.../ObjectFile/Minidump/Minidum
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/4] [lldb-dap] Add feature to remember last non-empty
expression.
@@ -191,6 +198,14 @@ def run_test_evaluate_expressions(
self.continue_to_next_stop()
self.assertEvaluate("my_bool_vec", "size=2")
+# Test memory read, especially with 'empty' repeat commands.
+if context == "repl":
+ self.continue_to_ne
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
return 0;
}
+struct SaveCoreRequest {
+ SaveCoreRequest(MinidumpFileBuilder &builder) : m_builder(builder) {}
+
+ ~SaveCoreRequest() {
+if (!m_success)
+ m_builder.DeleteFile();
---
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108448
Recently my coworker @jeffreytan81 pointed out that Minidumps don't show
breakpoints when collected. This was prior blocked because Minidumps could only
contain 1 exception, now that we support N signals/sectio
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Recently my coworker @jeffreytan81 pointed out that Minidumps don't
show breakpoints when collected. This was prior blocked because Minidumps could
only contain 1 exception, now that we support N signals/sec
@@ -54,6 +54,13 @@ using namespace lldb;
using namespace lldb_private;
using namespace llvm::minidump;
+// Set of all the stop reasons minidumps will collect.
Jlalond wrote:
@labath Hey Pavel, is there a more elegant way to define a constant set? I want
to d
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 030c6da7af826b641db005be925b20f956c3a6bb
030b74c9e763c86d217da39487478e7cf2dff074 --e
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 commented:
Can you add a test to check this?
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 approved this pull request.
I would suggest we added a unit test that checks that we do get an error
message if saving minidump failed.
Other than that, this looks good.
https://github.com/llvm/llvm-project/pull/108259
__
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108448
>From adcc5e8065d2a1b7edf877bd74de9cebd2f84cc9 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 12 Sep 2024 13:10:58 -0700
Subject: [PATCH 1/3] Create set for the stop reasons we collect, and add
breakpo
Jlalond wrote:
@jeffreytan81 I'll add a test to ensure we get an error message
https://github.com/llvm/llvm-project/pull/108259
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
030c6da7af826b641db005be925b20f956c3a6bb...099f017208ddadc07b3743ea7b04612f0f79617f
lldb
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -54,6 +54,13 @@ using namespace lldb;
using namespace lldb_private;
using namespace llvm::minidump;
+// Set of all the stop reasons minidumps will collect.
+const std::unordered_set
MinidumpFileBuilder::thread_stop_reasons {
+ lldb::StopReason::eStopReasonException,
+ ll
@@ -686,16 +692,10 @@ Status MinidumpFileBuilder::AddExceptions() {
for (const ThreadSP &thread_sp : thread_list) {
StopInfoSP stop_info_sp = thread_sp->GetStopInfo();
bool add_exception = false;
-if (stop_info_sp) {
- switch (stop_info_sp->GetStopReason()) {
jeffreytan81 wrote:
@jimingham, sounds good. I will move the logic into ValueObject.
> TryAllThreads is true
I did not see any client code setting this to true, I assume this happens
because `m_try_others` is true by default? Maybe we should set `m_try_others`'s
default value to false to avoi
@@ -1024,6 +1027,8 @@ Status MinidumpFileBuilder::AddMemoryList_32(
error = AddData(data_up->GetBytes(), bytes_read);
if (error.Fail())
return error;
+
+progress.Increment();
clayborg wrote:
might be nice to add detail before the ReadMemory a
1 - 100 of 143 matches
Mail list logo
