================
@@ -55,6 +55,21 @@ size_t ObjectFileMinidump::GetModuleSpecifications(
   return 0;
 }
 
+struct SaveCoreRequest {
----------------
jeffreytan81 wrote:

Per our naming convention, let's call this RAII class 
`FileRemoveHolder/DumpFailRemoveHolder` or something similar, then the reader 
immediately know it is a RAII class. The current `SaveCoreRequest` is not 
indicating its purpose.

https://github.com/llvm/llvm-project/pull/108259
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to