labath wrote:
> Thanks for the overwhelming support :-)
I hate to ruin a party, but I don't think this is a good use of `operator==`,
precisely because it does not define an equivalence relation (it's not
transitive). Might I suggest named function instead? `IsCompatible` ?
https://github.com
DavidSpickett wrote:
First, thanks for fixing this. It has been on Linaro's backlog for a while but
as usual resources are scarce.
> Currently, watchpoints don't work on Windows (this can be reproduced with the
> existing tests).
For background here, the Windows LLDB bot is run by Linaro and
labath wrote:
My previous message reflected my confusion about the usefulness about the
DW_IDX_cu+DW_IDX_tu combo. Let me try to start over.
The thing I don't like about this patch is the duplication between
`getForeignTUSkeletonCUOffset` (the new function) and `getCUOffset` (the
existing fun
DavidSpickett wrote:
I've re-ordered the register enums changes so that
https://github.com/llvm/llvm-project/pull/90059 will be last and I can go ahead
with the rest of it. So I'm going to land this now.
Next PR will teach lldb to parse the enum XML elements for use in register
commands.
htt
Author: David Spickett
Date: 2024-06-17T11:53:31+01:00
New Revision: f838f08c8def5f49001bba9dc4f682baef04cd14
URL:
https://github.com/llvm/llvm-project/commit/f838f08c8def5f49001bba9dc4f682baef04cd14
DIFF:
https://github.com/llvm/llvm-project/commit/f838f08c8def5f49001bba9dc4f682baef04cd14.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/90063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/95768
This teaches lldb to parse the enum XML elements sent by lldb-server, and make
use of the information in `register read` and `register info`.
The format is described in
https://sourceware.org/gdb/current/o
https://github.com/DavidSpickett ready_for_review
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This teaches lldb to parse the enum XML elements sent by lldb-server, and make
use of the information in `register read` and `register info`.
The format is described in
https://sourceware.org/gdb/curr
Michael137 wrote:
> > > The correct answer here is probably to fix the sizes in the RecordLayout
> > > itself; in particular, the DataSize of the members.
> >
> >
> > That would be ideal, but also means we'd have to reflect the various C++
> > attributes that affect layout in DWARF. Avoiding
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/95007
>From 6255aeca48a2ccd97d519a22632443f2f76d3773 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 4 Jun 2024 12:01:48 -0700
Subject: [PATCH] [lldb][API] Add Find(Ranges)InMemory() to Process SB API
Test Plan:
l
@@ -209,6 +209,14 @@ class LLDB_API SBProcess {
lldb::addr_t ReadPointerFromMemory(addr_t addr, lldb::SBError &error);
+ lldb::SBAddressRangeList
+ FindRangesInMemory(const void *buf, uint64_t size, SBAddressRangeList
&ranges,
+ uint32_t alignment, ui
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Yea the problem with checking the size reported by the AST layout vs. the LLVM
type layout is that in DWARF we get following representation:
```
// main.cpp
struct A {
long c, d;
};
struct B {
[[no_unique_address]] Empty x;
};
struct C {
[[no_unique_address]] Empty x;
}
https://github.com/walter-erquinigo approved this pull request.
This LGTM
https://github.com/llvm/llvm-project/pull/91570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aganea wrote:
This is breaking the github CI as seen here:
https://buildkite.com/llvm-project/github-pull-requests/builds/73339#01902659-9fbc-44d2-9a5b-783f5af41b78.
Should we add the "packaging" module to
https://github.com/llvm/llvm-project/blob/main/lldb/test/requirements.txt ?
https://git
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/95806
To fix CI after https://github.com/llvm/llvm-project/pull/93712 landed.
>From 5f50abb6d5f36a35b206b673f10a88635ba54a43 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 17 Jun 2024 15:44:16 +
Su
https://github.com/DavidSpickett ready_for_review
https://github.com/llvm/llvm-project/pull/95806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
To fix CI after https://github.com/llvm/llvm-project/pull/93712 landed.
---
Full diff: https://github.com/llvm/llvm-project/pull/95806.diff
1 Files Affected:
- (modified) lldb/test/requirements.txt
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/95075
>From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 10 Jun 2024 17:04:11 -0700
Subject: [PATCH 01/12] Add --targets and --modules option to statistics dump
---
lldb
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/95075
>From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 10 Jun 2024 17:04:11 -0700
Subject: [PATCH 01/13] Add --targets and --modules option to statistics dump
---
lldb
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
return error;
}
-size_t MinidumpFileBuilder::GetDirectoriesNum() const {
- return m_directories.size();
+static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) {
+
DavidSpickett wrote:
Still waiting for a Linux CI build, but I assume this would fix the problem so
I'm going to merge this now.
https://github.com/llvm/llvm-project/pull/95806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/95806
>From 5f50abb6d5f36a35b206b673f10a88635ba54a43 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 17 Jun 2024 15:44:16 +
Subject: [PATCH] [lldb] Add packaging to testing requirements.txt
To fix C
Author: David Spickett
Date: 2024-06-17T17:14:06+01:00
New Revision: 13c66388db650d7766b5eb63c09ef84bb5c9e9b8
URL:
https://github.com/llvm/llvm-project/commit/13c66388db650d7766b5eb63c09ef84bb5c9e9b8
DIFF:
https://github.com/llvm/llvm-project/commit/13c66388db650d7766b5eb63c09ef84bb5c9e9b8.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/95806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -858,10 +923,224 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
return error;
}
-size_t MinidumpFileBuilder::GetDirectoriesNum() const {
- return m_directories.size();
+Status MinidumpFileBuilder::AddMemoryList_32(
+const Process::CoreFileMemor
JDevlieghere wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/95806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Anyone reading this who has an active PR that this would fix, you'll need to
rebase it to include this change. If you're unlikely to effect lldb's tests
anyway, I suggest waiting until review is complete before doing the rebase.
https://github.com/llvm/llvm-project/pull/95
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-06-17T09:37:44-07:00
New Revision: 3380644fb070fd6648e873b1e75022bdfc432f1f
URL:
https://github.com/llvm/llvm-project/commit/3380644fb070fd6648e873b1e75022bdfc432f1f
DIFF:
https://github.com/llvm/llvm-project/commit/3380644fb070fd6648e873b1e75022bdfc432f1f.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/95623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/95571
>From 018c7a6052add708e0b0d09b911a904b52199da5 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Jun 2024 14:15:43 -0400
Subject: [PATCH 1/3] Reapply "Reapply PR/87550 (#94625)"
This reverts commit adcf33f8
cmtice wrote:
Just a reminder: Once we complete the work of adding type units to the merged
debug_names index, foreign type unit entries will need (and have)
DW_IDX_compile_unit values, even in the case without .dwp files, and will need
to be handled properly. So that should be kept in mind wh
@@ -85,7 +85,7 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
bool has_class_name = !class_name.empty();
bool has_interpreter_dict =
!(llvm::StringRef(m_interpreter.GetDictionaryName()).empty());
-if (!has_class_name && !has_interpret
@@ -0,0 +1,165 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = assignment_expression ;
adrian-prantl wrote:
Nice to actually have the grammar documented!
https://github.com/llvm/llvm-project/pull/957
clayborg wrote:
> My previous message reflected my confusion about the usefulness about the
> DW_IDX_cu+DW_IDX_tu combo. Let me try to start over.
>
> The thing I don't like about this patch is the duplication between
> `getForeignTUSkeletonCUOffset` (the new function) and `getCUOffset` (the
Author: Jonas Devlieghere
Date: 2024-06-17T10:20:58-07:00
New Revision: a1994ae6247ddd0374c7eb3a5d421925117833ab
URL:
https://github.com/llvm/llvm-project/commit/a1994ae6247ddd0374c7eb3a5d421925117833ab
DIFF:
https://github.com/llvm/llvm-project/commit/a1994ae6247ddd0374c7eb3a5d421925117833ab.d
https://github.com/bulbazord requested changes to this pull request.
I think you can probably just remove the check for `properties` value entirely.
This is the first property that may be printed, so it will never be greater
than 0. I think this will work:
```
stream.Printf(" ( arch=");
```
Th
@@ -745,26 +745,25 @@ Status Scalar::SetValueFromData(const DataExtractor &data,
bool Scalar::SignExtend(uint32_t sign_bit_pos) {
const uint32_t max_bit_pos = GetByteSize() * 8;
+ assert(sign_bit_pos < max_bit_pos);
- if (sign_bit_pos < max_bit_pos) {
-switch (m_type
https://github.com/fmayer edited https://github.com/llvm/llvm-project/pull/95678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/fmayer edited https://github.com/llvm/llvm-project/pull/95678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> But we won't want a CU index back if we have a `DW_IDX_type_unit` that is a
> local type unit. Makes no sense to return a CUOffset from such entries.
Can you elaborate on that? I believe it doesn't make sense to you, but I just
don't see the logic behind it. In particular I don
@@ -133,7 +133,9 @@ struct ConstStringStats {
struct StatisticsOptions {
bool summary_only = false;
bool load_all_debug_info = false;
- bool include_transcript = false;
+ bool include_targets = true;
+ bool include_modules = true;
royitaqi wrote:
Right
clayborg wrote:
> > But we won't want a CU index back if we have a `DW_IDX_type_unit` that is a
> > local type unit. Makes no sense to return a CUOffset from such entries.
>
> Can you elaborate on that? I believe it doesn't make sense to you, but I just
> don't see the logic behind it. In part
@@ -576,13 +576,19 @@ template static bool
isFirstInExternCContext(T *D) {
return First->isInExternCContext();
}
-static bool isSingleLineLanguageLinkage(const Decl &D) {
- if (const auto *SD = dyn_cast(D.getDeclContext()))
+static bool isUnbracedLanguageLinkage(const Dec
@@ -6286,7 +6286,7 @@ static FunctionDecl *rewriteBuiltinFunctionDecl(Sema
*Sema, ASTContext &Context,
FunctionDecl *OverloadDecl = FunctionDecl::Create(
Context, Parent, FDecl->getLocation(), FDecl->getLocation(),
FDecl->getIdentifier(), OverloadTy,
- /*TIn
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II,
QualType Type,
}
FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type,
- /*TInfo=*/nullptr, SC_Extern,
+
dwblaikie wrote:
> Good question, I haven't dug into the modules import mechanism yet, but if
> this is true, then that could give us an opportunity to introduce a "lazy
> method loading" mechanism on the ExternalASTSource that would fit both LLDB
> and modules? Will try to confirm this (unles
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II,
QualType Type,
}
FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type,
- /*TInfo=*/nullptr, SC_Extern,
+
@@ -576,13 +576,19 @@ template static bool
isFirstInExternCContext(T *D) {
return First->isInExternCContext();
}
-static bool isSingleLineLanguageLinkage(const Decl &D) {
- if (const auto *SD = dyn_cast(D.getDeclContext()))
+static bool isUnbracedLanguageLinkage(const Dec
https://github.com/temyurchenko updated
https://github.com/llvm/llvm-project/pull/93913
>From 410c7ba9fb7667dabdfbc48fdbda427401ca8df0 Mon Sep 17 00:00:00 2001
From: Artem Yurchenko <44875844+temyurche...@users.noreply.github.com>
Date: Thu, 30 May 2024 16:18:47 -0400
Subject: [PATCH 1/3] [clang
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II,
QualType Type,
}
FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type,
- /*TInfo=*/nullptr, SC_Extern,
+
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II,
QualType Type,
}
FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type,
- /*TInfo=*/nullptr, SC_Extern,
+
@@ -2380,7 +2380,7 @@ FunctionDecl *Sema::CreateBuiltin(IdentifierInfo *II,
QualType Type,
}
FunctionDecl *New = FunctionDecl::Create(Context, Parent, Loc, Loc, II, Type,
- /*TInfo=*/nullptr, SC_Extern,
+
https://github.com/temyurchenko edited
https://github.com/llvm/llvm-project/pull/93913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -131,11 +131,48 @@ struct ConstStringStats {
};
struct StatisticsOptions {
- bool summary_only = false;
- bool load_all_debug_info = false;
- bool include_targets = true;
- bool include_modules = true;
- bool include_transcript = true;
+public:
+ void SetSummaryOnly(b
@@ -131,11 +131,48 @@ struct ConstStringStats {
};
struct StatisticsOptions {
- bool summary_only = false;
- bool load_all_debug_info = false;
- bool include_targets = true;
- bool include_modules = true;
- bool include_transcript = true;
+public:
+ void SetSummaryOnly(b
https://github.com/hawkinsw edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hawkinsw commented:
Thank you for doing this work! I hope that these little bits help!
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -131,11 +131,48 @@ struct ConstStringStats {
};
struct StatisticsOptions {
- bool summary_only = false;
- bool load_all_debug_info = false;
- bool include_targets = true;
- bool include_modules = true;
- bool include_transcript = true;
+public:
+ void SetSummaryOnly(b
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/95075
>From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 10 Jun 2024 17:04:11 -0700
Subject: [PATCH 01/14] Add --targets and --modules option to statistics dump
---
lldb
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/95075
>From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 10 Jun 2024 17:04:11 -0700
Subject: [PATCH 01/15] Add --targets and --modules option to statistics dump
---
lldb
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,165 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = assignment_expression ;
+
+assignment_expression = conditional_expression
+logical_or_expression assignment_operator
assignment_ex
@@ -0,0 +1,165 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = assignment_expression ;
+
+assignment_expression = conditional_expression
+logical_or_expression assignment_operator
assignment_ex
@@ -0,0 +1,165 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = assignment_expression ;
+
+assignment_expression = conditional_expression
+logical_or_expression assignment_operator
assignment_ex
@@ -0,0 +1,165 @@
+(* LLDB Debug Expressions, a subset of C++ *)
+(* Insired by https://www.nongnu.org/hcb *)
+
+expression = assignment_expression ;
+
+assignment_expression = conditional_expression
+logical_or_expression assignment_operator
assignment_ex
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
return error;
}
-size_t MinidumpFileBuilder::GetDirectoriesNum() const {
- return m_directories.size();
+static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) {
+
Author: Adrian Prantl
Date: 2024-06-17T15:11:33-07:00
New Revision: 6c17f1cabdee3399feceb478921a8369bde18b16
URL:
https://github.com/llvm/llvm-project/commit/6c17f1cabdee3399feceb478921a8369bde18b16
DIFF:
https://github.com/llvm/llvm-project/commit/6c17f1cabdee3399feceb478921a8369bde18b16.diff
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/95857
This change by itself has no measurable effect on the LLDB testsuite. I'm
making it in preparation for threading through more errors in the Swift
language plugin.
>From 7e3d1420a941431de223098ee153d2d4c63
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This change by itself has no measurable effect on the LLDB testsuite. I'm
making it in preparation for threading through more errors in the Swift
language plugin.
---
Patch is 20.56 KiB, truncated to
Author: Jonas Devlieghere
Date: 2024-06-17T15:15:28-07:00
New Revision: 0041582b6ca137ad04e26985a87a1ae45fb0f0bb
URL:
https://github.com/llvm/llvm-project/commit/0041582b6ca137ad04e26985a87a1ae45fb0f0bb
DIFF:
https://github.com/llvm/llvm-project/commit/0041582b6ca137ad04e26985a87a1ae45fb0f0bb.d
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
6c17f1cabdee3399feceb478921a8369bde18b16...7e3d1420a941431de223098ee153d2d4c63cfbfc
lldb/
efriedma-quic wrote:
Oh, in this particular case, the issue isn't the computed datasize, it's that
FieldDecl::isZeroSize() returns the wrong result. If that's the case, maybe we
can just change FieldDecl::isZeroSize() to say the field is zero size? So
essentially, we pretend all empty field
dwblaikie wrote:
> Oh, in this particular case, the issue isn't the computed datasize, it's that
> FieldDecl::isZeroSize() returns the wrong result. If that's the case, maybe
> we can just change FieldDecl::isZeroSize() to say the field is zero size? So
> essentially, we pretend all empty fiel
efriedma-quic wrote:
That would mean if someone wrote `struct Empty {}; struct Z { Empty a,b,c; }`,
we'd lower it to `{ [3 x i8] }` instead of `{%Empty, %Empty, %Empty}`, which is
a bit ugly. Other than that, sure, I guess we could do that.
https://github.com/llvm/llvm-project/pull/93809
@@ -20,25 +20,96 @@
#include "lldb/Target/RegisterContext.h"
#include "lldb/Target/StopInfo.h"
#include "lldb/Target/ThreadList.h"
+#include "lldb/Utility/DataBufferHeap.h"
#include "lldb/Utility/DataExtractor.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h
@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
size_t size = memory_buffer->getBufferSize();
if (size == 0)
continue;
- AddDirectory(stream, size);
+ error = AddDirectory(stream, size);
+ if (error.Fail())
+return
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
return error;
}
-size_t MinidumpFileBuilder::GetDirectoriesNum() const {
- return m_directories.size();
+static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) {
+
@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
size_t size = memory_buffer->getBufferSize();
if (size == 0)
continue;
- AddDirectory(stream, size);
+ error = AddDirectory(stream, size);
+ if (error.Fail())
+return
@@ -480,71 +559,64 @@ class ArchThreadContexts {
}
};
-// Function returns start and size of the memory region that contains
-// memory location pointed to by the current stack pointer.
-llvm::Expected>
-findStackHelper(const lldb::ProcessSP &process_sp, uint64_t rsp) {
- M
@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
size_t size = memory_buffer->getBufferSize();
if (size == 0)
continue;
- AddDirectory(stream, size);
+ error = AddDirectory(stream, size);
+ if (error.Fail())
+return
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
return error;
}
-size_t MinidumpFileBuilder::GetDirectoriesNum() const {
- return m_directories.size();
+static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) {
+
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
Status error;
size_t bytes_written;
- bytes_written = header_size;
- error = core_file->Write(&header, bytes_written);
- if (error.Fail() || bytes_written != header_size) {
-if
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
Status error;
size_t bytes_written;
- bytes_written = header_size;
- error = core_file->Write(&header, bytes_written);
- if (error.Fail() || bytes_written != header_size) {
-if
@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
return error;
}
-size_t MinidumpFileBuilder::GetDirectoriesNum() const {
- return m_directories.size();
+static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) {
+
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/95871
The following warning is technically correct, but pretty much useless, since
there aren't any frame variables that we'd expect the debugger to understand.
This version of LLDB has no plugin for the langua
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/95871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The following warning is technically correct, but pretty much useless, since
there aren't any frame variables that we'd expect the debugger to understand.
> This version of LLDB has no plugin for th
https://github.com/medismailben approved this pull request.
LGTM but all the formatting changes are a bit distracting, would be nice to be
have them in a separate commit.
https://github.com/llvm/llvm-project/pull/95871
___
lldb-commits mailing list
ll
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
Status error;
size_t bytes_written;
- bytes_written = header_size;
- error = core_file->Write(&header, bytes_written);
- if (error.Fail() || bytes_written != header_size) {
-if
@@ -480,71 +559,64 @@ class ArchThreadContexts {
}
};
-// Function returns start and size of the memory region that contains
-// memory location pointed to by the current stack pointer.
-llvm::Expected>
-findStackHelper(const lldb::ProcessSP &process_sp, uint64_t rsp) {
- M
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
Status error;
size_t bytes_written;
- bytes_written = header_size;
- error = core_file->Write(&header, bytes_written);
- if (error.Fail() || bytes_written != header_size) {
-if
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
Status error;
size_t bytes_written;
- bytes_written = header_size;
- error = core_file->Write(&header, bytes_written);
- if (error.Fail() || bytes_written != header_size) {
-if
1 - 100 of 120 matches
Mail list logo
