[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 443574. Michael137 added a comment. - Move helper into new namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Material

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice work! I only had superficial comments, maybe let's also wait for @jingham to accept the patch. Comment at: lldb/include/lldb/Expression/UserExpression.h:283 + stat

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added a comment. with latest changes LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

labath added a comment. In D81471#3637057 , @werat wrote: > In D81471#3632297 , @labath wrote: > >> I guess the condition we really want to express here is "does this >> expression refer to a constexpr variable (id

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D129166#3636658 , @dblaikie wrote: >> The overall logic and the include and library paths make sense to me. The >> rpath thingy will not work on wi

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

labath added a comment. I am not fully versed on the patch, but generally speaking, if you're reasonably confident that your change fixed the origianl problem, you can resubmit the patch (and watch the bot for problems). If you still don't know what's the issue, then we may need to find someone

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. The patch is really trivial so I don't want to make big deal out of the test. However, I would like to continue the discussion started in the patch description, as I think it woul

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

DavidSpickett added a comment. > then we may need to find someone with an arm machine. I tried this patch on AArch64 and did not get any new failures. You can go ahead and reland. If there's still issues I can help fix them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

mstorsjo added a comment. In D129455#3641967 , @labath wrote: > You say that the issue is the lack of symtab in the "msvc" mode. What makes > this test work then? When invoked via the `%build` python script (lldb/test/Shell/helper/build.py), clang is i

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

mstorsjo added a comment. In D129455#3642015 , @mstorsjo wrote: > In D129455#3641967 , @labath wrote: > >> What does `-Wl,-debug:symtab` actually produce? Would it make sense to make >> it a part of the `%clang_h

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. In D50304#3641971 , @DavidSpickett wrote: >> then we may need to find someone with an arm machine. > > I tried this patch on AArch64 and did not get any new failures. You can go > ahead and reland. If there's still issues I

[Lldb-commits] [lldb] 419cc0a - [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

Author: Venkata Ramanaiah Nalamothu Date: 2022-07-11T18:45:37+05:30 New Revision: 419cc0a0b2ab7306dd721c337e7ce6ed31dc7287 URL: https://github.com/llvm/llvm-project/commit/419cc0a0b2ab7306dd721c337e7ce6ed31dc7287 DIFF: https://github.com/llvm/llvm-project/commit/419cc0a0b2ab7306dd721c337e7ce6ed

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG419cc0a0b2ab: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

labath added a comment. Well... I'm as puzzled as you are. Whatever the problem is, it seems to be limited to debian (kernel). I've filed a bug about that: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014754. One good thing I learned is that this problem seems to be limited to SIGSTOPs,

[Lldb-commits] [PATCH] D129487: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the first part of support for reading MTE tags from Linux core

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This teaches ProcessElfCore to recognise the MTE tag

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett added reviewers: omjavaid, labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. This change is purely about reading the tags. There will be another change to get fault reporting working. Right now lldb only looks at `signo` so you see a segfault but not w

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

labath created this revision. labath added reviewers: JDevlieghere, mib. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Precise string layout has changed a lot recently, but a long of these changes did not have any effect on the usages of its f

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Heh, and I actually thought using `SIGSTOP` was a good idea because it's unlikely to have any unexpected side effects ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

mgorny added a comment. Also, big, big thanks for helping out with this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129012/new/ https://reviews.llvm.org/D129012 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. I do not have commit access; could someone merge this patch as time allows? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-com

[Lldb-commits] [lldb] 9790406 - Reland "[lldb] [test] Improve stability of llgs vCont-threads tests"

Author: Michał Górny Date: 2022-07-11T18:05:14+02:00 New Revision: 9790406a9226e112e75eeeac1c326cff9b570264 URL: https://github.com/llvm/llvm-project/commit/9790406a9226e112e75eeeac1c326cff9b570264 DIFF: https://github.com/llvm/llvm-project/commit/9790406a9226e112e75eeeac1c326cff9b570264.diff

[Lldb-commits] [PATCH] D129012: [lldb] [test] Improve stability of llgs vCont-threads tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9790406a9226: Reland "[lldb] [test] Improve stability of llgs vCont-threads tests" (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D129012?vs=442916&id=443668#toc Repository:

[Lldb-commits] [lldb] 9302ff0 - Revert "jGetLoadedDynamicLibrariesInfos can inspect machos not yet loaded"

Author: Jonas Devlieghere Date: 2022-07-11T09:25:14-07:00 New Revision: 9302ff095168875a6a56e79d3401724e7b0069fd URL: https://github.com/llvm/llvm-project/commit/9302ff095168875a6a56e79d3401724e7b0069fd DIFF: https://github.com/llvm/llvm-project/commit/9302ff095168875a6a56e79d3401724e7b0069fd.d

[Lldb-commits] [lldb] f921985 - Rebase: [Facebook] Add clang driver options to test debug info and BOLT

Author: Amir Ayupov Date: 2022-07-11T09:31:51-07:00 New Revision: f921985a29fc9787b3ed98dbc897146cc3fd91f7 URL: https://github.com/llvm/llvm-project/commit/f921985a29fc9787b3ed98dbc897146cc3fd91f7 DIFF: https://github.com/llvm/llvm-project/commit/f921985a29fc9787b3ed98dbc897146cc3fd91f7.diff L

[Lldb-commits] [lldb] b444358 - Revert "Rebase: [Facebook] Add clang driver options to test debug info and BOLT"

Author: spupyrev Date: 2022-07-11T09:50:46-07:00 New Revision: b444358126aa6354e56bf629f50fdcd607b2a233 URL: https://github.com/llvm/llvm-project/commit/b444358126aa6354e56bf629f50fdcd607b2a233 DIFF: https://github.com/llvm/llvm-project/commit/b444358126aa6354e56bf629f50fdcd607b2a233.diff LOG:

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with a comment Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( Left over ? Repos

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione added a reviewer: Michael137. kastiglione added inline comments. Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( mib wrote: > Left over ? yep thanks! Repository: rG LLVM G

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 443707. Michael137 marked 9 inline comments as done. Michael137 added a comment. - Address stylistic/documentation comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:432 +m_size = g_default_var_byte_size; +m_alignment = g_default_var_alignment; } aprantl wrote: > FWIW, the refactoring of EntityVariable could have been a separate

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. @jingham, thanks for sharing the thoughts. > Setting the breakpoint search to only check base names will of course make > all your file and line breakpoints work, but they will also pick up extra > hits. In command line lldb that doesn't look nearly as weird as click

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG66cdd6548ac5: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] 66cdd65 - [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

Author: Martin Storsjö Date: 2022-07-11T23:41:35+03:00 New Revision: 66cdd6548ac51f2039b9f0bc10ec03f387b210c4 URL: https://github.com/llvm/llvm-project/commit/66cdd6548ac51f2039b9f0bc10ec03f387b210c4 DIFF: https://github.com/llvm/llvm-project/commit/66cdd6548ac51f2039b9f0bc10ec03f387b210c4.diff

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. This is great! Thanks for taking care of this! LGTM! Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:609 } else { -ValueObjectSP size_mode(dataval_sp->GetChild

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129490/new/ https://reviews.llvm.org/D129490 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

JDevlieghere added a comment. [bikeshedding] `pcm-info` seems a little odd. Do we have other command that end with `-info`? `target modules dump` already sounds like you're about to dump some kind of "info". What about just `pcm`? [/bikeshedding] Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] ce233e7 - [lldb] Use the just-built libc++ for testing the LLDB data formatters

Author: Jonas Devlieghere Date: 2022-07-11T14:49:24-07:00 New Revision: ce233e714665a0499fbd0686226e43130d44ef87 URL: https://github.com/llvm/llvm-project/commit/ce233e714665a0499fbd0686226e43130d44ef87 DIFF: https://github.com/llvm/llvm-project/commit/ce233e714665a0499fbd0686226e43130d44ef87.d

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGce233e714665: [lldb] Use the just-built libc++ for testing the LLDB data formatters (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D129166?vs

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione added a comment. @JDevlieghere I had it as `dump pcm` at first, but switched it to `pcm-info` for two reasons 1. it doesn't dump the whole pcm, the actual ast itself is not dumped 2. to match the clang flag `-module-file-info` I agree that `pcm` is better, but I was worried it would

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

clayborg created this revision. clayborg added reviewers: labath, jingham, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before this fix if you tried to call fork for vfork, the expression

[Lldb-commits] [lldb] 9097920 - [lldb] Add a test to prefer exact triple matches in platform selection

Author: Jonas Devlieghere Date: 2022-07-11T16:35:51-07:00 New Revision: 9097920ebabb6ab29f94e4051572c42459edcda8 URL: https://github.com/llvm/llvm-project/commit/9097920ebabb6ab29f94e4051572c42459edcda8 DIFF: https://github.com/llvm/llvm-project/commit/9097920ebabb6ab29f94e4051572c42459edcda8.d

[Lldb-commits] [PATCH] D104635: [lldb] Add support for escaping fish arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bc34636a50f: [lldb] Add support for escaping fish arguments (authored by teemperor, committed by JDevlieghere). Herald added a subscriber: lldb-comm

[Lldb-commits] [lldb] 9bc3463 - [lldb] Add support for escaping fish arguments

Author: Raphael Isemann Date: 2022-07-11T16:44:46-07:00 New Revision: 9bc34636a50ffd9d417d30af021798b6294a1725 URL: https://github.com/llvm/llvm-project/commit/9bc34636a50ffd9d417d30af021798b6294a1725 DIFF: https://github.com/llvm/llvm-project/commit/9bc34636a50ffd9d417d30af021798b6294a1725.dif

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This allows users to see similar output to wha

[Lldb-commits] [PATCH] D129529: [lldb] Make the g_arguments_data constexpr and fix the static assert

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. This fixes the static assert that's meant to keep the g_arguments_data table in sync with the CommandArgumentType enumeration. Indeed, the asser

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

jingham added a comment. In D129307#3643426 , @yinghuitan wrote: > @jingham, thanks for sharing the thoughts. First off, I am supportive of your project, this is a pain point for some folks for sure. I am in favor of trying to automate "I built my bin

[Lldb-commits] [PATCH] D129529: [lldb] Make the g_arguments_data constexpr and fix the static assert

jingham added a comment. Ack, sorry I missed adding that one! Everything else looks fine, but you parsed the enum incorrectly, it's eArgType - RecognizerID. This is in fact a stack-frame recognizer ID. I suggested an appropriate version above. Comment at: lldb/source/Inter

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1939-1950 + uint32_t addr_size = frame.GetThread().GetProcess().GetAddressByteSize(); + const uint32_t num_reg_sets = g_vsc.variables.registers.GetSize(); + for (uint32_t reg_set_idx=0; reg_se

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione updated this revision to Diff 443830. kastiglione added a comment. added error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include/clang/Frontend/FrontendActions.h

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

yinghuitan added a comment. Change looks good to me. I will let @jingham take a second look before accepting. I do wonder if there will be more unexpected signals (like SIGCHILD, SIGPIPE etc...) causing expression evaluation to pause? Should we maybe default to not stop on signals?