Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great from my side. Thank you for fixing this. http://reviews.llvm.org/D20193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] r269407 - [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-05-13 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri May 13 06:04:47 2016 New Revision: 269407 URL: http://llvm.org/viewvc/llvm-project?rev=269407&view=rev Log: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS Patch by Nitesh Jain. Summary: These patch will set clang::TargetOptions::A

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-05-13 Thread Nitesh Jain via lldb-commits
nitesh.jain closed this revision. nitesh.jain added a comment. Committed in revision 269407 Repository: rL LLVM http://reviews.llvm.org/D18638 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D20236: Remove ASTContexts from SystemInitializerCommon

2016-05-13 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: tberghammer, clayborg. labath added a subscriber: lldb-commits. The AST contexts are not needed in the server components, and the clang context in particular pulls in large parts of clang into the binary. Simply removing these two calls reduc

Re: [Lldb-commits] [PATCH] D20236: Remove ASTContexts from SystemInitializerCommon

2016-05-13 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Very nice! I don't know how we missed this optimization before. Finally the size of lldb-server starts to became more reasonable (3.7 MB on arm32) http://reviews.llvm.org/D20236

[Lldb-commits] [lldb] r269416 - Remove ASTContexts from SystemInitializerCommon

2016-05-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri May 13 08:40:51 2016 New Revision: 269416 URL: http://llvm.org/viewvc/llvm-project?rev=269416&view=rev Log: Remove ASTContexts from SystemInitializerCommon Summary: The AST contexts are not needed in the server components, and the clang context in particular pulls in lar

Re: [Lldb-commits] [PATCH] D20236: Remove ASTContexts from SystemInitializerCommon

2016-05-13 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269416: Remove ASTContexts from SystemInitializerCommon (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20236?vs=57171&id=57175#toc Repository: rL LLVM http://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. Thanks, Pavel! http://reviews.llvm.org/D20193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r269421 - Remove unused variable

2016-05-13 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri May 13 09:49:38 2016 New Revision: 269421 URL: http://llvm.org/viewvc/llvm-project?rev=269421&view=rev Log: Remove unused variable Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugins/ExpressionPars

Re: [Lldb-commits] [lldb] r269377 - Fix some long standing issues that caused tests to be flaky.

2016-05-13 Thread Ed Maste via lldb-commits
On 12 May 2016 at 18:58, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Thu May 12 17:58:52 2016 > New Revision: 269377 > > URL: http://llvm.org/viewvc/llvm-project?rev=269377&view=rev > Log: > Fix some long standing issues that caused tests to be flaky. On FreeBSD lldb now hits

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-05-13 Thread Luke Drummond via lldb-commits
ldrumm updated this revision to Diff 57199. ldrumm added a comment. rebased on current HEAD http://reviews.llvm.org/D17027 Files: include/lldb/Expression/LLVMUserExpression.h include/lldb/Target/LanguageRuntime.h source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Index: sour

[Lldb-commits] LLVM buildmaster will be updated and restarted tonight

2016-05-13 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r269434 - Disable HostThread::Cancel assertion on FreeBSD

2016-05-13 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri May 13 12:01:59 2016 New Revision: 269434 URL: http://llvm.org/viewvc/llvm-project?rev=269434&view=rev Log: Disable HostThread::Cancel assertion on FreeBSD It is still used by ProcessMonitor::StopMonitoringChildProcess and ProcessMonitor::StopOpThread. Modified: lldb

Re: [Lldb-commits] [lldb] r269377 - Fix some long standing issues that caused tests to be flaky.

2016-05-13 Thread Ed Maste via lldb-commits
On 13 May 2016 at 11:23, Ed Maste wrote: > On 12 May 2016 at 18:58, Greg Clayton via lldb-commits > wrote: >> Author: gclayton >> Date: Thu May 12 17:58:52 2016 >> New Revision: 269377 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=269377&view=rev >> Log: >> Fix some long standing issues that

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
Going to look at this today, but I'm getting some crashes when I run the lldb test suite, so I need to figure these out first so I have a clean baseline for comparison. On Fri, May 13, 2016 at 7:24 AM Todd Fiala wrote: > tfiala added a comment. > > Thanks, Pavel! > > > http://reviews.llvm.org/D2

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D20193#429750, @zturner wrote: > Going to look at this today, but I'm getting some crashes when I run the > lldb test suite, so I need to figure these out first so I have a clean > baseline for comparison. Okay. http://reviews.llvm.org/D201

[Lldb-commits] [lldb] r269454 - Clean up test results on Windows.

2016-05-13 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri May 13 13:26:30 2016 New Revision: 269454 URL: http://llvm.org/viewvc/llvm-project?rev=269454&view=rev Log: Clean up test results on Windows. Remove XFAIL from some tests that now pass. Add XFAIL to some tests that now fail. Fix a crasher where a null pointer check isn't

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import errors

2016-05-13 Thread Zachary Turner via lldb-commits
Do I still need to try the python -m unittest line? I didn't do that yet. On Fri, May 13, 2016 at 11:38 AM Zachary Turner wrote: > No issues on Windows, looks good over here. > > On Wed, May 11, 2016 at 6:03 PM Todd Fiala wrote: > >> tfiala created this revision. >> tfiala added reviewers: lab

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import errors

2016-05-13 Thread Zachary Turner via lldb-commits
No issues on Windows, looks good over here. On Wed, May 11, 2016 at 6:03 PM Todd Fiala wrote: > tfiala created this revision. > tfiala added reviewers: labath, zturner. > tfiala added subscribers: lldb-commits, zturner. > > This change enhances the LLDB test infrastructure to convert > load-time

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
zturner added a comment. D:\src\llvm\tools\lldb\packages\Python\lldbsuite\test_event>c:\Python35\python.exe -m unittest discover -s test/src -p "Test*.py" Traceback (most recent call last): File "c:\Python35\lib\runpy.py", line 170, in _run_module_as_main "__main__", mod_spec) File "c:\Py

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. > This directory named "src" doesn't exist. Am I missing something? Hmm let me try with a clean sync of the patch. Back in a moment... http://reviews.llvm.org/D20193 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D20193#429889, @tfiala wrote: > > This directory named "src" doesn't exist. Am I missing something? > > > Hmm let me try with a clean sync of the patch. Back in a moment... Oh you need to be one directory down - in test_event\test. http://r

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. (The test directory in the test_event package has a src dir for the package testing tests, and a resources dir for data/files used by the test.) http://reviews.llvm.org/D20193 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. Hey Zachary, forget about the test discovery part. If you can just run this directly and let me know if that works, that'll be fine: C:\Python35\python.exe D:\src\llvm\tools\lldb\packages\Python\lldbsuite\test_event\test\src\TestCatchInvalidDecorator.py That will be

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
It can't find six, I guess because it's trying to run a script directly rather than loading it as part of a package, so it never runs `import use_lldb_suite`. On Fri, May 13, 2016 at 12:17 PM Todd Fiala wrote: > tfiala added a comment. > > Hey Zachary, forget about the test discovery part. > > I

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D20193#429903, @zturner wrote: > It can't find six, I guess because it's trying to run a script directly > rather than loading it as part of a package, so it never runs `import > use_lldb_suite`. Ah of course. And this runs on OS X because s

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
Well, I have to copy use_lldb_suite.py into lldbsuite/test_event first. But then I get another error. D:\src\llvm\tools\lldb\packages\Python\lldbsuite\test_event>c:\Python35\python.exe -m unittest discover -s test/src -p "Test*.py" FF ===

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
zturner added a comment. I'm looking into a little bit. Currently I'm seeing that the temporary events file is completely empty. I can run the same command line that we're using in the subprocess.call() line, where in the code should I be looking to see events getting written to the file? http

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
Traceback (most recent call last): File "D:\src\llvm\tools\lldb\test\dotest.py", line 7, in lldbsuite.test.run_suite() File "D:\src\llvm\tools\lldb\packages\Python\lldbsuite\test\dotest.py", line 897, in run_suite setupTestResults() File "D:\src\llvm\tools\lldb\packages\Python\lldbsu

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. This chunk of code: with tempfile.NamedTemporaryFile( prefix="lldb_test_event_pickled_event_output", delete=False) as temp_file: return temp_file.name inside event_collector.py comes up with a temp file name. (It opens and then immediately cl

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
zturner added a comment. In lldbsuite\test_event\formatter\__init__.py, if I open the file with "wb" instead of "w" I get further, but I still get other errors. This might create a problem because you conditionally set the output file to stderr or stdout, which are opened for text already, so tho

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
Here's the patch I'm using so far to get to the point where dotest is actually running and successfully returning results. It just doesn't indicate any error results, only a job_begin and a job_end. All this patch does is add use_lldb_suite.py in 2 places, import it, and change a "w" to a "wb".

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
zturner added a comment. Ok the problem is that it cannot find lldb.exe anywhere. Normally we use a --executable argument when launching dotest.py, but there's no such argument here., but http://reviews.llvm.org/D20193 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D20193#429982, @zturner wrote: > Ok the problem is that it cannot find lldb.exe anywhere. Normally we use a > --executable argument when launching dotest.py, but there's no such > argument here., but Great, thanks for the patch! I'll have a

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. Zachary and I have been talking. I'm going to get this in, but I'll revisit the logic of the "test the test runner" test, which needs some work to get running on Windows. http://reviews.llvm.org/D20193 ___ lldb-commits mai

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Zachary Turner via lldb-commits
Ahh wait. Does the "wb" issue still need to be resolved first, or is that specific to testing the test? On Fri, May 13, 2016 at 2:37 PM Todd Fiala wrote: > tfiala added a comment. > > Zachary and I have been talking. I'm going to get this in, but I'll > revisit the logic of the "test the test

[Lldb-commits] [lldb] r269489 - test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri May 13 16:36:26 2016 New Revision: 269489 URL: http://llvm.org/viewvc/llvm-project?rev=269489&view=rev Log: test infra: catch bad decorators and import-time errors Summary: This change enhances the LLDB test infrastructure to convert load-time exceptions in a given Python

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269489: test infra: catch bad decorators and import-time errors (authored by tfiala). Changed prior to commit: http://reviews.llvm.org/D20193?vs=57090&id=57256#toc Repository: rL LLVM http://reviews

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

2016-05-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D20193#430073, @zturner wrote: > Ahh wait. Does the "wb" issue still need to be resolved first, or is that > specific to testing the test? That was specific to testing the test. It normally goes over a socket, which doesn't have that open i

[Lldb-commits] [lldb] r269525 - surface build error content through test event system

2016-05-13 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri May 13 19:42:30 2016 New Revision: 269525 URL: http://llvm.org/viewvc/llvm-project?rev=269525&view=rev Log: surface build error content through test event system Summary: print build errors nicely in test output This test infrastructure change adds a new Python exception

Re: [Lldb-commits] [PATCH] D20224: Unbreak build on NetBSD-7.0

2016-05-13 Thread Kamil Rytarowski via lldb-commits
krytarowski abandoned this revision. krytarowski added a comment. I'm giving up on LLDB in NetBSD-7.0, I'm working on upcoming NetBSD-8.0. Repository: rL LLVM http://reviews.llvm.org/D20224 ___ lldb-commits mailing list lldb-commits@lists.llvm.or