Re: [PR] KAFKA-18936: Fix share fetch when records are larger than max bytes [kafka]

2025-03-12 Thread via GitHub
AndrewJSchofield merged PR #19145: URL: https://github.com/apache/kafka/pull/19145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1990997212 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1990559413 ## server/src/main/java/org/apache/kafka/server/share/fetch/PartitionRotateStrategy.java: ## @@ -80,20 +81,8 @@ static LinkedHashMap rotateRoundRobin(

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1991041594 ## server/src/main/java/org/apache/kafka/server/share/ErroneousAndValidPartitionData.java: ## @@ -20,47 +20,48 @@ import org.apache.kafka.common.TopicIdPartitio

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1991048323 ## server/src/main/java/org/apache/kafka/server/share/fetch/PartitionRotateStrategy.java: ## @@ -80,20 +81,11 @@ static LinkedHashMap rotateRoundRobin(

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
adixitconfluent commented on PR #19148: URL: https://github.com/apache/kafka/pull/19148#issuecomment-2717068996 @apoorvmittal10 , I have addressed your comments. Please review when you can. Also, I had to do a force push to fix the branch history because it got corrupted by a merge commit p

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1990907805 ## docs/upgrade.html: ## @@ -19,6 +19,10 @@

[jira] [Created] (KAFKA-18964) Allow to set weights for controller nodes for leader election

2025-03-12 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18964: - Summary: Allow to set weights for controller nodes for leader election Key: KAFKA-18964 URL: https://issues.apache.org/jira/browse/KAFKA-18964 Project: Kafka Issu

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991148865 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
ijuma commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991162921 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x + +Up

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991184428 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests [kafka]

2025-03-12 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1991101107 ## server/src/main/java/org/apache/kafka/server/share/ErroneousAndValidPartitionData.java: ## @@ -20,47 +20,48 @@ import org.apache.kafka.common.TopicIdPartiti

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991166491 ## docs/upgrade.html: ## @@ -52,9 +73,6 @@ Upgrading to 4.0.0 from any vers Every https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/

Re: [PR] KAFKA-14484: Move UnifiedLog to storage module [kafka]

2025-03-12 Thread via GitHub
mimaison commented on code in PR #19030: URL: https://github.com/apache/kafka/pull/19030#discussion_r1991245995 ## storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java: ## @@ -55,6 +113,2298 @@ public class UnifiedLog { public static final String STR

[jira] [Resolved] (KAFKA-18936) Share fetch stuck when records are larger than fetch max bytes

2025-03-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-18936. --- Resolution: Fixed > Share fetch stuck when records are larger than fetch max bytes > ---

Re: [PR] MINOR: call the serialize method including headers from the MockProducer [kafka]

2025-03-12 Thread via GitHub
gklijs commented on PR #11144: URL: https://github.com/apache/kafka/pull/11144#issuecomment-2718126895 @divijvaidya not sure if something needs to be done anymore besides merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] KAFKA-18760: Deprecate Optional and return String from public EndPoint#listenerName (wip) [kafka]

2025-03-12 Thread via GitHub
FrankYang0529 opened a new pull request, #19191: URL: https://github.com/apache/kafka/pull/19191 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals,

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991658719 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -82,29 +97,41 @@ public StreamsGroupHeartbeatReques

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-12 Thread via GitHub
ShivsundarR commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r1991728528 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -1004,8 +1014,10 @@ private void updateLeaderInfoMap(Sh

Re: [PR] KAFKA-17715 remove force_use_zk_connection from e2e [kafka]

2025-03-12 Thread via GitHub
mimaison commented on PR #17465: URL: https://github.com/apache/kafka/pull/17465#issuecomment-2718236601 @mingdaoy Are you still working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-18276 Migrate ProducerRebootstrapTest to new test infra [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on PR #19046: URL: https://github.com/apache/kafka/pull/19046#issuecomment-2718333704 @chia7712 Thank you for your note. I have also updated this PR to fix the related issues from https://github.com/apache/kafka/pull/19094#discussion_r1986208718 -- This is an aut

[jira] [Commented] (KAFKA-18964) Allow to set weights for controller nodes for leader election

2025-03-12 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934496#comment-17934496 ] TengYao Chi commented on KAFKA-18964: - Hi [~showuon]  I'd like to take over this on

Re: [PR] KAFKA-18837: Ensure controller quorum timeouts and backoffs are at least 0 [kafka]

2025-03-12 Thread via GitHub
mimaison merged PR #18998: URL: https://github.com/apache/kafka/pull/18998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18942) Add reviewers to PR body with committer-tools

2025-03-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18942. Resolution: Fixed > Add reviewers to PR body with committer-tools > --

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
Yunyung commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1991792486 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -20,91 +20,85 @@ import org.apache.kafka.clients.admin.NewTopic; import org.apache.kafka.c

Re: [PR] KAFKA-17715 remove force_use_zk_connection from e2e [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on PR #17465: URL: https://github.com/apache/kafka/pull/17465#issuecomment-2718305049 @mimaison this ticket will be handled by @mingyen066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-18613: Unit tests for usage of incorrect RPCs [kafka]

2025-03-12 Thread via GitHub
lucasbru commented on PR #18383: URL: https://github.com/apache/kafka/pull/18383#issuecomment-2718091230 I retargeted this to trunk (I thought I had already). The tests weren't changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-03-12 Thread via GitHub
frankvicky commented on code in PR #18600: URL: https://github.com/apache/kafka/pull/18600#discussion_r1990879080 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -92,25 +97,25 @@ public void testNodeDirectoryId() { } @ParameterizedTest -

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991647238 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -61,9 +61,23 @@ public class StreamsGroupHeartbeatR

[jira] [Resolved] (KAFKA-18832) ShareFetch behaviour seems incorrect when MaxBytes is less than record size

2025-03-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-18832. --- Resolution: Fixed > ShareFetch behaviour seems incorrect when MaxBytes is less than record s

[jira] [Commented] (KAFKA-18832) ShareFetch behaviour seems incorrect when MaxBytes is less than record size

2025-03-12 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934553#comment-17934553 ] Apoorv Mittal commented on KAFKA-18832: --- Duplicate of: https://issues.apache.org/j

Re: [PR] KAFKA-18651: Add Streams-specific broker configurations [kafka]

2025-03-12 Thread via GitHub
lucasbru commented on PR #19176: URL: https://github.com/apache/kafka/pull/19176#issuecomment-2718102555 @aliehsaeedii there seem to be test fialures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991641888 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -119,9 +146,9 @@ private static List convertTaskId

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991660967 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManagerTest.java: ## @@ -476,20 +492,25 @@ public void testNotSendingL

[PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-12 Thread via GitHub
ShivsundarR opened a new pull request, #19192: URL: https://github.com/apache/kafka/pull/19192 *What* - Previously, the ShareConsumer.commitAsync() method retried sending ShareAcknowledge requests indefinitely. Now it will instead use the defaultApiTimeout config to expire the

[jira] [Updated] (KAFKA-18965) Improve release validation for kafka-clients

2025-03-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-18965: - Fix Version/s: 4.1.0 > Improve release validation for kafka-clients > --

[jira] [Updated] (KAFKA-18965) Improve release validation for kafka-clients

2025-03-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-18965: - Component/s: build clients release > Improve release validatio

[jira] [Created] (KAFKA-18965) Improve release validation for kafka-clients

2025-03-12 Thread David Arthur (Jira)
David Arthur created KAFKA-18965: Summary: Improve release validation for kafka-clients Key: KAFKA-18965 URL: https://issues.apache.org/jira/browse/KAFKA-18965 Project: Kafka Issue Type: Impr

[jira] [Resolved] (KAFKA-15844) Broker doesn't re-register after losing ZK session

2025-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-15844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-15844. Resolution: Won't Fix Marking it as won't fix since Kafka doesn't

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
Yunyung commented on code in PR #19187: URL: https://github.com/apache/kafka/pull/19187#discussion_r1991771351 ## core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java: ## @@ -20,91 +20,85 @@ import org.apache.kafka.clients.admin.NewTopic; import org.apache.kafka.c

Re: [PR] KAFKA-17715 remove force_use_zk_connection from e2e [kafka]

2025-03-12 Thread via GitHub
chia7712 closed pull request #17465: KAFKA-17715 remove force_use_zk_connection from e2e URL: https://github.com/apache/kafka/pull/17465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on PR #19187: URL: https://github.com/apache/kafka/pull/19187#issuecomment-2718310300 @clarkwtc cloud you please move this test to clients-integration-tests module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
mingdaoy commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991109201 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

[jira] [Updated] (KAFKA-18964) Allow to set weights for controller nodes for leader election

2025-03-12 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18964: Labels: needs-kip (was: ) > Allow to set weights for controller nodes for leader election > -

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991454625 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x + +Up

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991430908 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x + +Up

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991554768 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x + +Up

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac merged PR #19119: URL: https://github.com/apache/kafka/pull/19119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Assigned] (KAFKA-18819) StreamsGroupHeartbeat API and StreamsGroupDescribe API must check topic describe

2025-03-12 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-18819: -- Assignee: Lan Ding (was: Lucas Brutschy) > StreamsGroupHeartbeat API and StreamsGrou

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
dajac commented on PR #19119: URL: https://github.com/apache/kafka/pull/19119#issuecomment-2717976372 Merged to trunk and cherry-picked to 4.0 (manually resolved the conflicts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18422 Adjust Kafka client upgrade path section [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on code in PR #19119: URL: https://github.com/apache/kafka/pull/19119#discussion_r1991562442 ## docs/upgrade.html: ## @@ -29,7 +31,26 @@ Notable changes in 4 -Upgrading to 4.0.0 from any version 3.3.x through 3.9.x +

[jira] [Commented] (KAFKA-18286) Add support for streams groups to kafka-group.sh

2025-03-12 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934539#comment-17934539 ] Lucas Brutschy commented on KAFKA-18286: We'll need KAFAK-18613, to be able to w

[jira] [Resolved] (KAFKA-18422) add Kafka client upgrade path

2025-03-12 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18422. - Resolution: Fixed > add Kafka client upgrade path > - > >

Re: [PR] KAFKA-18613: Improve test coverage for missing topics [kafka]

2025-03-12 Thread via GitHub
lucasbru commented on PR #19189: URL: https://github.com/apache/kafka/pull/19189#issuecomment-2717992037 @cadonna Could you have a look? I'm adding three tests as a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18613: Improve test coverage for missing topics [kafka]

2025-03-12 Thread via GitHub
lucasbru commented on code in PR #19189: URL: https://github.com/apache/kafka/pull/19189#discussion_r1991576556 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -180,17 +178,13 @@ private static void enforceCop

[jira] [Commented] (KAFKA-18606) Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest

2025-03-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934546#comment-17934546 ] David Arthur commented on KAFKA-18606: -- This test is still very flaky https://deve

[jira] [Comment Edited] (KAFKA-18606) Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest

2025-03-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934546#comment-17934546 ] David Arthur edited comment on KAFKA-18606 at 3/12/25 2:05 PM: ---

[jira] [Reopened] (KAFKA-18845) Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled

2025-03-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reopened KAFKA-18845: -- > Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled > ---

[jira] [Commented] (KAFKA-18845) Fail test QuorumControllerTest#testUncleanShutdownBrokerElrEnabled

2025-03-12 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934548#comment-17934548 ] David Arthur commented on KAFKA-18845: -- There was another failure on trunk https:/

Re: [PR] MINOR: Remove unused ConfigCommandOptions#forceOpt [kafka]

2025-03-12 Thread via GitHub
chia7712 commented on PR #19170: URL: https://github.com/apache/kafka/pull/19170#issuecomment-2718377684 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-16024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991820732 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -61,9 +61,23 @@ public class StreamsGroupHeartbeatR

Re: [PR] KAFKA-18736: Do not send fields if not needed [kafka]

2025-03-12 Thread via GitHub
cadonna commented on code in PR #19181: URL: https://github.com/apache/kafka/pull/19181#discussion_r1991827905 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -82,29 +97,41 @@ public StreamsGroupHeartbeatReques

Re: [PR] KAFKA-18843: Fix MirrorMaker2 workerId is not unique, but use the sam… [kafka]

2025-03-12 Thread via GitHub
viktorsomogyi commented on code in PR #18994: URL: https://github.com/apache/kafka/pull/18994#discussion_r1991829652 ## checkstyle/import-control.xml: ## @@ -567,6 +567,7 @@ + Review Comment: @k0b3rIT sorry, I was doing a final pass while notice

Re: [PR] MINOR: Remove unused ConfigCommandOptions#forceOpt [kafka]

2025-03-12 Thread via GitHub
chia7712 merged PR #19170: URL: https://github.com/apache/kafka/pull/19170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-10731: add support for SSL hot reload [kafka]

2025-03-12 Thread via GitHub
mimaison commented on PR #17987: URL: https://github.com/apache/kafka/pull/17987#issuecomment-2718390145 Thanks for opening a KIP. I commented on the thread you started on the dev list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (KAFKA-18904) Listing of configs for dynamically created resources is mysterious

2025-03-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934589#comment-17934589 ] PoAn Yang commented on KAFKA-18904: --- KIP-1142: https://cwiki.apache.org/confluence/di

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed (#15241) [kafka]

2025-03-12 Thread via GitHub
junrao commented on PR #19150: URL: https://github.com/apache/kafka/pull/19150#issuecomment-2719366230 @jeqo : Thanks for the PR. We probably want to hold off on this PR under https://github.com/apache/kafka/pull/15241#discussion_r1988994745 is resolved. -- This is an automated message fr

[jira] [Commented] (KAFKA-18973) Review MetadataSchemaCheckerToolTest.testVerifyEvolutionGit requiring git project

2025-03-12 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935028#comment-17935028 ] PoAn Yang commented on KAFKA-18973: --- Hi [~lianetm], if you're not working on this, may

[jira] [Commented] (KAFKA-18973) Review MetadataSchemaCheckerToolTest.testVerifyEvolutionGit requiring git project

2025-03-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935037#comment-17935037 ] Lianet Magrans commented on KAFKA-18973: Sure, thanks! > Review MetadataSchemaC

Re: [PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2025-03-12 Thread via GitHub
dajac commented on PR #18091: URL: https://github.com/apache/kafka/pull/18091#issuecomment-2713111637 @m1a2st Would you have time for addressing the remaining comments? This is a blocker for the 4.0 release so we need to merge it asap. Thanks for your support! -- This is an automated mes

Re: [PR] KAFKA-18915: Rewrite AdminClientRebootstrapTest to cover the current scenario [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on PR #19187: URL: https://github.com/apache/kafka/pull/19187#issuecomment-2719603347 @chia7712 Sorry, I missed it. I've fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (KAFKA-18974) Uneven distribution of topic partitions across consumers while using Cooperative Sticky Assignor

2025-03-12 Thread Gangadharan (Jira)
Gangadharan created KAFKA-18974: --- Summary: Uneven distribution of topic partitions across consumers while using Cooperative Sticky Assignor Key: KAFKA-18974 URL: https://issues.apache.org/jira/browse/KAFKA-18974

[PR] add JDK 11 check and test [kafka]

2025-03-12 Thread via GitHub
Rancho-7 opened a new pull request, #19196: URL: https://github.com/apache/kafka/pull/19196 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some com

[jira] [Commented] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2025-03-12 Thread Cameron Redpath (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935045#comment-17935045 ] Cameron Redpath commented on KAFKA-16277: - Given both topics had 12 partitions,

[jira] [Commented] (KAFKA-18964) Allow to set weights for controller nodes for leader election

2025-03-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935047#comment-17935047 ] Luke Chen commented on KAFKA-18964: --- [~frankvicky] , forgot to say, welcome to propose

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-03-12 Thread via GitHub
github-actions[bot] commented on PR #18789: URL: https://github.com/apache/kafka/pull/18789#issuecomment-2719723238 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-16277) CooperativeStickyAssignor does not spread topics evenly among consumer group

2025-03-12 Thread Gangadharan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935048#comment-17935048 ] Gangadharan commented on KAFKA-16277: - thanks for the quick feedback Cameron. > Coo

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

2025-03-12 Thread via GitHub
github-actions[bot] commented on PR #18463: URL: https://github.com/apache/kafka/pull/18463#issuecomment-2719723304 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]

2025-03-12 Thread via GitHub
Rancho-7 commented on PR #19196: URL: https://github.com/apache/kafka/pull/19196#issuecomment-2719723657 I found that our current test flow doesn't work with JDK 11 for the `clients` and `streams` modules. So I created a new test flow to handle this. Here's what the output looks like:

Re: [PR] KAFKA-18142 Switch to `com.gradleup.shadow` [kafka]

2025-03-12 Thread via GitHub
mumrah merged PR #18018: URL: https://github.com/apache/kafka/pull/18018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18031: Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt [kafka]

2025-03-12 Thread via GitHub
github-actions[bot] commented on PR #19105: URL: https://github.com/apache/kafka/pull/19105#issuecomment-2719723038 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]

2025-03-12 Thread via GitHub
Rancho-7 commented on PR #19196: URL: https://github.com/apache/kafka/pull/19196#issuecomment-2719734796 I am getting this error while testing due to the `-Werror` flag in `build.gradle`,and I am working on fixing it. ``` > Task :streams:compileJava /home/runner/work/kafka/kafk

[PR] create separate merge_group workflow [kafka-merge-queue-sandbox]

2025-03-12 Thread via GitHub
mumrah opened a new pull request, #62: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/62 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-18606: Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest [kafka]

2025-03-12 Thread via GitHub
junrao commented on code in PR #18861: URL: https://github.com/apache/kafka/pull/18861#discussion_r1992116002 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/BaseDeleteSegmentsTest.java: ## @@ -55,7 +56,7 @@ protected void writeTestSpecifications(TieredStor

[jira] [Assigned] (KAFKA-18955) MetadataSchemaCheckerTool bug fixes

2025-03-12 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang reassigned KAFKA-18955: Assignee: Alyssa Huang > MetadataSchemaCheckerTool bug fixes > --

Re: [PR] MINOR: Clean up metadata module [kafka]

2025-03-12 Thread via GitHub
sjhajharia commented on code in PR #19069: URL: https://github.com/apache/kafka/pull/19069#discussion_r1992084076 ## metadata/src/test/java/org/apache/kafka/metadata/ControllerRegistrationTest.java: ## @@ -46,18 +44,18 @@ static Map doubleMap(K k1, V v1, K k2, V v2) {

Re: [PR] MINOR: Cleanups in CoreUtils [kafka]

2025-03-12 Thread via GitHub
mimaison merged PR #19175: URL: https://github.com/apache/kafka/pull/19175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-18970) [kafka-clients] Gradle module metadata publication should be enabled

2025-03-12 Thread Jira
Dejan Stojadinović created KAFKA-18970: -- Summary: [kafka-clients] Gradle module metadata publication should be enabled Key: KAFKA-18970 URL: https://issues.apache.org/jira/browse/KAFKA-18970 Proj

[jira] [Commented] (KAFKA-16538) Support UpdateFeatures for kraft.version so we can go from static quorums to dynamic

2025-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934595#comment-17934595 ] José Armando García Sancio commented on KAFKA-16538: [~zheguang] Kaf

Re: [PR] see what happens if a pr enqueued event fails [kafka-merge-queue-sandbox]

2025-03-12 Thread via GitHub
mumrah merged PR #61: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] KAFKA-18142 Switch to `com.gradleup.shadow` [kafka]

2025-03-12 Thread via GitHub
dejan2609 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2718833869 @mumrah related JIRA ticket is created here: https://issues.apache.org/jira/browse/KAFKA-18970 **_[kafka-clients] Gradle module metadata publication should be enabled_** -- This i

Re: [PR] create separate merge_group workflow [kafka-merge-queue-sandbox]

2025-03-12 Thread via GitHub
mumrah merged PR #62: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[jira] [Resolved] (KAFKA-18142) Switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade version)

2025-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović resolved KAFKA-18142. Resolution: Resolved Github PR [https://github.com/apache/kafka/pull/18018] is mer

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-12 Thread via GitHub
mjsax commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2718868615 http://ducktape-open-source-results.confluent.io.s3-website-us-west-2.amazonaws.com/confluent-open-source-kafka-branch-builder-system-test-results/?prefix=trunk/2025-03-12--001.75a62180-48c6

[jira] [Assigned] (KAFKA-18971) Update AK system tests for AK 4.0

2025-03-12 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-18971: Assignee: Alieh Saeedi > Update AK system tests for AK 4.0 >

[jira] [Created] (KAFKA-18971) Update AK system tests for AK 4.0

2025-03-12 Thread Alieh Saeedi (Jira)
Alieh Saeedi created KAFKA-18971: Summary: Update AK system tests for AK 4.0 Key: KAFKA-18971 URL: https://issues.apache.org/jira/browse/KAFKA-18971 Project: Kafka Issue Type: Task

[jira] [Updated] (KAFKA-18971) Update AK system tests for AK 4.0

2025-03-12 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi updated KAFKA-18971: - Description: Update AK system tests and add new “upgrade_from” version to {{StreamsConfig}} > U

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

2025-03-12 Thread via GitHub
github-actions[bot] commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2716296530 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18276 Migrate ProducerRebootstrapTest to new test infra [kafka]

2025-03-12 Thread via GitHub
clarkwtc commented on PR #19046: URL: https://github.com/apache/kafka/pull/19046#issuecomment-2718481150 @chia7712 @ijuma I already moved this test to clients-integration-tests. I have also added `` on `import-control-clients-integration-tests.xml` -- This is an automated message f

  1   2   >