[
https://issues.apache.org/jira/browse/KAFKA-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767860#comment-17767860
]
Luke Chen commented on KAFKA-15414:
---
Awesome! Thank you for the confirmation, [~fvisco
dajac closed pull request #14422: test -- ignore
URL: https://github.com/apache/kafka/pull/14422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-un
divijvaidya commented on PR #14420:
URL: https://github.com/apache/kafka/pull/14420#issuecomment-1731055664
Any changes to plugin API/contract (including throwing new exceptions)
requires a KIP since those API are considered public facing (and plugin
providers use them). Please add a KIP to
[
https://issues.apache.org/jira/browse/KAFKA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767900#comment-17767900
]
Sagar Rao commented on KAFKA-15460:
---
[~zhaohaidao]are you currently working on this?
divijvaidya commented on code in PR #14412:
URL: https://github.com/apache/kafka/pull/14412#discussion_r1334103035
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilderTest.java:
##
@@ -223,38 +208,9 @@ public void shouldThrowNullPointer
divijvaidya commented on code in PR #14412:
URL: https://github.com/apache/kafka/pull/14412#discussion_r1334106327
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilderTest.java:
##
@@ -223,38 +208,9 @@ public void shouldThrowNullPointer
nizhikov commented on PR #14355:
URL: https://github.com/apache/kafka/pull/14355#issuecomment-1731082390
@showuon Thank you for the review! I resolve all your comments. Please, take
a look one more time
--
This is an automated message from the Apache Git Service.
To respond to the message
nizhikov commented on code in PR #14355:
URL: https://github.com/apache/kafka/pull/14355#discussion_r1334114200
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -0,0 +1,790 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
divijvaidya commented on PR #14407:
URL: https://github.com/apache/kafka/pull/14407#issuecomment-1731082887
I will wait for other reviewers on this PR (cc: @satishd @clolov) to provide
an approval in the next few days before merging this.
--
This is an automated message from the Apache Gi
[
https://issues.apache.org/jira/browse/KAFKA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767920#comment-17767920
]
Sagar Rao commented on KAFKA-14504:
---
[~dajac], is it still too urgent? I can take a st
[
https://issues.apache.org/jira/browse/KAFKA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767920#comment-17767920
]
Sagar Rao edited comment on KAFKA-14504 at 9/22/23 9:23 AM:
divijvaidya merged PR #14404:
URL: https://github.com/apache/kafka/pull/14404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
[
https://issues.apache.org/jira/browse/KAFKA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-14504:
---
Assignee: Dongnuo Lyu
> Implement DescribeGroups API
>
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767922#comment-17767922
]
David Jacot commented on KAFKA-14504:
-
Hey [~sagarrao]! [~dongnuolyu] will tackle th
[
https://issues.apache.org/jira/browse/KAFKA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767925#comment-17767925
]
Sagar Rao commented on KAFKA-14504:
---
Sure, I would be happy to help :)
> Implement D
Divij Vaidya created KAFKA-15485:
Summary: Upgrade to JDK-21 (LTS release)
Key: KAFKA-15485
URL: https://issues.apache.org/jira/browse/KAFKA-15485
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15485:
-
Description:
JDK-21 is the latest LTS release which reached GA on 19th Sept 2023. This
ticket a
[
https://issues.apache.org/jira/browse/KAFKA-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767930#comment-17767930
]
David Jacot commented on KAFKA-14516:
-
[~sagarrao] How about this one? I don't have
sangyongchoi opened a new pull request, #14423:
URL: https://github.com/apache/kafka/pull/14423
I found meaningless lines when look at the code.
So I send pr to remove.
thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767939#comment-17767939
]
Sagar Rao commented on KAFKA-14516:
---
[~dajac], sure , thank you very much!
> Implemen
showuon opened a new pull request, #14424:
URL: https://github.com/apache/kafka/pull/14424
We should use `DEV_BRANCH` instead of `DEV_VERSION` in this case, otherwise,
error will be thrown:
```
RunnerClient:
kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_u
showuon commented on PR #14424:
URL: https://github.com/apache/kafka/pull/14424#issuecomment-1731162530
@satishd , PR to fix the failed system tests. I've confirmed the change will
make the tests pass. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-14516:
-
Assignee: Sagar Rao (was: David Jacot)
> Implement static membeship
>
Nickstery opened a new pull request, #14425:
URL: https://github.com/apache/kafka/pull/14425
Prior to uploading segment to remote storage, we have to unsure that there
is no index corruption take place.
--
This is an automated message from the Apache Git Service.
To respond to the message
yashmayya commented on PR #14093:
URL: https://github.com/apache/kafka/pull/14093#issuecomment-1731222665
@hgeraldino the Connect integration tests are failing with errors like:
```
org.apache.kafka.connect.errors.ConnectException: One or more plugins are
missing ServiceLoader mani
[
https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767979#comment-17767979
]
Victor van den Hoven commented on KAFKA-15417:
--
There is a PR submitted for
[
https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767979#comment-17767979
]
Victor van den Hoven edited comment on KAFKA-15417 at 9/22/23 12:18 PM:
--
nizhikov commented on PR #14355:
URL: https://github.com/apache/kafka/pull/14355#issuecomment-1731325027
@showuon Looks like tests are OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma reassigned KAFKA-15485:
---
Assignee: Ismael Juma
> Upgrade to JDK-21 (LTS release)
> ---
>
[
https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768001#comment-17768001
]
Ismael Juma commented on KAFKA-15485:
-
I started some work for this, so assigned it
Alexandre Dupriez created KAFKA-15486:
-
Summary: Include NIO exceptions as I/O exceptions to be part of
disk failure handling
Key: KAFKA-15486
URL: https://issues.apache.org/jira/browse/KAFKA-15486
[
https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768002#comment-17768002
]
Ismael Juma commented on KAFKA-15485:
-
Can we create a separate Jira ticket for expl
[
https://issues.apache.org/jira/browse/KAFKA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-15486:
--
Summary: Include NIO exceptions as I/O exceptions to be part of the disk
failure handl
[
https://issues.apache.org/jira/browse/KAFKA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-15486:
--
Description:
Currently, Apache Kafka offers the ability to detect and capture I/O erro
[
https://issues.apache.org/jira/browse/KAFKA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-15486:
--
Description:
Currently, Apache Kafka offers the ability to detect and capture I/O erro
Rafael Rios Saavedra created KAFKA-15487:
Summary: CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52,
10.0.16, 11.0.16, 12.0.1
Key: KAFKA-15487
URL: https://issues.apache.org/jira/browse/KAFKA-15487
[
https://issues.apache.org/jira/browse/KAFKA-15487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rafael Rios Saavedra updated KAFKA-15487:
-
Description:
CVE-2023-40167 and CVE-2023-36479 vulnerabilities affects Jetty ver
ijuma opened a new pull request, #14427:
URL: https://github.com/apache/kafka/pull/14427
This is one of the steps required for kafka to compile with Java 21.
The fixes are one of two types:
1. Suppress warning if fixing would potentially result in an incompatible
change (for public
divijvaidya commented on PR #14404:
URL: https://github.com/apache/kafka/pull/14404#issuecomment-1731447816
The tests failures are unrelated and build is successful -
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14404/1/pipeline
--
This is an automa
lianetm commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1731476330
Hey @philipnee , I see several updates here, thanks! let me know when you
want to me give it another pass (there are still some test failures)
--
This is an automated message from the A
[
https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768028#comment-17768028
]
Ismael Juma commented on KAFKA-15485:
-
First PR: https://github.com/apache/kafka/pul
ijuma commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334428308
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -381,15 +381,15 @@ private void doTransitionTo(TargetState targetState)
thr
[
https://issues.apache.org/jira/browse/KAFKA-15487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768031#comment-17768031
]
Divij Vaidya commented on KAFKA-15487:
--
Current release candidate 3.6 uses Jetty 9.
[
https://issues.apache.org/jira/browse/KAFKA-15487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15487:
-
Affects Version/s: 3.5.1
3.4.1
3.6.0
> CVE-2023-40
ijuma commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334438340
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -227,8 +226,9 @@ private T createDelegate(ClassLoader classLoader,
String className) {
}
dajac commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r1334469294
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -14,43 +14,62 @@
* See the License for the specific language governing permis
dajac commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r1334469581
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -14,43 +14,62 @@
* See the License for the specific language governing permis
dajac commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1334471084
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -523,9 +526,63 @@ public
CompletableFuture> groupsByTopicPartit
dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1731579985
@JimmyWang6 I am really sorry but I haven't had the time to dive into this
yet. At a high level, I think that the approach taken so far does not cover all
the aspects. For instance, how is
dajac commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1334519906
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -90,4 +90,29 @@ void validateOffsetFetch(
int memberEpoch,
long
dajac commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1334540685
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java:
##
@@ -46,6 +46,35 @@ public short unknownType() {
}
}
divijvaidya commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334524883
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java:
##
@@ -60,6 +60,7 @@ public TimeIndex(File file, long baseOffset, int
maxIndexSize)
ijuma commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334585052
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -50,6 +50,7 @@ public class RemoteLogMetadat
ijuma commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334596556
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -56,6 +56,7 @@ public class LeaderEpochFileCache {
* @param topic
ijuma commented on PR #14427:
URL: https://github.com/apache/kafka/pull/14427#issuecomment-1731708017
> Please add to the description - "this-escape" is related to new lint
warning
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
C0urante commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334606614
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -381,15 +381,15 @@ private void doTransitionTo(TargetState targetState)
CalvinConfluent commented on PR #14053:
URL: https://github.com/apache/kafka/pull/14053#issuecomment-1731725183
@splett2 @hachikuji Any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334626047
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -190,13 +194,23 @@ public DefaultBackgroundThread(final Time ti
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334633010
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334633010
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334636930
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
divijvaidya commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334642477
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -50,6 +50,7 @@ public class RemoteLogM
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334645635
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
divijvaidya commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334649199
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java:
##
@@ -60,6 +60,7 @@ public TimeIndex(File file, long baseOffset, int
maxIndexSize)
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334652824
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334657428
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334659219
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1334659282
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1334661304
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1334663114
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1242,7 +1304,11 @@ public void scheduleLoadOperation(
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334668800
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1334673715
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1242,7 +1304,11 @@ public void scheduleLoadOperation(
lianetm commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1334676439
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -237,4 +253,64 @@ public void
updateAssignment(ConsumerGroupHear
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1334705172
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Soft
rondagostino commented on PR #14405:
URL: https://github.com/apache/kafka/pull/14405#issuecomment-1731898597
None of the failed tests are from the affected file
`QuorumControllerTest.java`, so the test failures are unrelated. Merging to
trunk.
--
This is an automated message from the Ap
rondagostino merged PR #14405:
URL: https://github.com/apache/kafka/pull/14405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ijuma commented on code in PR #14427:
URL: https://github.com/apache/kafka/pull/14427#discussion_r1334734260
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -50,6 +50,7 @@ public class RemoteLogMetadat
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1334734541
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Founda
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r193941
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -636,42 +857,148 @@ public void assign(Collection
partitions) {
[
https://issues.apache.org/jira/browse/KAFKA-15463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768141#comment-17768141
]
A. Sophie Blee-Goldman commented on KAFKA-15463:
[~yevsh] try moving the
Albert Wong created KAFKA-15488:
---
Summary: Add StarRocks to the database integration list
Key: KAFKA-15488
URL: https://issues.apache.org/jira/browse/KAFKA-15488
Project: Kafka
Issue Type: Imp
cmccabe commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1334856841
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -719,38 +726,66 @@ public Node provide() {
abstract class Call {
pr
cmccabe commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1334857465
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4009,12 +4134,11 @@ void handleFailure(Throwable throwable) {
@Override
cmccabe commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1334858055
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -79,14 +79,17 @@ object KafkaRequestHandler {
/**
* A thread that answers kafka requests.
*/
-
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334869446
##
checkstyle/import-control.xml:
##
@@ -205,6 +205,10 @@
+
Review Comment:
Yes, just to set off the child `subpackage` element more cleanly. But I
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870059
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870549
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870694
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -16,197 +16,78 @@
*/
package org.apache.kafka.clients.consu
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334870782
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ErrorEventHandler.java:
##
@@ -22,13 +22,18 @@
import java.util.Queue;
public class ErrorEvent
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334871262
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -16,197 +16,78 @@
*/
package org.apache.kafka.clients.consu
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334871627
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -217,29 +98,33 @@ public void run() {
}
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334872019
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegate
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334872655
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegate
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334873271
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##
@@ -141,11 +77,25 @@ public T addAndGet(final
CompletableApplicatio
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334876767
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -636,42 +857,148 @@ public void assign(Collection
partitions)
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334878210
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -636,42 +857,148 @@ public void assign(Collection
partitions)
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334878765
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334879279
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334881403
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -192,71 +321,38 @@ public PrototypeAsyncConsumer(final Consumer
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334881860
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -192,71 +321,38 @@ public PrototypeAsyncConsumer(final Consumer
1 - 100 of 118 matches
Mail list logo
