akatona84 commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923072806
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -728,18 +779,11 @@ synchronized void maybeResolveSequences() {
[
https://issues.apache.org/jira/browse/KAFKA-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567871#comment-17567871
]
Martin Pelak commented on KAFKA-2170:
-
Hi, I have created [a pull request|https://git
[
https://issues.apache.org/jira/browse/KAFKA-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567880#comment-17567880
]
Martin Pelak commented on KAFKA-1194:
-
Hi, I have created [a pull request|https://git
dengziming commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1186984525
> How about the controller unfence the broker when the broker's
high-watermark
This is a good idea, however, the offset of each registration record is a
soft state(not persist t
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567906#comment-17567906
]
Bruno Cadonna commented on KAFKA-13217:
---
[~mjsax] and [~jhughes] may have some con
dengziming commented on code in PR #12414:
URL: https://github.com/apache/kafka/pull/12414#discussion_r923157385
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -128,7 +134,15 @@ class BrokerMetadataListener(
}
private def shouldSnapshot(
mimaison commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923145340
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
}
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567915#comment-17567915
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison commented on code in PR #420:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567916#comment-17567916
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison commented on PR #421:
URL: htt
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567917#comment-17567917
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on PR #421:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567920#comment-17567920
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison merged PR #422:
URL: https://g
viktorsomogyi opened a new pull request, #12417:
URL: https://github.com/apache/kafka/pull/12417
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
viktorsomogyi commented on PR #12417:
URL: https://github.com/apache/kafka/pull/12417#issuecomment-1187138701
@showuon thanks for merging the original PR, I created a backport to 3.2,
would you please merge this too?
--
This is an automated message from the Apache Git Service.
To respond
cadonna closed pull request #12384: KAFKA-10199: Add methods to add and remove
tasks to task manager
URL: https://github.com/apache/kafka/pull/12384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cadonna merged PR #12404:
URL: https://github.com/apache/kafka/pull/12404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
nicolasguyomar commented on PR #12378:
URL: https://github.com/apache/kafka/pull/12378#issuecomment-1187171895
Hello @jolshan
Yes you will see the log on any consumer/producer startup
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923311371
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -206,6 +206,39 @@ class KafkaConfigTest {
assertBadConfigContainingMessage(props, "Each lis
jsancio commented on PR #12274:
URL: https://github.com/apache/kafka/pull/12274#issuecomment-1187345352
> This is a good idea, however, the offset of each registration record is a
soft state(not persist to metadata log)
@dengziming The offset is persistent along with the record. This
pnagy-cldr commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923345335
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -168,6 +171,8 @@ private boolean isTransitionValid(State source, S
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923354559
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -206,6 +206,39 @@ class KafkaConfigTest {
assertBadConfigContainingMessage(props, "Each lis
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923359025
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -206,6 +206,39 @@ class KafkaConfigTest {
assertBadConfigContainingMessage(props, "Each lis
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923361588
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on PR #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-1187401803
@tombentley @mimaison I have gone through each of the review comments and
submitted the requested changes and marked them as resolved, only one comment
is still outstanding.
--
This
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923366063
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923282700
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -267,8 +276,31 @@ private void removeTask(final TaskId taskId) {
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568025#comment-17568025
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison commented on PR #421:
URL: htt
tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923431888
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -206,6 +206,39 @@ class KafkaConfigTest {
assertBadConfigContainingMessage(props, "Each lis
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568026#comment-17568026
]
ASF GitHub Bot commented on KAFKA-13868:
mimaison commented on code in PR #421:
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568029#comment-17568029
]
ASF GitHub Bot commented on KAFKA-13868:
tombentley commented on code in PR #421
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923463164
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -520,6 +568,8 @@ private Stream getStreamOfTasks() {
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568046#comment-17568046
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923482851
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -241,12 +246,39 @@ synchronized TransactionalRequestResult
initiali
tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923484438
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r923485561
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1413,10 +1458,55 @@ public void testOnJoinPrepareWithOffsetC
aiquestion commented on code in PR #12349:
URL: https://github.com/apache/kafka/pull/12349#discussion_r923485781
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1413,10 +1458,55 @@ public void testOnJoinPrepareWithOffsetC
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923486245
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -728,18 +779,11 @@ synchronized void maybeResolveSequences() {
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r923486565
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -168,6 +171,8 @@ private boolean isTransitionValid(State source, Sta
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568060#comment-17568060
]
ASF GitHub Bot commented on KAFKA-13868:
tombentley commented on code in PR #421
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923495672
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mimaison commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923498937
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
}
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923500547
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923502725
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923506009
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -983,6 +1120,27 @@ private void verifyRemovedTasks(final Task..
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923506434
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -498,6 +575,66 @@ private void shouldNotRemoveTaskFromFailedTas
cadonna commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923506717
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -498,6 +575,66 @@ private void shouldNotRemoveTaskFromFailedTas
cadonna commented on code in PR #12387:
URL: https://github.com/apache/kafka/pull/12387#discussion_r923475558
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskAndAction.java:
##
@@ -55,7 +67,7 @@ public Task getTask() {
}
public TaskId getTas
Gian Luca created KAFKA-14081:
-
Summary: Cannot get my MetricsReporter implementation to receive
meaningful metrics
Key: KAFKA-14081
URL: https://issues.apache.org/jira/browse/KAFKA-14081
Project: Kafka
tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923511503
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##
core/src/main/scala/kafka/utils/CoreUtils.scala:
##
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568071#comment-17568071
]
Jim Hughes commented on KAFKA-13217:
[~jagsancio] I've got a PR up to try and fix th
clolov opened a new pull request, #12418:
URL: https://github.com/apache/kafka/pull/12418
Partially addressing https://issues.apache.org/jira/browse/KAFKA-13414.
Other test files will be updated in other pull requests.
--
This is an automated message from the Apache Git Service.
To respon
clolov commented on PR #12418:
URL: https://github.com/apache/kafka/pull/12418#issuecomment-1187678788
@mimaison I believe you might be best suited to review this pull request :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-14081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568078#comment-17568078
]
Kirk True commented on KAFKA-14081:
---
Would you be able to share steps and/or some code
franz1981 commented on PR #12163:
URL: https://github.com/apache/kafka/pull/12163#issuecomment-1187692857
I've updated the PR, let me know if there're other concerns I can address
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
xiaoyao qu created KAFKA-14082:
--
Summary: Mirror Maker 2.0 sync topic configs need more validly
Key: KAFKA-14082
URL: https://issues.apache.org/jira/browse/KAFKA-14082
Project: Kafka
Issue Type
FreerXY opened a new pull request, #12419:
URL: https://github.com/apache/kafka/pull/12419
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
FreerXY commented on PR #12419:
URL: https://github.com/apache/kafka/pull/12419#issuecomment-1187700242
Fix Mirror Maker 2.0 sync topic configs need more validly ,linking:
https://issues.apache.org/jira/browse/KAFKA-14082
--
This is an automated message from the Apache Git Service.
To res
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568101#comment-17568101
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568102#comment-17568102
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
FreerXY commented on code in PR #12419:
URL: https://github.com/apache/kafka/pull/12419#discussion_r923577568
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -297,10 +291,18 @@ private void syncTopicAcls()
private void syn
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568110#comment-17568110
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
jolshan commented on PR #12378:
URL: https://github.com/apache/kafka/pull/12378#issuecomment-1187722165
I'm not sure I follow why this happens though -- can you share an example of
one of the logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
Ge opened a new pull request, #12420:
URL: https://github.com/apache/kafka/pull/12420
This commit changes the version check from` !=` to `>` as the `process`
method
works correctly on both version 1 and 2. `!=` incorrectly throws on v1
records.
*Summary of testing strategy (
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568117#comment-17568117
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on code in PR #42
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568153#comment-17568153
]
ASF GitHub Bot commented on KAFKA-13868:
divijvaidya commented on PR #420:
URL:
mumrah commented on PR #12349:
URL: https://github.com/apache/kafka/pull/12349#issuecomment-1188068663
@aiquestion looks like you've got a few test failures
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-12349/11/tests
--
This is an automated message fr
wcarlson5 opened a new pull request, #12421:
URL: https://github.com/apache/kafka/pull/12421
…r (#11228)"
This reverts commit 4835c64f
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13470:
-
Issue Type: Improvement (was: Bug)
> Test the handling of secure controller ports
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13470:
-
Description: It should be possible to configure the controller to use
secure ports. We need a ju
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13470:
-
Priority: Major (was: Critical)
> Test the handling of secure controller ports
> --
[
https://issues.apache.org/jira/browse/KAFKA-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568178#comment-17568178
]
Colin McCabe commented on KAFKA-13470:
--
We do not include the controller listener i
[
https://issues.apache.org/jira/browse/KAFKA-13743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568179#comment-17568179
]
Colin McCabe commented on KAFKA-13743:
--
The PR was merged, just not through the git
wcarlson5 commented on PR #12324:
URL: https://github.com/apache/kafka/pull/12324#issuecomment-1188229295
@ableegoldman looks like i had a small issue fixed it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Artem Livshits created KAFKA-14083:
--
Summary: Check if we don't need to refresh time in
RecordAccumulator.append
Key: KAFKA-14083
URL: https://issues.apache.org/jira/browse/KAFKA-14083
Project: Kafka
artemlivshits commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923725627
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
cmccabe commented on PR #12403:
URL: https://github.com/apache/kafka/pull/12403#issuecomment-1188236978
So, we definitely need to get rid of the calls to *.get* and other cases of
needless blocking. There are definitely some cases where we aren't properly
handling errors as well (this is re
cmccabe commented on PR #12278:
URL: https://github.com/apache/kafka/pull/12278#issuecomment-1188304891
It is part of the Authorizer KIP, but slipped from 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-14084:
-
Labels: kip-500 (was: )
> Support SCRAM when using KRaft mode
> ---
Colin McCabe created KAFKA-14084:
Summary: Support SCRAM when using KRaft mode
Key: KAFKA-14084
URL: https://issues.apache.org/jira/browse/KAFKA-14084
Project: Kafka
Issue Type: Improvement
mjsax merged PR #12420:
URL: https://github.com/apache/kafka/pull/12420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cmccabe commented on PR #12196:
URL: https://github.com/apache/kafka/pull/12196#issuecomment-1188314543
> @cmccabe is there a JIRA for this?
I created KAFKA-14084 for this. The message types and so on are spelled out
in KIP-631, I believe.
> Are you intending to implement suppo
mjsax commented on PR #12420:
URL: https://github.com/apache/kafka/pull/12420#issuecomment-1188316135
Thanks for the fix! Merged to `trunk` and cherry-picked to `3.3` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-14079:
--
Priority: Critical (was: Major)
> Source task will not commit offsets and develops memory lea
ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923872451
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if (log.
junrao commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r923872243
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
if (log
guozhangwang commented on PR #12386:
URL: https://github.com/apache/kafka/pull/12386#issuecomment-1188363535
> Currently, it is not clear to me if we also need to consider the case were
a task is paused before it is added to the state updater? Such a situation
might happen when a Kafka Stre
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923898461
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -267,8 +276,31 @@ private void removeTask(final TaskId taskId)
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923898981
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskAndAction.java:
##
@@ -47,6 +48,11 @@ public static TaskAndAction createRemoveTask(final T
rhauch merged PR #12412:
URL: https://github.com/apache/kafka/pull/12412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923899776
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskAndAction.java:
##
@@ -55,7 +61,7 @@ public Task getTask() {
}
public TaskId g
rhauch merged PR #12415:
URL: https://github.com/apache/kafka/pull/12415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923900551
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -143,6 +142,27 @@ public void shouldThrowIfStandbyTaskNotI
[
https://issues.apache.org/jira/browse/KAFKA-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-14079.
---
Reviewer: Randall Hauch
Resolution: Fixed
> Source task will not commit offsets and de
guozhangwang commented on code in PR #12386:
URL: https://github.com/apache/kafka/pull/12386#discussion_r923900844
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -983,6 +1120,27 @@ private void verifyRemovedTasks(final T
1 - 100 of 122 matches
Mail list logo
