mdedetrich commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923514829
##########
core/src/main/scala/kafka/utils/CoreUtils.scala:
##########
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
}
+ def validateOneIsIpv4AndOtherIpv6(first: String, second: String): Boolean =
+ (inetAddressValidator.isValidInet4Address(first) &&
inetAddressValidator.isValidInet6Address(second)) ||
Review Comment:
> AFAIU it would not make sense to accept an address with a prefix here
> I'm not sure whether we need to accept/support zone/scope here either, for
the same reason.
I haven't really looked into this, I would imagine that this is a different
type of checking that would happen elsewhere in the code (if it happens at
all)? I guess I could look into this but to me this seems like a different
feature/PR since this PR is specifically only about IPv4 vs IPv6 and this is a
different type of check.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
