jlprat closed pull request #11228:
URL: https://github.com/apache/kafka/pull/11228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
jlprat commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-902529232
Reopening to re-trigger CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
nandini created KAFKA-13220:
---
Summary: Group or Group Coordinator logs are misleading when using
assign(partitions) method in Consumer API.
Key: KAFKA-13220
URL: https://issues.apache.org/jira/browse/KAFKA-13220
[
https://issues.apache.org/jira/browse/KAFKA-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402190#comment-17402190
]
Justin Jack commented on KAFKA-7641:
This change will require a KIP as it is a public
dajac commented on pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#issuecomment-902666578
@lbradstreet The last run looks good. It seems that the previous one failed
for some other reasons.
--
This is an automated message from the Apache Git Service.
To respond to th
showuon opened a new pull request #11242:
URL: https://github.com/apache/kafka/pull/11242
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
officialpatterson commented on a change in pull request #11215:
URL: https://github.com/apache/kafka/pull/11215#discussion_r692925490
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
##
@@ -19,50 +19,46 @@
import org.apache.kafka.strea
officialpatterson commented on a change in pull request #11215:
URL: https://github.com/apache/kafka/pull/11215#discussion_r692925670
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
##
@@ -95,27 +91,19 @@ public void advanceIntervalMus
scholzj opened a new pull request #11243:
URL: https://github.com/apache/kafka/pull/11243
The Javadoc of the Admin API (`Admin` interface) has an example of how to
use the Admin API to create a topic. The example does not work because it is
missing one `)`. This small PR fixes it.
--
Th
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692947020
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -387,6 +389,12 @@
public static final String
DEFAULT_PRODUCTIO
[
https://issues.apache.org/jira/browse/KAFKA-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402211#comment-17402211
]
Tommy Becker commented on KAFKA-13197:
--
Hey [~guozhang] thanks for the response. To
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692947480
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -74,10 +74,18 @@
protected final InternalStreamsBuilder inte
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692947806
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/Materialized.java
##
@@ -103,6 +110,21 @@ protected Materialized(final Materialized
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692948732
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/MaterializedInternal.java
##
@@ -29,14 +31,26 @@
private final boolea
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692950023
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImpl.java
##
@@ -237,10 +238,21 @@
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402213#comment-17402213
]
Tommy Becker commented on KAFKA-12317:
--
At least in the case of left stream-globalT
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692951450
##
File path: streams/src/test/java/org/apache/kafka/streams/TopologyTest.java
##
@@ -1168,7 +1169,32 @@ public void
kGroupedStreamZeroArgCountShouldPres
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692952035
##
File path: streams/src/test/java/org/apache/kafka/streams/TopologyTest.java
##
@@ -1185,6 +1211,29 @@ public void
kGroupedStreamNamedMaterializedCount
showuon commented on pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#issuecomment-902703961
@vvcephei @mjsax , could you provide suggestion for this POC when available?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
showuon commented on pull request #11227:
URL: https://github.com/apache/kafka/pull/11227#issuecomment-902704750
@patrickstuedi @vvcephei , please take a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
ijuma commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692964096
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -91,6 +91,10 @@ class KafkaServer(
threadNamePrefix: Option[String] = None,
ena
vvcephei merged pull request #11236:
URL: https://github.com/apache/kafka/pull/11236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
Jason Gustafson created KAFKA-13221:
---
Summary: Add metric for `PartitionsWithLateTransactionsCount`
Key: KAFKA-13221
URL: https://issues.apache.org/jira/browse/KAFKA-13221
Project: Kafka
Is
[
https://issues.apache.org/jira/browse/KAFKA-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reassigned KAFKA-9886:
--
Assignee: (was: Jason Gustafson)
> Validate segment range before reading in `Log.r
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r693133897
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,220
hachikuji closed pull request #9803:
URL: https://github.com/apache/kafka/pull/9803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
hachikuji closed pull request #8585:
URL: https://github.com/apache/kafka/pull/8585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
hachikuji commented on pull request #8585:
URL: https://github.com/apache/kafka/pull/8585#issuecomment-902880145
I am going to close this. Since the new `Fetch` protocol versions allows
fetching from followers already, there seems little reason to add this logic
just for older versions. Th
[
https://issues.apache.org/jira/browse/KAFKA-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-9938.
Resolution: Won't Fix
I am going to close this issue as "won't fix." Since the new `Fetch`
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r693150166
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##
@@ -64,6 +66,7 @@ public ClientState(
splett2 opened a new pull request #11244:
URL: https://github.com/apache/kafka/pull/11244
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
Removes unsafe assertio
splett2 commented on pull request #11244:
URL: https://github.com/apache/kafka/pull/11244#issuecomment-902891510
@showuon can you take a look? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r693163634
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,212
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-902900779
Hi @cadonna
Thank you for valuable feedback.
I've addressed your comments. Please have a look once you got time.
--
This is an automated message from the Apache
ableegoldman commented on a change in pull request #11214:
URL: https://github.com/apache/kafka/pull/11214#discussion_r693194263
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java
##
@@ -101,102 +93,100 @@ public void startTimeShouldNotBe
hachikuji opened a new pull request #11245:
URL: https://github.com/apache/kafka/pull/11245
After we have shrunk the ISR, we have an opportunity to advance the high
watermark. We do this currently in `maybeShrinkIsr` after the synchronous
update through ZK. For the `AlterIsr` path, however
hachikuji opened a new pull request #11246:
URL: https://github.com/apache/kafka/pull/11246
A few small logging improvements:
- Only print error when it is not NONE
- Full list of remaining partitions are printed only at debug level
- Only backoff and print retry logging if there ar
showuon commented on pull request #11244:
URL: https://github.com/apache/kafka/pull/11244#issuecomment-902998301
I'll check it. Thank you for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ijuma commented on pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#issuecomment-903018432
@rondagostino I pushed a commit with a few changes. It seems that the main
problem is the existence of `currentState()`, I removed that and I think that
solves the problem. Can yo
showuon commented on a change in pull request #11244:
URL: https://github.com/apache/kafka/pull/11244#discussion_r693291090
##
File path:
core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
##
@@ -127,7 +127,6 @@ class ReassignPartitionsIntegrat
showuon commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r693292145
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -611,7 +619,7 @@ class KafkaServer(
// ignore and try again
showuon commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r693292310
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -594,13 +594,21 @@ class KafkaServer(
val clientResponse =
NetworkC
mjsax commented on pull request #11233:
URL: https://github.com/apache/kafka/pull/11233#issuecomment-903055614
As pointed out on the 3.0 release discussion thread on the dev mailing list,
it's really about preserving a clean upgrade path from the old join semantics
to the new join semantic
[
https://issues.apache.org/jira/browse/KAFKA-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402540#comment-17402540
]
leiminghany commented on KAFKA-13218:
-
yes, indeed it is, I set the timestamp to UTC
[
https://issues.apache.org/jira/browse/KAFKA-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leiminghany resolved KAFKA-13218.
-
Resolution: Not A Problem
> kafka deleted unexpired message unexpectedly
> -
showuon opened a new pull request #11247:
URL: https://github.com/apache/kafka/pull/11247
This is the doc rollback for https://github.com/apache/kafka/pull/11233
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cove
showuon commented on pull request #11233:
URL: https://github.com/apache/kafka/pull/11233#issuecomment-903069187
@mjsax , I found you forgot to rollback the doc part. I addressed in
https://github.com/apache/kafka/pull/11247. If we merged this hotfix, then we
should also merge the doc roll
showuon commented on a change in pull request #11247:
URL: https://github.com/apache/kafka/pull/11247#discussion_r693315762
##
File path: docs/streams/developer-guide/dsl-api.html
##
@@ -1952,9 +1951,8 @@ For each input
record on one side that does not have any match on the ot
showuon commented on a change in pull request #11247:
URL: https://github.com/apache/kafka/pull/11247#discussion_r693315762
##
File path: docs/streams/developer-guide/dsl-api.html
##
@@ -1952,9 +1951,8 @@ For each input
record on one side that does not have any match on the ot
49 matches
Mail list logo
