showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692947480
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -74,10 +74,18 @@
protected final InternalStreamsBuilder internalStreamsBuilder;
+ protected final StreamsConfig config;
+
public StreamsBuilder() {
+ this(null);
+ }
+
+ // new constructor
+ public StreamsBuilder(Properties props) {
topology = getNewTopology();
internalTopologyBuilder = topology.internalTopologyBuilder;
- internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder);
+ config = props == null ? null : new StreamsConfig(props);
+ internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder, config);
Review comment:
(4) add a new constructor for StreamsBuilder, to accept a properties
instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
