[jira] [Created] (KAFKA-10609) Mirror Maker 2.0 RemoteClusterUtils do not return offset map for Assign Mode Consumers

2020-10-14 Thread Ananya (Jira)
Ananya created KAFKA-10609: -- Summary: Mirror Maker 2.0 RemoteClusterUtils do not return offset map for Assign Mode Consumers Key: KAFKA-10609 URL: https://issues.apache.org/jira/browse/KAFKA-10609 Project: K

[jira] [Updated] (KAFKA-10609) Mirror Maker 2.0 RemoteClusterUtils do not return offset map for Assign Mode Consumers

2020-10-14 Thread Ananya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ananya updated KAFKA-10609: --- Description: I was using a mirror maker 2.0. I was testing the consumer checkpointing functionality. I foun

[jira] [Commented] (KAFKA-10313) Out of range offset errors leading to offset reset

2020-10-14 Thread Jikky John (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213690#comment-17213690 ] Jikky John commented on KAFKA-10313: Same issue here > Out of range offset errors l

[GitHub] [kafka] tombentley commented on pull request #9422: KAFKA-10602: Make RetryWithToleranceOperator thread safe

2020-10-14 Thread GitBox
tombentley commented on pull request #9422: URL: https://github.com/apache/kafka/pull/9422#issuecomment-708222714 @kkonstantine yeah, I was hoping someone would recommend a testing approach. I'll see if I'm able to reproduce it in a test. --

[GitHub] [kafka] xakassi closed pull request #9211: KAFKA-10426: Deadlock on session key update.

2020-10-14 Thread GitBox
xakassi closed pull request #9211: URL: https://github.com/apache/kafka/pull/9211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] xakassi opened a new pull request #9431: KAFKA-10426: Deadlock on session key update.

2020-10-14 Thread GitBox
xakassi opened a new pull request #9431: URL: https://github.com/apache/kafka/pull/9431 DistributedHerder goes to updateConfigsWithIncrementalCooperative() synchronized method and called configBackingStore.snapshot() which take a lock on internal object in KafkaConfigBackingStore class.

[GitHub] [kafka] xakassi commented on pull request #9211: KAFKA-10426: Deadlock on session key update.

2020-10-14 Thread GitBox
xakassi commented on pull request #9211: URL: https://github.com/apache/kafka/pull/9211#issuecomment-708231665 I have closed this PR and submitted a new one: https://github.com/apache/kafka/pull/9431 @kkonstantine Please, take a look at it. Thank you! --

[jira] [Commented] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-10-14 Thread Christian Duvholt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213725#comment-17213725 ] Christian Duvholt commented on KAFKA-10417: --- Hi [~vvcephei], I suspect that I

[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…

2020-10-14 Thread GitBox
chia7712 commented on pull request #9423: URL: https://github.com/apache/kafka/pull/9423#issuecomment-708252424 ``` kafka.api.PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords ``` pass on my local.

[GitHub] [kafka] tombentley commented on pull request #9422: KAFKA-10602: Make RetryWithToleranceOperator thread safe

2020-10-14 Thread GitBox
tombentley commented on pull request #9422: URL: https://github.com/apache/kafka/pull/9422#issuecomment-708294583 @kkonstantine I've written a small test which interleaves calls to `RetryWithToleranceOperator.execute` and `RetryWithToleranceOperator.executeFailed` and detects conflicts whi

[GitHub] [kafka] tombentley commented on pull request #9365: KAFKA-10566: Fix erroneous config usage warnings

2020-10-14 Thread GitBox
tombentley commented on pull request #9365: URL: https://github.com/apache/kafka/pull/9365#issuecomment-708295751 @rajinisivaram @omkreddy @ijuma @mjsax please could someone take a look at this fix? This is an automated mess

[GitHub] [kafka] tombentley commented on pull request #9397: KAFKA-10583: Add documentation on the thread-safety of KafkaAdminClient.

2020-10-14 Thread GitBox
tombentley commented on pull request #9397: URL: https://github.com/apache/kafka/pull/9397#issuecomment-708304114 @cmccabe @ijuma @hachikuji any chance we could merge this trivial javadoc change? This is an automated message

[jira] [Assigned] (KAFKA-10607) Ensure the error counts contains the NONE

2020-10-14 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-10607: --- Assignee: Tom Bentley > Ensure the error counts contains the NONE > ---

[GitHub] [kafka] vamossagar12 opened a new pull request #9432: KAFKA-10559 | Initial Commit

2020-10-14 Thread GitBox
vamossagar12 opened a new pull request #9432: URL: https://github.com/apache/kafka/pull/9432 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

[jira] [Commented] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213813#comment-17213813 ] huxihx commented on KAFKA-10606: I am wondering if we could change the default value for

[jira] [Comment Edited] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213813#comment-17213813 ] huxihx edited comment on KAFKA-10606 at 10/14/20, 10:45 AM:

[GitHub] [kafka] tombentley opened a new pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

2020-10-14 Thread GitBox
tombentley opened a new pull request #9433: URL: https://github.com/apache/kafka/pull/9433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] tombentley commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

2020-10-14 Thread GitBox
tombentley commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-708340163 @abbccdda please could you take a look since you opened the JIRA? Thanks. This is an automated message from the

[jira] [Commented] (KAFKA-8803) Stream will not start due to TimeoutException: Timeout expired after 60000milliseconds while awaiting InitProducerId

2020-10-14 Thread Pushkar Deole (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213887#comment-17213887 ] Pushkar Deole commented on KAFKA-8803: -- [~guozhang] I recently faced this issue on o

[jira] [Comment Edited] (KAFKA-8803) Stream will not start due to TimeoutException: Timeout expired after 60000milliseconds while awaiting InitProducerId

2020-10-14 Thread Pushkar Deole (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213887#comment-17213887 ] Pushkar Deole edited comment on KAFKA-8803 at 10/14/20, 12:59 PM: -

[jira] [Comment Edited] (KAFKA-8803) Stream will not start due to TimeoutException: Timeout expired after 60000milliseconds while awaiting InitProducerId

2020-10-14 Thread Pushkar Deole (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213887#comment-17213887 ] Pushkar Deole edited comment on KAFKA-8803 at 10/14/20, 1:03 PM: --

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-14 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r503489280 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java ## @@ -52,10 +52,10 @@ public void testClusterConfi

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-14 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r504726150 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -813,8 +852,9 @@ case class OffsetTruncationState(offset: Long, trun

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-14 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r504727381 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -408,9 +428,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-14 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r504729807 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -432,14 +455,22 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-14 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r504731267 ## File path: core/src/main/scala/kafka/server/DelayedFetch.scala ## @@ -77,6 +78,7 @@ class DelayedFetch(delayMs: Long, * Case E: This broker is

[GitHub] [kafka] rajinisivaram commented on pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-14 Thread GitBox
rajinisivaram commented on pull request #9382: URL: https://github.com/apache/kafka/pull/9382#issuecomment-708446946 @hachikuji Thanks for the review, have addressed the comments so far. This is an automated message from the

[GitHub] [kafka] vvcephei commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-10-14 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-708466216 Oh, sorry, @thake , I didn't see your replies when I submitted my review last night. Thanks both for your initial feedback and your reply. I'd certainly never pass up the

[GitHub] [kafka] vvcephei commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-14 Thread GitBox
vvcephei commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504763968 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -900,9 +900,7 @@ // These are not settable in the main Str

[jira] [Assigned] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-10606: --- Assignee: Tom Bentley > Auto create non-existent topics when fetching metadata for all topi

[GitHub] [kafka] vvcephei commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-14 Thread GitBox
vvcephei commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504775858 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -192,12 +191,11 @@ public String toSt

[GitHub] [kafka] vvcephei commented on a change in pull request #9368: KAFKA-9274: Add timeout handling for state restore and StandbyTasks

2020-10-14 Thread GitBox
vvcephei commented on a change in pull request #9368: URL: https://github.com/apache/kafka/pull/9368#discussion_r504792364 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -482,8 +486,10 @@ boolean tryToCompleteRestoration

[GitHub] [kafka] rajinisivaram opened a new pull request #9434: MINOR: Handle lastFetchedEpoch/divergingEpoch in FetchSession and DelayedFetch

2020-10-14 Thread GitBox
rajinisivaram opened a new pull request #9434: URL: https://github.com/apache/kafka/pull/9434 In 2.7, we added lastFetchedEpoch to fetch requests and divergingEpoch to fetch responses. We are not using these for truncation yet, but in order to use these for truncation with IBP 2.7 onwards

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-10-14 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r504803409 ## File path: core/src/main/scala/kafka/server/DelayedFetch.scala ## @@ -77,6 +78,7 @@ class DelayedFetch(delayMs: Long, * Case E: This broker is

[jira] [Created] (KAFKA-10610) Integration tests for each CLI command to make sure it continues working with existing minimal authorizations

2020-10-14 Thread Chris Johnson (Jira)
Chris Johnson created KAFKA-10610: - Summary: Integration tests for each CLI command to make sure it continues working with existing minimal authorizations Key: KAFKA-10610 URL: https://issues.apache.org/jira/brows

[jira] [Commented] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Lincong Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214051#comment-17214051 ] Lincong Li commented on KAFKA-10606: [~huxi_2b] Thanks for your comment. However, cl

[GitHub] [kafka] hachikuji commented on a change in pull request #9434: MINOR: Handle lastFetchedEpoch/divergingEpoch in FetchSession and DelayedFetch

2020-10-14 Thread GitBox
hachikuji commented on a change in pull request #9434: URL: https://github.com/apache/kafka/pull/9434#discussion_r504839142 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1084,7 +1084,7 @@ class ReplicaManager(val config: KafkaConfig, fetchInf

[jira] [Comment Edited] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214077#comment-17214077 ] Ismael Juma edited comment on KAFKA-10606 at 10/14/20, 5:19 PM: --

[jira] [Commented] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214077#comment-17214077 ] Ismael Juma commented on KAFKA-10606: - Seems like the way to fix this is to pass `fa

[jira] [Commented] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214080#comment-17214080 ] Tom Bentley commented on KAFKA-10606: - [~andrewlinc...@gmail.com] agreed that a brok

[jira] [Commented] (KAFKA-5235) GetOffsetShell: support for multiple topics and consumer configuration override

2020-10-14 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214081#comment-17214081 ] Ron Dagostino commented on KAFKA-5235: -- KIP: https://cwiki.apache.org/confluence/di

[jira] [Commented] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Lincong Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214088#comment-17214088 ] Lincong Li commented on KAFKA-10606: Hi [~tombentley]. Thanks for your comment. I wi

[GitHub] [kafka] abbccdda commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-14 Thread GitBox
abbccdda commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504831412 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,359 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Assigned] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-10606: --- Assignee: Lincong Li (was: Tom Bentley) > Auto create non-existent topics when fetching me

[jira] [Resolved] (KAFKA-10044) Deprecate ConsumerConfig#addDeserializerToConfig and ProducerConfig#addSerializerToConfig

2020-10-14 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-10044. - Resolution: Fixed Resolved via https://github.com/apache/kafka/pull/9013 > Deprecate ConsumerCo

[jira] [Resolved] (KAFKA-9929) Support reverse iterator on WindowStore

2020-10-14 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-9929. Resolution: Fixed Resolved via  !https://github.com/favicon.ico|width=16,height=16!  [GitHub Pull R

[jira] [Commented] (KAFKA-9915) Throttle Create Topic, Create Partition and Delete Topic Operations

2020-10-14 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214116#comment-17214116 ] Bill Bejeck commented on KAFKA-9915: [~dajac] can we resolve this issue? Looks like i

[jira] [Commented] (KAFKA-9915) Throttle Create Topic, Create Partition and Delete Topic Operations

2020-10-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214121#comment-17214121 ] Ismael Juma commented on KAFKA-9915: [~dajac] Sounds good, I missed it when I was loo

[GitHub] [kafka] Lincong opened a new pull request #9435: MINOR KAFKA-10606 Disable auto topic creation for fetch-all-topic-metadata request

2020-10-14 Thread GitBox
Lincong opened a new pull request #9435: URL: https://github.com/apache/kafka/pull/9435 There is a bug that causes fetch-all-topic-metadata requests triggering auto topic creation. Details are described in KAFKA-10606. This is the simplest way to fix this bug on the broker side.

[jira] [Commented] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-14 Thread Lincong Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214130#comment-17214130 ] Lincong Li commented on KAFKA-10606: Hi [~tombentley] [~ijuma] I just created a PR.

[jira] [Commented] (KAFKA-7061) Enhanced log compaction

2020-10-14 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214188#comment-17214188 ] Bill Bejeck commented on KAFKA-7061: PR is still open, and feature freeze for 2.7 pas

[GitHub] [kafka] rhauch commented on a change in pull request #8918: Use debug level logging for noisy log messages in Connect

2020-10-14 Thread GitBox
rhauch commented on a change in pull request #8918: URL: https://github.com/apache/kafka/pull/8918#discussion_r504899011 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -492,7 +492,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] rhauch commented on a change in pull request #9407: MINOR: Merge log error to avoid double error

2020-10-14 Thread GitBox
rhauch commented on a change in pull request #9407: URL: https://github.com/apache/kafka/pull/9407#discussion_r504901806 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -184,8 +184,7 @@ private void doRun() throws InterruptedE

[GitHub] [kafka] kowshik opened a new pull request #9436: MINOR: Check for active controller in UpdateFeatures request processing logic

2020-10-14 Thread GitBox
kowshik opened a new pull request #9436: URL: https://github.com/apache/kafka/pull/9436 Tuned the code a bit to check for active controller upfront in UpdateFeatures request processing logic, before the event is queued. **Tests:** Relying on existing test, particularly: `Upda

[GitHub] [kafka] kowshik commented on pull request #9436: MINOR: Check for active controller in UpdateFeatures request processing logic

2020-10-14 Thread GitBox
kowshik commented on pull request #9436: URL: https://github.com/apache/kafka/pull/9436#issuecomment-708598843 cc @junrao @abbccdda This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-14 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504909676 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -192,12 +191,11 @@ public String toStrin

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-14 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504910261 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -900,9 +900,7 @@ // These are not settable in the main Stream

[jira] [Created] (KAFKA-10611) Merge log error to avoid double error

2020-10-14 Thread Benoit MAGGI (Jira)
Benoit MAGGI created KAFKA-10611: Summary: Merge log error to avoid double error Key: KAFKA-10611 URL: https://issues.apache.org/jira/browse/KAFKA-10611 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-10472) Consider migrating Topology methods to the Builder pattern

2020-10-14 Thread Huynh Quang Thao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214210#comment-17214210 ] Huynh Quang Thao commented on KAFKA-10472: -- Hi [~mjsax], I followed on [https

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-14 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504915393 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,359 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-14 Thread GitBox
kowshik commented on pull request #9409: URL: https://github.com/apache/kafka/pull/9409#issuecomment-708609368 @abbccdda Thanks for the review! I've addressed the most recent comment. This is an automated message from the Apa

[GitHub] [kafka] cyrusv commented on a change in pull request #8918: Use debug level logging for noisy log messages in Connect

2020-10-14 Thread GitBox
cyrusv commented on a change in pull request #8918: URL: https://github.com/apache/kafka/pull/8918#discussion_r504916758 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -492,7 +492,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] bmaggi commented on pull request #9407: MINOR: Merge log error to avoid double error

2020-10-14 Thread GitBox
bmaggi commented on pull request #9407: URL: https://github.com/apache/kafka/pull/9407#issuecomment-708611073 Thanks for the comments. Following suggestions: * I created a JIRA ticket [KAFKA-10611](https://issues.apache.org/jira/browse/KAFKA-10611) on the subject * I also add

[jira] [Updated] (KAFKA-10611) Merge log error to avoid double error

2020-10-14 Thread Benoit MAGGI (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoit MAGGI updated KAFKA-10611: - External issue URL: https://github.com/apache/kafka/pull/9407 > Merge log error to avoid double

[jira] [Commented] (KAFKA-10472) Consider migrating Topology methods to the Builder pattern

2020-10-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214221#comment-17214221 ] Matthias J. Sax commented on KAFKA-10472: - Just create an account and share your

[GitHub] [kafka] rhauch commented on a change in pull request #8918: Use debug level logging for noisy log messages in Connect

2020-10-14 Thread GitBox
rhauch commented on a change in pull request #8918: URL: https://github.com/apache/kafka/pull/8918#discussion_r504920005 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -492,7 +492,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] thake commented on a change in pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-14 Thread GitBox
thake commented on a change in pull request #9338: URL: https://github.com/apache/kafka/pull/9338#discussion_r504924920 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/WrappingNullableSerde.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ijuma commented on pull request #9435: MINOR KAFKA-10606 Disable auto topic creation for fetch-all-topic-metadata request

2020-10-14 Thread GitBox
ijuma commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-708617750 Thanks for the PR. Thoughts on how to test this? This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] vvcephei commented on a change in pull request #9338: KAFKA-10515: Properly initialize nullable Serdes with default values

2020-10-14 Thread GitBox
vvcephei commented on a change in pull request #9338: URL: https://github.com/apache/kafka/pull/9338#discussion_r504936524 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/WrappingNullableSerde.java ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apac

[jira] [Created] (KAFKA-10612) Log When SSL Authentication is in Unexpected State

2020-10-14 Thread David Mollitor (Jira)
David Mollitor created KAFKA-10612: -- Summary: Log When SSL Authentication is in Unexpected State Key: KAFKA-10612 URL: https://issues.apache.org/jira/browse/KAFKA-10612 Project: Kafka Issue

[GitHub] [kafka] belugabehr opened a new pull request #9437: KAFKA-10612: Log When SSL Authentication is in Unexpected State

2020-10-14 Thread GitBox
belugabehr opened a new pull request #9437: URL: https://github.com/apache/kafka/pull/9437 Additional logging, no functional changes. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-14 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-708635800 Java 8 failed [StreamTableJoinTopologyOptimizationIntegrationTest/](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9237/17/testReport/junit/org.apache.kafka.streams.int

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9434: MINOR: Handle lastFetchedEpoch/divergingEpoch in FetchSession and DelayedFetch

2020-10-14 Thread GitBox
rajinisivaram commented on a change in pull request #9434: URL: https://github.com/apache/kafka/pull/9434#discussion_r504952903 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1084,7 +1084,7 @@ class ReplicaManager(val config: KafkaConfig, fetc

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9434: MINOR: Handle lastFetchedEpoch/divergingEpoch in FetchSession and DelayedFetch

2020-10-14 Thread GitBox
rajinisivaram commented on a change in pull request #9434: URL: https://github.com/apache/kafka/pull/9434#discussion_r504954049 ## File path: core/src/main/scala/kafka/server/DelayedFetch.scala ## @@ -88,6 +90,13 @@ class DelayedFetch(delayMs: Long, try { if

[GitHub] [kafka] Lincong commented on pull request #9435: MINOR KAFKA-10606 Disable auto topic creation for fetch-all-topic-metadata request

2020-10-14 Thread GitBox
Lincong commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-708650004 @ijuma One way to test it could be to mock objects passed to the `KafkaApis` class. The `MetadataCache` object should be mocked in a way that upon the first invocation on the meth

[GitHub] [kafka] cyrusv commented on a change in pull request #8918: Use debug level logging for noisy log messages in Connect

2020-10-14 Thread GitBox
cyrusv commented on a change in pull request #8918: URL: https://github.com/apache/kafka/pull/8918#discussion_r504963920 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -492,7 +492,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-14 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504910261 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -900,9 +900,7 @@ // These are not settable in the main Stream

[GitHub] [kafka] ijuma commented on pull request #9435: MINOR KAFKA-10606 Disable auto topic creation for fetch-all-topic-metadata request

2020-10-14 Thread GitBox
ijuma commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-708671677 `KafkaApisTest` has a few tests like that. Could we add one there? The main concern is that we will regress here if we don't have tests. ---

[jira] [Created] (KAFKA-10613) Broker should not set leader epoch if the list-offset request version < 4

2020-10-14 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10613: - Summary: Broker should not set leader epoch if the list-offset request version < 4 Key: KAFKA-10613 URL: https://issues.apache.org/jira/browse/KAFKA-10613 Project:

[GitHub] [kafka] guozhangwang opened a new pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

2020-10-14 Thread GitBox
guozhangwang opened a new pull request #9438: URL: https://github.com/apache/kafka/pull/9438 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

[jira] [Commented] (KAFKA-10613) Broker should not set leader epoch if the list-offset request version < 4

2020-10-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214294#comment-17214294 ] Ismael Juma commented on KAFKA-10613: - When did we regress here? > Broker should no

[GitHub] [kafka] ijuma commented on pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

2020-10-14 Thread GitBox
ijuma commented on pull request #9438: URL: https://github.com/apache/kafka/pull/9438#issuecomment-708677767 Can we add a test please? This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] mjsax commented on pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-14 Thread GitBox
mjsax commented on pull request #9384: URL: https://github.com/apache/kafka/pull/9384#issuecomment-708678450 Address comments. @vvcephei This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] guozhangwang commented on pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

2020-10-14 Thread GitBox
guozhangwang commented on pull request #9438: URL: https://github.com/apache/kafka/pull/9438#issuecomment-708678537 System tests on `StreamsUpgradeTest.test_metadata_upgrade`: trunk failed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4220/ this branch succeed

[GitHub] [kafka] cmccabe merged pull request #9428: MINOR: fix a bug in removing elements from an ImplicitLinkedHashColle…

2020-10-14 Thread GitBox
cmccabe merged pull request #9428: URL: https://github.com/apache/kafka/pull/9428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cmccabe commented on pull request #9428: MINOR: fix a bug in removing elements from an ImplicitLinkedHashColle…

2020-10-14 Thread GitBox
cmccabe commented on pull request #9428: URL: https://github.com/apache/kafka/pull/9428#issuecomment-708681157 Backported to 2.7 as well. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] Lincong commented on pull request #9435: MINOR KAFKA-10606 Disable auto topic creation for fetch-all-topic-metadata request

2020-10-14 Thread GitBox
Lincong commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-708681626 @ijuma Will do! Thanks This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] jsancio commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

2020-10-14 Thread GitBox
jsancio commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r505036063 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -19,33 +19,51 @@ import org.apache.kafka.common.record.Records; import java

[GitHub] [kafka] abbccdda closed pull request #9419: KAFKA-10343: Add IBP based ApiVersion tests

2020-10-14 Thread GitBox
abbccdda closed pull request #9419: URL: https://github.com/apache/kafka/pull/9419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] abbccdda commented on pull request #9419: KAFKA-10343: Add IBP based ApiVersion tests

2020-10-14 Thread GitBox
abbccdda commented on pull request #9419: URL: https://github.com/apache/kafka/pull/9419#issuecomment-708706701 Merged with https://github.com/apache/kafka/pull/9103 This is an automated message from the Apache Git Service. T

[GitHub] [kafka] lct45 commented on pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-14 Thread GitBox
lct45 commented on pull request #9383: URL: https://github.com/apache/kafka/pull/9383#issuecomment-708708449 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4226/ system tests part 2 This is an automated me

[GitHub] [kafka] lct45 edited a comment on pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-14 Thread GitBox
lct45 edited a comment on pull request #9383: URL: https://github.com/apache/kafka/pull/9383#issuecomment-708708449 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4227/ system tests part 2 This is an autom

[GitHub] [kafka] lct45 edited a comment on pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-14 Thread GitBox
lct45 edited a comment on pull request #9383: URL: https://github.com/apache/kafka/pull/9383#issuecomment-708708449 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4228/ system tests part 2 This is an autom

[GitHub] [kafka] xvrl commented on pull request #9427: backport KAFKA-10571

2020-10-14 Thread GitBox
xvrl commented on pull request #9427: URL: https://github.com/apache/kafka/pull/9427#issuecomment-708718493 merged to 2.7 as part of https://github.com/apache/kafka/commit/ff1e2271f9cf148c513207a0a87c22e647940d0b This is an

[GitHub] [kafka] xvrl closed pull request #9427: backport KAFKA-10571

2020-10-14 Thread GitBox
xvrl closed pull request #9427: URL: https://github.com/apache/kafka/pull/9427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] xvrl opened a new pull request #9439: KAFKA-10587 MirrorMaker CLI change for KIP-629

2020-10-14 Thread GitBox
xvrl opened a new pull request #9439: URL: https://github.com/apache/kafka/pull/9439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] junrao commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-14 Thread GitBox
junrao commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r505019265 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,359 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] feyman2016 commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-14 Thread GitBox
feyman2016 commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-708859895 Hi, @vvcephei and @abbccdda ,sorry this PR takes a very long time, just updated the PR, could you help to review? Thanks!

[GitHub] [kafka] feyman2016 commented on a change in pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-14 Thread GitBox
feyman2016 commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r505133488 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1040,21 +1040,36 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] feyman2016 commented on a change in pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-14 Thread GitBox
feyman2016 commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r505133488 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1040,21 +1040,36 @@ class GroupCoordinator(val brokerId: Int,

  1   2   >