rhauch commented on a change in pull request #8918:
URL: https://github.com/apache/kafka/pull/8918#discussion_r504899011
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -492,7 +492,7 @@ public boolean commitOffsets() {
// to persistent storage
// Next we need to wait for all outstanding messages to finish
sending
- log.info("{} flushing {} outstanding messages for offset commit",
this, outstandingMessages.size());
+ log.debug("{} flushing {} outstanding messages for offset commit",
this, outstandingMessages.size());
Review comment:
I'm not convinced that changing this to DEBUG is worth it. The number of
source records output in this log message can be instrumental in some cases.
For example, if the producer does not keep up with the source task (for
whatever reason), this currently INFO-level message appears shortly before the
following ERROR-level message:
```
... ERROR WorkerSourceTask{id=...} Failed to commit offsets
(org.apache.kafka.connect.runtime.SourceTaskOffsetCommitter)
```
The number of outstanding source records reported by this line is an
important factor in determining how to tune the producer and
`offset.flush.timeout.ms` value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
