Re: RFR: 8247781: Day periods support [v11]

2020-11-12 Thread Roger Riggs
On Tue, 10 Nov 2020 00:07:16 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

Re: RFR: 8247781: Day periods support [v12]

2020-11-12 Thread Roger Riggs
On Tue, 10 Nov 2020 19:52:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

Re: RFR: 8247781: Day periods support [v12]

2020-11-12 Thread Roger Riggs
On Tue, 10 Nov 2020 19:52:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

Re: RFR: 8247781: Day periods support [v12]

2020-11-12 Thread Stephen Colebourne
On Tue, 10 Nov 2020 19:52:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Andy Herrick
JDK-8189198: Add "forRemoval = true" to Applet APIs - Commit messages: - Merge branch 'master' into JDK-8189198 - JDK-8189198: Add "forRemoval = true" to Applet APIs - JDK-8189198: Add "forRemoval = true" to Applet APIs - JDK-8189198: Add "forRemoval = true" to Applet APIs Change

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Andy Herrick
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs preliminary changes for JDK-8189198 for evaluation - PR: https://git.openjdk.java.net/jdk/pull/1127

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Kevin Rushforth
On Mon, 9 Nov 2020 13:57:32 GMT, Andy Herrick wrote: >> JDK-8189198: Add "forRemoval = true" to Applet APIs > > preliminary changes for JDK-8189198 for evaluation The following field, which is currently deprecated (not for removal) should probably also be marked as deprecated for removal:: jav

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Iris Clark
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs Since all APIs in the java.applet package are deprecated "forRemoval = true", consider adding a brief deprecation note to java/applet/package-info.java too. As an example, when all of the

Re: RFR: 8247781: Day periods support [v13]

2020-11-12 Thread Naoto Sato
> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: 8247781: Day periods support [v11]

2020-11-12 Thread Naoto Sato
On Thu, 12 Nov 2020 15:18:44 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clarified 24:00 for "midnight" type in the spec. Some clean up. > > src/java.base/share/classes/java/time/format/DateTimeF

Re: RFR: 8247781: Day periods support [v12]

2020-11-12 Thread Naoto Sato
On Thu, 12 Nov 2020 15:21:52 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added a test case for user defined temporal field resolution with day >> period. > > test/jdk/java/time/test/java/time/fo

Re: RFR: 8247781: Day periods support [v12]

2020-11-12 Thread Naoto Sato
On Thu, 12 Nov 2020 15:41:56 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added a test case for user defined temporal field resolution with day >> period. > > src/java.base/share/classes/

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs [v2]

2020-11-12 Thread Andy Herrick
> JDK-8189198: Add "forRemoval = true" to Applet APIs Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the las

Re: RFR: 8247781: Day periods support [v13]

2020-11-12 Thread Stephen Colebourne
On Thu, 12 Nov 2020 20:03:14 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder

Re: RFR: 8247781: Day periods support [v13]

2020-11-12 Thread Naoto Sato
On Thu, 12 Nov 2020 21:49:16 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed the following comments: >> - https://github.com/openjdk/jdk/pull/938#discussion_r522185469 >> - http

Re: RFR: 8247781: Day periods support [v14]

2020-11-12 Thread Naoto Sato
> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs [v2]

2020-11-12 Thread Alexander Matveev
On Thu, 12 Nov 2020 20:48:13 GMT, Andy Herrick wrote: >> JDK-8189198: Add "forRemoval = true" to Applet APIs > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase.

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Kevin Rushforth
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs @andyherrick can you enter the `/csr needed` command? I would, but it needs to be done by either the author of the PR or a Reviewer. - PR: https://git.openjdk.java.net/jdk/pu