On Tue, 10 Nov 2020 00:07:16 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder >> method. The motivation and its spec are in this CSR: >> >> https://bugs.openjdk.java.net/browse/JDK-8254629 >> >> Naoto > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Clarified 24:00 for "midnight" type in the spec. Some clean up. src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 1483: > 1481: * exception is thrown and the day period is ignored. > 1482: * <p> > 1483: * "midnight" type allows both "00:00" as the start-of-day and > "24:00" as the Editorial: Add "The " at the beginning of the sentence. ------------- PR: https://git.openjdk.java.net/jdk/pull/938
