Re: RFR: 8247781: Day periods support [v5]

2020-11-04 Thread Joe Wang
On Fri, 30 Oct 2020 11:42:49 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed TCK test failures, added the new pattern char description in >> DateTimeFormatter > > Changes requested by

Re: RFR: 8247781: Day periods support [v5]

2020-11-04 Thread Naoto Sato
On Wed, 4 Nov 2020 18:44:33 GMT, Joe Wang wrote: >> Changes requested by scolebourne (Author). > > Since 24:00 is not represented in for example LocalTime and H (hour-of-day) > 0-23, it seems obvious midnight in the JDK would be 00:00, and the new > DayPeriod tests proves that. The CLDR rule fo

Re: RFR: 8247781: Day periods support [v6]

2020-11-04 Thread Naoto Sato
> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >