On Wed, 4 Nov 2020 18:44:33 GMT, Joe Wang <jo...@openjdk.org> wrote: >> Changes requested by scolebourne (Author). > > Since 24:00 is not represented in for example LocalTime and H (hour-of-day) > 0-23, it seems obvious midnight in the JDK would be 00:00, and the new > DayPeriod tests proves that. The CLDR rule for midnight is also obvious, but > the LDML spec does state that it "strongly recommend" that implementations > provide for the ability to specify whether midnight is supported or not (and > for either 00:00 or 24:00 or both). > > Just wonder whether there is a need to explicitly state the fact about > midnight? DateTimeFormatterBuilder::appendInstant() for example, stated > clearly how 24:00 is processed, e.g. "The end-of-day time of '24:00' is > handled as midnight at the start of the following day."
Thanks, Joe. I will incorporate some description about "midnight" in the next update. ------------- PR: https://git.openjdk.java.net/jdk/pull/938
