Re: [DISCUSS] KIP-584: Versioning scheme for features

Hello Kowshik, Thanks for the great write-up, overall it reads great to me already. Adding a few meta comments here: 1. Could you explain a bit what would the "the set of features supported by a broker" information, beyond the cluster-level finalized features, be used by the client? I think that

[jira] [Created] (KAFKA-9823) Consumer should check equality of the generation for coordinator requests

Guozhang Wang created KAFKA-9823: Summary: Consumer should check equality of the generation for coordinator requests Key: KAFKA-9823 URL: https://issues.apache.org/jira/browse/KAFKA-9823 Project: Kafk

Re: 2.5.0 Producer.sendOffsetsToTransaction() and Backwards Compatibility

Hello Gary, Just to clarify, even for Streams client it cannot detect automatically the broker's version and hence as KIP-447 proposed, the customer needs to set a config value indicating that she is assured the broker version is newer and hence the new API can be used. On the other hand, if the c

Re: [DISCUSS] KIP-588: Allow producers to recover gracefully from transaction timeouts

Hello Boyang, Thank you for the proposed KIP. Just some minor comments below: 1. Could you also describe which producer APIs could potentially throw the new TransactionTimedOutException, and also how should callers handle them differently (i.e. just to make your description more concrete as javad

[jira] [Resolved] (KAFKA-8417) Remove redundant network definition --net=host when starting testing docker containers

[ https://issues.apache.org/jira/browse/KAFKA-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-8417. --- Resolution: Fixed > Remove redundant network definition --net=host when start

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Thanks for the update, Levani! -John On Sat, Apr 4, 2020, at 04:36, Levani Kokhreidze wrote: > Hello, > > Small update regarding this KIP. As per John’s suggestion during the > code review > (https://github.com/apache/kafka/pull/7170#discussion_r392608571 >

Re: [DISCUSS] KIP-584: Versioning scheme for features

Hi Colin, Thanks a lot for the explanation! I've updated the KIP based on your suggestions. Please find my response to your comments below. > If you can just treat "not present" as version level 0, you can have just checks like the second one. This should lead to simpler code. (Kowshik): Good i