Re: [PATCH 12/16] crypto/dpaa2_sec: fix bitmask truncation

On 15-11-2024 11:35, Stephen Hemminger wrote: The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://pvs-studio.com/en/blog/posts/cpp/118

Re: [PATCH 1/1] doc: virtual function MTU settings has no meaning

Hi, From: Slava Ovsiienko Sent: Monday, October 28, 2024 4:45 PM To: dev@dpdk.org Cc: Raslan Darawsheh; Matan Azrad; Suanming Mou Subject: [PATCH 1/1] doc: virtual function MTU settings has no meaning There is the mlx5 NIC limitations - configuring MTU for PCI Virtual Function has no meaning. Th

RE: [EXTERNAL] [PATCH 4/4] net/bnx2x: fix duplicate branch

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, November 12, 2024 11:14 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Julien Aube > ; Harish Patil > Subject: [EXTERNAL] [PATCH 4/4] net/bnx2x: fix duplicate branch > > Coverity spotted that both legs of the conditional

Re: [PATCH 14/16] event/dpaa: fix bitmask truncation

On 15-11-2024 11:35, Stephen Hemminger wrote: More bitmask truncation from mask computation. Fixes: 0ee17f79ebd0 ("event/dpaa: add enqueue/dequeue") Cc: sunil.k...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/event/dpaa/dpaa_eventdev.c | 10 +- 1 file c

Re: [PATCH 15/16] net/dpaa: fix bitmask truncation

Acked-by: Hemant Agrawal On 15-11-2024 11:35, Stephen Hemminger wrote: The dqrr_held mask is 64 bit but updates were getting truncated because 1 is of type int (32 bit) and the result shift of int is of type int (32 bit); therefore any value >= 32 would get truncated. Link: https://pvs-studio.

[PATCH v16 2/4] pmu: support reading ARM PMU events in runtime

Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 4 ++ lib/pmu/meson.build | 8 lib/pmu/pmu_arm64.c | 94 + lib/pmu/rte_pmu.h | 4 ++ lib/pmu/rte_pmu_pmc_arm6

Re: [PATCH v6 00/14] use rte_strerror() for rte_errno

Series-Acked-by: Huisong Li 在 2024/11/14 19:39, Dengdui Huang 写道: Whether strerror() needs to be replaced needs further discussion, but rte_error should not be used by strerror() because rte_errno may be an RTE-specific error code. This patchset use rte_strerror() instead of strerror() for rte

Re: [PATCH v3 10/10] app/test-dma-perf: fix parsing of DMA address

On 2024/11/16 4:06, Stephen Hemminger wrote: > There was useless loop when looking at the DMA address. > It looks like it was meant to skip whitespace before > calling strtok. > > Good time to replace strtok with strtok_r as well. Please delete this line, with this fixed: Acked-by: Chengwen Feng

RE: [PATCH v3 04/10] app/test: avoid duplicate initialization

> -Original Message- > From: Stephen Hemminger > Sent: Saturday, November 16, 2024 1:37 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; > jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; Gujjar, Abhinandan S > > Subject: [PATCH v3 04/10] app/test: avoid duplicate initialization >

[PATCH v16 0/4] add support for self monitoring

This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain advantages when application runs on isolated cores running dedicated tasks. Events can be read directly using rte_pmu_read()

[PATCH v16 1/4] lib: add generic support for reading PMU events

Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performance. Signed

[PATCH v16 4/4] eal: add PMU support to tracing library

In order to profile app one needs to store significant amount of samples somewhere for an analysis later on. Since trace library supports storing data in a CTF format lets take advantage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- app/test/test_trace_perf.c

[RFC] Revert "vhost: use imported VDUSE uAPI header"

The file vduse.h does not have a license that is compatiable with current DPDK license policy. This reverts commit 9fec3f0569087de0129c7f2badaf5be2776e. Signed-off-by: Stephen Hemminger --- kernel/linux/uapi/linux/vduse.h | 353 lib/vhost/meson.build

Re: [PATCH v3 09/11] net/ntnic: remove unnecessary void cast

>On 14.11.2024, 04:38, "Stephen Hemminger" wrote: > > >There is no need to cast memset to void. > > >Signed-off-by: Stephen Hemminger > >--- >drivers/net/ntnic/nim/i2c_nim.c | 2 +- >drivers/net/ntnic/nthw/flow_filter/flow_nthw_cat.c | 4 ++-- >drivers/net/ntnic/nth

Re: [PATCH v3 10/11] net/ntnic: check result of malloc

On 14.11.2024, 04:38, "Stephen Hemminger" wrote: > > >Need to check the result of malloc() before calling memset. >This is only place in this driver that forgot, other code >does check. > > >Signed-off-by: Stephen Hemminger > >--- >drivers/net/ntnic/nthw/nthw_rac.

Re: [PATCH v3 11/11] net/ntnic: remove unnecessary memset

>On 14.11.2024, 04:38, "Stephen Hemminger" wrote: > > >Calling memset before free() has no effect and will be flagged >by security parsing tools as a potential bug. None of these data >structures have sensitive information. > > >Signed-off-by: Stephen Hemminger >

Re: rte_fib network order bug

Hi all, [Robin] > I had not understood that it was *only* the lookups that were network order [Morten] >When I saw the byte order flag the first time, it was not clear to me either that it only affected lookups - I too thought it covered the entire API of the library. This needs to be emphasized i

Re: [PATCH] eal: fix lcore variables documentation

On 2024-11-14 18:09, Thomas Monjalon wrote: The lcore variables API is new in DPDK 24.11, that's why the function rte_lcore_var_alloc() was marked experimental. To be clearer, the whole header file (including all macros) is marked experimental. A change decreased the default buffer size from 1 M