> -Original Message-
> From: Wu, Jingjing
> Sent: Friday, March 22, 2024 11:47 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing ; jer...@marvell.com;
> pbhagavat...@marvell.com; Yan, Zhirun
> Subject: [PATCH v2] graph: fix head move when graph walk in mcore dispatch
>
> Head move happens befo
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, March 25, 2024 11:01 AM
> To: annou...@dpdk.org
> Subject: release candidate 24.03-rc4
>
> A new DPDK release candidate is ready for testing:
> https://git.dpdk.org/dpdk/tag/?id=v24.03-rc4
>
> There are 31 new patches in
On Mon, 25 Mar 2024 at 10:02, Morten Brørup wrote:
>
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Monday, 25 March 2024 00.14
> >
> > 17/01/2024 17:24, Kevin Traynor:
> > > The existing official policy was to maintain LTS releases for 2 years.
> > >
> > > 19.11 and 20.11 LTS re
On 28/03/2024 10:01, Luca Boccassi wrote:
> On Mon, 25 Mar 2024 at 10:02, Morten Brørup
> wrote:
>>
>>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>>> Sent: Monday, 25 March 2024 00.14
>>>
>>> 17/01/2024 17:24, Kevin Traynor:
The existing official policy was to maintain LTS releases
On Wed, Mar 27, 2024 at 7:44 PM Vladimir Medvedkin
wrote:
>
> The ICE hardware can operate in two modes - single vlan mode
> or double vlan mode. Depending on the operating mode the hardware
> handles vlan header with single vlan tag differently.
> When double vlan enabled, a packet with a single
https://bugs.dpdk.org/show_bug.cgi?id=1408
Bug ID: 1408
Summary: Check dependencies on remote target
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Release status meeting minutes 2024-03-28
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* ARM
* Debian/Microsoft
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the current/u
Fix grammar, spelling and formatting of DPDK 24.03 release notes.
Signed-off-by: John McNamara
---
Note: template sections should be removed.
doc/guides/rel_notes/release_24_03.rst | 27 ++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/doc/guides/rel_
On 2024/3/28 20:05, John McNamara wrote:
> Fix grammar, spelling and formatting of DPDK 24.03 release notes.
>
> Signed-off-by: John McNamara
Acked-by: Chengwen Feng
This series aims at fixing several issues found in
Virtio-user PMD related to queues setup and cleanup.
It has been tested with Vhost-vDPA backend using Nvidia
Cx6-Dx vDPA VF.
First patch in the series renames the queues iterator
helper, so it is not a fix. But I would suggest to have it
backport
This patch uses the freshly renamed iterator to destroy
queues at stop time. Doing this, we fix the missing
control queue destruction.
Fixes: 90966e8e5b67 ("net/virtio-user: send shadow virtqueue info to the
backend")
Cc: sta...@dpdk.org
Acked-by: David Marchand
Signed-off-by: Maxime Coquelin
The Virtio-user control queue kick and call FDs were not
uninitialized at device stop time.
This patch fixes this using the queues iterator helper for
both initialization and uninitialization.
Fixes: 90966e8e5b67 ("net/virtio-user: send shadow virtqueue info to the
backend")
Cc: sta...@dpdk.org
This is a preliminary rework to prepare for iterating
over queues for non-setup operations.
Also, remove the error log that does not provide much
information given the callbacks already provide one.
Acked-by: David Marchand
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_user/virt
It is possible to have the control queue without the
device advertising VIRTIO_NET_F_MQ.
Rely on the VIRTIO_NET_F_CTRL_VQ feature being advertised
instead.
Fixes: 6fdf32d1e318 ("net/virtio-user: remove max queues limitation")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
drivers/net/v
28/03/2024 13:24, fengchengwen:
> On 2024/3/28 20:05, John McNamara wrote:
> > Fix grammar, spelling and formatting of DPDK 24.03 release notes.
> >
> > Signed-off-by: John McNamara
>
> Acked-by: Chengwen Feng
Applied, thanks.
From: Shai Brandes
Hi, the fix is for a bug that was introduced in 23.11.
The fix was already merged into 24.03 indirectly as part of c8a1898f82f8
("net/ena: improve style and readability")
and the entire function was later restructured in patch bcb1753156ac
("net/ena/base: modify customer metr
From: Shai Brandes
The driver accidentally allocates a huge memory
buffer for the customer metrics because it uses
an uninitialized variable for the buffer length.
This can lead to excessive memory footprint for
the driver which can even fail to initialize in
case of insufficient memory.
Signed-
From: Shai Brandes
Hi, the fix is for a bug that was introduced in 23.11.
The fix was already merged into 24.03 indirectly as part of c8a1898f82f8
("net/ena: improve style and readability")
and the entire function was later restructured in patch bcb1753156ac
("net/ena/base: modify customer metr
From: Shai Brandes
The driver accidentally allocates a huge memory
buffer for the customer metrics because it uses
an uninitialized variable for the buffer length.
This can lead to excessive memory footprint for
the driver which can even fail to initialize in
case of insufficient memory.
Signed-
Sorry, for some reason this appears on the wrong branch
I will fix this and upload a new patch
> -Original Message-
> From: shaib...@amazon.com
> Sent: Thursday, March 28, 2024 4:03 PM
> To: ferruh.yi...@amd.com; bl...@debian.org;
> christian.ehrha...@canonical.com; xuemi...@nvidia.com;
>
Please see https://core.dpdk.org/contribute/ for instructions on
sending patches for stable releases, otherwise they will be missed
On Thu, 28 Mar 2024 at 14:22, Brandes, Shai wrote:
>
> Sorry, for some reason this appears on the wrong branch
> I will fix this and upload a new patch
>
> > -Or
From: Yuying Zhang
Delete self from cpfl driver.
Signed-off-by: Yuying Zhang
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0d1c8126e3..6a7d0293c6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -800,7 +800,6 @@ F: doc/guides/nics/idpf.rst
F:
From: Yuying Zhang
Delete self from testpmd.
Signed-off-by: Yuying Zhang
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6a7d0293c6..969b70eabd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1781,7 +1781,6 @@ F: app/test/sample_packet_forward.
From: Yuying Zhang
Delete self from i40e driver.
Signed-off-by: Yuying Zhang
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 969b70eabd..1338d3d70e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -758,7 +758,6 @@ F: doc/guides/nics/intel_vf.rst
MSVC does not support older MMX intrinsics use SSE/AVX instead.
v2:
* move conditional #include into rte_vect.h and include
rte_vect.h into net_crc_avx512.c net_crc_sse.c instead of duplicating
conditional compile of include in each file.
Tyler Retzlaff (2):
eal: include header for M
MSVC documents that you use the monolithic intrin.h for all intrinsics
(including SIMD intrinsics) include intrin.h into rte_vec.h when
building with MSVC so we don't have to duplicate conditionally compile
include it across the DPDK source.
Signed-off-by: Tyler Retzlaff
---
lib/eal/include/gene
Update code to use only avx/sse intrinsics as mmx is not supported on
MSVC.
Signed-off-by: Tyler Retzlaff
---
lib/net/net_crc_avx512.c | 27 +++
lib/net/net_crc_sse.c| 27 +++
2 files changed, 14 insertions(+), 40 deletions(-)
diff --git a/lib
On Thu, Mar 21, 2024 at 07:01:17PM +0100, Thomas Monjalon wrote:
> 21/03/2024 18:27, Tyler Retzlaff:
> > On Thu, Mar 21, 2024 at 06:09:01PM +0100, Thomas Monjalon wrote:
> > > 20/03/2024 22:12, Tyler Retzlaff:
> > > > +#ifdef RTE_TOOLCHAIN_MSVC
> > > > +#include
> > > > +#else
> > > > #include
>
Overall I like the idea of having a structured way of passing
command-line arguments to applications as strings and I think that
this is a well-abstracted approach. I also like that this approach
still supports the ability to pass strings "as-is" and use them as
parameters as well. That opens the d
On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote:
>
> Make it so that interactive shells accept an implementation of `Params`
> for app arguments. Convert EalParameters to use `Params` instead.
>
> String command line parameters can still be supplied by using the
> `StrParams` implementation.
>
We talked about this in DTS meeting, looking at this some more, we
already use default parameters for Eal and structure those, so we
already have sort of tied ourselves into a situation of if those ever
change (unlikely) we would need to change as well, so maybe this could
be something we use, I'd
On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote:
> diff --git a/dts/framework/remote_session/interactive_shell.py
> b/dts/framework/remote_session/interactive_shell.py
> index a2c7b30d9f..5d80061e8d 100644
> --- a/dts/framework/remote_session/interactive_shell.py
> +++ b/dts/framework/remote
On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote:
>
> This commit provides a state container for TestPmdShell. It currently
> only indicates whether the packet forwarding has started
> or not, and the number of ports which were given to the shell.
>
> This also fixes the behaviour of `wait_link
On Thu, Mar 28, 2024 at 09:14:05AM -0700, Tyler Retzlaff wrote:
> MSVC documents that you use the monolithic intrin.h for all intrinsics
> (including SIMD intrinsics) include intrin.h into rte_vec.h when
> building with MSVC so we don't have to duplicate conditionally compile
> include it across th
On Thu, Mar 28, 2024 at 09:14:06AM -0700, Tyler Retzlaff wrote:
> Update code to use only avx/sse intrinsics as mmx is not supported on
> MSVC.
>
> Signed-off-by: Tyler Retzlaff
> ---
One comment inline below. With or without that suggestion:
Acked-by: Bruce Richardson
> lib/net/net_crc_avx5
On Thu, Mar 28, 2024 at 04:06:38PM +, yuying.zh...@intel.com wrote:
> From: Yuying Zhang
>
> Delete self from cpfl driver.
>
> Signed-off-by: Yuying Zhang
> ---
Sorry to see you go,
Acked-by: Bruce Richardson
On Thu, Mar 28, 2024 at 04:10:21PM +, yuying.zh...@intel.com wrote:
> From: Yuying Zhang
>
> Delete self from testpmd.
>
> Signed-off-by: Yuying Zhang
> ---
Acked-by: Bruce Richardson
On Thu, Mar 28, 2024 at 04:13:07PM +, yuying.zh...@intel.com wrote:
> From: Yuying Zhang
>
> Delete self from i40e driver.
>
> Signed-off-by: Yuying Zhang
> ---
Acked-by: Bruce Richardson
Recheck-request: github-robot
A new major release is available:
https://fast.dpdk.org/rel/dpdk-24.03.tar.xz
This is the work we did during the last months:
987 commits from 154 authors
1334 files changed, 79260 insertions(+), 22824 deletions(-)
It is not planned to start a maintenance branch for 24.03
Currently virtio_dev_tx_packed() always allocates requested @count of
packets, no matter how many packets are really available on the virtio
Tx ring. Later it has to free all packets it didn't use and if, for
example, there were zero available packets on the ring, then all @count
mbufs would be all
Improvements and unification of logging library.
This version works on all platforms: Linux, Windows and FreeBSD.
This is update to rework patch set. It adds several new features
to the console log output.
* Putting a timestamp on console output which is useful for
analyzing performance of
"You touch it you own it"
Add myself as maintainer for log library.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7abb3aee49..54c28a601d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@
Having different prototypes on different platforms can lead
to lots of unnecessary workarounds. Looks like the version of
getopt used from windows was based on an older out of date
version from FreeBSD.
This patch changes getopt, getopt_long, etc to have the same const
attributes as Linux and Fre
Windows does not have localtime_r but it does have a similar
function that can be used instead.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/eal/windows/include/rte_os_shim.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/lib/eal/windows/include/rte_os_shim
Replace the windows version of asprintf() that was only usable
in eal. With a more generic one that supports both vasprintf()
and asprintf(). This also eliminates duplicate code.
Fixes: 8f4de2dba9b9 ("bus/pci: fill bus specific information")
Fixes: 9ec521006db0 ("eal/windows: hide asprintf shim")
The code to parse for log-level option should be same on
all OS variants.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/eal/common/eal_common_options.c | 46 +
lib/eal/common/eal_options.h| 1 +
lib/eal/freebsd/eal.c | 42 --
The message already goes through logging, and does not need
to be printed on stderr. Message level should be ALERT
to match function name.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/eal/freebsd/eal.c | 3 +--
lib/eal/linux/eal.c | 3 +--
2 files changed, 2 insertions(+)
The rte_exit() output format confuses the timestamp and coloring
options. Change it to use be a single line with proper prefix.
Before:
[ 0.006481] EAL: Error - exiting with code: 1
Cause: [ 0.006489] Cannot init EAL: Permission denied
After:
[ 0.006238] EAL: Error - exiting with co
The syslog facility property is better handled in lib/log
rather than in eal. This also allows for changes to what
syslog flag means in later steps.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_options.c | 51 ++---
lib/eal/freebsd/eal.c |
In order for all log messages (including CPU mismatch) to
come out through the logging library, it must be initialized
as early in rte_eal_init() as possible on all platforms.
Where it was done before was likely historical based on
the support of non-OS isolated CPU's which required a shared
memor
This patch makes the log setup code common across all platforms.
Drops syslog support for now, will come back in later patch.
Signed-off-by: Stephen Hemminger
---
app/test/test_eal_flags.c | 11 ++-
lib/eal/common/eal_common_options.c | 3 -
lib/log/log.c | 2
This is useful for when decorating log output for console
or journal. Provide basic version in this patch.
Signed-off-by: Stephen Hemminger
---
lib/log/log.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/lib/log/log.c b/lib/log/log.c
index f597da2e39..acd4
When debugging driver or startup issues, it is useful to have
a timestamp on each message printed. The messages in syslog
already have a timestamp, but often syslog is not available
during testing.
There are multiple timestamp formats similar to Linux dmesg.
The default is time relative since star
If DPDK application is being run as a systemd service, then
it can use the journal protocol which allows putting more information
in the log such as priority and other information.
The use of journal protocol is automatically detected and
handled. Rather than having a dependency on libsystemd,
ju
Like dmesg, colorize the log output (unless redirected to file).
Timestamp is green, the subsystem is in yellow and the message
is red if urgent, boldface if an error, and normal for info and
debug messages.
Signed-off-by: Stephen Hemminger
---
app/test/test_eal_flags.c | 24
doc
Log to syslog only if option is specified. And if syslog is used
then normally only log to syslog, don't duplicate output.
Also enables syslog support on FreeBSD.
Signed-off-by: Stephen Hemminger
---
app/test/test_eal_flags.c | 5 +-
doc/guides/linux_gsg/linux_eal_parameter
On Thu, Mar 28, 2024 at 04:44:26PM -0700, Stephen Hemminger wrote:
> On Thu, 28 Mar 2024 16:33:38 -0700
> Andrey Ignatov wrote:
>
> >
> > +static __rte_always_inline uint16_t
> > +get_nb_avail_entries_packed(const struct vhost_virtqueue *__rte_restrict
> > vq,
> > + uint1
在 2024/3/26 20:46, Morten Brørup 写道:
From: lihuisong (C) [mailto:lihuis...@huawei.com]
Sent: Tuesday, 26 March 2024 13.15
在 2024/3/26 16:27, Morten Brørup 写道:
From: lihuisong (C) [mailto:lihuis...@huawei.com]
Sent: Tuesday, 26 March 2024 03.12
在 2024/3/22 20:35, Morten Brørup 写道:
From: lihu
Recheck-request: iol-unit-amd64-testing
在 2024/3/26 21:47, Ajit Khaparde 写道:
On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C) wrote:
在 2024/3/26 18:30, Thomas Monjalon 写道:
26/03/2024 02:42, lihuisong (C):
在 2024/3/25 17:30, Thomas Monjalon 写道:
25/03/2024 07:24, huangdengdui:
On 2024/3/22 21:58, Thomas Monjalon wrote:
22/03/2024
61 matches
Mail list logo
