On Thu, Mar 28, 2024 at 04:44:26PM -0700, Stephen Hemminger wrote:
> On Thu, 28 Mar 2024 16:33:38 -0700
> Andrey Ignatov <r...@apple.com> wrote:
> 
> >  
> > +static __rte_always_inline uint16_t
> > +get_nb_avail_entries_packed(const struct vhost_virtqueue *__rte_restrict 
> > vq,
> > +                       uint16_t max_nb_avail_entries)
> > +{
> 
> You don't need always inline, the compiler will do it anyway.

I can remove it in v2, but it's not completely obvious to me how is it
decided when to specify it explicitly and when not?

I see plenty of __rte_always_inline in this file:

% git grep -c '^static __rte_always_inline' lib/vhost/virtio_net.c
lib/vhost/virtio_net.c:66

Reply via email to