On Tue, Dec 19, 2023 at 6:16 PM Stephen Hemminger
wrote:
>
> On Tue, 19 Dec 2023 16:45:19 +0100
> Thomas Monjalon wrote:
>
> > 18/12/2023 15:38, David Marchand:
> > > +#ifdef RTE_TOOLCHAIN_GCC
> > > +#define RTE_LOG_CHECK_NO_NEWLINE(fmt) \
> > > + static_assert(!__builtin_strchr(fmt, '\n'), \
>
By default all packets received on ethdev_rx node
is forwarded to pkt_cls node.This patch provides
library support to add a new node as next node to
ethdev_rx node and forward packet to new node from
rx node.
Signed-off-by: Rakesh Kudurumalla
---
V6: Addressed comments
updated documentation
Adds a txport to forward packet for every rxport
Mapping will be used to forward packets to txport
received on rxport
Following commands are exposed:
- ethdev forward "
Signed-off-by: Rakesh Kudurumalla
---
app/graph/cli.c| 1 +
app/graph/ethdev.c | 63 +++
Added portforward usecase.In this usecase
packets received Rx port is forwarded to
respective Tx port.
Signed-off-by: Rakesh Kudurumalla
---
app/graph/ethdev.c | 13 ++
app/graph/ethdev.h | 1 +
app/graph/examples/l2fwd.cli |
This patch enabled FEC set and get functions.
Signed-off-by: Qiming Yang
---
drivers/net/i40e/i40e_ethdev.c | 183 +
1 file changed, 183 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 3ca226156b..1eb49176d1 100644
On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> DESTDIR to be usable.
>
> Signed-off-by: Tyler Retzlaff
> ---
Acked-by: Bruce Richardson
just received an update marking this as `Superseded`. I will send again
with `ACK` also
Thank you Morten for the understanding
*From:* Morten Brørup
*Sent:* 12 December 2023 23:39
*To:* Varghese, Vipin ; Bruce Richardso
On Wed, Dec 20, 2023 at 10:18 AM Varghese, Vipin wrote:
>
> just received an update marking this as `Superseded`. I will send again with
> `ACK` also
I saw multiple versions of a patch, with the last one marked as
deferred, so I cleaned the previous revision as superseded.
There are many instanc
[AMD Official Use Only - General]
Hi Morten,
> -Original Message-
> From: Morten Brørup
> Sent: Wednesday, December 20, 2023 12:58 PM
> To: Tummala, Sivaprasad ;
> david.march...@redhat.com; ktray...@redhat.com; tho...@monjalon.net;
> konstantin.anan...@huawei.com; konstantin.v.anan...@y
This patch set adds an IAVF testpmd command "set tx lldp on|off" which
will register an mbuf dynfield IAVF_TX_LLDP_DYNFIELD, currently only
supported turning on.
IAVF will fill the SWTCH_UPLINK bit in the Tx context descriptor based on
the mbuf dynfield to send the LLDP packet.
For avx512, need t
This patch adds an mbuf dynfield IAVF_TX_LLDP_DYNFIELD to determine
whether or not to fill the SWTCH_UPLINK bit in the Tx context descriptor
to send LLDP packet.
Signed-off-by: Zhichao Zeng
---
drivers/net/iavf/iavf_rxtx.c| 18 --
drivers/net/iavf/rte_pmd_iavf.h | 4
2
This patch adds an avx512 ctx Tx path that supports context descriptor,
filling in the SWTCH_UPLINK bit based on mbuf dynfield
IAVF_TX_LLDP_DYNFIELD to support sending LLDP packet.
Signed-off-by: Zhichao Zeng
---
drivers/net/iavf/iavf_rxtx.c| 5 +
drivers/net/iavf/iavf_rxtx.h
This patch adds an IAVF testpmd command "set tx lldp on|off" which
will register an mbuf dynfield IAVF_TX_LLDP_DYNFIELD to indicate
the need to send LLDP packet. Currently, it only supports turning on.
For avx512, need to close the Tx port first, then "set tx lldp on",
and reopen the port to selec
Got `Superseded` is there a new version shared for `AMD tuning guide`?
On 10/10/2023 9:04 PM, Vipin Varghese wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Add AMD EPYC SoC tuning guide as new setcio
On Wed, Dec 20, 2023 at 10:25 AM Varghese, Vipin wrote:
>
> Got `Superseded` is there a new version shared for `AMD tuning guide`?
That's a question for yourself.
I saw two patches with the same title.
More checks were passing on the more recent one.
I marked the first as superseded.
--
David
On 12/20/2023 2:57 PM, David Marchand wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
On Wed, Dec 20, 2023 at 10:25 AM Varghese, Vipin wrote:
Got `Superseded` is there a new version shared for `AMD
On Wed, Dec 20, 2023 at 10:31 AM Varghese, Vipin wrote:
> On 12/20/2023 2:57 PM, David Marchand wrote:
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > On Wed, Dec 20, 2023 at 10:25 AM Varghes
On 12/20/2023 3:02 PM, David Marchand wrote:
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
On Wed, Dec 20, 2023 at 10:31 AM Varghese, Vipin wrote:
On 12/20/2023 2:57 PM, David Marchand wrote:
Caution:
19/12/2023 18:40, Harman Kalra:
> +The CNXK driver supports port representor model by adding virtual ethernet
> +ports providing a logical representation in DPDK for physical function(PF) or
> +SR-IOV virtual function (VF) devices for control and monitoring.
> +
> +Base device or parent device unde
19/12/2023 16:17, Euan Bourke:
> +Each table entry can hold information about packets of up to
> ``RTE_LIBRTE_IP_FRAG_MAX_FRAGS`` fragments,
> +where ``RTE_LIBRTE_IP_FRAG_MAX_FRAGS`` defaults to:
Instead of repeating the name, you can use "it".
> +
> +.. literalinclude:: ../../../config/rte_conf
By default all packets received on ethdev_rx node
is forwarded to pkt_cls node.This patch provides
library support to add a new node as next node to
ethdev_rx node and forward packet to new node from
rx node.
Signed-off-by: Rakesh Kudurumalla
---
v7:
Remove warning
lib/node/ethdev_ctrl.c
Adds a txport to forward packet for every rxport
Mapping will be used to forward packets to txport
received on rxport
Following commands are exposed:
- ethdev forward "
Signed-off-by: Rakesh Kudurumalla
---
app/graph/cli.c| 1 +
app/graph/ethdev.c | 63 +++
Added portforward usecase.In this usecase
packets received Rx port is forwarded to
respective Tx port.
Signed-off-by: Rakesh Kudurumalla
---
app/graph/ethdev.c | 13 ++
app/graph/ethdev.h | 1 +
app/graph/examples/l2fwd.cli |
On Wed, Dec 20, 2023 at 10:42:28AM +0100, Thomas Monjalon wrote:
> 19/12/2023 16:17, Euan Bourke:
> > +Each table entry can hold information about packets of up to
> > ``RTE_LIBRTE_IP_FRAG_MAX_FRAGS`` fragments,
> > +where ``RTE_LIBRTE_IP_FRAG_MAX_FRAGS`` defaults to:
>
> Instead of repeating the
We currently don't store test cases that couldn't be executed because of
a previous failure, such as when a test suite setup failed, resulting in
no executed test cases.
In order to record the test cases that couldn't be executed, we must
know the lists of test suites and test cases ahead of the a
The dts.py module deviates from the rest of the code without a clear
reason. Converting it into a class and using better naming will improve
organization and code readability.
Signed-off-by: Juraj Linkeš
---
dts/framework/config/__init__.py | 3 -
dts/framework/dts.py | 228 ---
Move the code responsible for running the test suite from the
TestSuite class to the DTSRunner class. This restructuring decision
was made to consolidate and unify the related logic into a single unit.
Signed-off-by: Juraj Linkeš
---
dts/framework/runner.py | 156
We initialize test suite/case objects at the start of
the program and store them with custom execution config
(add test case names) in Execution. This change helps
identify errors with test suites earlier, and we have
access to the right data when programs crash earlier.
Signed-off-by: Juraj Linke
In case of a failure during execution, build target or suite setup
the test case results will be recorded as blocked. We also unify
methods add_ to add_child_result to be more consistently.
Now we store the corresponding config in each result with child
configs and parent result.
Signed-off-by: Ju
Refactor logging for improved configuration and flexibility,
investigating unclear arguments and exploring alternatives
for logging test suites into separate files. In addition,
efforts were made to ensure that the modules remained
independent from the logger module, enabling potential use
by other
https://bugs.dpdk.org/show_bug.cgi?id=1337
Bug ID: 1337
Summary: [21.11.5] iavf driver stuck in rte_eal_alarm_cancel
Product: DPDK
Version: 21.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
From: Vipin Varghese
Replace pktmbuf pool with mempool, this allows increase in MOPS
especially in lower buffer size. Using Mempool, allows to reduce
the extra CPU cycles.
Changes made are
1. pktmbuf pool create with mempool create.
2. create src & dst pointer array from the appropaite numa.
3.
Hi Stephen,
Please see inline.
Thanks,
Anoob
> -Original Message-
> From: Stephen Hemminger
> Sent: Tuesday, December 19, 2023 10:49 PM
> To: Anoob Joseph
> Cc: Radu Nicolau ; Akhil Goyal
> ; Konstantin Ananyev
> ; Jerin Jacob Kollanukkaran
> ; dev@dpdk.org
> Subject: [EXT] Re: [PATCH
Hi all,
Here is a list of patches targeted for stable release 21.11.6.
The planned date for the final release is 12 January.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validatio
Adding GEN5 files for handling GEN5 specific operaions.
These files are inherited from the existing files/APIs
which has some changes specific GEN5 requirements
Also updated the mailmap file.
Signed-off-by: Nishikant Nayak
---
.mailmap | 1 +
drivers/common
Adding GEN5 specific macros which is required for updating
the support for GEN5 features.
Also this patch adds other macros which is being used by GEN5
Specific APIs.
Signed-off-by: Nishikant Nayak
---
drivers/common/qat/meson.build| 2 +
.../qat/qat_adf/adf_transport_access_mac
This patch handles the changes required for updating the common
header fields specific to GEN5, Also added/updated of the response
processing APIs based on GEN5 requirement.
Signed-off-by: Nishikant Nayak
---
drivers/crypto/qat/qat_sym.c | 10 -
drivers/crypto/qat/qat_sym.h |
Adding one new unit test code for validating the features
added as part of GCM with 64 byte AAD.
The new test case adds one new test for GCM algo for both
encrypt and decrypt operations.
Signed-off-by: Nishikant Nayak
---
app/test/test_cryptodev.c | 48 +---
app/tes
18/12/2023 15:38, David Marchand:
> Convert many libraries that call RTE_LOG(... "\n", ...) to RTE_LOG_LINE.
>
> Note:
> - for acl and sched libraries that still has some debug multilines
> messages, a direct call to RTE_LOG is used: this will make it easier to
> notice such special cases,
[.
On Wed, Dec 20, 2023 at 2:46 PM Thomas Monjalon wrote:
>
> 18/12/2023 15:38, David Marchand:
> > Convert many libraries that call RTE_LOG(... "\n", ...) to RTE_LOG_LINE.
> >
> > Note:
> > - for acl and sched libraries that still has some debug multilines
> > messages, a direct call to RTE_LOG is
This patchset builds on the previous v1 and v2, and the discussion
which followed about what libraries should be optional. While still
a long way to go from the position suggested in the v2 discussion,
this set moves us a bit further along the road.
The first patch is a direct v3 from previous ver
DPDK now has more optional libraries than mandatory ones, so invert the
list stored in the meson.build file from the optional ones to the
"always_enable" ones. As well as being a shorter list:
* we can remove the loop building up the "always_enable" list
dynamically from the optional list
* it b
Remove five more libs from the mandatory build list. Only one needing
any special treatment is LPM, which is an optional dependency for some
secondary process autotests.
Signed-off-by: Bruce Richardson
---
app/test/meson.build | 4 ++--
lib/meson.build | 5 -
2 files changed, 2 insertio
In order to remove more libraries from the mandatory list, we need to
have support for optionally having a dependency from a driver or library
to another driver or lib. This patch adds this support by adding a new
optional_deps variable, the contents of which are added to the deps list
if those opt
Fix to allow telemetry to handle empty dictionaries correctly.
This patch resolves an issue where empty dictionaries are reported
by telemetry as '[]' rather than '{}'. Initializing the output
buffer based on the container type resolves the issue.
Signed-off-by: Jonathan Erb
---
.mailmap
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Wednesday, 20 December 2023 15.22
>
> In order to remove more libraries from the mandatory list, we need to
> have support for optionally having a dependency from a driver or
> library
> to another driver or lib. This patch adds
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Wednesday, 20 December 2023 15.22
>
> Remove five more libs from the mandatory build list. Only one needing
> any special treatment is LPM, which is an optional dependency for some
> secondary process autotests.
>
> Signed-off-b
Getting readable and consistent logs is important when running a DPDK
application, especially when troubleshooting.
A common issue with logs is when a DPDK change do not add (or on the
contrary add too many \n) in the format string.
This issue would only get noticed when actually hitting this log
This macro is not used.
Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
lib/hash/rte_cuckoo_hash.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a
This library logtype was not initialized so its logs would end up under
the 0 logtype, iow, RTE_LOGTYPE_EAL.
Fixes: b25246beaefc ("regexdev: add core functions")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
Acked-by: Ori Kam
---
No printf!
When a dedicated log helper exists, use it.
And no usurpation please: a library should log under its logtype
(see the eventdev rx adapter update for example).
Note: the RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET macro is renamed for
consistency with the rest of eventdev (private) macros.
Cc:
Fix places leading to a log message not terminated with a newline.
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
Reviewed-by: Andrew Rybchenko
---
lib/eal/common/eal_common_options.c | 2 +-
lib/eal/linux/eal_hugepage_info.c | 2
Fix places where two newline characters may be logged.
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Stephen Hemminger
Reviewed-by: Chengwen Feng
Acked-by: Mattias Rönnblom
---
Changes since RFC v1:
- split fixes on direct calls to printf or RTE_LOG in a previous patch,
---
dr
An error log message does not need to paraphrase the DPDK documentation.
Signed-off-by: David Marchand
Acked-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/eal/linux/eal_timer.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/eal/linux/eal_timer.c b/lib/eal
There is no other log level than debug, simplify this helper.
Signed-off-by: David Marchand
Acked-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/bpf/bpf_validate.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_valida
Those error log messages don't need to span on multiple lines.
Signed-off-by: David Marchand
Acked-by: Tyler Retzlaff
Reviewed-by: Andrew Rybchenko
---
Changes since RFC v2:
- fixed format string crossing line boundaries,
---
lib/acl/tb_mem.c| 4 ++--
lib/bpf/bpf_stub.c
Add the device name as a prefix of logs associated to madvise() calls.
Signed-off-by: David Marchand
Acked-by: Stephen Hemminger
---
lib/vhost/iotlb.c | 18 +-
lib/vhost/vhost.h | 2 +-
lib/vhost/vhost_user.c | 26 +-
3 files changed, 23 insert
gcc builtin __builtin_strchr can be used as a static assertion to check
whether passed format strings contain a \n.
This can be useful to detect double \n in log messages.
Signed-off-by: David Marchand
Acked-by: Stephen Hemminger
Acked-by: Chengwen Feng
---
Changes since v4:
- fixed build with
Use RTE_LOG_LINE in existing macros that append a \n.
This will help catching unwanted newline character or multilines
in log messages.
Signed-off-by: David Marchand
Reviewed-by: Chengwen Feng
Reviewed-by: Andrew Rybchenko
---
Changes since v4:
- converted more helpers,
Changes since v3:
- fix
On Wed, Dec 20, 2023 at 4:39 PM David Marchand
wrote:
>
> gcc builtin __builtin_strchr can be used as a static assertion to check
> whether passed format strings contain a \n.
> This can be useful to detect double \n in log messages.
>
> Signed-off-by: David Marchand
> Acked-by: Stephen Hemminger
On Wed, Dec 20, 2023 at 04:08:08PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Wednesday, 20 December 2023 15.22
> >
> > In order to remove more libraries from the mandatory list, we need to
> > have support for optionally having a dependenc
On Wed, Dec 20, 2023 at 04:18:32PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Wednesday, 20 December 2023 15.22
> >
> > Remove five more libs from the mandatory build list. Only one needing
> > any special treatment is LPM, which is an opti
On Wed, 20 Dec 2023 07:45:00 +0100
Sivaprasad Tummala wrote:
> diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
> index e97273152a..22fe76eeb5 100644
> --- a/examples/qos_sched/args.c
> +++ b/examples/qos_sched/args.c
> @@ -182,10 +182,10 @@ app_parse_flow_conf(const char *conf_
Signed-off-by: Euan Bourke
---
content/roadmap/_index.md | 8
1 file changed, 8 insertions(+)
diff --git a/content/roadmap/_index.md b/content/roadmap/_index.md
index 93e590e..66ea5c6 100644
--- a/content/roadmap/_index.md
+++ b/content/roadmap/_index.md
@@ -27,12 +27,20 @@ This list is
hi
> -Original Message-
> From: Zhang, Qi Z
> Sent: Thursday, December 14, 2023 4:41 PM
> To: Yang, Qiming
> Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org
> Subject: [PATCH v2] net/ice: fix link update
>
> The ice_aq_get_link_info function is not thread-safe. However, it is possible
>
> -Original Message-
> From: Yang, Qiming
> Sent: Thursday, December 21, 2023 9:44 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH v2] net/ice: fix link update
>
> hi
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Thursday, December 1
Use rte_pktmbuf_free_bulk() API instead of looping through the packets
and freeing individually.
Signed-off-by: Anoob Joseph
Suggested-by: Stephen Hemminger
---
examples/ipsec-secgw/ipsec-secgw.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/examples/ipsec-secgw/ipsec-
On x86 platforms, max lcores are limited to 128 by default.
On AMD EPYC processors, this limit was adjusted for native
builds in the previous patch.
https://patches.dpdk.org/project/dpdk/patch/
20230925151027.558546-1-sivaprasad.tumm...@amd.com/
As agreed earlier in mailing list, this patch adjus
On 2023/12/20 11:35 PM, David Marchand wrote:
This macro is not used.
Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
lib/hash/rte_cuckoo_hash.h | 11 ---
On 2023/12/20 11:35 PM, David Marchand wrote:
This macro is not used.
Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Stephen Hemminger
Reviewed-by: Tyler Retzlaff
---
lib/hash/rte_cuckoo_hash.h | 11 ---
Using proper API to perform copy to mbox device memory region
Fixes: 02719901d50f ("common/cnxk: send link status event to VF")
Cc: sta...@dpdk.org
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/roc_dev.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/comm
Adding the has vlan check in inner headers i.e in LF layer. If
has_vlan is 0 it should be masked out while installing flow rule.
Fixes: c34ea71b878d ("common/cnxk: add NPC parsing API")
Cc: sta...@dpdk.org
Signed-off-by: Harman Kalra
---
drivers/common/cnxk/roc_npc_parse.c | 10 --
1 fi
This patch set adds an IAVF testpmd command "set tx lldp on|off" which
will register an mbuf dynfield IAVF_TX_LLDP_DYNFIELD, currently only
supported turning on.
IAVF will fill the SWTCH_UPLINK bit in the Tx context descriptor based on
the mbuf dynfield to send the LLDP packet.
For avx512, need t
This patch adds an mbuf dynfield IAVF_TX_LLDP_DYNFIELD to determine
whether or not to fill the SWTCH_UPLINK bit in the Tx context descriptor
to send LLDP packet.
Signed-off-by: Zhichao Zeng
---
drivers/net/iavf/iavf_ethdev.c | 1 +
drivers/net/iavf/iavf_rxtx.c | 16 ++--
drivers/n
This patch adds an avx512 ctx Tx path that supports context descriptor,
filling in the SWTCH_UPLINK bit based on mbuf
dynfield IAVF_TX_LLDP_DYNFIELD to support sending LLDP packet.
Signed-off-by: Zhichao Zeng
---
drivers/net/iavf/iavf_rxtx.c| 5 +
drivers/net/iavf/iavf_rxtx.h
This patch adds an IAVF testpmd command "set tx lldp on|off" which
will register an mbuf dynfield IAVF_TX_LLDP_DYNFIELD to indicate
the need to send LLDP packet. Currently, it only supports turning on.
For avx512, need to close the Tx port first, then "set tx lldp on",
and reopen the port to selec
77 matches
Mail list logo
