Those error log messages don't need to span on multiple lines.
Signed-off-by: David Marchand <david.march...@redhat.com>
Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
Reviewed-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
---
Changes since RFC v2:
- fixed format string crossing line boundaries,
---
lib/acl/tb_mem.c | 4 ++--
lib/bpf/bpf_stub.c | 6 ++----
lib/eal/windows/eal_hugepages.c | 4 ++--
lib/ethdev/rte_ethdev.c | 12 ++++--------
4 files changed, 10 insertions(+), 16 deletions(-)
diff --git a/lib/acl/tb_mem.c b/lib/acl/tb_mem.c
index 6a9d96aaed..4ee65b23da 100644
--- a/lib/acl/tb_mem.c
+++ b/lib/acl/tb_mem.c
@@ -26,8 +26,8 @@ tb_pool(struct tb_mem_pool *pool, size_t sz)
size = sz + pool->alignment - 1;
block = calloc(1, size + sizeof(*pool->block));
if (block == NULL) {
- RTE_LOG(ERR, ACL, "%s(%zu)\n failed, currently allocated "
- "by pool: %zu bytes\n", __func__, sz, pool->alloc);
+ RTE_LOG(ERR, ACL, "%s(%zu) failed, currently allocated by pool:
%zu bytes\n",
+ __func__, sz, pool->alloc);
siglongjmp(pool->fail, -ENOMEM);
return NULL;
}
diff --git a/lib/bpf/bpf_stub.c b/lib/bpf/bpf_stub.c
index ebc5343896..83c2203622 100644
--- a/lib/bpf/bpf_stub.c
+++ b/lib/bpf/bpf_stub.c
@@ -19,8 +19,7 @@ rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char
*fname,
return NULL;
}
- RTE_BPF_LOG(ERR, "%s() is not supported with current config\n"
- "rebuild with libelf installed\n",
+ RTE_BPF_LOG(ERR, "%s() is not supported, rebuild with libelf
installed\n",
__func__);
rte_errno = ENOTSUP;
return NULL;
@@ -36,8 +35,7 @@ rte_bpf_convert(const struct bpf_program *prog)
return NULL;
}
- RTE_BPF_LOG(ERR, "%s() is not supported with current config\n"
- "rebuild with libpcap installed\n",
+ RTE_BPF_LOG(ERR, "%s() is not supported, rebuild with libpcap
installed\n",
__func__);
rte_errno = ENOTSUP;
return NULL;
diff --git a/lib/eal/windows/eal_hugepages.c b/lib/eal/windows/eal_hugepages.c
index b007dceb39..775c67e4c4 100644
--- a/lib/eal/windows/eal_hugepages.c
+++ b/lib/eal/windows/eal_hugepages.c
@@ -105,8 +105,8 @@ int
eal_hugepage_info_init(void)
{
if (hugepage_claim_privilege() < 0) {
- RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n"
- "Verify that large-page support privilege is assigned to the
current user\n");
+ RTE_LOG(ERR, EAL,
+ "Cannot claim hugepage privilege, check large-page
support privilege\n");
return -1;
}
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index b9d99ece15..9dd0efa9d8 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6709,8 +6709,7 @@ rte_eth_ip_reassembly_capability_get(uint16_t port_id,
if (dev->data->dev_configured == 0) {
RTE_ETHDEV_LOG(ERR,
- "Device with port_id=%u is not configured.\n"
- "Cannot get IP reassembly capability\n",
+ "port_id=%u is not configured, cannot get IP reassembly
capability\n",
port_id);
return -EINVAL;
}
@@ -6745,8 +6744,7 @@ rte_eth_ip_reassembly_conf_get(uint16_t port_id,
if (dev->data->dev_configured == 0) {
RTE_ETHDEV_LOG(ERR,
- "Device with port_id=%u is not configured.\n"
- "Cannot get IP reassembly configuration\n",
+ "port_id=%u is not configured, cannot get IP reassembly
configuration\n",
port_id);
return -EINVAL;
}
@@ -6779,16 +6777,14 @@ rte_eth_ip_reassembly_conf_set(uint16_t port_id,
if (dev->data->dev_configured == 0) {
RTE_ETHDEV_LOG(ERR,
- "Device with port_id=%u is not configured.\n"
- "Cannot set IP reassembly configuration\n",
+ "port_id=%u is not configured, cannot set IP reassembly
configuration\n",
port_id);
return -EINVAL;
}
if (dev->data->dev_started != 0) {
RTE_ETHDEV_LOG(ERR,
- "Device with port_id=%u started,\n"
- "cannot configure IP reassembly params.\n",
+ "port_id=%u is started, cannot configure IP reassembly
params.\n",
port_id);
return -EINVAL;
}
--
2.43.0
