Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-05 Thread Konstantin Ananyev
03/03/2023 16:51, Ferruh Yigit пишет: On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a r

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-05 Thread Konstantin Ananyev
In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added dela

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-05 Thread Konstantin Ananyev
03/03/2023 01:38, fengchengwen пишет: On 2023/3/2 20:30, Konstantin Ananyev wrote: Use rte_eth_fp_ops_setup() instead of directly manipulating rte_eth_fp_ops variable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/bnxt/bnxt_cpr.c| 5 + drivers/net/bnxt/bnxt_eth

Re: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-03-05 Thread Konstantin Ananyev
Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performance.

Re: [PATCH] lib/bpf: Rename 'bpf_validate' to avoid potential conflict with libpcap

2023-03-05 Thread Stephen Hemminger
On Fri, 3 Mar 2023 21:56:54 +0800 Martzki wrote: > The library libpcap has their function 'bpf_validate' either so > there would be a multiple definition issue when linking with > librte_bpf.a and libpcap.a staticly. > > You can reproduce this issue by 'meson build -Dprefer_static=true > -Denab

Re: [PATCH] lib/bpf: Rename 'bpf_validate' to avoid potential conflict with libpcap

2023-03-05 Thread Stephen Hemminger
On Sun, 5 Mar 2023 09:16:55 -0800 Stephen Hemminger wrote: > On Fri, 3 Mar 2023 21:56:54 +0800 > Martzki wrote: > > > The library libpcap has their function 'bpf_validate' either so > > there would be a multiple definition issue when linking with > > librte_bpf.a and libpcap.a staticly. > > >

[PATCH] app/test: fix data length of each packet segment

2023-03-05 Thread Zhuobin Huang
Assign correct data length to each segments according to the given pkt_len and nb_pkt_segs, instead of using pkt_len as the data_len of every packet segment Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes") Cc: cunming.li...@intel.com Signed-off-by: Zhuobin Huang ---

[PATCH v2] app/test: fix data length of each packet segment

2023-03-05 Thread Zhuobin Huang
v2: * fix code format Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes") Cc: cunming.li...@intel.com Signed-off-by: Zhuobin Huang --- ...x-data-length-of-each-packet-segment.patch | 54 +++ app/test/packet_burst_generator.c | 2 +- 2 files

[PATCH] app/test: fix data length of each packet segment

2023-03-05 Thread Zhuobin Huang
Assign correct data length to each segments according to the given pkt_len and nb_pkt_segs, instead of using pkt_len as the data_len of every packet segment Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes") Cc: cunming.li...@intel.com Signed-off-by: Zhuobin Huang ---

[PATCH] app/test: fix data length of each packet segment

2023-03-05 Thread Zhuobin Huang
Assign correct data length to each segments according to the given pkt_len and nb_pkt_segs, instead of using pkt_len as the data_len of every packet segment Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes") Cc: cunming.li...@intel.com Signed-off-by: Zhuobin Huang ---

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-05 Thread fengchengwen
On 2023/3/4 0:51, Ferruh Yigit wrote: > On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: >> >>> In the proactive error handling mode, the PMD will set the data path >>> pointers to dummy functions and then try recovery, in this period the >>> application may still invoking data path API. This will i

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-05 Thread fengchengwen
On 2023/3/4 1:19, Ferruh Yigit wrote: > On 2/26/2023 5:22 PM, Konstantin Ananyev wrote: >> If ethdev enqueue or dequeue function is called during eth_dev_fp_ops_setup(), it may get pre-empted after setting the function pointers, but before setting the pointer

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-05 Thread Ajit Khaparde
On Sun, Mar 5, 2023 at 7:58 AM Konstantin Ananyev wrote: > > 03/03/2023 01:38, fengchengwen пишет: > > On 2023/3/2 20:30, Konstantin Ananyev wrote: > >> > >>> Use rte_eth_fp_ops_setup() instead of directly manipulating > >>> rte_eth_fp_ops variable. > >>> > >>> Cc: sta...@dpdk.org > >>> > >>> Sign

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-05 Thread Ruifeng Wang
> -Original Message- > From: Ferruh Yigit > Sent: Saturday, March 4, 2023 1:19 AM > To: Konstantin Ananyev ; dev@dpdk.org; > fengchengwen > ; Konstantin Ananyev > ; Honnappa > Nagarahalli ; Stephen Hemminger > ; > Ruifeng Wang ; Ajit Khaparde > (ajit.khapa...@broadcom.com) > > Subject

RE: [PATCH v2] net/virtio: deduce IP length for Virtio TSO checksum

2023-03-05 Thread Xia, Chenbo
Hi Boleslav, The change seems good, but patchwork is complaining about lack of .mailmap change. http://mails.dpdk.org/archives/test-report/2023-March/363061.html Guess this is your first patch? So you need to add name and email in mailmap file. Thanks, Chenbo > -Original Message- > F

Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq

2023-03-05 Thread Jie Hai
Hi, Thomas, A gentle ping~ Since this patch has been acked by David Hunt, is there anything more I can do to push the process forward? Thanks, Jie Hai On 2023/2/22 17:46, Hunt, David wrote: On 22/02/2023 02:13, Jie Hai wrote: Hi, David Hunt, Kindly ping. Could you please take a look at this

[PATCH] app/test: fix data length of each packet segment

2023-03-05 Thread Zhuobin Huang
Assign correct data length to each segments according to the given pkt_len and nb_pkt_segs, instead of using pkt_len as the data_len of every packet segment Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes") Cc: cunming.li...@intel.com Signed-off-by: Zhuobin Huang ---

RE: [PATCH v2] net/i40e: don't check link status on device start

2023-03-05 Thread Su, Simei
> -Original Message- > From: David Marchand > Sent: Tuesday, December 13, 2022 5:19 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Yuying ; Xing, Beilei > ; Zhang, Qi Z ; Dapeng Yu > ; Wenxuan Wu ; Wang, > Jie1X > Subject: [PATCH v2] net/i40e: don't check link status on device sta

Re: MAC address set requires decision

2023-03-05 Thread lihuisong (C)
在 2023/2/23 22:32, Bruce Richardson 写道: On Thu, Feb 23, 2023 at 02:18:59PM +, Ferruh Yigit wrote: On 2/23/2023 4:32 AM, Hemant Agrawal wrote: On 22-Feb-23 11:25 PM, Honnappa Nagarahalli wrote: -Original Message- From: Richardson, Bruce Sent: Thursday, February 16, 2023 9:05 AM

RE: [PATCH] net/nfp: write link speed to control BAR

2023-03-05 Thread Chaoyong He
> On 2/21/2023 6:29 AM, Chaoyong He wrote: > > From: James Hershaw > > > > Due to changes in the firmware for NFPs, firmware will no longer write > > the link speed of a port to the control BAR. In line with the > > behaviour of the kernel NFP driver, this is now handled by the PMD by > > reading

[PATCH] log: add timestamp for log

2023-03-05 Thread luzhipeng
From: zhipeng Lu add timestamp for log Signed-off-by: zhipeng Lu --- lib/eal/common/eal_common_log.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index bd7b188ceb..2b481116b6 1006

[PATCH] log: add timestamp for log

2023-03-05 Thread luzhipeng
From: zhipeng Lu add timestamp for log Signed-off-by: zhipeng Lu --- lib/eal/common/eal_common_log.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index bd7b188ceb..2b481116b6 1006