Re: [PATCH v1] maintainers: add explicit maintainer for some bbdev PMDs

2022-03-09 Thread David Marchand
On Wed, Mar 9, 2022 at 12:23 AM Thomas Monjalon wrote: > > 03/03/2022 19:51, Nicolas Chautru: > > These were implicit from DPDK script but adding > > separate reference to make it explicit > > > > Signed-off-by: Nicolas Chautru > > --- > > MAINTAINERS | 4 > > 1 file changed, 4 insertions(+

RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-09 Thread Slava Ovsiienko
Hi, Thinh Thank you for the patch, the code looks OK to me, but commit message is not compliant: - it should contain "fix" keyword in the title, like this: "net/mlx5: fix CPU socket ID for Rx queue creation" - could you, please, make problem description less personal and less wordy? "The defa

[PATCH v2] doc: fix telemetry example for cryptodev

2022-03-09 Thread Sean Morrissey
Blank line added to the final telemetry example for the cryptography device library as to fix the example rendering. Fixes: 1c559ee8469 ("cryptodev: add telemetry endpoint for capabilities") Cc: sta...@dpdk.org Signed-off-by: Sean Morrissey --- doc/guides/prog_guide/cryptodev_lib.rst | 1 + 1 f

[PATCH] net/mlx5: fix push VLAN action validation

2022-03-09 Thread Dariusz Sosnowski
Flow domain and direction was validated when OF_PUSH_VLAN action appears in flow actions. Flow was rejected whenever this action: - was used in NIC domain, in ingress direction; - was used in FDB domain, in ingress direction, on ConnectX-5. This validation logic rejected a valid case when the OF_

RE: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-09 Thread Ori Kam
Hi Lihusiong, > -Original Message- > From: lihuisong (C) > Sent: Wednesday, March 9, 2022 10:03 AM > Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior > > > 在 2022/3/3 10:47, lihuisong (C) 写道: > > Hi, Ori, > > > > 在 2022/3/2 22:07, Ori Kam 写道: > >> Hi Lihuisong, >

RE: [PATCH v2] app/testpmd : fix testpmd quit error

2022-03-09 Thread Wu, WenxuanX
> -Original Message- > From: Yigit, Ferruh > Sent: 2022年3月5日 0:19 > To: Wu, WenxuanX ; Yang, Qiming > ; Zhang, Qi Z ; Li, Xiaoyun > ; Singh, Aman Deep ; > Zhang, Yuying > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] app/testpmd : fix testpmd quit error > > On 3/4/2022 2:37 AM, wenxuanx..

[PATCH] net/mlx5: fix the sample flow failure on the trusted device

2022-03-09 Thread Jiawei Wang
The flow with sample action will be split into two sub flows, and a tag action was added implicitly in the sample prefix sub flow, the reserved metadata regC index was used for this tag action. The reserved metadata regC was shared with metering action, for Connect-5 trusted device(VF/SF), the res

RE: [PATCH v3 1/2] app/testpmd: do not poll stopped queues

2022-03-09 Thread Dmitry Kozlyuk
> Calling Rx/Tx functions on a stopped queue is not supported. > Do not run packet forwarding for streams that use stopped queues. > > Each stream has a read-only "disabled" field, > so that lcore function can skip such streams. > Forwarding engines can set this field > using a new "stream_init" c

[PATCH] crypto/ipsec_mb: fix GMAC parameters setting

2022-03-09 Thread Pablo de Lara
AES-GMAC requires plaintext length to be 0 when using AES-GCM, so only AAD data is used. Fixes: a501609ea646 ("crypto/ipsec_mb: fix length and offset settings") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 16 ++

Re: [PATCH v2 2/2] build: hide local symbols in shared libraries

2022-03-09 Thread Kevin Traynor
Hi Thomas, On 08/03/2022 14:24, Thomas Monjalon wrote: The symbols which are not listed in the version script are exported by default. Adding a local section with a wildcard make non-listed functions and variables as hidden, as it should be in all version.map files. These are the changes done i

RE: [PATCH] crypto/ipsec_mb: fix GMAC parameters setting

2022-03-09 Thread Zhang, Roy Fan
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, March 9, 2022 10:45 AM > To: Nicolau, Radu ; Buckley, Daniel M > ; Zhang, Roy Fan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] crypto/ipsec_mb: fix GMAC parameters setting > > AES-GM

[PATCH] maintainers: update for KNI, UIO and pcap

2022-03-09 Thread Ferruh Yigit
Won't able to allocate time on these components, resigning from maintaining them. Signed-off-by: Ferruh Yigit --- Cc: David Marchand --- MAINTAINERS | 4 1 file changed, 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ba4c8d67c43..fdea1c623f5f 100644 --- a/MAINTAINERS +++ b/M

Re: [PATCH] crypto/ipsec_mb: fix GMAC parameters setting

2022-03-09 Thread Nicolau, Radu
On 3/9/2022 10:45 AM, Pablo de Lara wrote: AES-GMAC requires plaintext length to be 0 when using AES-GCM, so only AAD data is used. Fixes: a501609ea646 ("crypto/ipsec_mb: fix length and offset settings") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara ---

RE: [PATCH] app/testpmd: register metadata dynfield on modify field

2022-03-09 Thread Dariusz Sosnowski
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 3, 2022 13:21 > To: Dariusz Sosnowski ; Ori Kam > ; Xiaoyun Li ; Aman Singh > ; Yuying Zhang > Cc: dev@dpdk.org; Slava Ovsiienko > Subject: Re: [PATCH] app/testpmd: register metadata dynfield on modify > field

[PATCH v1] net/mlx5: disallow multiple ASO actions in a single flow

2022-03-09 Thread Rongwei Liu
For now, only one ASO action is supported in a single flow. Flow with more than one ASO action should be rejected in the validation stage. Flow with action non-shared AGE and COUNT together should be treated as non-ASO because AGE will fall back to use HW counter, not ASO hit object. Group 0 will

RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value

2022-03-09 Thread Ji, Kai
> > -Original Message- > > From: Bronowski, PiotrX > > Sent: Monday, March 7, 2022 3:33 PM > > To: dev@dpdk.org > > Cc: Zhang, Roy Fan ; tho...@monjalon.net; > > gak...@marvell.com; Yigit, Ferruh ; Doherty, > > Declan ; Bronowski, PiotrX > > ; sta...@dpdk.org > > Subject: [PATCH v2] crypto

[PATCH] lib/power: power pmd errata with RTM and gcc-9

2022-03-09 Thread David Hunt
An errata exists where users may see reduced power savings when using PMD Power Management. This issue occurs when compiling DPDK applications with gcc-9 on platforms with TSX enabled. In rte_power_monitor_multi(), the function may return without successfully starting the RTM transaction (the _xbeg

DTS Improvement Working Group Minutes (March 2)

2022-03-09 Thread Owen Hilyard
Attendees - Owen Hilyard - Honnappa Nagarahalli - Lijuan Tu - Lincoln Lavoie Agenda - Additions to the agenda - Review/Carry forward pending action items - Review DTS DPDK Modifications excel sheet - Merging DTS into DPDK - Review ad

RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value

2022-03-09 Thread Zhang, Roy Fan
Hi Piotr, > -Original Message- > From: Zhang, Roy Fan > Sent: Monday, March 7, 2022 4:27 PM > To: Bronowski, PiotrX ; dev@dpdk.org > Cc: tho...@monjalon.net; gak...@marvell.com; Yigit, Ferruh > ; Doherty, Declan ; > sta...@dpdk.org > Subject: RE: [PATCH v2] crypto/ipsec_mb: fix usage of u

RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value

2022-03-09 Thread Power, Ciara
Hi Piotr, >-Original Message- >From: Zhang, Roy Fan >Sent: Wednesday 9 March 2022 14:35 >To: Zhang, Roy Fan ; Bronowski, PiotrX >; dev@dpdk.org >Cc: tho...@monjalon.net; gak...@marvell.com; Yigit, Ferruh >; Doherty, Declan ; >sta...@dpdk.org; Power, Ciara >Subject: RE: [PATCH v2] crypto/

[PATCH v3] crypto/ipsec_mb: fix coverity issue

2022-03-09 Thread Piotr Bronowski
This patch removes coverity defect CID 375828: Untrusted value as argument (TAINTED_SCALAR) Coverity issue: CID 375828 Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") Signed-off-by: Piotr Bronowski Cc: sta...@dpdk.org --- v3: use a different logic to check digest length --- driver

RE: [PATCH v2] doc: fix telemetry example for cryptodev

2022-03-09 Thread Power, Ciara
Hi Sean, >-Original Message- >From: Sean Morrissey >Sent: Wednesday 9 March 2022 09:33 >Cc: dev@dpdk.org; Morrissey, Sean ; >sta...@dpdk.org >Subject: [PATCH v2] doc: fix telemetry example for cryptodev > >Blank line added to the final telemetry example for the cryptography device >librar

RE: [EXT] Re: [PATCH] examples/l3fwd: resolve stack buffer overflow issue

2022-03-09 Thread Rahul Bhansali
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 8, 2022 4:51 PM > To: Rahul Bhansali > Cc: dev@dpdk.org; david.march...@redhat.com; Conor Walsh > > Subject: [EXT] Re: [PATCH] examples/l3fwd: resolve stack buffer overflow issue > > External Email > >

[PATCH v1] gpu/cuda: set unused gdrcopy functions arguments

2022-03-09 Thread eagostini
From: Elena Agostini Without enabling gdrcopy, dpdk build has warnings about unused gdrcopy functions input parameters. This patch set them to __rte_unused . Fixes: 24c7759 ("gpu/cuda: map GPU memory with GDRCopy") Signed-off-by: Elena Agostini --- drivers/gpu/cuda/gdrcopy.c | 4 ++-- 1 file

RE: [PATCH] examples/l3fwd: resolve stack buffer overflow issue

2022-03-09 Thread Ananyev, Konstantin
> This patch fixes the stack buffer overflow error reported > from AddressSanitizer. > Function send_packetsx4() tries to access out of bound data > from rte_mbuf and fill it into TX buffer even in the case > where no pending packets (len = 0). > Performance impact:- No > > ASAN error report:- > =

FW: [dpdk] Patch notification: 2 patches updated

2022-03-09 Thread Honnappa Nagarahalli
Hi Christian/Luca, It was discussed in the mailing list to merge this into stable releases, however the 'Cc' to stable was missing. Can you please make sure this is going into stable releases? Kevin is adding it to 21.11 LTS. Thanks, Honnappa -Original Message- From: DPDK patchw

Re: FW: [dpdk] Patch notification: 2 patches updated

2022-03-09 Thread Kevin Traynor
On 09/03/2022 16:36, Honnappa Nagarahalli wrote: Hi Christian/Luca, It was discussed in the mailing list to merge this into stable releases, however the 'Cc' to stable was missing. Can you please make sure this is going into stable releases? Kevin is adding it to 21.11 LTS. In case i

Re: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-09 Thread Thinh Tran
Hi, On 3/9/2022 2:50 AM, Slava Ovsiienko wrote: Hi, Thinh Thank you for the patch, the code looks OK to me, but commit message is not compliant: - it should contain "fix" keyword in the title, like this: "net/mlx5: fix CPU socket ID for Rx queue creation" - could you, please, make problem d

[PATCH v4] crypto/ipsec_mb: fix coverity issue

2022-03-09 Thread Piotr Bronowski
This patch removes coverity defect CID 375828: Untrusted value as argument (TAINTED_SCALAR) Coverity issue: CID 375828 Fixes: ceb863938708 ("crypto/aesni_gcm: support all truncated digest sizes") Signed-off-by: Piotr Bronowski Cc: sta...@dpdk.org --- v4: commit message corrected --- drivers/

Re: [PATCH v2 2/2] build: hide local symbols in shared libraries

2022-03-09 Thread Thomas Monjalon
09/03/2022 11:58, Kevin Traynor: > Hi Thomas, > > On 08/03/2022 14:24, Thomas Monjalon wrote: > > The symbols which are not listed in the version script > > are exported by default. > > Adding a local section with a wildcard make non-listed functions > > and variables as hidden, as it should be in

RE: [PATCH] crypto/ipsec_mb: fix GMAC parameters setting

2022-03-09 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, March 9, 2022 11:01 AM > To: De Lara Guarch, Pablo ; Nicolau, Radu > ; Buckley, Daniel M > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] crypto/ipsec_mb: fix GMAC parameters setting > > > -Original

Re: [EXT] Re: [PATCH] examples/l3fwd: resolve stack buffer overflow issue

2022-03-09 Thread Thomas Monjalon
09/03/2022 16:24, Rahul Bhansali: > Hi Thomas, > > From: Thomas Monjalon > > 11/01/2022 13:50, Rahul Bhansali: > > > /* copy rest of the packets into the TX buffer. */ > > > len = num - n; > > > + if (len == 0) > > > + goto exit; > > > + > > > > I don'

RE: [PATCH] net/mlx5: fix the port match in sample flow

2022-03-09 Thread Slava Ovsiienko
> -Original Message- > From: Jiawei(Jonny) Wang > Sent: Monday, March 7, 2022 4:11 > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the port match in sample flow > > If there are an explicit port mat

[PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation

2022-03-09 Thread Thinh Tran
The default CPU socket ID was used while creating the Rx queue and this caused creation failure in case if hardware was not resided on the default socket. The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before calling the mlx5_rxq_create_devx_rq_resources() which eventually calls ml

[PATCH] net/af_xdp: fix custom program loading with multiple queues

2022-03-09 Thread Junxiao Shi
When the PMD is configured to load a custom XDP program, it sets XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from loading its default XDP program. However, when queue_count is set to greater than 1, this flag is only set for the first XSK socket but not for subsequent XSK sockets. Th

[PATCH] app/test-regex: fix incorrect number of matches

2022-03-09 Thread Gerry Gribbon
Depending on number of jobs specified on command line, part of the data buffer may not get searched, resulting in incorrect number of matches being reported. Additional change to ensure the "All Matches" summary outputs the correct match start locations in the supplied data buffer. Fixes: de06137

RE: [PATCH] net/cnxk: fix error when compiled for x86

2022-03-09 Thread Jiang, YuX
Hi maintainers, Who can give acked-by for this patch? May I know this patch can be merged into 22.03 or not? > -Original Message- > From: Rakesh Kudurumalla > Sent: 2022年3月4日 22:24 > To: Nithin Dabilpuram ; Kiran Kumar K > ; Sunil Kumar Kori ; Satha > Rao > Cc: dev@dpdk.org; jer...@marv

[PATCH] net/mlx5: fix the implicit tag insertion in sample flow

2022-03-09 Thread Jiawei Wang
The flow with sample action was split into two sub-flows, and the implicit tag action with unique id was added in the prefix sub-flow, the suffix sub-flow used the tag item to match with that unique id, and the implicit set tag action was inserted next to the sample action. While there's either PU

Re: [PATCH] usertools: add check for IOMMU support in dpdk-devbind

2022-03-09 Thread Fidaullah Noonari
I agree with your suggestion. I would add new flag for noiommu and submit v2 for the patch. On Tue, Mar 8, 2022 at 5:57 PM Bruce Richardson wrote: > > On Tue, Mar 08, 2022 at 05:49:01PM +0500, Fidaullah Noonari wrote: > > binding with vfio driver, when IOMMU is disabled, causes program to crash.

[PATCH] doc: mention MPRQ incompatibility with external buffers

2022-03-09 Thread Alexander Kozyrev
Multi-Packet Rx queue uses PMD-managed buffers to store packets. These buffers are externally attached to user mbufs. This conflicts with the feature that allows using user-managed externally attached buffers in an application. Add the corresponding limitation to MLX5 documentation that MPRQ and ex

[PATCH] app/testpmd: fix flex item input link parsing

2022-03-09 Thread Gregory Etelson
Testpmd reads flex item configuration from a JSON file. Flex item input link description is stored in testpmd flow item format. For example, `eth type is 0x0800`. The item description is placed into a general testpmd CLI flow rule command template and parsed to convert string into flow item object.

[RFC,v3 0/2] vhost: support async dequeue data path

2022-03-09 Thread xuan . ding
From: Xuan Ding The presence of asynchronous path allows applications to offload memory copies to DMA engine, so as to save CPU cycles and improve the copy performance. This patch set is a draft implementation for split ring in vhost async dequeue data path. The code is based on latest enqueue ch

[RFC,v3 1/2] vhost: support async dequeue for split ring

2022-03-09 Thread xuan . ding
From: Xuan Ding This patch implements asynchronous dequeue data path for vhost split ring, with dmadev library integrated. Signed-off-by: Xuan Ding Signed-off-by: Yuan Wang --- lib/vhost/rte_vhost_async.h | 37 ++- lib/vhost/version.map | 1 + lib/vhost/vhost.h | 1 + lib

[RFC,v3 2/2] examples/vhost: support async dequeue data path

2022-03-09 Thread xuan . ding
From: Xuan Ding This patch adds the use case for async dequeue API. Vswitch can leverage DMA device to accelerate vhost async dequeue path. Signed-off-by: Wenwu Ma Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding --- doc/guides/sample_app_ug/vhost.rst | 9 +- examples/vhost/main.c

RE: [PATCH v2 2/2] app/testpmd:fix testpmd quit failure

2022-03-09 Thread Wu, WenxuanX
> -Original Message- > From: Wu, WenxuanX > Sent: 2022年3月9日 11:07 > To: Yigit, Ferruh ; Li, Xiaoyun > ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2 2/2] app/testpmd:fix testpmd quit failure > > > > > -Original Message- > > From: Yigit, Ferruh > > Sent: 2022年

[PATCH] eal/windows: fix data race when creating threads

2022-03-09 Thread Tyler Retzlaff
create lcore worker threads suspended and then subsequently resume to allow &lcore_config[i].thread_id be stored before eal_thread_loop execution. Fixes: 53ffd9f080fc ("eal/windows: add minimum viable code") Cc: anand.ra...@intel.com Cc: sta...@dpdk.org Signed-off-by: Tyler Retzlaff --- lib/eal

Re: [PATCH 1/3] net/qede: fix Tx callback completion routine

2022-03-09 Thread Jerin Jacob
On Fri, Mar 4, 2022 at 5:38 PM Devendra Singh Rawat wrote: > > Tx completion routine was first incrementing no. of free slots in Tx > ring and then freeing corresponding mbufs in bulk. In some situations > no. of mbufs freed were less than no. of Tx ring slots freed. This > caused TX ring to get i