Hi,
On 3/9/2022 2:50 AM, Slava Ovsiienko wrote:
Hi, Thinh
Thank you for the patch, the code looks OK to me, but commit message is not
compliant:
- it should contain "fix" keyword in the title, like this:
"net/mlx5: fix CPU socket ID for Rx queue creation"
- could you, please, make problem description less personal and less wordy?
"The default CPU socket ID was used while creating the Rx queue and this
caused
creation failure in case if hardware was not resided on the default socket.
The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before
calling the mlx5_rxq_create_devx_rq_resources() which eventually calls
mlx5_devx_rq_create() with correct CPU socket ID."
- please add tags:
Cc: sta...@dpdk.org
Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
With best regards,
Slava
I'll resubmit the patch with suggestions above.
Regards,
Thinh
-----Original Message-----
From: Raslan Darawsheh <rasl...@nvidia.com>
Sent: Tuesday, March 8, 2022 14:25
To: Dmitry Kozlyuk <dkozl...@nvidia.com>
Cc: Thinh Tran <thin...@linux.vnet.ibm.com>; dev@dpdk.org;
d...@linux.vnet.ibm.com
Subject: RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl
-----Original Message-----
From: Dmitry Kozlyuk <dkozl...@nvidia.com>
Sent: Tuesday, March 8, 2022 2:23 PM
To: Raslan Darawsheh <rasl...@nvidia.com>
Cc: Thinh Tran <thin...@linux.vnet.ibm.com>; dev@dpdk.org;
d...@linux.vnet.ibm.com
Subject: Re: [PATCH] net/mlx5: set correct CPU socket ID for
mlx5_rxq_ctrl
Hi Raslan,
Missing:
Fixes tag:
Fixes: 5ceb3a02b000 ("net/mlx5: move Rx queue DevX resource")
Cc: xuemi...@nvidia.com
I believe the bug originates from my earlier commit, not Xueming's one:
Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
Yes I think you are correct, my mistake 😊
Kindest regards,
Raslan Darawsheh
