[PATCH 1/8] common/cnxk: fix shift offset for tl3 length disable

2021-12-09 Thread Nithin Dabilpuram
Fix shift offset for length disable flag in NIXX_AF_TL3X_SHAPE register to be 24 instead of zero similar to other level SHAPE registers. Also mask unused bits in adjust value. Fixes: 0885429c3028 ("common/cnxk: add NIX TM hierarchy enable/disable") Signed-off-by: Nithin Dabilpuram Signed-off-by:

[PATCH 2/8] common/cnxk: use for loop in shaper profiles cleanup

2021-12-09 Thread Nithin Dabilpuram
From: Gowrishankar Muthukrishnan In shaper profiles cleanup, KW reports infinite loop although existing loop condition is alright. False positive may be due to tqh_first not checked in loop, hence switching to FOREACH_SAFE to make KW happy. Signed-off-by: Gowrishankar Muthukrishnan Signed-off-b

[PATCH 3/8] common/cnxk: change order of frag sizes and infos

2021-12-09 Thread Nithin Dabilpuram
Change the order of frag sizes and infos to match HW implementation. Signed-off-by: Nithin Dabilpuram Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/hw/cpt.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/comm

[PATCH 4/8] common/cnxk: reset stale values on error debug registers

2021-12-09 Thread Nithin Dabilpuram
From: Harman Kalra LF's error debug registers like NIX_LF_SQ_OP_ERR_DBG, NIX_LF_MNQ_ERR_DBG, NIX_LF_SEND_ERR_DBG captures debug info for an error detected during LMT operation or meta enqueue or after meta enqueue granted respectively. HW sets a valid bit when info is captured and SW is expected

[PATCH 5/8] common/cnxk: always use single qint with NIX

2021-12-09 Thread Nithin Dabilpuram
From: Harman Kalra An errata exists whereby, in certain cases NIX may use an incorrect QINT_IDX for SQ interrupts. As a result, the interrupt may not be delivered to software, or may not be associated with the correct SQ. When NIX uses an incorrect QINT_IDX : 1. NIX_LF_QINT(0..63)_CNT[COUNT] will

[PATCH 6/8] common/cnxk: handle issues from static analysis

2021-12-09 Thread Nithin Dabilpuram
From: Gowrishankar Muthukrishnan Handle issues reported by static analysis tool such as null pointer dereferences, variable initialization, etc. Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.c | 7 +++-- drivers/common/cnxk/r

[PATCH 7/8] net/cnxk: improve inbound inline error handling for cn9k

2021-12-09 Thread Nithin Dabilpuram
Improve inbound inline error handling for CN9K in terms of packet delivered to application for different kinds of errors. Also update udp ports to be used for UDP encapsulation support. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/cnxk_security.c | 6 + drivers/common/cnxk/roc_

[PATCH 8/8] net/cnxk: synchronize inline session create and destroy

2021-12-09 Thread Nithin Dabilpuram
Synchronize inline session create and destroy using spinlock. Also move security related error prints outside the spinlock. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev_sec.c | 35 --- drivers/net/cnxk/cn9k_ethdev_sec.c | 34

RE: 20.11.4 patches review and test

2021-12-09 Thread Jiang, YuX
> -Original Message- > From: Xueming Li > Sent: Tuesday, December 7, 2021 12:15 AM > To: sta...@dpdk.org > Cc: xuemi...@nvidia.com; dev@dpdk.org; Abhishek Marathe > ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Govindharajan, Hariprasad > ; Hemant Agrawal > ; Stokes, Ian ; Je

[PATCH] net/ice: fix error forwarding IPv6 VXLAN packet

2021-12-09 Thread Kevin Liu
In ice_txd_enable_offload(), when set tunnel packet Tx checksum offload enable, td_offset should be set with outer l2/l3 len instead of inner l2/l3 len. This patch fix the bug that the checksum engine can forward tunnle packets. Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") Signed-

[PATCH] net/ice: fix error forwarding IPv6 VXLAN packet

2021-12-09 Thread Kevin Liu
In ice_txd_enable_offload(), when set tunnel packet Tx checksum offload enable, td_offset should be set with outer l2/l3 len instead of inner l2/l3 len. This patch fix the bug that the checksum engine can forward tunnle packets. Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") Signed-

Re: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs

2021-12-09 Thread Kevin Traynor
On 08/12/2021 15:40, Matan Azrad wrote: Hi Ferruh Thanks for the review. Please see inside some clarifications. From: Ferruh Yigit On 12/8/2021 12:52 PM, Michael Baum wrote: On 12/07/2021 3:41 PM, ferruh.yi...@intel.com wrote: On 11/23/2021 6:38 PM, michae...@nvidia.com wrote: From: Mich

[Bug 898] Memory leak during interprocess communication.

2021-12-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=898 Bug ID: 898 Summary: Memory leak during interprocess communication. Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2021-12-09 Thread Aaron Conole
Jerin Jacob writes: > On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: >> >> Even though test_interrupts.c can compile on Windows, skip interrupt >> tests for now since majority of eal_interrupt on Windows are stubs. >> Will remove the skip after interrupt being fully enabled on Windows. >> >> Si

testpmd behavior with stopped queues

2021-12-09 Thread Dmitry Kozlyuk
Hello, There are testpmd commands to start/stop RxQ/TxQ: "port 1 rxq 0 stop", "port 1 txq 0 start", etc. IIUC, when a queue is stopped, testpmd should ignore it. Currently, it doesn't and tries to use the stopped queue. If a RxQ is stopped, nothing will be send to the paired TxQ. If a TxQ is stopp

19.11.11 patches review and test

2021-12-09 Thread christian . ehrhardt
Hi all, Here is a list of patches targeted for stable release 19.11.11. The planned date for the final release is 7th January 2021. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported va

Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2021-12-09 Thread Bruce Richardson
On Thu, Dec 09, 2021 at 08:15:01AM -0500, Aaron Conole wrote: > Jerin Jacob writes: > > > On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: > >> > >> Even though test_interrupts.c can compile on Windows, skip interrupt > >> tests for now since majority of eal_interrupt on Windows are stubs. > >> W

RE: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2021-12-09 Thread Richardson, Bruce
> -Original Message- > From: Bruce Richardson > Sent: Thursday, December 9, 2021 4:17 PM > To: Aaron Conole > Cc: Jerin Jacob ; Jie Zhou > ; dpdk-dev ; Dmitry Kozlyuk > ; roret...@microsoft.com; Narcisa Ana Maria > Vasile ; Dmitry Malloy (MESHCHANINOV) > ; Kadam, Pallavi ; > tal...@nvid

[PATCH v1] app/testpmd: fix dereference before null check

2021-12-09 Thread Sean Morrissey
Assign 'left' variable only after null check on 'size' as function returns if 'size' is null. Coverity issue: 374381 Fixes: 169a9fed1f4 ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Cc: wei.zh...@intel.com Signed-off-by: Sean Morrissey --- app/test-pmd/cmdline_

Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2021-12-09 Thread Bruce Richardson
On Thu, Dec 09, 2021 at 04:17:08PM +, Bruce Richardson wrote: > On Thu, Dec 09, 2021 at 08:15:01AM -0500, Aaron Conole wrote: > > Jerin Jacob writes: > > > > > On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: > > >> > > >> Even though test_interrupts.c can compile on Windows, skip interrupt >

[PATCH] net/af_xdp: fix build with -Wunused-function

2021-12-09 Thread Ciara Loftus
The get_shared_umem function is only called when the kernel flag XDP_UMEM_UNALIGNED_CHUNK_FLAG is defined. Move the function implementation and associated helper so that it only gets compiled when that flag is set. Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") Cc: sta...@dpdk.org Signed

Re: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

2021-12-09 Thread Tyler Retzlaff
On Wed, Dec 08, 2021 at 07:40:10PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 8 December 2021 18.35 > > > > On Fri, Dec 03, 2021 at 11:37:10AM +0100, Morten Brørup wrote: > > > > From: Morten Brørup [mailto:m...@smartsharesystems

Re: [PATCH v14 02/11] app/test: remove POSIX-specific code

2021-12-09 Thread Tyler Retzlaff
On Wed, Dec 08, 2021 at 10:59:51AM -0800, Jie Zhou wrote: > - Replace POSIX-specific code with DPDK equivalents or > conditionally disable it on Windows > - Use NUL on Windows as /dev/null for Unix > - Exclude tests not supported on Windows yet > * multi-process > * PMD performance statistics

Re: [PATCH v14 09/11] app/test: add test stubs for not supported ones

2021-12-09 Thread Tyler Retzlaff
On Wed, Dec 08, 2021 at 10:59:58AM -0800, Jie Zhou wrote: > Add test stubs for tests which are not yet supported for Windows: > - The libraries that tests depend on are not enabled on Windows yet > - The tests can compile but with issue still under investigation > * test_func_reentrancy: >

Re: [PATCH v14 00/11] app/test: enable subset of tests on Windows

2021-12-09 Thread Tyler Retzlaff
On Wed, Dec 08, 2021 at 10:59:49AM -0800, Jie Zhou wrote: > The goal of this patchset is to enable unit tests in CI for Windows. > It mainly contains: > - Replace POSIX specific codes > - Fix some lib and tests per failures investigation > - Add test stubs for not yet supported ones on Windows > -

DTS WG update

2021-12-09 Thread Honnappa Nagarahalli
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:Central Standard Time BEGIN:STANDARD DTSTART:16010101T02 TZOFFSETFROM:-0500 TZOFFSETTO:-0600 RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=1SU;BYMONTH=11 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T02000

[PATCH v3] net/ixgbe: add vector Rx parameter check

2021-12-09 Thread Bin Zheng
Under the circumstance that `rx_tail` wrap back to zero and the advance speed of `rx_tail` is greater than `rxrearm_start`, `rx_tail` will catch up with `rxrearm_start` and surpass it. This may cause some mbufs be reused by application. So we need to make some restrictions to ensure that `rx_tail