Re: [dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys

Harry, Can you add the following to the cheat-sheet? Don't do many patches these days, and I'm not the only one to miss these recently.. ..Remy On 26/07/2018 19:11, Thomas Monjalon wrote: Remy, You are not new to DPDK. Please pay attention to details: - subject does not start with lib/ - fix

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

Hi Thomas, Why deferred? This patch is only to be applied to 17.11.3. Because the changes the memory code has gone through the last months, the same fix will be different for newer versions. I'm working on it but waiting all the current patches from Anatoly being accepted for creating the final p

Re: [dpdk-dev] [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT

On 26-Jul-18 5:43 PM, Pattan, Reshma wrote: Hi, -Original Message- From: Somarowthu, Naga SureshX Sent: Thursday, July 26, 2018 1:50 PM To: dev@dpdk.org Cc: Horton, Remy ; Pattan, Reshma ; Somarowthu, Naga SureshX Subject: [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

27/07/2018 09:03, Alejandro Lucero: > Hi Thomas, > > Why deferred? This patch is only to be applied to 17.11.3. Because the > changes the memory code has gone through the last months, the same fix will > be different for newer versions. OK, I can change them to "Not Applicable". > I'm working on

Re: [dpdk-dev] [PATCH v2] net/i40e: fix max frame size checking

> -Original Message- > From: Wu, Yanglong > Sent: Friday, July 27, 2018 5:40 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Ananyev, Konstantin > ; Yao, Lei A ; > Wu, Yanglong > Subject: [PATCH v2] net/i40e: fix max frame size checking > > Check patcket size according to TSO or no-TSO. >

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

On Fri, Jul 27, 2018 at 10:01 AM, Thomas Monjalon wrote: > 27/07/2018 09:03, Alejandro Lucero: > > Hi Thomas, > > > > Why deferred? This patch is only to be applied to 17.11.3. Because the > > changes the memory code has gone through the last months, the same fix > will > > be different for newer

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test

Hi, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 26, 2018 9:08 PM > To: Pattan, Reshma > Cc: sta...@dpdk.org; dev@dpdk.org; Burakov, Anatoly > ; Parthasarathy, JananeeX M > ; Yigit, Ferruh > > Subject: Re: [dpdk-stable] [PATCH v5 10/10]

[dpdk-dev] [PATCH] eal/bsd: silence not supported error in interrupts

Currently, nic_uio driver does not support interrupts, so any attempts to install an interrupt handler will fail with a not supported error, which will cause an error message that is confusing to the user. Silence this error by moving it to debug log level, and reword the message to avoid containi

Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

Hi, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 26, 2018 9:05 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; Burakov, Anatoly ; > Parthasarathy, JananeeX M > Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again > > 17/07/

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test

27/07/2018 10:22, Pattan, Reshma: > Hi, > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, July 26, 2018 9:08 PM > > To: Pattan, Reshma > > Cc: sta...@dpdk.org; dev@dpdk.org; Burakov, Anatoly > > ; Parthasarathy, JananeeX M > > ; Yigit, Fer

Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

On 27-Jul-18 9:36 AM, Pattan, Reshma wrote: Hi, -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Thursday, July 26, 2018 9:05 PM To: Pattan, Reshma Cc: dev@dpdk.org; Burakov, Anatoly ; Parthasarathy, JananeeX M Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make u

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

27/07/2018 10:22, Alejandro Lucero: > Thomas Monjalon wrote: > > 27/07/2018 09:03, Alejandro Lucero: > > > Thomas Monjalon wrote: > > > > 10/07/2018 19:25, Alejandro Lucero: > > > > > This patchset applies on 17.11.3. > > > > > > > > > > Similar changes will be submitted to main DPDK branch soon.

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

On 27-Jul-18 9:22 AM, Alejandro Lucero wrote: On Fri, Jul 27, 2018 at 10:01 AM, Thomas Monjalon > wrote: 27/07/2018 09:03, Alejandro Lucero: > Hi Thomas, > > Why deferred? This patch is only to be applied to 17.11.3. Because the > changes the

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

On Fri, Jul 27, 2018 at 10:52 AM, Thomas Monjalon wrote: > 27/07/2018 10:22, Alejandro Lucero: > > Thomas Monjalon wrote: > > > 27/07/2018 09:03, Alejandro Lucero: > > > > Thomas Monjalon wrote: > > > > > 10/07/2018 19:25, Alejandro Lucero: > > > > > > This patchset applies on 17.11.3. > > > >

[dpdk-dev] [PATCH v6 00/10] Make unit tests great again

Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memory at

[dpdk-dev] [PATCH v6 01/10] autotest: fix printing

From: Anatoly Burakov Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpd

[dpdk-dev] [PATCH v6 02/10] autotest: fix invalid code on reports

From: Anatoly Burakov There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework

[dpdk-dev] [PATCH v6 05/10] autotest: improve filtering

From: Anatoly Burakov Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't

[dpdk-dev] [PATCH v6 03/10] autotest: make autotest runner python 2/3 compliant

From: Anatoly Burakov Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH v6 04/10] autotest: visually separate different test categories

From: Anatoly Burakov Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a

[dpdk-dev] [PATCH v6 06/10] autotest: remove autotest grouping

From: Anatoly Burakov Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autot

[dpdk-dev] [PATCH v6 07/10] autotest: properly parallelize unit tests

From: Anatoly Burakov Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of

[dpdk-dev] [PATCH v6 08/10] autotest: update autotest test case list

From: Jananee Parthasarathy Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy Reviewed-by: Anatoly Burakov --- test/test/autotest_data.py |

[dpdk-dev] [PATCH v6 09/10] mk: update make targets for classified testcases

From: Jananee Parthasarathy Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different targets for the ab

[dpdk-dev] [PATCH v6 10/10] mk: remove unnecessary make rules of test

From: Reshma Pattan make rule test-basic is duplicate of test rule. removed unused test-mempool and test-ring make rules. Fixes: a3df7f8d9c ("mk: rename test related rules") CC: sta...@dpdk.org CC: ferruh.yi...@intel.com Signed-off-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- mk/rte.sd

Re: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init failure

On 7/26/2018 6:39 PM, De Lara Guarch, Pablo wrote: Hi Radu, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau Sent: Wednesday, July 18, 2018 2:50 PM To: dev@dpdk.org Cc: Hunt, David ; Yao, Lei A ; Nicolau, Radu Subject: [dpdk-dev] [PATCH] examples/

[dpdk-dev] [PATCH v2] examples/l3fw-power: do not exit on power lib init failure

Do not exit the application if power library fails to initialize or high performance cores configuration cannot be used. Signed-off-by: Radu Nicolau --- v2: updated init_power_library to return error code if any core init fails examples/l3fwd-power/main.c | 10 ++ 1 file changed, 6 ins

Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

Hi, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 26, 2018 9:05 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; Burakov, Anatoly ; > Parthasarathy, JananeeX M > Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again > > Reshma

Re: [dpdk-dev] [PATCH v2] net/bonding: fix race condition

On Wed, Jul 25, 2018 at 5:46 AM Radu Nicolau wrote: > Race condition can appear in the bond_mode_8023ad_periodic_cb() > callback when bonding port is stopped, reconfigured and restarted. > > Re-ordered calls in bond_ethdev_start() to have callback alarm set > after slave ports are reconfigured. >

[dpdk-dev] [PATCH v2 2/2] mempool: fold memory size calculation helper

rte_mempool_calc_mem_size_helper() was introduced to avoid code duplication and used in deprecated rte_mempool_mem_size() and rte_mempool_op_calc_mem_size_default(). Now the first one is removed and it is better to fold the helper into the second one to make it more readable. Signed-off-by: Andrew

Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions

On 27.07.2018 00:34, Thomas Monjalon wrote: 11/07/2018 12:59, Andrew Rybchenko: Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and rte_mempool_populate_phys_tab() are just wrappers for corresponding IOVA functions and were deprecated in v17.11. Functions rte_mempool_xmem_create()

[dpdk-dev] [PATCH v2 1/2] mempool: remove deprecated functions

Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and rte_mempool_populate_phys_tab() are just wrappers for corresponding IOVA functions and were deprecated in v17.11. Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(), rte_mempool_xmem_usage() and rte_mempool_populate_iova_t

Re: [dpdk-dev] DPDK and forked processes

As this discussion has broad implications for DPDK, is it a good candidate for a techboard meeting topic? > -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 10:09 AM > To: Eads, Gage ; dev@dpdk.org > Subject: Re: DPDK and forked processes > > On 16-Jul-18 4:00 P

[dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any other IPv6 extension headers when finding the fragment header. According to RFC 8200, there is no guarantee that the IPv6 Fragment extension header will come before any other extension header, even though it is recommended. Signed-o

[dpdk-dev] [PATCH v8 2/4] test: add unit tests for bitrate library

Unit Test Cases for BitRate library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_bitratestats.c | 229 ++ 3 fi

[dpdk-dev] [PATCH v8 0/4] add unit tests for bitrate, latency and pdump libraries

1/4: add helper functions for tests using ring-PMD Rx/Tx 2/4: unit test cases added for bitrate library 3/4: unit test cases added for latencystats library 4/4: unit test cases added for pdump library Patches 2/4,3/4 depends on 1/4 Patch 4/4 depends on 1/4 and the

[dpdk-dev] [PATCH v8 4/4] test: add unit test for pdump library

Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/receive packets continuously in a separate thread. Client

[dpdk-dev] [PATCH v8 3/4] test: add unit tests for latencystats library

Unit Test Cases added for latencystats library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_latencystats.c | 216 ++ 3 files changed, 22

[dpdk-dev] [PATCH v8 1/4] test: add helper functions for tests using ring-PMD Rx/Tx

Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- test/test/Makefile| 1 + test/test/sample_packet_forward.c | 115

Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions

27/07/2018 15:45, Andrew Rybchenko: > On 27.07.2018 00:34, Thomas Monjalon wrote: > > 11/07/2018 12:59, Andrew Rybchenko: > >> Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and > >> rte_mempool_populate_phys_tab() are just wrappers for corresponding > >> IOVA functions and were depr

Re: [dpdk-dev] DPDK and forked processes

27/07/2018 15:46, Eads, Gage: > As this discussion has broad implications for DPDK, is it a good candidate > for a techboard meeting topic? We can discuss it in techboard, but usually we prefer discussing topics whose resolution is not clear. In this case, I think everybody agree with Anatoly, i

[dpdk-dev] [PATCH] net/bnx2x: fix copyright

Originally the PMD had "QLogic Corporation" copyright. When we submitted commit e3de5dad2a5d ("net/bnx2x: change copyright info to Cavium"), the "Qlogic Corporation" copyright was accidentally replaced with "Cavium Inc". So now we see multiple Cavium copyright messages. We're changing it to "Broadc

[dpdk-dev] [PATCH v3] net/bnx2x: move SPDX tags to source files

We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing tag from all the source file. Remove the LICENSE.bnx2x_pmd file and directly include SPDX tags in source files. Signed-off-by: Rasesh Mody Acked-by: Hemant Agrawal --- drivers/net/bnx2x/LICENSE.bnx2x_pmd |3 --- driver

Re: [dpdk-dev] DPDK and forked processes

On Fri, 27 Jul 2018 17:03:48 +0200 Thomas Monjalon wrote: > 27/07/2018 15:46, Eads, Gage: > > As this discussion has broad implications for DPDK, is it a good candidate > > for a techboard meeting topic? > > We can discuss it in techboard, but usually we prefer discussing topics > whose reso

Re: [dpdk-dev] DPDK and forked processes

Agreed on both points. I'll submit a patchset to remove the l2fwd_fork example and its user-guide, so it doesn't appear that DPDK supports this model. If anyone on the ML disagrees, they can respond here or on the patch thread. > -Original Message- > From: Stephen Hemminger [mailto:step.

[dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

rx_drop_en is an optimization that does nothing on single-queue devices like e1000. Do not force applications that do not care to select per-devices optimizations flags by returning an error, just log it and carry on. Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") C

[dpdk-dev] [PATCH] net/e1000: enable MSI-x for linkup and other events in 82574

Linux supports 82574 MSI-x interrupt for linkup and other link conditions. Enable the same feature in the e1000 PMD in order to allow this card to work properly, as it requires interrupt handling for link negotiations among other things. Signed-off-by: Luca Boccassi --- Hi Wenzhuo - just to make

[dpdk-dev] Questions about TX descriptors run out occasionally

Hi Experts, I'm developing my own dpdk-based application via Intel 82599ES port. My Application is doing a job to send ICMP requests (packet size varies from 64 bytes to 1472 bytes, 200,000 pps, 1.1Gbps) and receive responses, with ARP request/response and ICMP response handling when necessary. It