[dpdk-dev] [PATCH] net/i40e: fix fail to set TPID with AQ command

2018-07-05 Thread Beilei Xing
TPID can be set by set_switch_config AdminQ command on new FW release. But find fail to set 0x88A8 on some NICs. According to the datasheet, Switch Tag value should not be identical to either the First Tag or Second Tag values. So set something other than common Ethertype for internal switching. F

Re: [dpdk-dev] [PATCH v7 09/15] vhost: add shadow used ring support for packed rings

2018-07-05 Thread Tiwei Bie
On Wed, Jul 04, 2018 at 11:54:32PM +0200, Maxime Coquelin wrote: [...] > + > +static __rte_always_inline void > +flush_shadow_used_ring_packed(struct virtio_net *dev, > + struct vhost_virtqueue *vq) > +{ [...] > +} > + > +static __rte_always_inline void > +update_shadow_used_rin

Re: [dpdk-dev] [PATCH v7 14/15] vhost: add notification for packed ring

2018-07-05 Thread Maxime Coquelin
On 07/05/2018 07:12 AM, Tiwei Bie wrote: On Wed, Jul 04, 2018 at 11:54:37PM +0200, Maxime Coquelin wrote: [...] @@ -225,6 +231,15 @@ struct vring_desc_packed { uint16_t index; uint16_t flags; }; + +#define VRING_EVENT_F_ENABLE 0x0 +#define VRING_EVENT_F_DISABLE 0x1 +#define

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-05 Thread Thomas Monjalon
05/07/2018 05:37, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 05/07/2018 03:38, Zhang, Qi Z: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 04/07/2018 12:49, Zhang, Qi Z: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > 04/07/2018

[dpdk-dev] [PATCH] test: add unit tests for metrics library

2018-07-05 Thread Hari kumar Vemula
Unit Testcases are added for metrics library. Signed-off-by: Hari Kumar Reviewed-by: Reshma Pattan --- test/test/Makefile | 2 + test/test/test_metrics.c | 340 +++ 2 files changed, 342 insertions(+) create mode 100644 test/test/test_metrics.

[dpdk-dev] [PATCH V5 1/7] bus: add hotplug failure handler

2018-07-05 Thread Jeff Guo
When device be hotplug out, if app still continue to access device by mmio, it will cause of memory failure and result the system crash. This patch introduces a bus ops to handle device hotplug failure, it is a bus specific behavior,so that each kind of bus can implement its own logic case by case

[dpdk-dev] [PATCH V5 4/7] bus/pci: implement sigbus handler operation

2018-07-05 Thread Jeff Guo
This patch implements the ops of sigbus handler for PCI bus, it is functional to find the corresponding pci device which is be hotplug out. and then handle the hotplug failure for this device. Signed-off-by: Jeff Guo --- v5->v4: no change --- drivers/bus/pci/pci_common.c | 49 +++

[dpdk-dev] [PATCH V5 0/7] hot plug failure handle mechanism

2018-07-05 Thread Jeff Guo
As we know, hot plug is an importance feature, either use for the datacenter device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring the higher flexibility and continuality to the networking services in multiple use cases in industry. So let we see, dpdk as an importance netw

[dpdk-dev] [PATCH V5 2/7] bus/pci: implement hotplug failure handler ops

2018-07-05 Thread Jeff Guo
This patch implements the ops of hotplug failure handler for PCI bus, it is functional to remap a new dummy memory which overlap to the failure memory to avoid MMIO read/write error. Signed-off-by: Jeff Guo --- v5->v4: refine log and commit log --- drivers/bus/pci/pci_common.c | 28 +

[dpdk-dev] [PATCH V5 5/7] bus: add helper to handle sigbus

2018-07-05 Thread Jeff Guo
This patch aim to add a helper to iterate all buses to find the corresponding bus to handle the sigbus error. Signed-off-by: Jeff Guo --- v5->v4: refine the errno restore logic --- lib/librte_eal/common/eal_common_bus.c | 36 +- lib/librte_eal/common/eal_private.h

[dpdk-dev] [PATCH V5 3/7] bus: add sigbus handler

2018-07-05 Thread Jeff Guo
When device be hotplug out, if data path still read/write device, the sigbus error will occur, this error need to be handled. So a handler need to be here to capture the signal and handle it correspondingly. This patch introduces a bus ops to handle sigbus error, it is a bus specific behavior,so t

[dpdk-dev] [PATCH V5 6/7] eal: add failure handle mechanism for hotplug

2018-07-05 Thread Jeff Guo
This patch introduces a failure handler mechanism to handle device hot plug removal event. First register sigbus handler, once sigbus error be captured, will check the failure address and accordingly remap the invalid memory for the corresponding device. Bese on this mechanism, it could guaranty t

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-05 Thread Guo, Jia
On 7/4/2018 3:06 PM, Matan Azrad wrote: Hi Thomas, Guo From: Thomas Monjalon 03/07/2018 11:35, Guo, Jia: On 7/1/2018 3:46 PM, Matan Azrad wrote: From: Jeff Guo --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum

Re: [dpdk-dev] [PATCH v3 2/4] doc: rename compress feature flag

2018-07-05 Thread Trahe, Fiona
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 4, 2018 3:11 PM > To: shally.ve...@caviumnetworks.com; ashish.gu...@caviumnetworks.com; Trahe, > Fiona > ; Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v3 2/4] doc: rename compress feat

Re: [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix

2018-07-05 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 4, 2018 3:11 PM > To: shally.ve...@caviumnetworks.com; > ashish.gu...@caviumnetworks.com; Trahe, Fiona ; > Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v3 1/4] doc: cleanup ISA-L PMD featur

Re: [dpdk-dev] [PATCH v3 4/4] compressdev: add huffman encoding flags

2018-07-05 Thread Verma, Shally
>-Original Message- >From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] >Sent: 04 July 2018 19:41 >To: Verma, Shally ; Gupta, Ashish >; fiona.tr...@intel.com; >lee.d...@intel.com >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v3 4/4] compressdev: add huffman encoding flags

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] doc: fixes the limitations for dpaa sec

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, June 21, 2018 3:23 PM > To: Hemant Agrawal ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] doc: fixes the limitations > for > dpaa sec

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] doc: fixes the limitations for dpaa2 sec

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, June 21, 2018 3:22 PM > To: Hemant Agrawal ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] doc: fixes the limitations > for > dpaa2 sec

Re: [dpdk-dev] [PATCH v6] examples: fix RSS hash function configuration

2018-07-05 Thread Zhao, MeijuanX
-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit Sent: Thursday, July 5, 2018 4:02 AM To: Jerin Jacob ; Lu, Wenzhuo ; Wu, Jingjing ; Iremonger, Bernard ; Doherty, Declan ; Chas Williams ; Richardson, Bruce ; Hunt, David ; Van Haaren, Harry ; Dumitr

Re: [dpdk-dev] [PATCH] security: change to SPDX license tags

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Wednesday, July 4, 2018 8:51 AM > To: Nicolau, Radu ; akhil.go...@nxp.com; Doherty, > Declan > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] security: change to SPDX license tags > > Sig

[dpdk-dev] [PATCH V5 0/7] hot plug failure handle mechanism

2018-07-05 Thread Jeff Guo
As we know, hot plug is an importance feature, either use for the datacenter device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring the higher flexibility and continuality to the networking services in multiple use cases in industry. So let we see, dpdk as an importance netw

[dpdk-dev] [PATCH V5 7/7] igb_uio: fix uio release issue when hot unplug

2018-07-05 Thread Jeff Guo
When hotplug out device, the kernel will release the device resource in the kernel side, such as the fd sys file will disappear, and the irq will be released. At this time, if igb uio driver still try to release this resource, it will cause kernel crash. On the other hand, something like interrupt

Re: [dpdk-dev] [PATCH V4 1/9] bus: introduce hotplug failure handler

2018-07-05 Thread Thomas Monjalon
05/07/2018 08:23, Guo, Jia: > > On 7/4/2018 3:55 PM, Thomas Monjalon wrote: > > 04/07/2018 09:16, Guo, Jia: > >> On 7/4/2018 6:21 AM, Thomas Monjalon wrote: > >>> 29/06/2018 12:30, Jeff Guo: > /** > + * Implementation a specific hot plug handler, which is responsible > + * for ha

Re: [dpdk-dev] [PATCH] security: change to SPDX license tags

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Thursday, July 5, 2018 9:19 AM > To: Hemant Agrawal ; Nicolau, Radu > ; akhil.go...@nxp.com; Doherty, Declan > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] security: change

Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

2018-07-05 Thread Verma, Shally
>-Original Message- >From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] >Sent: 04 July 2018 19:41 >To: Verma, Shally ; Gupta, Ashish >; fiona.tr...@intel.com; >lee.d...@intel.com >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v3 3/4] compressdev: replace mbuf scatter gather

[dpdk-dev] [PATCH v4 00/10] net/mlx5: add port representor support

2018-07-05 Thread Adrien Mazarguil
This series adds support for port (VF) representors to the mlx5 PMD, which can be instantiated using the standard "representor" device parameter. Note the PMD only probes existing representors which exist as Verbs devices; their creation is part of the host system configuration. v4 changes: - Fi

[dpdk-dev] [PATCH v4 02/10] net/mlx5: remove redundant objects in probe code

2018-07-05 Thread Adrien Mazarguil
This patch gets rid of redundant calls to open the device and query its attributes in order to simplify the code. Signed-off-by: Adrien Mazarguil Reviewed-by: Xueming Li -- v2 changes: - Minor indent fix on existing code. --- drivers/net/mlx5/mlx5.c | 64 +--

[dpdk-dev] [PATCH v4 01/10] net/mlx5: rename confusing object in probe code

2018-07-05 Thread Adrien Mazarguil
There are several attribute objects in this function: - IB device attributes (struct ibv_device_attr_ex device_attr). - Direct Verbs attributes (struct mlx5dv_context attrs_out). - Port attributes (struct ibv_port_attr). - IB device attributes again (struct ibv_device_attr_ex device_attr_ex). "at

[dpdk-dev] [PATCH v4 04/10] net/mlx5: split PCI from generic probing code

2018-07-05 Thread Adrien Mazarguil
All the generic probing code needs is an IB device. While this device is currently supplied by a PCI lookup, other methods will be added soon. This patch divides the original function, which has become huge over time, as follows: 1. PCI-specific (mlx5_pci_probe()). 2. Verbs device (mlx5_dev_spawn

[dpdk-dev] [PATCH v4 03/10] net/mlx5: drop useless support for several Verbs ports

2018-07-05 Thread Adrien Mazarguil
Unlike mlx4 from which this capability was inherited, mlx5 devices expose exactly one Verbs port per PCI bus address. Each physical port gets assigned its own bus address with a single Verbs port. While harmless, this code requires an extra loop that would get in the way of subsequent refactoring.

[dpdk-dev] [PATCH v4 06/10] net/mlx5: add port representor awareness

2018-07-05 Thread Adrien Mazarguil
The current PCI probing method is not aware of Verbs port representors, which appear as standard Verbs devices bound to the same PCI address and cannot be distinguished. Problem is that more often than not, the wrong Verbs device is used, resulting in unexpected traffic. This patch makes the driv

[dpdk-dev] [PATCH v4 08/10] net/mlx5: probe port representors in natural order

2018-07-05 Thread Adrien Mazarguil
Port representors are probed in whatever unspecified order ibv_get_device_list() returns them. This is counterintuitive to users since DPDK port IDs assignment almost never follows the same sequence as representor IDs. Additionally, the master device does not necessarily inherit the lowest DPDK po

[dpdk-dev] [PATCH v4 09/10] net/mlx5: add parameter for port representors

2018-07-05 Thread Adrien Mazarguil
Prior to this patch, all port representors detected on a given device were probed and Ethernet devices instantiated for each of them. This patch adds support for the standard "representor" parameter, which implies that port representors are not probed by default anymore, except for the list provid

[dpdk-dev] [PATCH v4 05/10] net/mlx5: re-indent generic probing function

2018-07-05 Thread Adrien Mazarguil
Since commit "net/mlx5: drop useless support for several Verbs ports" removed an inner loop, mlx5_dev_spawn() is left with an unnecessary indent level. This patch eliminates a block, moves its local variables to function scope, and re-indents its contents (diff best viewed with --ignore-all-space)

[dpdk-dev] [PATCH v4 07/10] net/mlx5: probe all port representors

2018-07-05 Thread Adrien Mazarguil
Probe existing port representors in addition to their master device and associate them automatically. To avoid collision between Ethernet devices, they are named as follows: - "{DBDF}" for master/switch devices. - "{DBDF}_representor_{rep}" with "rep" starting from 0 for port representors. (Pa

[dpdk-dev] [PATCH v4 10/10] net/mlx5: support negative identifiers for port representors

2018-07-05 Thread Adrien Mazarguil
This patch brings support for BlueField representors. Signed-off-by: Adrien Mazarguil Cc: Shahaf Shuler -- v3 changes: - This patch was not present in prior revisions. --- drivers/net/mlx5/mlx5.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/

Re: [dpdk-dev] [PATCH v2 12/20] net/mlx5: add mark/flag flow action

2018-07-05 Thread Nélio Laranjeiro
On Wed, Jul 04, 2018 at 01:34:19AM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:44PM +0200, Nelio Laranjeiro wrote: > > Signed-off-by: Nelio Laranjeiro > > --- > > drivers/net/mlx5/mlx5_flow.c | 209 +++ > > 1 file changed, 209 insertions(+) > > > >

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-07-05 Thread Akhil Goyal
Hi Konstantin, On 6/22/2018 5:21 PM, Ananyev, Konstantin wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, June 22, 2018 11:41 AM To: Ananyev, Konstantin ; dev@dpdk.org Cc: Nicolau, Radu Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fi

[dpdk-dev] [PATCH] maintainers: update for Mellanox PMDs

2018-07-05 Thread Adrien Mazarguil
Shahaf and Matan volunteered to replace Nélio and myself as maintainers for mlx4 and mlx5 PMDs. Cheers! Signed-off-by: Adrien Mazarguil Signed-off-by: Nelio Laranjeiro Cc: sta...@dpdk.org Cc: Shahaf Shuler Cc: Matan Azrad --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

Re: [dpdk-dev] [Bug 62] Rawdev autotest fails

2018-07-05 Thread Shreyansh Jain
On Friday 15 June 2018 04:52 PM, bugzi...@dpdk.org wrote: https://dpdk.org/tracker/show_bug.cgi?id=62 Bug ID: 62 Summary: Rawdev autotest fails Product: DPDK Version: 18.05 Hardware: All OS: All Status: CON

Re: [dpdk-dev] [PATCH] mk: using initial-exec model for thread local variable

2018-07-05 Thread Thomas Monjalon
05/07/2018 16:13, Marvin Liu: > When building share library, thread-local storage model will be changed > to global-dynamic. It will add additional cost for reading thread local > variable. On the other hand, dynamically load share library with static > TLS will request additional DTV slot which is

Re: [dpdk-dev] [PATCH v6] examples: fix RSS hash function configuration

2018-07-05 Thread Hunt, David
Hi Ferruh, On 4/7/2018 9:02 PM, Ferruh Yigit wrote: ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying

Re: [dpdk-dev] [PATCH v9 20/27] ethdev: register ether layer as a class

2018-07-05 Thread Gaëtan Rivet
Hi Andrew, On Wed, Jul 04, 2018 at 03:20:17PM +0300, Andrew Rybchenko wrote: > On 07/04/2018 01:15 AM, Gaetan Rivet wrote: > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_ethdev/Makefile| 3 +- > > lib/librte_ethdev/rte_class_eth.c | 79 > >

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-05 Thread Nélio Laranjeiro
On Wed, Jul 04, 2018 at 03:54:32PM +0100, Ferruh Yigit wrote: > On 7/2/2018 11:40 AM, Mohammad Abdul Awal wrote: > > > > On 27/06/2018 12:45, Nelio Laranjeiro wrote: > >> This series adds an easy and maintainable configuration version support for > >> those two actions for 18.08 by using global va

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-05 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 5, 2018 3:23 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > ; arybche..

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-05 Thread Mordechay Haimovsky
Hi, Didn’t see it in our setups (not an excuse), Investigating Moti > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, July 4, 2018 4:49 PM > To: Mordechay Haimovsky ; Shahaf Shuler > > Cc: Adrien Mazarguil ; dev@dpdk.org > Subject: Re: [d

[dpdk-dev] [PATCH] security: fix segfault when destroy NULL session

2018-07-05 Thread Radu Nicolau
rte_security_session_destroy should return -EINVAL is session is NULL, but segfaults because of rte_mempool_from_obj(NULL) call. Fixes: c261d1431bd8 ("security: introduce security API and framework") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- lib/librte_security/rte_security.c | 3 +--

[dpdk-dev] [PATCH v5 00/16] Cryptodev API changes

2018-07-05 Thread Pablo de Lara
API changes in the cryptodev library, announced in the previous release, 18.05. Changes in v5: - Modified .ini files with new SGL/OOP flags - Modified overview cryptodev documentation, removing the clarification note on scatter-gather limitations and including the meaning of the new feature f

[dpdk-dev] [PATCH v5 01/16] cryptodev: replace bus specific struct with generic dev

2018-07-05 Thread Pablo de Lara
Structure rte_cryptodev_info has currently PCI device information ("struct rte_pci_device") in it. This information is not generic to all devices, so this gets replaced with the generic "rte_device" structure, compatible with all crypto devices. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal

[dpdk-dev] [PATCH v5 02/16] cryptodev: remove max number of sessions per queue

2018-07-05 Thread Pablo de Lara
The cryptodev info structure currently contains the maximum number of sessions that can be used in a queue pair. This is only set in DPAA_SEC PMD, and since it is calculated based on the maximum number of sessions (which is not used anymore), this field can be removed. Signed-off-by: Pablo de Lara

[dpdk-dev] [PATCH v5 03/16] app/crypto-perf: limit number of sessions

2018-07-05 Thread Pablo de Lara
Instead of creating a fixed number of sessions, calculate the necessary number based on number of devices and queue pairs used. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/main.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletio

[dpdk-dev] [PATCH v5 05/16] examples/l2fwd-crypto: limit number of sessions

2018-07-05 Thread Pablo de Lara
Calculate the number of sessions required for the application, knowing that there is only one session required per device. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- examples/l2fwd-crypto/main.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --gi

[dpdk-dev] [PATCH v5 04/16] test/crypto: limit number of sessions

2018-07-05 Thread Pablo de Lara
Instead of using the maximum number of sessions allowed by the PMDs (which will change to unlimited most of the PMDs), limit the number to a small sufficient amount. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- test/test/test_cryptodev.c | 27 +-- 1 file change

[dpdk-dev] [PATCH v5 06/16] examples/ipsec-secgw: check for max supported sessions

2018-07-05 Thread Pablo de Lara
Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec-secgw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index a5da8b280..2582dcb6e 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c

[dpdk-dev] [PATCH v5 07/16] crypto/mvsam: parse max number of sessions

2018-07-05 Thread Pablo de Lara
The maximum number of sessions device argument will be removed, as most PMDs do not have a limitation on this number. Therefore, the MVSAM PMD needs to parse this value internally. Signed-off-by: Pablo de Lara --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 132 1

[dpdk-dev] [PATCH v5 08/16] cryptodev: define value for unlimited sessions

2018-07-05 Thread Pablo de Lara
Currently, the info structure contains the maximum number of sessions that a device can manage. This field was useful when the session mempool was created inside each device, but now it is created at the application level. Most PMDs do not have a limitation on the sessions managed, but a few do, t

[dpdk-dev] [PATCH v5 09/16] cryptodev: remove max number of sessions parameter

2018-07-05 Thread Pablo de Lara
Most crypto PMDs do not have a limitation of the number of the sessions that can be handled internally. The value that was set before was not actually used at all, since the sessions are created at the application level. Therefore, this value is not parsed from the initial crypto parameters anymore

[dpdk-dev] [PATCH v5 11/16] cryptodev: remove queue start/stop functions

2018-07-05 Thread Pablo de Lara
Removed cryptodev queue start/stop functions, as they were marked deprecated in 18.05, since they were not implemented by any driver. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 4 --- doc/guides/rel_notes/release_18_08.rst |

[dpdk-dev] [PATCH v5 12/16] cryptodev: remove old get session size functions

2018-07-05 Thread Pablo de Lara
Removed rte_cryptodev_get_header_session_size and rte_cryptodev_get_private_session_size functions, as they have been substituted with functions specific for symmetric operations, with _sym_ word after "rte_cryptodev_". Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes

[dpdk-dev] [PATCH v5 10/16] doc: remove unneeded deprecation notice

2018-07-05 Thread Pablo de Lara
In release 18.05, a deprecation notice to remove the `sym` structure in the cryptodev info structure was sent. However, only one of the fields inside the structure will be removed, so the notice is not actually correct. In any case, it needs to be removed. Signed-off-by: Pablo de Lara Acked-by: A

[dpdk-dev] [PATCH v5 14/16] cryptodev: remove attach/detach session API

2018-07-05 Thread Pablo de Lara
As announced in the previous release, The API to attach/dettach a session to a queue pair is removed, as it was only used in DPAA, and it is not actually needed. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 8 doc/guides/rel_notes

[dpdk-dev] [PATCH v5 13/16] cryptodev: replace mbuf scatter gather flag

2018-07-05 Thread Pablo de Lara
The current mbuf scatter gatter feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not, plus if in-place and/or out-of-place is supported. Therefore, five new flags will replace this flag: - RTE_CRYPTODEV_FF_IN_PLACE_SGL - RTE_CRYPTODEV_

[dpdk-dev] [PATCH v5 15/16] cryptodev: rename PMD symmetric session API

2018-07-05 Thread Pablo de Lara
The PMD specific API to configure, clear and obtain session private size is renamed, including the word _sym_ to clarify that it is API for symmetric sessions, so there will not be any conflicts for asymmetric and other type of sessions in the future. Signed-off-by: Pablo de Lara Acked-by: Akhil

[dpdk-dev] [PATCH v5 16/16] cryptodev: check if symmetric sessions are supported

2018-07-05 Thread Pablo de Lara
Since asymmetric functionality will be implemented soon, not all PMDs must support symmetric sessions. Therefore, a check is added if a device does not implement the symmetric functions, meaning that the device does not support symmetric operations. Signed-off-by: Pablo de Lara Acked-by: Akhil Go

[dpdk-dev] [PATCH 0/2] Enable eal event hotplug for i40e

2018-07-05 Thread Jeff Guo
As we may know, we have eal event for rte device hotplug and ethdev event for ethdev hotplug. Some ethdev need to use eal event to detect hotplug behaviors, the privors way is register eal event callback in app, but seems that it will have some race between these 2 event process. In oder to fix the

[dpdk-dev] [PATCH 2/2] testpmd: remove the dev event callback register

2018-07-05 Thread Jeff Guo
Since now we can use driver to management the eal event for hotplug, so no need to register dev event callback in app anymore. This patch remove the related code. Signed-off-by: Jeff Guo --- app/test-pmd/testpmd.c | 76 -- 1 file changed, 76 deleti

[dpdk-dev] [PATCH 1/2] net/i40e: enable hotplug in i40e

2018-07-05 Thread Jeff Guo
This patch aim to enable hotplug in i40e pmd driver. Firstly it set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug ability, and then use rte_dev_event_callback_register to register the hotplug event callback to eal, when eal detect the hotplug event, will call the callback to p

Re: [dpdk-dev] [PATCH] common/qat: replace snprintf

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Monday, July 2, 2018 6:26 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH] common/qat: replace snprintf > > Replaced snprintf with strlcpy for safer string copy > > Signed-off-by:

Re: [dpdk-dev] [PATCH] security: fix segfault when destroy NULL session

2018-07-05 Thread Akhil Goyal
On 7/5/2018 3:34 PM, Radu Nicolau wrote: rte_security_session_destroy should return -EINVAL is session is NULL, but segfaults because of rte_mempool_from_obj(NULL) call. Fixes: c261d1431bd8 ("security: introduce security API and framework") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --

Re: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv physical address

2018-07-05 Thread De Lara Guarch, Pablo
Hi Jianjay, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhoujian (jay) > Sent: Tuesday, July 3, 2018 1:29 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv physica

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-05 Thread Thomas Monjalon
05/07/2018 11:54, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 05/07/2018 05:37, Zhang, Qi Z: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 05/07/2018 03:38, Zhang, Qi Z: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > 04/07/2018

[dpdk-dev] DPDK Release Status Meeting 05/07/2018

2018-07-05 Thread Ferruh Yigit
Minutes of 5 July 2018 -- Agenda: * Merge Deadline for 18.08 * Subtrees * Bugzilla Participants: * Intel * Mellanox * NXP * Red Hat * SuSe Merge Deadline for 18.08 * *RC1* date pushed to *Wednesday 11 July*. * sub-trees will be pulled on Tuesday 10

[dpdk-dev] [PATCH] compress/isal: add chained mbuf support

2018-07-05 Thread Lee Daly
This patch adds chained mbuf support for input or output buffers during compression/decompression operations. Signed-off-by: Lee Daly --- doc/guides/compressdevs/features/isal.ini | 2 +- doc/guides/compressdevs/isal.rst | 2 - drivers/compress/isal/isal_compress_pmd.c |

Re: [dpdk-dev] [PATCH v3 2/4] doc: rename compress feature flag

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, July 5, 2018 3:41 AM > To: De Lara Guarch, Pablo ; Gupta, Ashish > ; Trahe, Fiona ; Daly, Lee > ; Sahu, Sunila > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 2/4] doc: rename compress feature flag

Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, July 5, 2018 9:39 AM > To: De Lara Guarch, Pablo ; Gupta, Ashish > ; Trahe, Fiona ; Daly, Lee > ; Sahu, Sunila > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter

Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

2018-07-05 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 05 July 2018 16:36 >To: Verma, Shally ; Gupta, Ashish >; Trahe, Fiona ; >Daly, Lee ; Sahu, Sunila >Cc: dev@dpdk.org >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

Re: [dpdk-dev] [PATCH v9 20/27] ethdev: register ether layer as a class

2018-07-05 Thread Bruce Richardson
On Thu, Jul 05, 2018 at 11:36:38AM +0200, Gaëtan Rivet wrote: > Hi Andrew, > > On Wed, Jul 04, 2018 at 03:20:17PM +0300, Andrew Rybchenko wrote: > > On 07/04/2018 01:15 AM, Gaetan Rivet wrote: > > > Signed-off-by: Gaetan Rivet > > > --- > > > lib/librte_ethdev/Makefile| 3 +- > > > li

Re: [dpdk-dev] [PATCH] net/sfc: cut non VLAN ID bits from TCI

2018-07-05 Thread Adrien Mazarguil
On Fri, Jun 29, 2018 at 04:23:31PM +0100, Andrew Rybchenko wrote: > TCI may contain PCP or DEI bits. Matching of these bits is not > supported, but the bits still may be set in specification value and > not covered by mask. So, these bits should be ignored. > > Fixes: 894080975e1e ("net/sfc: suppo

Re: [dpdk-dev] [PATCH v3 4/4] compressdev: add huffman encoding flags

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, July 5, 2018 9:14 AM > To: De Lara Guarch, Pablo ; Gupta, Ashish > ; Trahe, Fiona ; Daly, Lee > > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 4/4] compressdev: add huffman encoding flags > > >

Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, July 5, 2018 12:13 PM > To: De Lara Guarch, Pablo ; Gupta, Ashish > ; Trahe, Fiona ; Daly, Lee > ; Sahu, Sunila > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter g

Re: [dpdk-dev] [PATCH v5 04/16] test/crypto: limit number of sessions

2018-07-05 Thread Verma, Shally
>-Original Message- >From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] >Sent: 05 July 2018 07:38 >To: declan.dohe...@intel.com; akhil.go...@nxp.com; Verma, Shally >; ravi1.ku...@amd.com; Jacob, >Jerin ; roy.fan.zh...@intel.com; >fiona.tr...@intel.com; t...@semihalf.com; >jian

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-05 Thread Ferruh Yigit
On 7/5/2018 11:09 AM, Mordechay Haimovsky wrote: > Hi, > Didn’t see it in our setups (not an excuse), Investigating Thanks. Perhaps it can be related to compiler version: gcc (GCC) 8.1.1 20180502 (Red Hat 8.1.1-1) (ICC 32bit also gave same build error.) btw, to clarify rdma-core v19 build

Re: [dpdk-dev] [PATCH v5 04/16] test/crypto: limit number of sessions

2018-07-05 Thread Akhil Goyal
Hi Shally, On 7/5/2018 4:57 PM, Verma, Shally wrote: -Original Message- From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] Sent: 05 July 2018 07:38 To: declan.dohe...@intel.com; akhil.go...@nxp.com; Verma, Shally ; ravi1.ku...@amd.com; Jacob, Jerin ; roy.fan.zh...@intel.com;

Re: [dpdk-dev] [PATCH v5 13/16] cryptodev: replace mbuf scatter gather flag

2018-07-05 Thread Akhil Goyal
On 7/5/2018 7:38 AM, Pablo de Lara wrote: The current mbuf scatter gatter feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not, plus if in-place and/or out-of-place is supported. Therefore, five new flags will replace this flag: -

[dpdk-dev] [PATCH v10 03/27] kvargs: build before EAL

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/Makefile | 3 +-- lib/librte_eal/meson.build| 1 + lib/librte_kvargs/Makefile| 2 +- lib/librte_kvargs/meson.build | 3 +++ lib/meson.build | 8 ++-- 5 files changed, 12 insertions(+), 5 deletions(-) diff --git a/lib/

[dpdk-dev] [PATCH v10 00/27] Device querying

2018-07-05 Thread Gaetan Rivet
This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a

[dpdk-dev] [PATCH v10 04/27] kvargs: introduce a more flexible parsing function

2018-07-05 Thread Gaetan Rivet
This function permits defining additional terminating characters, ending the parsing to arbitrary delimiters. Signed-off-by: Gaetan Rivet --- lib/Makefile | 1 + lib/librte_kvargs/meson.build| 2 ++ lib/librte_kvargs/rte_kvargs.c | 25 +

[dpdk-dev] [PATCH v10 02/27] kvargs: remove error logs

2018-07-05 Thread Gaetan Rivet
Error logs in kvargs parsing should be better handled in components calling the library. This library must be as lean as possible. Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v10 05/27] eal: introduce dtor macros

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_common.h | 23 ++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 434adfd45..0dd832728 100644 --- a/lib/librte_eal/co

[dpdk-dev] [PATCH v10 01/27] devargs: add non-variadic parsing function

2018-07-05 Thread Gaetan Rivet
rte_devargs_parse becomes non-variadic, rte_devargs_parsef becomes the variadic version, to be used to compose device strings. Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c| 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- lib/librte_eal/common/eal_commo

[dpdk-dev] [PATCH v10 07/27] eal/class: register destructor

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index b5e550a34..e8176f5e1 100644 --- a/lib/librte_eal/common/include/rte_class

[dpdk-dev] [PATCH v10 08/27] devargs: add function to parse device layers

2018-07-05 Thread Gaetan Rivet
This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 lib/librte_eal/common/eal_private.h

[dpdk-dev] [PATCH v10 09/27] eal/dev: add device iterator interface

2018-07-05 Thread Gaetan Rivet
A device iterator allows iterating over a set of devices. This set is defined by the two descriptions offered, * rte_bus * rte_class Only one description can be provided, or both. It is not allowed to provide no description at all. Each layer of abstraction then performs a filter based on th

[dpdk-dev] [PATCH v10 06/27] eal: introduce device class abstraction

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_common_class.c | 62 +++ lib/librte_eal/common/include/rte_class.h | 121 + lib/librte_eal/common/incl

[dpdk-dev] [PATCH v10 14/27] kvargs: add generic string matching callback

2018-07-05 Thread Gaetan Rivet
This function can be used as a callback to rte_kvargs_process. This should reduce code duplication. Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 10 + lib/librte_kvargs/rte_kvargs.h | 28 lib/librte_kvargs/rte_kvargs_versi

[dpdk-dev] [PATCH v10 10/27] eal/class: add device iteration

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index e8176f5e1..9d5b06807 100644 --- a/lib/librte_eal/common/include/rte_class.h ++

[dpdk-dev] [PATCH v10 13/27] eal/dev: implement device iteration

2018-07-05 Thread Gaetan Rivet
Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 168 lib/librte_eal/common/include/rte_dev.h | 26 lib/librte_eal/rte_eal_ve

[dpdk-dev] [PATCH v10 12/27] eal/dev: implement device iteration initialization

2018-07-05 Thread Gaetan Rivet
Parse a device description. Split this description in their relevant part for each layers. No dynamic allocation is performed. Signed-off-by: Gaetan Rivet --- lib/Makefile| 1 + lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH v10 11/27] eal/bus: add device iteration

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index eb9eded4e..747baf140 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/

[dpdk-dev] [PATCH v10 15/27] bus/pci: implement device iteration and comparison

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 3 +- drivers/bus/pci/meson.build | 6 +++- drivers/bus/pci/pci_common.c | 3 +- drivers/bus/pci/pci_params.c | 53 drivers/bus/pci/private.h| 25 + 5 files changed, 86 inse

  1   2   3   >