jojochuang opened a new pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9
HADOOP-17648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822173335
Yeah I think we should release hadoop-thirdparty 1.1.0 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
virajjasani commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822173643
Just one minor comment: We can update PR title to include `HADOOP-17648`
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822175134
Oh yeah you're right. I'm doing too much work at once. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822398949
Actually this PR breaks shading
`Error creating shaded jar: duplicate entry: META-INF/LICENSE.txt`
Looking into this error.
--
This is an automated message from th
jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822907603
The above commit fixes the shading problem. @virajjasani care to have
another look?
--
This is an automated message from the Apache Git Service.
To respond to the mess
virajjasani commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822972015
I see, it was coming from `checker-qual`. Sounds good to exclude it.
+1 (non-binding).
@jojochuang where do we usually see QA results for hadoop-thirdparty? It
see
jojochuang commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-823699977
It doesn't look like we run QA for hadoop-thirdparty repo. It's a relatively
less developed repo after all.
--
This is an automated message from the Apache Git Service.
jojochuang opened a new pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10
Manually tested by running command `mvn dependency-check:aggregate`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
aajisaka merged pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
aajisaka commented on pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10#issuecomment-826483156
Thanks @jojochuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
aajisaka merged pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
aajisaka commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-826486797
Thank you @jojochuang and @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
aajisaka commented on pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-826486797
Thank you @jojochuang and @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
aajisaka merged pull request #9:
URL: https://github.com/apache/hadoop-thirdparty/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
aajisaka commented on pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10#issuecomment-826483156
Thanks @jojochuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
aajisaka merged pull request #10:
URL: https://github.com/apache/hadoop-thirdparty/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
jojochuang opened a new pull request #11:
URL: https://github.com/apache/hadoop-thirdparty/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
aajisaka opened a new pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12
JIRA: https://issues.apache.org/jira/browse/HADOOP-17667
Test GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826744706
Umm. Maybe GitHub actions will be enabled after the PR is merged into the
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message
aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826751862
Result: https://github.com/aajisaka/hadoop-thirdparty/actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
smengcl commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826852986
Thanks @aajisaka . Would you trigger a re-run on your fork? looks like it is
still failing on the previous java-version typo here:
https://github.com/aajisaka/hadoop-thi
smengcl edited a comment on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826852986
Thanks @aajisaka . ~~Would you trigger a re-run on your fork? looks like it
is still failing on the previous java-version typo here:
https://github.com/aajisaka/h
aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-827247977
@jojochuang @ayushtkn
Do you need any additional tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jojochuang merged pull request #11:
URL: https://github.com/apache/hadoop-thirdparty/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
medb opened a new pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13
Protobuf 3.7.1 is not available in any OS repo and requires manual
compilation which takes time (10-15 mins).
Protobuf 3.12.4 is not only newer but also available in latest Debian and
Ubuntu
aajisaka merged pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
aajisaka commented on pull request #12:
URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-830728944
Merged. Thank you @smengcl and @jojochuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jojochuang opened a new pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14
(1) Hard code a python dependency version to avoid image build error.
(2) Remove npm which is not used for building hadoop-thirdparty to avoid
image build error.
(2) Migrate to Ubuntu 18
jojochuang commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-839651970
This change blocks the hadoop-thirdparty 1.1.0 release. Please review
@aajisaka @ayushtkn @vinayakumarb
--
This is an automated message from the Apache Git Service.
aajisaka commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840239920
Thank you @jojochuang. Maybe we need to update the description to something
like "Fix the docker image".
In the future, I want to clean up the Dockerfile:
- Upgr
aajisaka commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631520733
##
File path: dev-support/docker/Dockerfile
##
@@ -93,20 +94,8 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists
jojochuang opened a new pull request #15:
URL: https://github.com/apache/hadoop-thirdparty/pull/15
Update the LICENSE and NOTICE files to reflect what's bundled in
hadoop-thirdparty 1.1 and above.
1. Removed licenses and notices of the thirdparty dependency that shipped
along with o
aajisaka opened a new pull request #16:
URL: https://github.com/apache/hadoop-thirdparty/pull/16
JIRA: HADOOP-17697
- Added the license header
- Create a job to check license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jojochuang commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631526674
##
File path: dev-support/docker/Dockerfile
##
@@ -93,20 +94,8 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lis
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840250988
So at the end of the day, we probably don't need to use protobuf in the
hadoop-thirdparty repository. See:
https://github.com/apache/hadoop-thirdparty/pull/14#discussio
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840251431
Instead, we should do this for the main hadoop repository, not the
hadoop-thirdparty repo.
https://github.com/apache/hadoop/blob/trunk/dev-support/docker/Dockerfile#L12
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840254235
@jojochuang May you clarify, do you mean that we do not need to compile
protoc in [`hadoop-thirdparty` Docker
file](https://github.com/apache/hadoop-thirdparty/blob/trunk/dev
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840256223
Yeah. We have a number of redundant steps in hadoop-thirdparty Dockerfile.
It was copied from the main hadoop repo but we don't need many of the packages.
--
This is
jojochuang commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631539990
##
File path: dev-support/docker/Dockerfile
##
@@ -93,20 +94,8 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lis
jojochuang merged pull request #15:
URL: https://github.com/apache/hadoop-thirdparty/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
jojochuang commented on pull request #15:
URL: https://github.com/apache/hadoop-thirdparty/pull/15#issuecomment-840301789
Thanks @aajisaka @tasanuma !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jojochuang merged pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
jojochuang commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840305102
Thanks @aajisaka !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jojochuang merged pull request #16:
URL: https://github.com/apache/hadoop-thirdparty/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
aajisaka commented on pull request #16:
URL: https://github.com/apache/hadoop-thirdparty/pull/16#issuecomment-840328780
Thank you @jojochuang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840985181
@jojochuang rebased on the trunk HEAD and updated PR to the latest Protobuf
version
--
This is an automated message from the Apache Git Service.
To respond to the message,
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117
As I said, this PR is not needed. I'd like to ask you to work on the
protobuf update in the main hadoop repository.
--
This is an automated message from the Apache Gi
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117
As I said, this PR is not needed. I'd like to ask you to work on the
protobuf update in the main hadoop repository.
--
This is an automated message from the Apache Gi
tasanuma opened a new pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17
JIRA: https://issues.apache.org/jira/browse/HADOOP-17707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842794574
@jojochuang Could you review it? We may need it in 1.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
smengcl commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842802932
Thanks @tasanuma @jojochuang for taking care of the doc.
Posting `mvn dependency:tree` result on latest trunk here just for reference:
```bash
[INFO] --
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842812751
@jojochuang @smengcl Thanks for your reviews and your help. I added guava
document.
--
This is an automated message from the Apache Git Service.
To respond to the messa
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-843034859
@jojochuang I added the information about `org.checkerframework`.
`failureaccess` and `listenablefuture` are included in `com.google.guava`,
and both of the relocat
tasanuma merged pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-843794096
Thanks for your view, @jojochuang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844164345
Sorry, I forgot to squash it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
smengcl commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844355268
@tasanuma We can probably configure the "Merge button" config in Repo
Settings page the same as apache/hadoop to only allow squash merging.
--
This is an automated messa
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844755126
I don't have the privilege to see the Repo Settings page. Maybe we need to
add `.asf.yml` like HADOOP-17234?
--
This is an automated message from the Apache Git Service
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844761869
Actually, we asked INFRA to only allow squash merging for apache/hadoop. I
will create another jira for hadoop-thirdparty.
https://issues.apache.org/jira/browse/INFRA-1
tasanuma commented on pull request #17:
URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-846657744
Now only the "Squash and Merge" is enabled.
https://issues.apache.org/jira/browse/INFRA-21905
--
This is an automated message from the Apache Git Service.
To respond
jojochuang opened a new pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18
Tested by compiling Ozone with the modified Hadoop-thirdparty 1.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jojochuang commented on pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18#issuecomment-848416511
@ayushtkn or @tasanuma can you review?
I am thinking to add this and then start a hadoop-thirdparty 1.1.1 vote. It
is not strictly required. For Ozone, I have a w
jojochuang merged pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servic
jojochuang commented on pull request #18:
URL: https://github.com/apache/hadoop-thirdparty/pull/18#issuecomment-848474245
Thanks! I'll start preparing the 1.1.1 RC then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-912924915
@jojochuang sent PR to the Hadoop repo:
https://github.com/apache/hadoop/pull/3384
Please, let me know if this is correct.
--
This is an automated message from the A
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242
@jojochuang I took a look at Hadoop changes, and it seems to upgrade
Protobuf both PRs are necessary (in `hadoop-thirdparty` and `hadoop`
repositories)
May you explain
medb edited a comment on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242
@jojochuang I took a look at Hadoop changes in apache/hadoop#3384, and it
seems that to upgrade Protobuf both PRs are required
(apache/hadoop-thirdparty#13 in `hadoop-
cjolivier01 commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-1050314164
It would be good to update this to a non-vulnerable version of protobuf
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
steveloughran opened a new pull request, #19:
URL: https://github.com/apache/hadoop-thirdparty/pull/19
This patch bumps up the protobuf version so that Hadoop
is not a vulnerable to CVE-2021-22569.
I'm not renaming the module hadoop-shaded-protobuf_3_7
because that significan
ayushtkn commented on PR #19:
URL: https://github.com/apache/hadoop-thirdparty/pull/19#issuecomment-1150334147
>That said, I don't see why the version number needed to be
included there. We will have to live with that.
That wasn't something we wanted to do that initially, that came
ayushtkn opened a new pull request, #20:
URL: https://github.com/apache/hadoop-thirdparty/pull/20
Similar to [HADOOP-17234](https://issues.apache.org/jira/browse/HADOOP-17234)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
ayushtkn merged PR #20:
URL: https://github.com/apache/hadoop-thirdparty/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-dev-unsubscr...@
vinayakumarb opened a new pull request #1: HADOOP-16595. [pb-upgrade] Create
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1
This is an automated message from the Ap
Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r329297329
##
File path: pom.xml
##
@@ -0,0 +1,466 @@
+
+
+http://maven
Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r329297473
##
File path: hadoop-shaded-protobuf/pom.xml
##
@@ -0,0 +1,1
vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#issuecomment-539941211
Will update the PR later today
---
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333191213
##
File path: hadoop-shaded-protobuf/pom.xml
##
@@ -0,0
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333191323
##
File path: pom.xml
##
@@ -0,0 +1,466 @@
+
+
+http://
jojochuang commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333198496
##
File path: hadoop-shaded-protobuf37/pom.xml
##
@@ -0,0
jojochuang commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333198546
##
File path: src/site/markdown/index.md.vm
##
@@ -0,0 +1
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r48847
##
File path: hadoop-shaded-protobuf37/pom.xml
##
@@ -0
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r48879
##
File path: src/site/markdown/index.md.vm
##
@@ -0,0
ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333460910
##
File path: .gitignore
##
@@ -0,0 +1,6 @@
+.idea
+**/targ
ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333461008
##
File path: LICENSE.txt
##
@@ -0,0 +1,224 @@
+
+
ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333461646
##
File path: NOTICE-binary
##
@@ -0,0 +1,840 @@
+Apache Ha
ayushtkn commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r333463878
##
File path: hadoop-shaded-protobuf37/pom.xml
##
@@ -0,0 +
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r359182162
##
File path: hadoop-shaded-protobuf37/pom.xml
##
@@ -0
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r360321079
##
File path: dev-support/bin/create-release
##
@@ -0,0
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r360321593
##
File path: dev-support/bin/create-release
##
@@ -0,0
vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#issuecomment-567883149
Thanks @ayushtkn for reviews.
@Apache9 @jojochuang Please take a look latest change
Apache9 commented on a change in pull request #1: HADOOP-16595. [pb-upgrade]
Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r363039815
##
File path: hadoop-shaded-protobuf_3_7/pom.xml
##
@@ -0,0
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r363041310
##
File path: hadoop-shaded-protobuf_3_7/pom.xml
##
@@
brahmareddybattula commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r365116836
##
File path: hadoop-shaded-protobuf_3_7/pom.xml
#
vinayakumarb commented on a change in pull request #1: HADOOP-16595.
[pb-upgrade] Create hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#discussion_r365172839
##
File path: hadoop-shaded-protobuf_3_7/pom.xml
##
@@
vinayakumarb merged pull request #1: HADOOP-16595. [pb-upgrade] Create
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1
This is an automated message from the Apache G
vinayakumarb commented on issue #1: HADOOP-16595. [pb-upgrade] Create
hadoop-thirdparty artifact to have shaded protobuf
URL: https://github.com/apache/hadoop-thirdparty/pull/1#issuecomment-573513164
Merged.
Thanks @Apache9 @ayushtkn @jojochuang @brahmareddybattula for reviews.
---
vinayakumarb opened a new pull request #2: HADOOP-16820. [thirdparty] ChangeLog
and ReleaseNote are not packaged by createrelease script
URL: https://github.com/apache/hadoop-thirdparty/pull/2
# Changes
ChangeLog and ReleaseNotes were not included due to version change.
Hadoop thirdpa
vinayakumarb opened a new pull request #3: HADOOP-16821. [pb-upgrade] Use
'o.a.h.thirdparty.protobuf' shaded prefix instead of 'protobuf_3_7'
URL: https://github.com/apache/hadoop-thirdparty/pull/3
This is an automated m
steveloughran commented on issue #3: HADOOP-16821. [pb-upgrade] Use
'o.a.h.thirdparty.protobuf' shaded prefix instead of 'protobuf_3_7'
URL: https://github.com/apache/hadoop-thirdparty/pull/3#issuecomment-576710054
LGTM, +1
T
1 - 100 of 143 matches
Mail list logo
