[PATCH] D46922: [checks/property-decls] Fix comment in clang-tidy/objc/PropertyDeclarationCheck.cpp ✍️

stephanemoore created this revision. Herald added a subscriber: cfe-commits. The comment incorrectly claims that the listed acronyms are all extracted from the linked Apple documentation. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46922 Files: clang-tidy/objc/PropertyDec

[PATCH] D46659: [clang-tidy/google-readability-casting] Disable check for Objective-C++

stephanemoore accepted this revision. stephanemoore added inline comments. Comment at: clang-tidy/google/AvoidCStyleCastsCheck.cpp:103-104 // The rest of this check is only relevant to C++. - if (!getLangOpts().CPlusPlus) + // We also disable it for Objective-C++. + if (!ge

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D47393 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp ===

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore updated this revision to Diff 148672. Repository: rC Clang https://reviews.llvm.org/D47393 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp === --- uni

[PATCH] D46895: add AR to acronyms of clang-tidy property check

stephanemoore added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:37-38 /// The acronyms are from /// https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore updated this revision to Diff 148705. Repository: rC Clang https://reviews.llvm.org/D47393 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp === --- uni

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. §1 Description This check finds function names in function definitions in Objective-C files that do not follow the naming pattern described in the Google Objective-C Style Guide. Function names should

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 163638. stephanemoore added a comment. Minor fixes: - Fixed header guard. - Removed unnecessary imports in header. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/Fun

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 163647. stephanemoore added a comment. Fixed alphabetical ordering of clang-tidy improvements in release notes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/Functio

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New :doc:`google-objc-function-naming + ` check. Eugene.Zelenko wrote: > Please use alphabetical order. Good catch. Fixed. Repository

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 163656. stephanemoore marked an inline comment as done. stephanemoore added a comment. Updated with changes: - Removed unit tests as other tests have been indicated to provide adequate coverage. - Added a comment explaining why only function definition

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:57 + functionDecl( + isDefinition(), + unless(anyOf(isMain(), matchesName(validFunctionNameRegex(true)), -

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 164568. stephanemoore marked 3 inline comments as done. stephanemoore edited the summary of this revision. stephanemoore added a comment. Implemented the following suggested changes: • Restricted matching to function declarations that are not in expansio

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 164569. stephanemoore added a comment. Implemented the following suggested changes: • Added a note that FunctionNamingCheck does not apply to Objective-C method name or property declarations. Repository: rCTE Clang Tools Extra https://reviews.llvm.

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 164570. stephanemoore marked an inline comment as done. stephanemoore added a comment. Cleaned up comment about FunctionNamingCheck not applying to Objective-C method or property declarations. Repository: rCTE Clang Tools Extra https://reviews.llvm

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:57 + functionDecl( + isDefinition(), + unless(anyOf(isMain(), matchesName(validFunctionNameRegex(true)), hokein wrote: > stephanemoore wrote: > > hok

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

stephanemoore created this revision. stephanemoore added reviewers: benhamilton, Wizard. Herald added subscribers: cfe-commits, jfb. §1 Description This changes the objc-property-declaration check to allow arbitrary acronyms and initialisms instead of using whitelisted acronyms. In Objective-C i

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

stephanemoore updated this revision to Diff 164582. stephanemoore added a comment. Fix a couple issues: • Forward declare `NSArray` in `objc-property-declaration.m`. • Remove unnecessary lightweight generics declaration from `IDs` property in `objc-property-declaration.m` to fix compilation error

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

stephanemoore updated this revision to Diff 164583. stephanemoore added a comment. Sorted forward declared classes in `objc-property-declaration.m`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51832 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc

[PATCH] D42704: [clang-format] Do not break Objective-C string literals inside array literals

stephanemoore added a comment. The summary states that -Wobjc-string-concatenation is enabled by default? I looked through `include/clang/Basic/DiagnosticGroups.td` and did not see evidence that `ObjCStringConcatenation` is under `All`. Am I missing something? Is -Wobjc-string-concatenation ena

[PATCH] D42708: [clang-format] Set ObjCBinPackProtocolList to Never for google style

stephanemoore added a comment. I believe that I have consensus from Google to be able to approve this. I sent out a last call for dissenting opinions. If I don't hear anything I plan on approving tomorrow. Repository: rC Clang https://reviews.llvm.org/D42708 _

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

stephanemoore added a comment. Looks reasonable 👌 Repository: rL LLVM https://reviews.llvm.org/D42864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42708: [clang-format] Set ObjCBinPackProtocolList to Never for google style

stephanemoore accepted this revision. stephanemoore added a comment. Pretty unanimous from the Google style arbitration side. Looks good to me. Repository: rC Clang https://reviews.llvm.org/D42708 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D42704: [clang-format] Do not break Objective-C string literals inside array literals

stephanemoore added a comment. Thanks for the explanation 👌 I'm still learning the inner workings of clang 😅 The change looks good to me. Repository: rC Clang https://reviews.llvm.org/D42704 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore created this revision. Herald added a subscriber: cfe-commits. The current Objective-C global variable declaration check restricts naming that is permitted by the Objective-C style guide. The Objective-C style guide states the following: "Global and file scope constants should have

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore updated this revision to Diff 135291. stephanemoore added a comment. Added excerpts from the Google Objective-C style guide section on constant naming (http://google.github.io/styleguide/objcguide#constants) as additional test cases. Repository: rCTE Clang Tools Extra https://

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore marked an inline comment as done. stephanemoore added a comment. In https://reviews.llvm.org/D43581#1014664, @aaron.ballman wrote: > LGTM with a few additional test cases. > > It'd be nice if the style guide linked actually described what a "good" > prefix is rather than make the r

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

stephanemoore added a comment. I have this change out for review as well: https://reviews.llvm.org/D43581 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore updated this revision to Diff 135489. stephanemoore added a comment. I forgot to update the diagnostic message per the change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/goog

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore added a comment. In https://reviews.llvm.org/D43581#1016300, @Wizard wrote: > Please update the warning info to indicate that prefix 'k' is not the only > option for constants. Something like: > "const global variable '%0' must have an appropriate prefix or a name which > starts

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore updated this revision to Diff 135497. stephanemoore added a comment. Update the diagnostic information to link to the Google Objective-C style guide for guidance on an appropriate prefix. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files: clang-tidy/go

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore added a comment. In https://reviews.llvm.org/D43581#1016327, @Wizard wrote: > In https://reviews.llvm.org/D43581#1016318, @stephanemoore wrote: > > > In https://reviews.llvm.org/D43581#1016300, @Wizard wrote: > > > > > Please update the warning info to indicate that prefix 'k' is no

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

stephanemoore updated this revision to Diff 135510. stephanemoore added a comment. Revert the inclusion of the link to the Google Objective-C style guide in the diagnostic message. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files: clang-tidy/google/GlobalVariableDe

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore updated this revision to Diff 135595. stephanemoore marked 2 inline comments as done. stephanemoore retitled this revision from "[clang-tidy/google] Fix the Objective-C global variable declaration check 🔧" to "[clang-tidy/google] Improve the Objective-C global variable declaration c

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl->getName() << generateFixItHint(Decl, true); ---

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore marked an inline comment as not done. stephanemoore added inline comments. Comment at: test/clang-tidy/google-objc-global-variable-declaration.m:33 static NSString* const kGood = @"hello"; +static NSString* const XYGood = @"hello"; static NSString* gMyIntGood = 0;

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore updated this revision to Diff 135745. stephanemoore marked 3 inline comments as done. stephanemoore added a comment. Removed the regex from the diagnostic ✂️ Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files: clang-tidy/google/GlobalVariableDeclarationC

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore marked 2 inline comments as done. stephanemoore added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl-

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore marked an inline comment as done. stephanemoore added a comment. In https://reviews.llvm.org/D43581#1018499, @aaron.ballman wrote: > This LGTM! Do you need someone to commit on your behalf? I would be happy to commit assuming that I am able to and can meet submission requirements

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore updated this revision to Diff 149338. stephanemoore added a comment. Removed the last format from the tests. That particular scenario was failing and it might need additional changes to pass. I also think that particular scenario is not critical to the change and can be considered

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore added a comment. Polling the Google Objective-C community to see if anyone objects to this change. So far no concerns have been raised. Repository: rC Clang https://reviews.llvm.org/D47393 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore added reviewers: benhamilton, jolesiak, djasper. stephanemoore added a comment. I believe I have consensus that this is the correct change for Google Objective-C style. Repository: rC Clang https://reviews.llvm.org/D47393 ___ cfe-c

[PATCH] D46922: [checks/property-decls] Fix comment in clang-tidy/objc/PropertyDeclarationCheck.cpp ✍️

stephanemoore added a comment. Is it possible to get someone to land this for me? I don't believe I have access to land it myself. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46922 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D46922: [checks/property-decls] Fix comment in clang-tidy/objc/PropertyDeclarationCheck.cpp ✍️

stephanemoore added a comment. In https://reviews.llvm.org/D46922#1125689, @benhamilton wrote: > > Is it possible to get someone to land this for me? I don't believe I have > > access to land it myself. > > Done. Thank you, kind sir 🙇 Repository: rL LLVM https://reviews.llvm.org/D46922

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore added a comment. Are additional approvals needed to land this? I pinged jolesiak earlier this week asking if he had any comments but have not heard back yet. (also, once necessary approvals have been granted can I request help from someone to land it for me? 😇) Repository: rC

[PATCH] D48432: [clang-format] Add AlwaysBreakBeforeMultilineString tests

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D48432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore created this revision. stephanemoore added reviewers: benhamilton, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. The `Acronyms` and `IncludeDefaultAcronyms` options were deprecated in https://reviews.llvm.org/D51832. These options can be removed. Tested by running

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore updated this revision to Diff 182660. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Use :option: prefix for options in release notes. Add missing space in check reference in release notes. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACT

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

This revision was automatically updated to reflect the committed changes. Closed by commit rL351921: [clang-tidy] Delete obsolete objc-property-declaration options ✂️ (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: docs/ReleaseNotes.rst:248 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration` Eugene.Zelenko wrote: > Please rebase f

[PATCH] D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. stephanemoore edited the summary of this revision. The Acronyms and IncludeDefaultAcronyms options were deprecated in https://reviews.llvm.org/D51832. These options can be removed. Tested by running the clang-t

[PATCH] D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: docs/ReleaseNotes.rst:76 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration ` In https://reviews.llvm.org/D56945, I

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Implicit functions are outside the control of source authors and should be exempt from style restrictions. Tested via running clang tools tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore updated this revision to Diff 183646. stephanemoore added a comment. Updated the comment describing the matching behavior. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57207/new/ https://reviews.llvm.org/D57207 Files: clang-tidy/go

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore marked 2 inline comments as done. stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:96-97 // Match function declarations that are not in system headers and are not // main. Finder->addMatcher( aaro

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: docs/ReleaseNotes.rst:248 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration` stephanemoore wrote: > Eugene.Zelenko w

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

stephanemoore planned changes to this revision. stephanemoore added a comment. Reiterating outstanding action items: • Evaluate using hasDeclContext instead of hasAncestor. • Include type encoding size information in diagnostic messages. I've been observing some unexpected behaviors with matching

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore marked 3 inline comments as done. stephanemoore added a comment. Thanks for the review! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57207/new/ https://reviews.llvm.org/D57207 ___ cfe-com

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

stephanemoore updated this revision to Diff 184553. stephanemoore marked an inline comment as done. stephanemoore added a comment. Add comment explaining that builtin function call generates implicit function declaration and update calling function name for improved clarity. Repository: rCTE

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

stephanemoore updated this revision to Diff 172285. stephanemoore marked an inline comment as done. stephanemoore added a comment. Updated comments, release notes, and documentation to be consistent with the implemented changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

stephanemoore added a comment. I believe that it should be safe to remove the `Acronyms` and `IncludeDefaultAcronyms` options but if it's alright with you, I would prefer to separate that into a followup change. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:28-31

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore marked an inline comment as done. stephanemoore added a comment. https://reviews.llvm.org/D51832 is in review to update the objc-property-declaration check to allow arbitrary acronyms and initialisms. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 ___

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 172296. stephanemoore added a comment. Updated diff after pulling and merging. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/FunctionNamingCheck.cpp clang-tidy/goo

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 173244. stephanemoore marked an inline comment as done. stephanemoore added a comment. Added a test case for an extern function without an appropriate prefix (`IsPrime`). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 Files:

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore added inline comments. Comment at: docs/clang-tidy/checks/google-objc-function-naming.rst:20 + static bool is_positive(int i) { return i > 0; } + bool IsNegative(int i) { return i < 0; } + benhamilton wrote: > This is not actually handled by the c

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 173544. stephanemoore marked 9 inline comments as done. stephanemoore added a comment. Updated with the following changes: • Elided conditional braces to comply with LLVM style. • Converted conditional loop break to loop condition in generateFixItHint. •

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 173936. stephanemoore added a comment. Reworded "upper camel case" to "Pascal case". Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/FunctionNamingCheck.cpp clang-ti

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore added a comment. Thanks for the review everyone! Let me know if there are any further changes that you want me to make or any further action required on my part to land this 😁 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 ___

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore added a comment. I received commit access yesterday so I believe I should be able to land this myself (after I get myself set up and land a test commit). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 ___ cfe-co

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:63 + bool AtWordBoundary = true; + while (Index >= NewName.size()) { +char ch = NewName[Index]; I forgot to invert this condition when I refactored the early return i

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 174465. stephanemoore added a comment. Fixed loop condition in generateFixItHint. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/FunctionNamingCheck.cpp clang-tidy/

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

This revision was automatically updated to reflect the committed changes. Closed by commit rL347132: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C… (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

stephanemoore created this revision. stephanemoore added reviewers: benhamilton, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. The google-objc-function-naming check applies to functions that are not namespaced and should not be applied to C++ member functions. Such function de

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

stephanemoore updated this revision to Diff 176206. stephanemoore marked an inline comment as done. stephanemoore added a comment. Re-formatted google-objc-function-naming.mm to LLVM style. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55101/new/ ht

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

stephanemoore added a comment. In D55101#1314716 , @benhamilton wrote: > IMHO we should just disable this check entirely for C++ files (including > Objective-C++). > > Since Objective-C++ files will have a mix of the Google Objective-C and > Google C++ s

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

stephanemoore added a comment. In D55101#1315294 , @benhamilton wrote: > > Would you be okay with landing this fix and if we get any further reports > > for Objective-C++ sources then we can suppress it in all C++/Objective-C++ > > sources? I think there

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

stephanemoore added a comment. Chatted offline with Ben and confirmed that he's okay with proceeding. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55101/new/ https://reviews.llvm.org/D55101 ___ cfe-com

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

This revision was automatically updated to reflect the committed changes. Closed by commit rL348317: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function… (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

stephanemoore added a comment. Chatted with Ben offline and he's okay with proceeding. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51832/new/ https://reviews.llvm.org/D51832 ___ cfe-commits mailing li

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

stephanemoore updated this revision to Diff 176756. stephanemoore added a comment. Rebased changes and resolved merge conflicts. Moved release notes update next to other release notes regarding updates to existing checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51832/new/ https:/

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

This revision was automatically updated to reflect the committed changes. Closed by commit rL348331: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary… (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore created this revision. stephanemoore added reviewers: benhamilton, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. The diagnostics from google-objc-function-naming check will be more actionable if they provide a brief description of the requirements from the Google O

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore updated this revision to Diff 177609. stephanemoore marked 4 inline comments as done. stephanemoore added a comment. Use the select modifier to customize diagnostics for static and non-static function instead of branching diagnostic code paths for static and non-static functions.

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-125 + if (MatchedDecl->getStorageClass() == SC_Static) { +diag(MatchedDecl->getLocation(), + "static function name %0 must be in Pascal case as required by " + "Goo

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-118 diag(MatchedDecl->getLocation(), - "function name %0 not using function naming conventions described by " - "Google Ob

[PATCH] D55544: Warning: objc-encodings-larger-than=

stephanemoore added a comment. FYI: I have a clang-tidy check almost ready for review that aims to flag large Objective-C type encodings. Comment at: include/clang/Basic/LangOptions.def:103 +BENIGN_LANGOPT(ObjCLargeEncodingSize, 32, 0, + "if non-zero, warn about O

[PATCH] D55546: [clang] Add AST matcher for block expressions 🔍

stephanemoore created this revision. Herald added a subscriber: cfe-commits. This change adds a new AST matcher for block expressions. Test Notes: Ran the clang unit tests. Repository: rC Clang https://reviews.llvm.org/D55546 Files: docs/LibASTMatchersReference.html include/clang/ASTMat

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore updated this revision to Diff 177795. stephanemoore marked 5 inline comments as done. stephanemoore added a comment. Changes: • Drop const on local bool variable. • Adopt the term "function in global namespace" in diagnostic messages. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore created this revision. Herald added subscribers: cfe-commits, jdoerfert, xazax.hun. Herald added a project: clang. In contrast to Google C++, Objective-C often uses built-in integer types other than `int`. In fact, the Objective-C runtime itself defines the types NSInteger¹ and NSUIn

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore updated this revision to Diff 190520. stephanemoore added a comment. Document change in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336 Files: clang-tools-extra/clang-tidy/goo

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore added a comment. Let me know if you think this change would benefit from added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336 ___ cfe-comm

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Thanks for the review! Comment at: clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp:57 // Find all TypeLocs. The relevant Style Guide rule only applies to C++. - if (!getLangOpts().CPlus

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore updated this revision to Diff 190742. stephanemoore added a comment. Add google-runtime-int tests for Objective-C and Objective-C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336 Files: cl

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore added a comment. In D59336#1429564 , @aaron.ballman wrote: > This is missing test cases that demonstrate the behavior is what we expect it > to be for ObjC++ code vs C++ code. Added tests for Objective-C and Objective-C++. Repository:

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore updated this revision to Diff 191198. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Updated with changes: • Switched to using `| count 0` instead of grep'ing for warnings. • Merged Objective-C and Objective-C++ test cases into single file with multip

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.m:1 +// RUN: clang-tidy -checks=-*,google-runtime-int %s 2>&1 -- -x objective-c | not grep 'warning:\|error:' + aaron.ballman wrote: > We typically use `| count

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore updated this revision to Diff 191219. stephanemoore added a comment. Remove redundant specification of `-x objective-c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336 Files: clang-tools-ex

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore marked 3 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.m:1 +// RUN: clang-tidy -checks=-*,google-runtime-int %s 2>&1 -- -x objective-c | not grep 'warning:\|error:' +

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356627: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓 (authored by stephanemoore, committed by ). Changed prior to commit: https://reviews.llvm.org/D59336?vs=191219&id=191599#toc Reposit

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

stephanemoore marked an inline comment as done. stephanemoore added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336 ___ cfe-co

  1   2   3   >