stephanemoore planned changes to this revision. stephanemoore added a comment.
Reiterating outstanding action items: • Evaluate using hasDeclContext instead of hasAncestor. • Include type encoding size information in diagnostic messages. I've been observing some unexpected behaviors with matching in the proposed test sample that I am still investigating (as I recall the issue pertained to interfaces/protocols without interfaces). Including the type encoding size information in diagnostic messages shouldn't be too hard (assuming we can get precise type encoding size information by analyzing the AST). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55640/new/ https://reviews.llvm.org/D55640 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
