[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 133027. massberg edited the summary of this revision. massberg added a comment. Addressed comments and renamed test to modernize-deprecated-functional https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/Depre

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 4 inline comments as done. massberg added a comment. Thanks for the comments! I double-checked that the renaming went well and hope that I haven't missed anything this time ... https://reviews.llvm.org/D42730 ___ cfe-commits mailing

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 134578. massberg edited the summary of this revision. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedFunctionalCheck.cpp clang-tidy/modernize/DeprecatedFunctionalCheck.h clang-tidy/modernize/

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 8 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:26 +.bind("base")), + anyOf(isClass(), ast_matchers:

[PATCH] D96281: Add options to flag individual core increments and to ignore macros to cognitive complexity check.

massberg created this revision. massberg added reviewers: lebedev.ri, alexfh. Herald added a subscriber: nullptr.cpp. massberg requested review of this revision. Herald added a project: clang. Often you are only interested in the overall cognitive complexity of a function and not every individual

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 322921. massberg added a comment. Clarified option FlagBasicIncrements and removed base default constructor from class initializer list of FunctionASTVisitor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9628

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230 + explicit FunctionASTVisitor(const bool IgnoreMacros) + : RecursiveASTVisitor(),

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 323052. massberg marked 2 inline comments as done. massberg added a comment. Add test cases showing that when IgnoreMacros is set to 'true', also macro arguments are ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg added a comment. In D96281#2556586 , @njames93 wrote: > How does this handle a macro where the argument has complex code. > > MACRO(if (...) {}); I agree that macro arguments should account to the complexity. However, with this change macro

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 323962. massberg added a comment. Change option name, improve description and minor fixes. - Change name FlagBasicIncrements to DescribeBasicIncrements. - Improve description of this option and added an example. - Minor code fixes. Repository: rG LLVM Gi

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg marked 4 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.h:24-26 +/// * `FlagBasicIncrements`- if set to `true`, additional to flagging +// functio

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327721. massberg added a comment. Remove IgnoreMacros option (to be added in a follow up patch) and sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https://reviews.llvm.org/D96281 Files

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg added a comment. In D96281#2596657 , @lebedev.ri wrote: > Once again, can we please split this into two patches? > I'm quite happy with the `DescribeBasicIncrements` stuff, that can be merged > right now. I have removed the IgnoreMacros and will

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327746. massberg added a comment. Add checks to ensure that notes aren't added for specific options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https://reviews.llvm.org/D96281 Files: clang-too

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327805. massberg added a comment. Remove unnecessary checks. After testing locally it turned out that we do not need these checks. If there is an unexpected note, the test fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-function-cognitive-complexity-flags.cpp:16 + // CHECK-NOTES: :[[@LINE-1]]:6: warning: function 'func_of_complexity_4' has cognitive com

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg created this revision. Herald added subscribers: lebedev.ri, xazax.hun. Herald added a reviewer: lebedev.ri. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a macro is used within a function, the code inside the macro d

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 329559. massberg added a comment. Sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://reviews.llvm.org/D98070 Files: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComp

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++20 is more strict when erroring out due to incomplete types. Thus

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg added a comment. > Having as few code in headers as possible is the general style guide in LLVM, > so I'd rather err towards that and put definitions out-of-line as much as > possible. Therefore if we can getaway by just moving definitions out-of-line, > while keeping rest of the hea

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg updated this revision to Diff 488976. massberg added a comment. Clean up code and only mode definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 Files: clang-tools-extra/clang-doc/Repre

[PATCH] D141671: Move definitions to prevent incomplete types.

massberg added a comment. I have updated the code. It turned out that much less code has to be moved than I initially thought. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 _

[PATCH] D141671: Move definitions to prevent incomplete types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf88c6b9166f8: Move definitions to prevent incomplete types. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto l

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Con

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9ab43dd44ca: [clangd][c++20] Add concept Hover tests. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D155581: [clangd][c++20] Add concept semantic highlighting test case

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Rep

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 549066. massberg marked an inline comment as done. massberg added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Only call `AddConceptReference` if there is a concept reference. Repository: rG LLVM Github Monore

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552307. massberg added a comment. Resolve some of the reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https://reviews.llvm.org/D155858 Files: clang/include/clang/AST/ASTConcep

[PATCH] D155858: Add a concept AST node.

massberg marked 13 inline comments as done. massberg added a comment. I have resolved some of the comments, but I need another round to finish all of the, Thanks to all reviewers so far! Comment at: clang/include/clang/AST/ExprConcepts.h:90 + // NOTE(massberg): For the first

[PATCH] D155858: Add a concept AST node.

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size]; +

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552742. massberg marked 4 inline comments as done. massberg added a comment. Resolved the next round of comments. There are still some left to be addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/

[PATCH] D155581: [clangd][c++20] Add concept semantic highlighting test case

This revision was automatically updated to reflect the committed changes. Closed by commit rG8af016aefd83: [clangd][c++20] Add concept semantic highlighting test case (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155581/new/

[PATCH] D156867: Add a concept AST nodes.

massberg created this revision. massberg added reviewers: hokein, sammccall, erichkeane. Herald added subscribers: ChuanqiXu, kadircet, martong. Herald added a reviewer: shafik. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, ilya-biry

[PATCH] D156867: [clang] Add a concept AST nodes.

massberg added a comment. @erichkeane Hi Erich, we would like to add an AST node for concepts (see description above) and we are interested in your opinion on the high level design.. This patch is a draft of what the new AST node could look like and how it would be part of the existing infrast

[PATCH] D155858: Add a concept AST node.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: ChuanqiXu, martong. Herald added a reviewer: shafik. Herald added a project: All. massberg updated this revision to Diff 544722. massberg added a comment. massberg updated this revision to Diff 545601. m

[PATCH] D156867: [clang] Add a concept AST nodes.

massberg abandoned this revision. massberg added a comment. Abandon this revision in favor of https://reviews.llvm.org/D155858 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156867/new/ https://reviews.llvm.org/D156867 _

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 547804. massberg edited the summary of this revision. massberg added a comment. Rename `ConceptLoc` back to `ConceptReference`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https://reviews.llvm.or

[PATCH] D155858: Add a concept AST node.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang/include/clang/AST/ASTConcept.h:118 /// template arguments. -class ConceptReference { +class ConceptLoc { protected: cor3ntin wrote: > hokein wrote: > > I'm not sure the

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537161. massberg added a comment. Update code by resolving comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/ https://reviews.llvm.org/D154450 Files: clang-tools-extra/clangd/CodeComplete.c

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg marked 7 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:327 +return ""; + return "<" + Signature.substr(FirstComma + 2); +} sammccall wrote: > I don't love the arithmetic, the repetitio

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537163. massberg marked 2 inline comments as done. massberg added a comment. Add test case that isn't correctly handled yet and add FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/ http

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1af0e34477a3: [clangd][c++20] Drop first template argument in code completion in some… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D154580: Add missing semantic highlighing for concepts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gith

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg updated this revision to Diff 537642. massberg added a comment. Set correct token for deduced auto types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154580/new/ https://reviews.llvm.org/D154580 Files: clang-tools-extra/clangd/Semanti

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg updated this revision to Diff 537643. massberg added a comment. Directly get correct source loc in case of deduced auto types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154580/new/ https://reviews.llvm.org/D154580 Files: clang-tools

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:969 + if (ATL.isConstrained()) { + StartLoc = ATL.getConceptNameInfo().getEndLoc().getLocWithOffset(1); + } ---

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

This revision was automatically updated to reflect the committed changes. massberg marked an inline comment as done. Closed by commit rG8af9a373ad95: Add missing semantic highlighing for concepts. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D154623: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D154623: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec9e2048024: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1546

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Thi

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg updated this revision to Diff 538952. massberg added a comment. clang-format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154853/new/ https://reviews.llvm.org/D154853 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, kristof.beyls. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, cl

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:562 )cpp"; - EXPECT_DECLS("ConceptSpecializationExpr", + EXPECT_DECLS("TemplateTypeParmTypeLoc", {"template concept Fooable = true"}); This is

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg added inline comments. Comment at: clang/unittests/AST/SourceLocationTest.cpp:274 + + Verifier.expectRange(2, 11, 2, 31); + EXPECT_TRUE(Verifier.match("template concept Fooable = true;\n" massberg wrote: > This range looks a bit to long. What I'm doin

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554257. massberg marked 7 inline comments as done. massberg added a comment. Resolve more of the open comments. - add `getBeginLoc()`, `getEndLoc()` and `getSourceRange()` to `ConceptReference` and updated corresponding functions in `ConceptSpecializationE

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554660. massberg marked 3 inline comments as done. massberg added a comment. Resolve remaining comments. - Added tests for new location functions of `ConceptReference`. There is an existing bug with the end location if there are no template arguments. As it

[PATCH] D155858: Add a concept AST node.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size]; + TemplateSpecializationTypeLoc::initia

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554743. massberg marked 7 inline comments as done. massberg added a comment. Fixed remaining nits. Thanks for the reviews and comments everyone! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https:

[PATCH] D155858: Add a concept AST node.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2bf9baf5987: Add a concept AST node. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Dir

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg updated this revision to Diff 554985. massberg marked an inline comment as done. massberg added a comment. Use VisitConceptReference instead of TraverseConceptReference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159268/new/ https://revi

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc39dcd2c2bc7: [c++20][clangd] Simplify code using the new `ConceptReference` nodes. (authored by massberg). Repository: rG LLVM Github Monorepo C

[PATCH] D159300: [AST] Support ConceptReference in DynTypedNode, add dump().

massberg accepted this revision. massberg added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159300/new/ https://reviews.llvm.org/D159300

[PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

massberg added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:2545 }; -dependentSizedArrayType() +dependentSizedArrayType matches "T data[Size]" Was this change to drop the () by purpose? Comment at: clang/docs/LibAS

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159450 File

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d2e756dacfd: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159450/n

[PATCH] D159465: Add index test with unconstrained auto.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without the fix in https://reviews.llvm.org/D15

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg updated this revision to Diff 477941. massberg added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138701/new/ https://reviews.llvm.org/D138701 Files: clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp

[PATCH] D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138701/new/ https://reviews.llvm.org/D138701 ___ cfe-commits ma

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The zero-as-null-pointer-constant check should not fire if it is inside a defaul

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478227. massberg added a comment. Sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp clang/test/SemaCXX/warn-zero-nullp

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478261. massberg added a comment. Run clang-format on changed files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp clang/test/Se

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg updated this revision to Diff 478477. massberg added a comment. Fixed comments and removed unnecessary includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 Files: clang/lib/Sema/Sema.cpp

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 ___ cfe-commits ma

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg added a comment. Note: The build failures are in parts of the code that isn't effected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727 ___

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG849b650cf3b6: [clang] Skip defaulted functions in zero-as-null-pointer-constant. (authored by massberg). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a new init capture type for a lamdba expression is created, one has to pass

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 479579. massberg added a comment. Add a diagnostics test for pack expansions to check if args are passed by reference and not by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/ https://review

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 479581. massberg added a comment. Remove unnecessary code from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/ https://reviews.llvm.org/D139125 Files: clang/lib/Sema/TreeTransform.h clang/

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg created this revision. massberg added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In C++20 some

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 532867. massberg added a comment. Fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 532921. massberg added a comment. Add test to FindTargetTests and extend test in HoverTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-ext

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments, I have added an additional test to FindTargetTest. See also my other comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover, RewrittenBinaryOperato

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 533204. massberg marked 2 inline comments as done. massberg added a comment. Switched the "Hover, All" test to run with C++20 instead of C++17 and moved the RewrittenBinaryOperatorSpaceship test to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover, RewrittenBinaryOperatorSpaceshipMassberg) { + Annotations T(R"cpp( sammccall wrote: > massberg wrote: > >

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 533211. massberg marked an inline comment as done. massberg added a comment. clang-format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-e

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f065bfd633d: [clangd][c++20]Consider rewritten binary operators in TargetFinder (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

massberg created this revision. massberg added a reviewer: usaxena95. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes #62880 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

massberg added a comment. I just realized that we should probably also enable the other check (err_defaulted_comparison_param) for dependent types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151200/new/ https://reviews.llvm.org/D151200 ___

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

massberg updated this revision to Diff 524704. massberg added a comment. Also error out if the comparion operator has a single parameter that isn't a const reference. See also https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2002r1.html on how it shpuld behave in C++20. Repository:

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparison operator aren't as expected.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c0774b1d6e: [Clang][C++20] Error out if parameter types of a defaulted comparion operator… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

cfe-commits@lists.llvm.org

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implemed the change proposed in [P2002R1] to 11.11.1 [class.compare.

cfe-commits@lists.llvm.org

massberg updated this revision to Diff 517489. massberg added a comment. Updated errort messages, code and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/include/clang/Basic/

cfe-commits@lists.llvm.org

massberg marked 5 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8593 +const FunctionProtoType *FnType = FD->getType()->castAs(); +if (FnType->isVolatile()) { aaron.ballman wrote: > aaron.ballman wro

[PATCH] D149649: Update comment.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [class.rel] has been renamed to [class.compare.secondary]. Repository: rG LL

cfe-commits@lists.llvm.org

massberg updated this revision to Diff 519042. massberg marked an inline comment as done. massberg added a comment. Fixed typo, added release note and updated cxx_status.html. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://review

cfe-commits@lists.llvm.org

massberg updated this revision to Diff 519432. massberg added a comment. Fix test that broke after last change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/docs/ReleaseNotes.rst clang

  1   2   >