[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

2022-09-09 Thread Archit Saxena via Phabricator via cfe-commits
iamarchit123 added a comment. Hi @modimo @paulkirth any good open source benchmarks where I also can test this? The problem is finding some standard benchmarks which are profiled as well as have standard performance measuring metric to measure improvement. Repository: rG LLVM Github Monorep

[PATCH] D132186: Clang add front flags for Wmisnoinline

2022-08-18 Thread Archit Saxena via Phabricator via cfe-commits
iamarchit123 created this revision. Herald added subscribers: mtrofin, ormris, ChuanqiXu, haicheng, hiraditya. Herald added a project: All. iamarchit123 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test Plan: Reposito

[PATCH] D132188: Add documentation and test cases for Wmisnoinline

2022-08-18 Thread Archit Saxena via Phabricator via cfe-commits
iamarchit123 created this revision. Herald added a subscriber: wenlei. Herald added a project: All. iamarchit123 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test Plan: Repository: rG LLVM Github Monorepo https://r

[PATCH] D132186: Clang add front flags for Wmisnoinline

2022-08-18 Thread Archit Saxena via Phabricator via cfe-commits
iamarchit123 updated this revision to Diff 453828. iamarchit123 added a comment. Herald added a subscriber: wenlei. update commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132186/new/ https://reviews.llvm.org/D132186 Files: clang/docs/MisNoI

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

2022-08-25 Thread Archit Saxena via Phabricator via cfe-commits
iamarchit123 added a comment. In D132186#3741210 , @paulkirth wrote: > Hi, thanks for taking a look at this. Before we start an in-depth review, can > you describe the deficiencies w/ the existing diagnostics, and why they don't > meet your needs? > > P

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

2022-08-25 Thread Archit Saxena via Phabricator via cfe-commits
iamarchit123 added a comment. @paulkirth this change was done under the intuition that marking hot functions noinline may hurt performance. This change till now hasn't been tested for performance improvements and so the points that you raise that functions marked noinline are marked not for ho