iamarchit123 added a comment. @paulkirth this change was done under the intuition that marking hot functions noinline may hurt performance. This change till now hasn't been tested for performance improvements and so the points that you raise that functions marked noinline are marked not for hotness/performance but rather correctness is something that I was unaware of. Since I don't have access to big services currently and can't test this change, so I may be unable to defend this change. @modimo feel free if you think folks can come back and test this change for effectiveness or completely redo this if the above change is still insufficient.
I agree until it's shown/proven that there is a serious performance win this change may not be useful. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132186/new/ https://reviews.llvm.org/D132186 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
