[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: First pass, I like the approach overall. https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -95,7 +95,19 @@ void SPIRV::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("-o"); CmdArgs.push_back(Output.getFilename()); + // Use of --sycl-link will call the clang-sycl-link-wrapper instead of + // the default linker (spirv-link). + i

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -466,7 +467,7 @@ void HIP::constructGenerateObjFileFromHIPFatBinary( "-o", Output.getFilename(), "-x", "assembler", ObjinFile, "-c"}; - const char *Clang = Args.MakeArgString(C.getDriver().ClangE

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/112249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][aarch64] Add support for the MSVC qualifiers __ptr32, __ptr64, __sptr, __uptr for AArch64 (PR #111879)

2024-10-14 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/111879 >From 0f2017d7b9d3a8b0d1eee21f25e22ace58a398cc Mon Sep 17 00:00:00 2001 From: "Daniel Paoliello (HE/HIM)" Date: Wed, 9 Oct 2024 16:47:57 -0700 Subject: [PATCH] [clang][aarch64] Add support for the MS qualifie

[clang] [NFC] [MTE] Use aarch64-linux-android34 for globals test (PR #112050)

2024-10-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/3469 Here is the relevant piece of the build log fo

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Matt Arsenault via cfe-commits
@@ -721,7 +721,9 @@ class Qualifiers { // to implicitly cast into the default address space. (A == LangAS::Default && (B == LangAS::cuda_constant || B == LangAS::cuda_device || - B == LangAS::cuda_shared)); + B == LangAS

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: I think it's backport worthy. It's very small and has a near zero regression risk, and is a quite obvious fix. It might be a bit late for 19.1.2 which should be cut tomorrow, but should probably make it for 19.1.3. Just add this PR to the right 19.x milestone and type a `/cherr

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-14 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. Thanks for this! https://github.com/llvm/llvm-project/pull/109165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-14 Thread Tom Eccles via cfe-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/109165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-14 Thread Tom Eccles via cfe-commits
@@ -194,11 +197,29 @@ int Compilation::ExecuteCommand(const Command &C, if (LogOnly) return 0; + // We don't use any timers or llvm::TimeGroup's because those are tied into + // the global static timer list which, in principle, could be cleared without + // us knowing

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-14 Thread Tom Eccles via cfe-commits
@@ -194,11 +197,29 @@ int Compilation::ExecuteCommand(const Command &C, if (LogOnly) return 0; + // We don't use any timers or llvm::TimeGroup's because those are tied into + // the global static timer list which, in principle, could be cleared without + // us knowing

[clang] [llvm] [clang][aarch64] Add support for the MSVC qualifiers __ptr32, __ptr64, __sptr, __uptr for AArch64 (PR #111879)

2024-10-14 Thread Eli Friedman via cfe-commits
@@ -1,5 +1,6 @@ // RUN: %clang_cc1 -triple x86_64-windows-msvc -fms-extensions -emit-llvm -O2 < %s | FileCheck %s --check-prefixes=X64,ALL // RUN: %clang_cc1 -triple i386-pc-win32 -fms-extensions -emit-llvm -O2 < %s | FileCheck %s --check-prefixes=X86,ALL +// RUN: %clang_cc1 -

[clang] [llvm] [clang][aarch64] Add support for the MSVC qualifiers __ptr32, __ptr64, __sptr, __uptr for AArch64 (PR #111879)

2024-10-14 Thread Eli Friedman via cfe-commits
@@ -5570,15 +5583,7 @@ std::string llvm::UpgradeDataLayoutString(StringRef DL, StringRef TT) { if (!T.isX86()) return Res; - // If the datalayout matches the expected format, add pointer size address - // spaces to the datalayout. - std::string AddrSpaces = "-p270:32

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/6543 Here is the relevant piece of the b

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread via cfe-commits
llvmbot wrote: >I think it's backport worthy. It's very small and has a near zero regression >risk, and is a quite obvious fix. It might be a bit late for 19.1.2 which >should be cut tomorrow, but should probably make it for 19.1.3. > >Just add this PR to the right 19.x milestone and type a `/

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Thanks for fixing this, didn't even know the `getPrependArg` was something we supported. Sorry for the extra work. https://github.com/llvm/llvm-project/pull/112249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [llvm] Add ifunc support for Windows on AArch64. (PR #111962)

2024-10-14 Thread Alexandros Lamprineas via cfe-commits
@@ -1505,6 +1505,10 @@ class TargetInfo : public TransferrableTargetInfo, bool supportsIFunc() const { if (getTriple().isOSBinFormatMachO()) return true; +if (getTriple().isOSWindows() && getTriple().isAArch64()) + return true; +if (getTriple().getArch(

[clang] [llvm] Add ifunc support for Windows on AArch64. (PR #111962)

2024-10-14 Thread Alexandros Lamprineas via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: %clang_cc1 -triple aarch64-pc-windows-msvc -emit-llvm -o - %s | FileCheck %s labrinea wrote: Is this test file specific to AArch64? If so is it worth adding an 'aarch64-' prefix to it? https://github.com/llvm/llvm-project/pull/111962

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-14 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/108051 >From e39aee57ce8a98723f40f67ae33808bc6213c61d Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Sat, 7 Sep 2024 15:53:09 +0100 Subject: [PATCH 1/4] [llvm] Support llvm::Any across shared libraries on windows

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 39ac8b25cdca230509078d575d46c538bdf90e18 d336c456a93b36b1a15fd1cbf1a80275b2704525 --e

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-14 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,713 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-14 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,713 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-14 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-14 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Konstantin Bogdanov (thevar1able) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112283.diff 2 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/CrtpConstructorAccessibilityCheck.cpp (+1-1) -

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Konstantin Bogdanov (thevar1able) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112283.diff 2 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/CrtpConstructorAccessibilityCheck.cpp (+1

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread Konstantin Bogdanov via cfe-commits
https://github.com/thevar1able created https://github.com/llvm/llvm-project/pull/112283 None >From 31e4d362b6466b101cdf896003c6c264786b3f2a Mon Sep 17 00:00:00 2001 From: Konstantin Bogdanov Date: Tue, 15 Oct 2024 01:21:21 +0200 Subject: [PATCH] Fix a typo --- .../CrtpConstructorAccessibilit

[clang-tools-extra] [clang-tidy] Fix a typo (PR #112283)

2024-10-14 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-14 Thread Tor Shepherd via cfe-commits
torshepherd wrote: Ok I found a couple of nontrivial issues that I took care of in the latest commit. 1. Using `DefaultArguments` required having parameter names set to true as well. I separated them so that both have a modality that works with or without the other. See screenshot for default

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-10-14 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd updated https://github.com/llvm/llvm-project/pull/95712 >From 2c9e7c16524b7ce3bf818e451279722dc45d3efc Mon Sep 17 00:00:00 2001 From: Tor Shepherd Date: Mon, 23 Sep 2024 23:12:23 -0400 Subject: [PATCH 1/5] just defaults --- clang-tools-extra/clangd/Config.h

[clang] [Wunsafe-buffer-usage] False positives for & expression indexing constant size array (arr[anything & 0]) (PR #112284)

2024-10-14 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak created https://github.com/llvm/llvm-project/pull/112284 Do not warn when a constant sized array is indexed with an expression that contains bitwise and operation involving constants and it always results in a bound safe access. (rdar://136684050) >From b557d1

[clang] [Wunsafe-buffer-usage] False positives for & expression indexing constant size array (arr[anything & 0]) (PR #112284)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Malavika Samak (malavikasamak) Changes Do not warn when a constant sized array is indexed with an expression that contains bitwise and operation involving constants and it always results in a bound safe access. (rdar://136684050) --- Ful

[clang] [Wunsafe-buffer-usage] False positives for & expression indexing constant size array (arr[anything & 0]) (PR #112284)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Malavika Samak (malavikasamak) Changes Do not warn when a constant sized array is indexed with an expression that contains bitwise and operation involving constants and it always results in a bound safe access. (rdar://136684050)

[clang] 6277465 - Reapply "[clang][CodeGen] Zero init unspecified fields in initializers in C" (#109898) (#110051)

2024-10-14 Thread via cfe-commits
Author: yabinc Date: 2024-10-14T16:32:24-07:00 New Revision: 627746581b8fde4143533937130f420bbbdf9ddf URL: https://github.com/llvm/llvm-project/commit/627746581b8fde4143533937130f420bbbdf9ddf DIFF: https://github.com/llvm/llvm-project/commit/627746581b8fde4143533937130f420bbbdf9ddf.diff LOG: R

[clang] [clang] Generate note on declaration for nodiscard-related attributes (PR #112289)

2024-10-14 Thread Yihe Li via cfe-commits
https://github.com/Mick235711 created https://github.com/llvm/llvm-project/pull/112289 Currently, the following program ```cpp [[nodiscard]] int fun() { return 1; } [[deprecated]] int fun2() { return 2; } int main() { fun(); fun2(); } ``` generates the following diagnostics on Clang trunk:

[clang] [clang] Generate note on declaration for nodiscard-related attributes (PR #112289)

2024-10-14 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Generate note on declaration for nodiscard-related attributes (PR #112289)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yihe Li (Mick235711) Changes Currently, the following program ```cpp [[nodiscard]] int fun() { return 1; } [[deprecated]] int fun2() { return 2; } int main() { fun(); fun2(); } ``` generates the following diagnostics on Clang trunk: ([

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -6728,7 +6728,10 @@ def fsycl : Flag<["-"], "fsycl">, def fno_sycl : Flag<["-"], "fno-sycl">, Visibility<[ClangOption, CLOption]>, Group, HelpText<"Disables SYCL kernels compilation for device">; - +def sycl_link : Flag<["--"], "sycl-link">, Flags<[HelpHidden]>,

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,528 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Why do we need these? We can create empty bitcode files inside the tests using `clang`. (Also I'm wondering if there's an existing empty bitcode file). https://github.com/llvm/llvm-project/pull/112245

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -95,7 +95,19 @@ void SPIRV::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("-o"); CmdArgs.push_back(Output.getFilename()); + // Use of --sycl-link will call the clang-sycl-link-wrapper instead of + // the default linker (spirv-link). + i

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,528 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,530 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -721,7 +721,9 @@ class Qualifiers { // to implicitly cast into the default address space. (A == LangAS::Default && (B == LangAS::cuda_constant || B == LangAS::cuda_device || - B == LangAS::cuda_shared)); + B == LangAS

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#112258 https://github.com/llvm/llvm-project/pull/112066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-14 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/109165 >From 3b926fce8dbf42577adf54e80d3383a85b170e91 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Wed, 18 Sep 2024 09:49:26 -0600 Subject: [PATCH 1/6] [clang][flang] Support -time in both clang and flang The

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-14 Thread Tarun Prabhu via cfe-commits
@@ -194,11 +197,29 @@ int Compilation::ExecuteCommand(const Command &C, if (LogOnly) return 0; + // We don't use any timers or llvm::TimeGroup's because those are tied into + // the global static timer list which, in principle, could be cleared without + // us knowing

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-14 Thread Tarun Prabhu via cfe-commits
@@ -194,11 +197,29 @@ int Compilation::ExecuteCommand(const Command &C, if (LogOnly) return 0; + // We don't use any timers or llvm::TimeGroup's because those are tied into + // the global static timer list which, in principle, could be cleared without + // us knowing

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -4593,6 +4593,44 @@ def HLSLResourceBinding: InheritableAttr { let LangOpts = [HLSL]; let Args = [StringArgument<"Slot">, StringArgument<"Space", 1>]; let Documentation = [HLSLResourceBindingDocs]; + let AdditionalMembers = [{ + enum class RegisterType : unsigned

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -4593,6 +4593,44 @@ def HLSLResourceBinding: InheritableAttr { let LangOpts = [HLSL]; let Args = [StringArgument<"Slot">, StringArgument<"Space", 1>]; let Documentation = [HLSLResourceBindingDocs]; + let AdditionalMembers = [{ + enum class RegisterType : unsigned

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -83,6 +81,49 @@ static RegisterType getRegisterType(StringRef Slot) { } } +static ResourceClass getResourceClass(RegisterType RT) { + switch (RT) { + case RegisterType::SRV: +return ResourceClass::SRV; + case RegisterType::UAV: +return ResourceClass::UAV; + ca

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -4593,6 +4593,44 @@ def HLSLResourceBinding: InheritableAttr { let LangOpts = [HLSL]; let Args = [StringArgument<"Slot">, StringArgument<"Space", 1>]; let Documentation = [HLSLResourceBindingDocs]; + let AdditionalMembers = [{ + enum class RegisterType : unsigned

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp edited https://github.com/llvm/llvm-project/pull/111203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -4593,6 +4593,44 @@ def HLSLResourceBinding: InheritableAttr { let LangOpts = [HLSL]; let Args = [StringArgument<"Slot">, StringArgument<"Space", 1>]; let Documentation = [HLSLResourceBindingDocs]; + let AdditionalMembers = [{ + enum class RegisterType : unsigned

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -83,6 +81,49 @@ static RegisterType getRegisterType(StringRef Slot) { } } +static ResourceClass getResourceClass(RegisterType RT) { + switch (RT) { + case RegisterType::SRV: +return ResourceClass::SRV; + case RegisterType::UAV: +return ResourceClass::UAV; + ca

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp commented: I've looked through some of this and added some comments. I called out one place where there's some missing `const`s on members, but I think in general the code is not const correct and I didn't call out all the spots that I saw. I have to admit I'm pretty

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -4593,6 +4593,44 @@ def HLSLResourceBinding: InheritableAttr { let LangOpts = [HLSL]; let Args = [StringArgument<"Slot">, StringArgument<"Space", 1>]; let Documentation = [HLSLResourceBindingDocs]; + let AdditionalMembers = [{ + enum class RegisterType : unsigned

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -4593,6 +4593,44 @@ def HLSLResourceBinding: InheritableAttr { let LangOpts = [HLSL]; let Args = [StringArgument<"Slot">, StringArgument<"Space", 1>]; let Documentation = [HLSLResourceBindingDocs]; + let AdditionalMembers = [{ + enum class RegisterType : unsigned

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -28,13 +28,62 @@ class AttributeCommonInfo; class IdentifierInfo; class ParsedAttr; class Scope; +class VarDecl; + +using llvm::dxil::ResourceClass; // FIXME: This can be hidden (as static function in SemaHLSL.cpp) once we no // longer need to create builtin buffer types

[clang] [llvm] [clang][aarch64] Add support for the MSVC qualifiers __ptr32, __ptr64, __sptr, __uptr for AArch64 (PR #111879)

2024-10-14 Thread Daniel Paoliello via cfe-commits
@@ -1,5 +1,6 @@ // RUN: %clang_cc1 -triple x86_64-windows-msvc -fms-extensions -emit-llvm -O2 < %s | FileCheck %s --check-prefixes=X64,ALL // RUN: %clang_cc1 -triple i386-pc-win32 -fms-extensions -emit-llvm -O2 < %s | FileCheck %s --check-prefixes=X86,ALL +// RUN: %clang_cc1 -

[clang] [llvm] [clang][aarch64] Add support for the MSVC qualifiers __ptr32, __ptr64, __sptr, __uptr for AArch64 (PR #111879)

2024-10-14 Thread Daniel Paoliello via cfe-commits
dpaoliello wrote: > Need to make sure the autoupgraded string matches the new string, but > otherwise should be fine. (I remember last time we made major changes for > x86, the 128-bit integer alignment change, it was sort of tricky, but the > issue mostly wasn't the layout string itself.) Th

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-14 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From 8c0527aae4542c7065c14e8f21d6ca37010a29a6 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang-tools-extra] 3484ed9 - [docs][clang-tools-extra] Fix broken document link in ReleaseNotes.rst

2024-10-14 Thread via cfe-commits
Author: Nicolas van Kempen Date: 2024-10-14T18:43:33-04:00 New Revision: 3484ed9325f30b56717a1b939af4c58dd07848e0 URL: https://github.com/llvm/llvm-project/commit/3484ed9325f30b56717a1b939af4c58dd07848e0 DIFF: https://github.com/llvm/llvm-project/commit/3484ed9325f30b56717a1b939af4c58dd07848e0.

[clang-tools-extra] [clang-tidy] [docs] Replace _not_ in reserved-identifier.rst with *not* (PR #112162)

2024-10-14 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Rebase past 3484ed9325f30b56717a1b939af4c58dd07848e0 for green CI. https://github.com/llvm/llvm-project/pull/112162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > So overall I'm leaning against doing it as is; guarding it under some flavour > of `allow-relaxed-address-space-handling` or something that sounds better but > is still noisy enough to make it clear there's danger seems preferable, at > least to me. A language option is reaso

[clang] [OpenACC] Implement 'loop' 'vector' clause (PR #112259)

2024-10-14 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/112259 The 'vector' clause specifies the iterations to be executed in vector or SIMD mode. There are some limitations on which associated compute contexts may be associated with this and have arguments, but otherw

[clang] [OpenACC] Implement 'loop' 'vector' clause (PR #112259)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes The 'vector' clause specifies the iterations to be executed in vector or SIMD mode. There are some limitations on which associated compute contexts may be associated with this and have arguments, but othe

[clang] [OpenACC] Implement 'loop' 'vector' clause (PR #112259)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Erich Keane (erichkeane) Changes The 'vector' clause specifies the iterations to be executed in vector or SIMD mode. There are some limitations on which associated compute contexts may be associated with this and have arguments,

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Shilei Tian via cfe-commits
shiltian wrote: I think the default AS is expected to be losslessly converted to other AS but not the other way around, though I understand it is not clearly stated in LangRef or other places and a lot of code just assumes it can. https://github.com/llvm/llvm-project/pull/112248 __

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585, #111173)" (PR #111852)

2024-10-14 Thread Shafik Yaghmour via cfe-commits
shafik wrote: It looks like this is linked to this crash: https://github.com/llvm/llvm-project/issues/11 https://github.com/llvm/llvm-project/pull/111852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel` running on `ppc64le-clang-rhel-test` while building `clang,compiler-rt,lld,llvm` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/2476 He

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-10-14 Thread via cfe-commits
@@ -1391,22 +1411,60 @@ static void AddParamAndFnBasicAttributes(const CallBase &CB, AttributeList AL = NewInnerCB->getAttributes(); for (unsigned I = 0, E = InnerCB->arg_size(); I < E; ++I) { -// Check if the underlying value for the parameter is an argum

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
https://github.com/dpalermo created https://github.com/llvm/llvm-project/pull/112274 Reverts llvm/llvm-project#111332 Unable to build clang/flang with OpenMP this patch. Results in: https://lab.llvm.org/staging/#/builders/105/builds/6816 38.873 [112/2/7464] Linking CXX shared library lib/libl

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld-wasm @llvm/pr-subscribers-clang-driver Author: None (dpalermo) Changes Reverts llvm/llvm-project#111332 Unable to build clang/flang with OpenMP this patch. Results in: https://lab.llvm.org/staging/#/builders/105/builds/6816 38.873 [112/2/7464] Lin

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly Author: None (dpalermo) Changes Reverts llvm/llvm-project#111332 Unable to build clang/flang with OpenMP this patch. Results in: https://lab.llvm.org/staging/#/builders/105/builds/6816 38.873 [112/2/7464] Linking CXX shared library

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (dpalermo) Changes Reverts llvm/llvm-project#111332 Unable to build clang/flang with OpenMP this patch. Results in: https://lab.llvm.org/staging/#/builders/105/builds/6816 38.873 [112/2/7464] Linking CXX shared library lib/liblldWas

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-pgo Author: None (dpalermo) Changes Reverts llvm/llvm-project#111332 Unable to build clang/flang with OpenMP this patch. Results in: https://lab.llvm.org/staging/#/builders/105/builds/6816 38.873 [112/2/7464] Linking CXX shared library lib/liblldWasm.

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: None (dpalermo) Changes Reverts llvm/llvm-project#111332 Unable to build clang/flang with OpenMP this patch. Results in: https://lab.llvm.org/staging/#/builders/105/builds/6816 38.873 [112/2/7464] Linking CXX shared library lib/liblldWasm.s

[clang] [compiler-rt] [lld] [llvm] Revert "[Coverage][WebAssembly] Add initial support for WebAssembly/WASI" (PR #112274)

2024-10-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld Author: None (dpalermo) Changes Reverts llvm/llvm-project#111332 Unable to build clang/flang with OpenMP this patch. Results in: https://lab.llvm.org/staging/#/builders/105/builds/6816 38.873 [112/2/7464] Linking CXX shared library lib/liblldWasm.

[clang] [Clang] Instantiate Typedefs referenced by type alias deduction guides (PR #111804)

2024-10-14 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#112293 https://github.com/llvm/llvm-project/pull/111804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Link to libatomic with openmp and rtlib=libgcc (PR #112202)

2024-10-14 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. LGTM thanks! https://github.com/llvm/llvm-project/pull/112202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Update llvm::Registry to work for LLVM shared library builds on windows (PR #109024)

2024-10-14 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/109024 >From beef0d9f53f05c31041677101577929281e908b1 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Wed, 28 Aug 2024 16:08:52 +0100 Subject: [PATCH 1/8] Update llvm::Registry to work for LLVM shared library build

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-14 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From 8c0527aae4542c7065c14e8f21d6ca37010a29a6 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH 1/2] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryE

[clang] [llvm] [clang][aarch64] Add support for the MSVC qualifiers __ptr32, __ptr64, __sptr, __uptr for AArch64 (PR #111879)

2024-10-14 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-shared` running on `bolt-worker` while building `clang,compiler-rt,lld,llvm` at step 6 "test-build-bolt-check-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/151/builds/2770

[clang] [llvm] [HLSL] Add handle initialization for simple resource declarations (PR #111207)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -489,3 +494,100 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() { GV->eraseFromParent(); } } + +// Returns handle type of a resource, if the type is a resource +// or an array of resources +static const HLSLAttributedResourceType *findHandleTypeOnResource(QualTy

[clang] [llvm] [HLSL] Add handle initialization for simple resource declarations (PR #111207)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -489,3 +494,100 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() { GV->eraseFromParent(); } } + +// Returns handle type of a resource, if the type is a resource +// or an array of resources +static const HLSLAttributedResourceType *findHandleTypeOnResource(QualTy

[clang] [llvm] [HLSL] Add handle initialization for simple resource declarations (PR #111207)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -1121,6 +1121,11 @@ CodeGenFunction::GenerateCXXGlobalInitFunc(llvm::Function *Fn, if (Decls[i]) EmitRuntimeCall(Decls[i]); +if (getLangOpts().HLSL) + if (llvm::Function *ResInitFn = + CGM.getHLSLRuntime().createResourceBindingInitFn())

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-14 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From d7a37cb7805d5ba982b8073c2485f16dec8a1eac Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [llvm] [HLSL] Add handle initialization for simple resource declarations (PR #111207)

2024-10-14 Thread Damyan Pepper via cfe-commits
@@ -5622,6 +5622,9 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl *D, getCUDARuntime().handleVarRegistration(D, *GV); } + if (LangOpts.HLSL) +getHLSLRuntime().handleGlobalVarDefinition(D, GV); damyanp wrote: Just checking you know th

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Arvind Sudarsanam via cfe-commits
@@ -0,0 +1,530 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Arvind Sudarsanam via cfe-commits
@@ -0,0 +1,530 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [llvm] Add ifunc support for Windows on AArch64. (PR #111962)

2024-10-14 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/111962 >From 122864160f098392c4afd1728eb924e7e26e70d9 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Tue, 8 Oct 2024 22:58:37 +0200 Subject: [PATCH 1/3] Add ifuncs support for Windows. --- clang/include/c

[clang] [llvm] Add ifunc support for Windows on AArch64. (PR #111962)

2024-10-14 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss edited https://github.com/llvm/llvm-project/pull/111962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Arvind Sudarsanam via cfe-commits
https://github.com/asudarsa updated https://github.com/llvm/llvm-project/pull/112245 >From eff4a0300336c4c106e1d293b19e795f5ccbabc1 Mon Sep 17 00:00:00 2001 From: Arvind Sudarsanam Date: Fri, 27 Sep 2024 13:03:12 -0700 Subject: [PATCH 1/2] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link

[clang] [LinkerWrapper] Extract device archives if symbol is used on the host (PR #111921)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers] [ARM64EC] Fix extra tokens inside intrin0.h preprocessor directive (PR #112066)

2024-10-14 Thread Max Winkler via cfe-commits
MaxEW707 wrote: @efriedma-quic What is the process for getting a fix into a milestone such as the upcoming 19.1.2 milestone. I read the docs on `cherry-pick` but I couldn't find any information about who decides what is considered suitable for a patch release. I am going to defer to you if you

  1   2   3   4   5   6   >