https://github.com/damyanp commented:
I've looked through some of this and added some comments. I called out one place where there's some missing `const`s on members, but I think in general the code is not const correct and I didn't call out all the spots that I saw. I have to admit I'm pretty confused about what the code is trying to do - the ratio of new code added to new tests / changes to the tests is a bit surprising. This means I can't look at the tests to try and understand what the code change is for, but it also points at maybe there being a testing gap. https://github.com/llvm/llvm-project/pull/111203 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
